[A/B/OEM][PATCH] Chang the location for one of two front mics on a lenovo thinkcentre machine

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[A/B/OEM][PATCH] Chang the location for one of two front mics on a lenovo thinkcentre machine

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1766477

[Impact]
On one of Lenovo thinkcenter machines we have, there are two microphone jacks
on the front panel, but only one of them can work after we plug a micrphone in
them.

[Fix]
Because two microphones are located in front panels, the alsa driver will assign
the same jack name to them, but pulseaudio can't handle two jacks with the same
name.

After applying this FIXUP, they will have different mixer name,
then pulseaudio can handle them correctly.


[Test Case]
After booting up, plug micrphone into any one of the two audio jacks, the microphone
works very well.

[Regression Potential]
Very low, since this patch is specific to the thinkcenter machine with subsystem id
0x17aa3138.


Hui Wang (1):
  ALSA: hda/realtek - adjust the location of one mic

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[A/B/OEM][PATCH] ALSA: hda/realtek - adjust the location of one mic

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1766477

There are two front mics on this machine, if we don't adjust the
location for one of them, they will have the same mixer name,
pulseaudio can't handle this situation.

After applying this FIXUP, they will have different mixer name,
then pulseaudio can handle them correctly.

Cc: <[hidden email]>
Signed-off-by: Hui Wang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit a3dafb2200bf3c13905a088e82ae11f1eb275a83)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 5f9b3d1..6a1f5ae 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6443,6 +6443,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
  SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
  SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
  SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
+ SND_PCI_QUIRK(0x17aa, 0x3138, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x3112, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
  SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [A/B/OEM][PATCH] Chang the location for one of two front mics on a lenovo thinkcentre machine

Po-Hsu Lin (Sam)
In reply to this post by Hui Wang
Clean cherry-pick, change limited to a specific HW.
And the ALC294_FIXUP_LENOVO_MIC_LOCATION does not available in Xenial, so I
think we can safely skip it.

Acked-by: Po-Hsu Lin <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED/OEM-A Re: [A/B/OEM][PATCH] Chang the location for one of two front mics on a lenovo thinkcentre machine

Timo Aaltonen-6
In reply to this post by Hui Wang
On 24.04.2018 08:44, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1766477
>
> [Impact]
> On one of Lenovo thinkcenter machines we have, there are two microphone jacks
> on the front panel, but only one of them can work after we plug a micrphone in
> them.
>
> [Fix]
> Because two microphones are located in front panels, the alsa driver will assign
> the same jack name to them, but pulseaudio can't handle two jacks with the same
> name.
>
> After applying this FIXUP, they will have different mixer name,
> then pulseaudio can handle them correctly.
>
>
> [Test Case]
> After booting up, plug micrphone into any one of the two audio jacks, the microphone
> works very well.
>
> [Regression Potential]
> Very low, since this patch is specific to the thinkcenter machine with subsystem id
> 0x17aa3138.
>
>
> Hui Wang (1):
>   ALSA: hda/realtek - adjust the location of one mic
>
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)

applied to artful/oem-next, thanks


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [A/B/OEM][PATCH] ALSA: hda/realtek - adjust the location of one mic

Aaron Ma
In reply to this post by Hui Wang
Reply | Threaded
Open this post in threaded view
|

APPLIED: [A/B/OEM][PATCH] Chang the location for one of two front mics on a lenovo thinkcentre machine

Kleber Souza
In reply to this post by Hui Wang
On 04/24/18 07:44, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1766477
>
> [Impact]
> On one of Lenovo thinkcenter machines we have, there are two microphone jacks
> on the front panel, but only one of them can work after we plug a micrphone in
> them.
>
> [Fix]
> Because two microphones are located in front panels, the alsa driver will assign
> the same jack name to them, but pulseaudio can't handle two jacks with the same
> name.
>
> After applying this FIXUP, they will have different mixer name,
> then pulseaudio can handle them correctly.
>
>
> [Test Case]
> After booting up, plug micrphone into any one of the two audio jacks, the microphone
> works very well.
>
> [Regression Potential]
> Very low, since this patch is specific to the thinkcenter machine with subsystem id
> 0x17aa3138.
>
>
> Hui Wang (1):
>   ALSA: hda/realtek - adjust the location of one mic
>
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
>

Applied to artful/master-next and bionic/master-next branched.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team