[A/B/OEM][PATCH] set PINCFG_HEADSET_MIC to parse_flags for Dell precision 3630

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[A/B/OEM][PATCH] set PINCFG_HEADSET_MIC to parse_flags for Dell precision 3630

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1766398

[Impact]
On this Dell machine (codename: turtle bay), the microphone always shows up
in the sound-setting even there is no microphone plugged in.

[Fix]

Without this fix, the pin will be regarded as microphone, and the jack name
is "Mic Phantom", it is always on in the pulseaudio even nothing is plugged
into the jack. So the UI is confusing to users since the microphone always
shows up in the UI even there is no microphone plugged.

After adding this flag, the jack name is "Headset Mic Phantom", then
the pulseaudio can handle its detection correctly.


[Test Case]
After booting up the system, and without plugging anything in the audio combo
jack, there is nothing in the input tab of sound-setting, then plug a headset
in the jack, the what-did-you-plug-in dialogue pops up, users can select headset
mic from UI, and headset-mic shows up in the sound-setting, we can record sound
via headset-mic


[Regression Potential]
Very low, since this patch is specific for ALC255_FIXUP_DELL_HEADSET_MIC which is
only used by Dell precision 3630 by now.


Hui Wang (1):
  ALSA: hda/realtek - set PINCFG_HEADSET_MIC to parse_flags

 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[A/B/OEM][PATCH] ALSA: hda/realtek - set PINCFG_HEADSET_MIC to parse_flags

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1766398

Otherwise, the pin will be regarded as microphone, and the jack name
is "Mic Phantom", it is always on in the pulseaudio even nothing is
plugged into the jack. So the UI is confusing to users since the
microphone always shows up in the UI even there is no microphone
plugged.

After adding this flag, the jack name is "Headset Mic Phantom", then
the pulseaudio can handle its detection correctly.

Fixes: f0ba9d699e5c ("ALSA: hda/realtek - Fix Dell headset Mic can't record")
Cc: <[hidden email]>
Signed-off-by: Hui Wang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit 3ce0d5aa265bcc0a4b281cb0cabf92491276101b)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ded79e4..5f9b3d1 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6252,6 +6252,8 @@ static const struct hda_fixup alc269_fixups[] = {
  { 0x19, 0x01a1913c }, /* use as headset mic, without its own jack detect */
  { }
  },
+ .chained = true,
+ .chain_id = ALC269_FIXUP_HEADSET_MIC
  },
 };
 
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [A/B/OEM][PATCH] set PINCFG_HEADSET_MIC to parse_flags for Dell precision 3630

Po-Hsu Lin (Sam)
In reply to this post by Hui Wang
Clean cherry-pick, change limited to a specific HW.
Acked-by: Po-Hsu Lin <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED/OEM-A Re: [A/B/OEM][PATCH] set PINCFG_HEADSET_MIC to parse_flags for Dell precision 3630

Timo Aaltonen-6
In reply to this post by Hui Wang
On 24.04.2018 08:10, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1766398
>
> [Impact]
> On this Dell machine (codename: turtle bay), the microphone always shows up
> in the sound-setting even there is no microphone plugged in.
>
> [Fix]
>
> Without this fix, the pin will be regarded as microphone, and the jack name
> is "Mic Phantom", it is always on in the pulseaudio even nothing is plugged
> into the jack. So the UI is confusing to users since the microphone always
> shows up in the UI even there is no microphone plugged.
>
> After adding this flag, the jack name is "Headset Mic Phantom", then
> the pulseaudio can handle its detection correctly.
>
>
> [Test Case]
> After booting up the system, and without plugging anything in the audio combo
> jack, there is nothing in the input tab of sound-setting, then plug a headset
> in the jack, the what-did-you-plug-in dialogue pops up, users can select headset
> mic from UI, and headset-mic shows up in the sound-setting, we can record sound
> via headset-mic
>
>
> [Regression Potential]
> Very low, since this patch is specific for ALC255_FIXUP_DELL_HEADSET_MIC which is
> only used by Dell precision 3630 by now.
>
>
> Hui Wang (1):
>   ALSA: hda/realtek - set PINCFG_HEADSET_MIC to parse_flags
>
>  sound/pci/hda/patch_realtek.c | 2 ++
>  1 file changed, 2 insertions(+)

applied to artful/oem-next, thanks

--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [A/B/OEM][PATCH] ALSA: hda/realtek - set PINCFG_HEADSET_MIC to parse_flags

Aaron Ma
In reply to this post by Hui Wang
Reply | Threaded
Open this post in threaded view
|

APPLIED[A/B]: [A/B/OEM][PATCH] set PINCFG_HEADSET_MIC to parse_flags for Dell precision 3630

Kleber Souza
In reply to this post by Hui Wang
On 04/24/18 07:10, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1766398
>
> [Impact]
> On this Dell machine (codename: turtle bay), the microphone always shows up
> in the sound-setting even there is no microphone plugged in.
>
> [Fix]
>
> Without this fix, the pin will be regarded as microphone, and the jack name
> is "Mic Phantom", it is always on in the pulseaudio even nothing is plugged
> into the jack. So the UI is confusing to users since the microphone always
> shows up in the UI even there is no microphone plugged.
>
> After adding this flag, the jack name is "Headset Mic Phantom", then
> the pulseaudio can handle its detection correctly.
>
>
> [Test Case]
> After booting up the system, and without plugging anything in the audio combo
> jack, there is nothing in the input tab of sound-setting, then plug a headset
> in the jack, the what-did-you-plug-in dialogue pops up, users can select headset
> mic from UI, and headset-mic shows up in the sound-setting, we can record sound
> via headset-mic
>
>
> [Regression Potential]
> Very low, since this patch is specific for ALC255_FIXUP_DELL_HEADSET_MIC which is
> only used by Dell precision 3630 by now.
>
>
> Hui Wang (1):
>   ALSA: hda/realtek - set PINCFG_HEADSET_MIC to parse_flags
>
>  sound/pci/hda/patch_realtek.c | 2 ++
>  1 file changed, 2 insertions(+)
>

Applied to artful/master-next and bionic/master-next branches.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team