[Artful/linux-oem][PATCH v2] system can't detect external microphone with the codec alc274

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[Artful/linux-oem][PATCH v2] system can't detect external microphone with the codec alc274

Hui Wang
BugLink: http://bugs.launchpad.net/bugs/1731822

This is v2, comparing to v1, I add SRU justification template here.

This patch is only for Artful and OEM kernel.

This patch is in v4.14-rc, so it will be in the Bionic kernel automatically.

Neither Xenial kernel nor Zesty kernel supports alc274 well yet, they lack lots
of functions like setting coefficient for eapd, headset mode, mic_in mode, ctia
and omtp mode. So only applying this patch is not sufficient to fix this bug.


[Impact]
There is a headset jack on this machine, after plugging the headset, the
headset-mic can't be detected, as a result we can't record sound with this
mic.


[Test Case]
plugging the headset and checking the sound-setting to verify the headset-mic
shows up. And recording sound with this mic, it works well.

[Fix]
adding the pin definition to quirk table, then this machine will be applied
ALC269_FIXUP_DELL1_MIC_NO_PRESENCE.

[Regression Potential]
No, it does not change any existing functions.


Hui Wang (1):
  ALSA: hda - fix headset mic problem for Dell machines with alc274

 sound/pci/hda/patch_realtek.c | 5 +++++
 1 file changed, 5 insertions(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[Artful/linux-oem][PATCH v2] ALSA: hda - fix headset mic problem for Dell machines with alc274

Hui Wang
BugLink: http://bugs.launchpad.net/bugs/1731822

Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
the pin 0x1a is for Headphone Mic, he suggested to apply
ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
verified applying this FIXUP can fix this problem.

Cc: <[hidden email]>
Cc: Kailang Yang <[hidden email]>
Signed-off-by: Hui Wang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ab8b154..64dc6f6 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6523,6 +6523,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
  {0x14, 0x90170110},
  {0x1b, 0x90a70130},
  {0x21, 0x03211020}),
+ SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
+ {0x12, 0xb7a60130},
+ {0x13, 0xb8a61140},
+ {0x16, 0x90170110},
+ {0x21, 0x04211020}),
  SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
  {0x12, 0x90a60130},
  {0x14, 0x90170110},
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [Artful/linux-oem][PATCH v2] ALSA: hda - fix headset mic problem for Dell machines with alc274

Aaron Ma
Clean cherry-pick with limited impacts,

Acked-by: Aaron Ma <[hidden email]>

On 11/23/2017 11:46 AM, Hui Wang wrote:

> BugLink: http://bugs.launchpad.net/bugs/1731822
>
> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
> the pin 0x1a is for Headphone Mic, he suggested to apply
> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
> verified applying this FIXUP can fix this problem.
>
> Cc: <[hidden email]>
> Cc: Kailang Yang <[hidden email]>
> Signed-off-by: Hui Wang <[hidden email]>
> Signed-off-by: Takashi Iwai <[hidden email]>
> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
> Signed-off-by: Hui Wang <[hidden email]>
> ---
>  sound/pci/hda/patch_realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index ab8b154..64dc6f6 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6523,6 +6523,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>   {0x14, 0x90170110},
>   {0x1b, 0x90a70130},
>   {0x21, 0x03211020}),
> + SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
> + {0x12, 0xb7a60130},
> + {0x13, 0xb8a61140},
> + {0x16, 0x90170110},
> + {0x21, 0x04211020}),
>   SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>   {0x12, 0x90a60130},
>   {0x14, 0x90170110},
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [Artful/linux-oem][PATCH v2] ALSA: hda - fix headset mic problem for Dell machines with alc274

Timo Aaltonen-6
In reply to this post by Hui Wang
On 23.11.2017 05:46, Hui Wang wrote:

> BugLink: http://bugs.launchpad.net/bugs/1731822
>
> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
> the pin 0x1a is for Headphone Mic, he suggested to apply
> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
> verified applying this FIXUP can fix this problem.
>
> Cc: <[hidden email]>
> Cc: Kailang Yang <[hidden email]>
> Signed-off-by: Hui Wang <[hidden email]>
> Signed-off-by: Takashi Iwai <[hidden email]>
> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
> Signed-off-by: Hui Wang <[hidden email]>

this is already applied in Ubuntu-4.13.0-18.21, so a rebase is enough
for linux-oem -1009.


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [Artful/linux-oem][PATCH v2] ALSA: hda - fix headset mic problem for Dell machines with alc274

Colin King
In reply to this post by Hui Wang
On 23/11/17 03:46, Hui Wang wrote:

> BugLink: http://bugs.launchpad.net/bugs/1731822
>
> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
> the pin 0x1a is for Headphone Mic, he suggested to apply
> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
> verified applying this FIXUP can fix this problem.
>
> Cc: <[hidden email]>
> Cc: Kailang Yang <[hidden email]>
> Signed-off-by: Hui Wang <[hidden email]>
> Signed-off-by: Takashi Iwai <[hidden email]>
> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
> Signed-off-by: Hui Wang <[hidden email]>
> ---
>  sound/pci/hda/patch_realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index ab8b154..64dc6f6 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6523,6 +6523,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>   {0x14, 0x90170110},
>   {0x1b, 0x90a70130},
>   {0x21, 0x03211020}),
> + SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
> + {0x12, 0xb7a60130},
> + {0x13, 0xb8a61140},
> + {0x16, 0x90170110},
> + {0x21, 0x04211020}),
>   SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>   {0x12, 0x90a60130},
>   {0x14, 0x90170110},
>

Clean cherry pick, limited SRU regression potential because this quirk
is for a specific device. Looks good to me.

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team