[Artful] switch UNWINDER_ORC to UNWINDER_FRAME_POINTER

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Artful] switch UNWINDER_ORC to UNWINDER_FRAME_POINTER

Kamal Mostafa-2
CVE-2017-5754

CONFIG_UNWINDER_ORC breaks CONFIG_FRAME_POINTER, which is undesirable.
Switch from CONFIG_UNWINDER_ORC to CONFIG_UNWINDER_FRAME_POINTER instead.

---

Kamal Mostafa (2):
  Revert "UBUNTU: [Config] updateconfigs to enable PTI"
  UBUNTU: [Config] Enable PTI with UNWINDER_FRAME_POINTER

 debian.master/config/amd64/config.common.amd64 | 1 -
 debian.master/config/config.common.ubuntu      | 5 +++--
 debian.master/config/i386/config.common.i386   | 1 -
 3 files changed, 3 insertions(+), 4 deletions(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH][Artful] Revert "UBUNTU: [Config] updateconfigs to enable PTI"

Kamal Mostafa-2
CVE-2017-5754

This reverts commit 239497489e75fe18b55f568a43c76fd65a7cbf4f.

Enabling CONFIG_UNWINDER_ORC disabled CONFIG_FRAME_POINTER, which is
undesirable.

Signed-off-by: Kamal Mostafa <[hidden email]>
---
 debian.master/config/amd64/config.common.amd64 | 1 -
 debian.master/config/config.common.ubuntu      | 5 +----
 debian.master/config/i386/config.common.i386   | 1 -
 3 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/debian.master/config/amd64/config.common.amd64 b/debian.master/config/amd64/config.common.amd64
index 6412a13..6df8bcf 100644
--- a/debian.master/config/amd64/config.common.amd64
+++ b/debian.master/config/amd64/config.common.amd64
@@ -471,7 +471,6 @@ CONFIG_UIO_PRUSS=m
 CONFIG_UIO_SERCOS3=m
 CONFIG_ULTRIX_PARTITION=y
 CONFIG_UNIXWARE_DISKLABEL=y
-# CONFIG_UNWINDER_FRAME_POINTER is not set
 CONFIG_USB_DWC2_PCI=m
 CONFIG_USB_EHCI_HCD_PLATFORM=y
 CONFIG_USB_GADGET=m
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index ebb00db..37a1487 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -6201,7 +6201,6 @@ CONFIG_PADATA=y
 CONFIG_PAGE_COUNTER=y
 # CONFIG_PAGE_OWNER is not set
 # CONFIG_PAGE_POISONING is not set
-CONFIG_PAGE_TABLE_ISOLATION=y
 CONFIG_PALMAS_GPADC=m
 CONFIG_PANASONIC_LAPTOP=m
 CONFIG_PANEL=m
@@ -8660,7 +8659,7 @@ CONFIG_STACKTRACE=y
 CONFIG_STACKTRACE_SUPPORT=y
 CONFIG_STACK_GUARD=256
 CONFIG_STACK_TRACER=y
-CONFIG_STACK_VALIDATION=y
+# CONFIG_STACK_VALIDATION is not set
 # CONFIG_STAGING_BOARD is not set
 CONFIG_STAGING_MEDIA=y
 # CONFIG_STATIC_KEYS_SELFTEST is not set
@@ -9174,8 +9173,6 @@ CONFIG_UNIX=y
 CONFIG_UNIX98_PTYS=y
 CONFIG_UNIX_DIAG=m
 CONFIG_UNUSED_SYMBOLS=y
-# CONFIG_UNWINDER_GUESS is not set
-CONFIG_UNWINDER_ORC=y
 CONFIG_UPROBES=y
 CONFIG_UPROBE_EVENTS=y
 CONFIG_US5182D=m
diff --git a/debian.master/config/i386/config.common.i386 b/debian.master/config/i386/config.common.i386
index 4b8d6a1..eb973e0 100644
--- a/debian.master/config/i386/config.common.i386
+++ b/debian.master/config/i386/config.common.i386
@@ -463,7 +463,6 @@ CONFIG_UIO_PRUSS=m
 CONFIG_UIO_SERCOS3=m
 CONFIG_ULTRIX_PARTITION=y
 CONFIG_UNIXWARE_DISKLABEL=y
-CONFIG_UNWINDER_FRAME_POINTER=y
 CONFIG_USB_DWC2_PCI=m
 CONFIG_USB_EHCI_HCD_PLATFORM=y
 CONFIG_USB_GADGET=m
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH][Artful] UBUNTU: [Config] Enable PTI with UNWINDER_FRAME_POINTER

Kamal Mostafa-2
In reply to this post by Kamal Mostafa-2
CVE-2017-5754

Signed-off-by: Kamal Mostafa <[hidden email]>
---
 debian.master/config/config.common.ubuntu | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 37a1487..e4a363b 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -6201,6 +6201,7 @@ CONFIG_PADATA=y
 CONFIG_PAGE_COUNTER=y
 # CONFIG_PAGE_OWNER is not set
 # CONFIG_PAGE_POISONING is not set
+CONFIG_PAGE_TABLE_ISOLATION=y
 CONFIG_PALMAS_GPADC=m
 CONFIG_PANASONIC_LAPTOP=m
 CONFIG_PANEL=m
@@ -9173,6 +9174,9 @@ CONFIG_UNIX=y
 CONFIG_UNIX98_PTYS=y
 CONFIG_UNIX_DIAG=m
 CONFIG_UNUSED_SYMBOLS=y
+CONFIG_UNWINDER_FRAME_POINTER=y
+# CONFIG_UNWINDER_GUESS is not set
+# CONFIG_UNWINDER_ORC is not set
 CONFIG_UPROBES=y
 CONFIG_UPROBE_EVENTS=y
 CONFIG_US5182D=m
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [Artful] switch UNWINDER_ORC to UNWINDER_FRAME_POINTER

Marcelo Henrique Cerri
In reply to this post by Kamal Mostafa-2
Acked-by: Marcelo Henrique Cerri <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [Artful] switch UNWINDER_ORC to UNWINDER_FRAME_POINTER

Seth Forshee
In reply to this post by Kamal Mostafa-2
On Mon, Jan 08, 2018 at 09:45:03AM -0800, Kamal Mostafa wrote:
> CVE-2017-5754
>
> CONFIG_UNWINDER_ORC breaks CONFIG_FRAME_POINTER, which is undesirable.
> Switch from CONFIG_UNWINDER_ORC to CONFIG_UNWINDER_FRAME_POINTER instead.

This matches what I've done in 4.14/4.15. Should consider also updating
annotations to avoid accidentally disabling in the future, but that can
be done later.

Acked-by: Seth Forshee <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Applied: [Artful/pti] switch UNWINDER_ORC to UNWINDER_FRAME_POINTER

Kamal Mostafa-2
In reply to this post by Kamal Mostafa-2