[B/C/D/unstable][PATCH 0/1] The mute led can't work on lenovo x1

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[B/C/D/unstable][PATCH 0/1] The mute led can't work on lenovo x1

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1808465

This patch fixes a regression introduced by a patch I sent in Nov
(https://lists.ubuntu.com/archives/kernel-team/2018-November/096882.html),
That patch got ack but not formally merged to ubuntu kernel yet, I generated
this patch on the master-next-backlog branch of ubuntu-bionic, so for
B/C/D/unstable kernel, please apply the patch of the (2018-November/096882.html)
first, then apply this patch.


[Impact]
The mute led can't work on several lenovo laptop models after applying the
patch of #1805079, this is a regression introduced by that patch.

[Fix]
chanin the ALC269_FIXUP_THINKPAD_ACPI, this will make the led work again.


[Test Case]
press F1 and F4, the mute led and micmute led work well.


[Regression Potential]
Very low, this patch is specific to ALC285_FIXUP_LENOVO_HEADPHONE_NOISE, and
this FIXUP is specific several lenovo laptop models. I have tested audio and
led functions on those machines.


Hui Wang (1):
  ALSA: hda/realtek - Fix the mute LED regresion on Lenovo X1 Carbon

 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[B/C/D/unstable][PATCH 1/1] ALSA: hda/realtek - Fix the mute LED regresion on Lenovo X1 Carbon

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1808465

Users reported a mute LED regression on Lenovo X1 Carbon, the root
cause is we applied the fixup of ALC285_FIXUP_LENOVO_HEADPHONE_NOISE
to this machine, then the machine can't apply the fixup of
ALC269_FIXUP_THINKPAD_ACPI anymore. To fix it, we chain two fixup
together.

Fixes: c4cfcf6f4297 ("ALSA: hda/realtek - fix the pop noise on headphone for lenovo laptops")
Cc: <[hidden email]>
Signed-off-by: Hui Wang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit 6ba189c5c1a4bda70dc1e4826c58b0246068bb8d)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index c2b2cd7580f2..1aec6e22fadc 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6399,6 +6399,8 @@ static const struct hda_fixup alc269_fixups[] = {
  [ALC285_FIXUP_LENOVO_HEADPHONE_NOISE] = {
  .type = HDA_FIXUP_FUNC,
  .v.func = alc285_fixup_invalidate_dacs,
+ .chained = true,
+ .chain_id = ALC269_FIXUP_THINKPAD_ACPI
  },
 };
 
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NAK: [B/C/D/unstable][PATCH 1/1] ALSA: hda/realtek - Fix the mute LED regresion on Lenovo X1 Carbon

Po-Hsu Lin (Sam)
Seems that this patch cannot be cherry-picked for Bionic / Cosmic.
Can you please check if this needs to be backported for these two?

Thanks
Sam

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: NAK: [B/C/D/unstable][PATCH 1/1] ALSA: hda/realtek - Fix the mute LED regresion on Lenovo X1 Carbon

Hui Wang
Sorry make use confused. This patch depends on another patch (it is
based on the branch of master-next-backlog):

This patch fixes a regression introduced by a patch I sent in Nov
(https://lists.ubuntu.com/archives/kernel-team/2018-November/096882.html),
That patch got ack but not formally merged to ubuntu kernel yet, I generated
this patch on the master-next-backlog branch of ubuntu-bionic, so for
B/C/D/unstable kernel, please apply the patch of the (2018-November/096882.html)
first, then apply this patch.

On 2018/12/17 下午5:19, Po-Hsu Lin wrote:
> Seems that this patch cannot be cherry-picked for Bionic / Cosmic.
> Can you please check if this needs to be backported for these two?
>
> Thanks
> Sam
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: NAK: [B/C/D/unstable][PATCH 1/1] ALSA: hda/realtek - Fix the mute LED regresion on Lenovo X1 Carbon

Hui Wang
s/use/you/ :-)

On 2018/12/18 上午10:11, Hui Wang wrote:

> Sorry make use confused. This patch depends on another patch (it is
> based on the branch of master-next-backlog):
>
> This patch fixes a regression introduced by a patch I sent in Nov
> (https://lists.ubuntu.com/archives/kernel-team/2018-November/096882.html),
>
> That patch got ack but not formally merged to ubuntu kernel yet, I
> generated
> this patch on the master-next-backlog branch of ubuntu-bionic, so for
> B/C/D/unstable kernel, please apply the patch of the
> (2018-November/096882.html)
> first, then apply this patch.
>
> On 2018/12/17 下午5:19, Po-Hsu Lin wrote:
>> Seems that this patch cannot be cherry-picked for Bionic / Cosmic.
>> Can you please check if this needs to be backported for these two?
>>
>> Thanks
>> Sam
>>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [B/C/D/unstable][PATCH 1/1] ALSA: hda/realtek - Fix the mute LED regresion on Lenovo X1 Carbon

Po-Hsu Lin (Sam)
In reply to this post by Hui Wang
Ah ok, thanks for the explaination!

As the prerequisite patch has been applied to "master-next-backlog" branch and
will be pick up in January SRU [1], plus clean-cherry pick with chnage limited
to a specific HW:

Acked-by: Po-Hsu Lin <[hidden email]>

[1] https://lists.ubuntu.com/archives/kernel-team/2018-November/096930.html

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [B/C/D/unstable][PATCH 0/1] The mute led can't work on lenovo x1

Khaled Elmously
In reply to this post by Hui Wang
On 2018-12-14 13:41:43 , Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1808465
>
> This patch fixes a regression introduced by a patch I sent in Nov
> (https://lists.ubuntu.com/archives/kernel-team/2018-November/096882.html),
> That patch got ack but not formally merged to ubuntu kernel yet, I generated
> this patch on the master-next-backlog branch of ubuntu-bionic, so for
> B/C/D/unstable kernel, please apply the patch of the (2018-November/096882.html)
> first, then apply this patch.
>
>
> [Impact]
> The mute led can't work on several lenovo laptop models after applying the
> patch of #1805079, this is a regression introduced by that patch.
>
> [Fix]
> chanin the ALC269_FIXUP_THINKPAD_ACPI, this will make the led work again.
>
>
> [Test Case]
> press F1 and F4, the mute led and micmute led work well.
>
>
> [Regression Potential]
> Very low, this patch is specific to ALC285_FIXUP_LENOVO_HEADPHONE_NOISE, and
> this FIXUP is specific several lenovo laptop models. I have tested audio and
> led functions on those machines.
>
>
> Hui Wang (1):
>   ALSA: hda/realtek - Fix the mute LED regresion on Lenovo X1 Carbon
>
>  sound/pci/hda/patch_realtek.c | 2 ++
>  1 file changed, 2 insertions(+)
>
Acked-by: Khalid Elmously <[hidden email]>
 

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED(B,C,U): [B/C/D/unstable][PATCH 0/1] The mute led can't work on lenovo x1

Khaled Elmously
In reply to this post by Hui Wang
Applied to B, C and unstable (D is unstable right now so that's redundant)

On 2018-12-14 13:41:43 , Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1808465
>
> This patch fixes a regression introduced by a patch I sent in Nov
> (https://lists.ubuntu.com/archives/kernel-team/2018-November/096882.html),
> That patch got ack but not formally merged to ubuntu kernel yet, I generated
> this patch on the master-next-backlog branch of ubuntu-bionic, so for
> B/C/D/unstable kernel, please apply the patch of the (2018-November/096882.html)
> first, then apply this patch.
>
>
> [Impact]
> The mute led can't work on several lenovo laptop models after applying the
> patch of #1805079, this is a regression introduced by that patch.
>
> [Fix]
> chanin the ALC269_FIXUP_THINKPAD_ACPI, this will make the led work again.
>
>
> [Test Case]
> press F1 and F4, the mute led and micmute led work well.
>
>
> [Regression Potential]
> Very low, this patch is specific to ALC285_FIXUP_LENOVO_HEADPHONE_NOISE, and
> this FIXUP is specific several lenovo laptop models. I have tested audio and
> led functions on those machines.
>
>
> Hui Wang (1):
>   ALSA: hda/realtek - Fix the mute LED regresion on Lenovo X1 Carbon
>
>  sound/pci/hda/patch_realtek.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED(D): [B/C/D/unstable][PATCH 0/1] The mute led can't work on lenovo x1

Khaled Elmously
In reply to this post by Hui Wang
apparently Disco is no longer unstable.

Applied to Disco now too


On 2018-12-14 13:41:43 , Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1808465
>
> This patch fixes a regression introduced by a patch I sent in Nov
> (https://lists.ubuntu.com/archives/kernel-team/2018-November/096882.html),
> That patch got ack but not formally merged to ubuntu kernel yet, I generated
> this patch on the master-next-backlog branch of ubuntu-bionic, so for
> B/C/D/unstable kernel, please apply the patch of the (2018-November/096882.html)
> first, then apply this patch.
>
>
> [Impact]
> The mute led can't work on several lenovo laptop models after applying the
> patch of #1805079, this is a regression introduced by that patch.
>
> [Fix]
> chanin the ALC269_FIXUP_THINKPAD_ACPI, this will make the led work again.
>
>
> [Test Case]
> press F1 and F4, the mute led and micmute led work well.
>
>
> [Regression Potential]
> Very low, this patch is specific to ALC285_FIXUP_LENOVO_HEADPHONE_NOISE, and
> this FIXUP is specific several lenovo laptop models. I have tested audio and
> led functions on those machines.
>
>
> Hui Wang (1):
>   ALSA: hda/realtek - Fix the mute LED regresion on Lenovo X1 Carbon
>
>  sound/pci/hda/patch_realtek.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team