[B][D][E][F][SRU][PATCH 0/1] UBUNTU: SAUCE: Fix RK818 ID template

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[B][D][E][F][SRU][PATCH 0/1] UBUNTU: SAUCE: Fix RK818 ID template

Po-Hsu Lin (Sam)
BugLink: https://bugs.launchpad.net/bugs/1853192

== SRU Justification ==
User reported that Ubuntu will hang at boot on Rockchip boards with
RK818 power management IC (PMIC), it's because the chip ID was wrong.

It should be changed from 0x8181 to 0x8180.

== Fix ==
* 37ef8c2c (mfd: rk808: Fix RK818 ID template) in linux-next

This patch can be cherry-picked into E/F.
For B/D, this patch needs to be backported with some context
adjustment as the entries for RK817/RK809 were not there.

== Test ==
Test kernels can be found here:
https://people.canonical.com/~phlin/kernel/lp-1853192-RK818/

These test kernels were built with ROCKCHIP ARM64 support enabled
(bug 1825222) have been tested by the bug reporter, Paweł Jarosz,
and the test results are good.

== Regression Potentail ==
Low, ID change limited to a specific hardware.

Daniel Schultz (1):
  mfd: rk808: Fix RK818 ID template

 include/linux/mfd/rk808.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[B][D][SRU][PATCH 1/1] UBUNTU: SAUCE: mfd: rk808: Fix RK818 ID template

Po-Hsu Lin (Sam)
From: Daniel Schultz <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1853192

The Rockchip PMIC driver can automatically detect connected component
versions by reading the ID_MSB and ID_LSB registers. The probe function
will always fail with RK818 PMICs because the ID_MSK is 0xFFF0 and the
RK818 template ID is 0x8181.

This patch changes this value to 0x8180.

Fixes: 9d6105e19f61 ("mfd: rk808: Fix up the chip id get failed")
Cc: [hidden email]
Cc: Elaine Zhang <[hidden email]>
Cc: Joseph Chen <[hidden email]>
Signed-off-by: Daniel Schultz <[hidden email]>
Signed-off-by: Heiko Stuebner <[hidden email]>
Signed-off-by: Lee Jones <[hidden email]>
(backported from commit 37ef8c2c15bdc1322b160e38986c187de2b877b2 linux-next)
[PHLin: content adjustment to skip RK817/RK809, which belongs to 586c1b41]
Signed-off-by: Po-Hsu Lin <[hidden email]>
---
 include/linux/mfd/rk808.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h
index d315659..338e0f6 100644
--- a/include/linux/mfd/rk808.h
+++ b/include/linux/mfd/rk808.h
@@ -443,7 +443,7 @@ enum {
 enum {
  RK805_ID = 0x8050,
  RK808_ID = 0x0000,
- RK818_ID = 0x8181,
+ RK818_ID = 0x8180,
 };
 
 struct rk808 {
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[E][F][SRU][PATCH 1/1] UBUNTU: SAUCE: mfd: rk808: Fix RK818 ID template

Po-Hsu Lin (Sam)
In reply to this post by Po-Hsu Lin (Sam)
From: Daniel Schultz <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1853192

The Rockchip PMIC driver can automatically detect connected component
versions by reading the ID_MSB and ID_LSB registers. The probe function
will always fail with RK818 PMICs because the ID_MSK is 0xFFF0 and the
RK818 template ID is 0x8181.

This patch changes this value to 0x8180.

Fixes: 9d6105e19f61 ("mfd: rk808: Fix up the chip id get failed")
Cc: [hidden email]
Cc: Elaine Zhang <[hidden email]>
Cc: Joseph Chen <[hidden email]>
Signed-off-by: Daniel Schultz <[hidden email]>
Signed-off-by: Heiko Stuebner <[hidden email]>
Signed-off-by: Lee Jones <[hidden email]>
(cherry picked from commit 37ef8c2c15bdc1322b160e38986c187de2b877b2 linux-next)
Signed-off-by: Po-Hsu Lin <[hidden email]>
---
 include/linux/mfd/rk808.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h
index 7cfd2b0..a59bf32 100644
--- a/include/linux/mfd/rk808.h
+++ b/include/linux/mfd/rk808.h
@@ -610,7 +610,7 @@ enum {
  RK808_ID = 0x0000,
  RK809_ID = 0x8090,
  RK817_ID = 0x8170,
- RK818_ID = 0x8181,
+ RK818_ID = 0x8180,
 };
 
 struct rk808 {
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [B][D][E][F][SRU][PATCH 0/1] UBUNTU: SAUCE: Fix RK818 ID template

You-Sheng Yang
In reply to this post by Po-Hsu Lin (Sam)
Acked-By: You-Sheng Yang <[hidden email]>

On 2019-11-22 16:48, Po-Hsu Lin wrote:

> BugLink: https://bugs.launchpad.net/bugs/1853192
>
> == SRU Justification ==
> User reported that Ubuntu will hang at boot on Rockchip boards with
> RK818 power management IC (PMIC), it's because the chip ID was wrong.
>
> It should be changed from 0x8181 to 0x8180.
>
> == Fix ==
> * 37ef8c2c (mfd: rk808: Fix RK818 ID template) in linux-next
>
> This patch can be cherry-picked into E/F.
> For B/D, this patch needs to be backported with some context
> adjustment as the entries for RK817/RK809 were not there.
>
> == Test ==
> Test kernels can be found here:
> https://people.canonical.com/~phlin/kernel/lp-1853192-RK818/
>
> These test kernels were built with ROCKCHIP ARM64 support enabled
> (bug 1825222) have been tested by the bug reporter, Paweł Jarosz,
> and the test results are good.
>
> == Regression Potentail ==
> Low, ID change limited to a specific hardware.
>
> Daniel Schultz (1):
>   mfd: rk808: Fix RK818 ID template
>
>  include/linux/mfd/rk808.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [B][D][E][F][SRU][PATCH 0/1] UBUNTU: SAUCE: Fix RK818 ID template

Stefan Bader-2
In reply to this post by Po-Hsu Lin (Sam)
On 22.11.19 09:48, Po-Hsu Lin wrote:

> BugLink: https://bugs.launchpad.net/bugs/1853192
>
> == SRU Justification ==
> User reported that Ubuntu will hang at boot on Rockchip boards with
> RK818 power management IC (PMIC), it's because the chip ID was wrong.
>
> It should be changed from 0x8181 to 0x8180.
>
> == Fix ==
> * 37ef8c2c (mfd: rk808: Fix RK818 ID template) in linux-next
>
> This patch can be cherry-picked into E/F.
> For B/D, this patch needs to be backported with some context
> adjustment as the entries for RK817/RK809 were not there.
>
> == Test ==
> Test kernels can be found here:
> https://people.canonical.com/~phlin/kernel/lp-1853192-RK818/
>
> These test kernels were built with ROCKCHIP ARM64 support enabled
> (bug 1825222) have been tested by the bug reporter, Paweł Jarosz,
> and the test results are good.
>
> == Regression Potentail ==
> Low, ID change limited to a specific hardware.
>
> Daniel Schultz (1):
>   mfd: rk808: Fix RK818 ID template
>
>  include/linux/mfd/rk808.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Stefan Bader <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED(unstable): [B][D][E][F][SRU][PATCH 0/1] UBUNTU: SAUCE: Fix RK818 ID template

Andrea Righi
In reply to this post by Po-Hsu Lin (Sam)
On Fri, Nov 22, 2019 at 04:48:04PM +0800, Po-Hsu Lin wrote:

> BugLink: https://bugs.launchpad.net/bugs/1853192
>
> == SRU Justification ==
> User reported that Ubuntu will hang at boot on Rockchip boards with
> RK818 power management IC (PMIC), it's because the chip ID was wrong.
>
> It should be changed from 0x8181 to 0x8180.
>
> == Fix ==
> * 37ef8c2c (mfd: rk808: Fix RK818 ID template) in linux-next
>
> This patch can be cherry-picked into E/F.
> For B/D, this patch needs to be backported with some context
> adjustment as the entries for RK817/RK809 were not there.
>
> == Test ==
> Test kernels can be found here:
> https://people.canonical.com/~phlin/kernel/lp-1853192-RK818/
>
> These test kernels were built with ROCKCHIP ARM64 support enabled
> (bug 1825222) have been tested by the bug reporter, Paweł Jarosz,
> and the test results are good.
>
> == Regression Potentail ==
> Low, ID change limited to a specific hardware.
>
> Daniel Schultz (1):
>   mfd: rk808: Fix RK818 ID template
>
>  include/linux/mfd/rk808.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[B/D/E]/cmnt: [B][D][E][F][SRU][PATCH 0/1] UBUNTU: SAUCE: Fix RK818 ID template

Kleber Souza
In reply to this post by Po-Hsu Lin (Sam)
On 2019-11-22 09:48, Po-Hsu Lin wrote:

> BugLink: https://bugs.launchpad.net/bugs/1853192
>
> == SRU Justification ==
> User reported that Ubuntu will hang at boot on Rockchip boards with
> RK818 power management IC (PMIC), it's because the chip ID was wrong.
>
> It should be changed from 0x8181 to 0x8180.
>
> == Fix ==
> * 37ef8c2c (mfd: rk808: Fix RK818 ID template) in linux-next
>
> This patch can be cherry-picked into E/F.
> For B/D, this patch needs to be backported with some context
> adjustment as the entries for RK817/RK809 were not there.
>
> == Test ==
> Test kernels can be found here:
> https://people.canonical.com/~phlin/kernel/lp-1853192-RK818/
>
> These test kernels were built with ROCKCHIP ARM64 support enabled
> (bug 1825222) have been tested by the bug reporter, Paweł Jarosz,
> and the test results are good.
>
> == Regression Potentail ==
> Low, ID change limited to a specific hardware.
>
> Daniel Schultz (1):
>   mfd: rk808: Fix RK818 ID template
>
>  include/linux/mfd/rk808.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied to bionic, disco and eoan master-next branch, removing
'linux-next' from the provenance since this patch was already
applied to Linus' tree.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team