[B][D][E][SRU][PATCH 0/1] Enable VIMC module

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[B][D][E][SRU][PATCH 0/1] Enable VIMC module

Po-Hsu Lin (Sam)
BugLink: https://bugs.launchpad.net/bugs/1831482

== SRU Justification ==
VIMC is a virtual media controller that can emulate a real media device.
This is useful for automated tests, and development of multimedia frameworks.

== Fix ==
Enable VIMC as a module in B/D/E kernel configs.

== Test ==
Test kernels could be found here:
https://people.canonical.com/~phlin/kernel/lp-1831482-cfg-vimc/

User has reported that the Eoan kernel works as expected.
I have also smoke tested the B/D kernel to make sure the VIMC modules
can be loaded properly.

== Regression Potential ==
Low, this patchset just enable the VIMC module support.

Po-Hsu Lin (1):
  UBUNTU: [Config] Enable VIMC module

 debian.master/config/config.common.ubuntu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[B][SRU][PATCH 1/1] UBUNTU: [Config] Enable VIMC module

Po-Hsu Lin (Sam)
BugLink: https://bugs.launchpad.net/bugs/1831482

VIMC is a virtual media controller that can emulate a real media device.
This is useful for automated tests, and development of multimedia frameworks.

Signed-off-by: Po-Hsu Lin <[hidden email]>
---
 debian.master/config/config.common.ubuntu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index c633d6d..edef7f2 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -10143,7 +10143,7 @@ CONFIG_VIDEO_V4L2_SUBDEV_API=y
 CONFIG_VIDEO_V4L2_TPG=m
 CONFIG_VIDEO_VIA_CAMERA=m
 CONFIG_VIDEO_VIM2M=m
-# CONFIG_VIDEO_VIMC is not set
+CONFIG_VIDEO_VIMC=m
 CONFIG_VIDEO_VIVID=m
 CONFIG_VIDEO_VIVID_CEC=y
 CONFIG_VIDEO_VIVID_MAX_DEVS=64
--
2.7.4

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[D][E][SRU][PATCH 1/1] UBUNTU: [Config] Enable VIMC module

Po-Hsu Lin (Sam)
In reply to this post by Po-Hsu Lin (Sam)
BugLink: https://bugs.launchpad.net/bugs/1831482

VIMC is a virtual media controller that can emulate a real media device.
This is useful for automated tests, and development of multimedia frameworks.

Signed-off-by: Po-Hsu Lin <[hidden email]>
---
 debian.master/config/config.common.ubuntu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index bb855f1..a0ffc55 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -10635,7 +10635,7 @@ CONFIG_VIDEO_V4L2_TPG=m
 CONFIG_VIDEO_VIA_CAMERA=m
 CONFIG_VIDEO_VICODEC=m
 CONFIG_VIDEO_VIM2M=m
-# CONFIG_VIDEO_VIMC is not set
+CONFIG_VIDEO_VIMC=m
 CONFIG_VIDEO_VIVID=m
 CONFIG_VIDEO_VIVID_CEC=y
 CONFIG_VIDEO_VIVID_MAX_DEVS=64
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NAK: [B][D][E][SRU][PATCH 0/1] Enable VIMC module

Seth Forshee
In reply to this post by Po-Hsu Lin (Sam)
On Thu, Aug 01, 2019 at 12:03:59PM +0800, Po-Hsu Lin wrote:

> BugLink: https://bugs.launchpad.net/bugs/1831482
>
> == SRU Justification ==
> VIMC is a virtual media controller that can emulate a real media device.
> This is useful for automated tests, and development of multimedia frameworks.
>
> == Fix ==
> Enable VIMC as a module in B/D/E kernel configs.
>
> == Test ==
> Test kernels could be found here:
> https://people.canonical.com/~phlin/kernel/lp-1831482-cfg-vimc/
>
> User has reported that the Eoan kernel works as expected.
> I have also smoke tested the B/D kernel to make sure the VIMC modules
> can be loaded properly.
>
> == Regression Potential ==
> Low, this patchset just enable the VIMC module support.

As a rule we don't enable these sorts of drivers as they are generally
only meant for developers, who generally will be building their own
kernels anyway. But if this one will be used for automated tests then it
makes sense to enable it.

However we should also update the annotations file to note the bug
number which explains why we've enabled it. Can you resend this with the
annotations update?

Thanks,
Seth

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: NAK: [B][D][E][SRU][PATCH 0/1] Enable VIMC module

Po-Hsu Lin (Sam)
Hi Seth,
nice to know we have this rule.

A side note is that for now we don't have any test that depends on
this module (perhaps we can investigate for one in the future, after
knowing such driver exists), should we keep going and enable this?

Thanks
Sam


On Thu, Aug 8, 2019 at 11:16 PM Seth Forshee <[hidden email]> wrote:

>
> On Thu, Aug 01, 2019 at 12:03:59PM +0800, Po-Hsu Lin wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1831482
> >
> > == SRU Justification ==
> > VIMC is a virtual media controller that can emulate a real media device.
> > This is useful for automated tests, and development of multimedia frameworks.
> >
> > == Fix ==
> > Enable VIMC as a module in B/D/E kernel configs.
> >
> > == Test ==
> > Test kernels could be found here:
> > https://people.canonical.com/~phlin/kernel/lp-1831482-cfg-vimc/
> >
> > User has reported that the Eoan kernel works as expected.
> > I have also smoke tested the B/D kernel to make sure the VIMC modules
> > can be loaded properly.
> >
> > == Regression Potential ==
> > Low, this patchset just enable the VIMC module support.
>
> As a rule we don't enable these sorts of drivers as they are generally
> only meant for developers, who generally will be building their own
> kernels anyway. But if this one will be used for automated tests then it
> makes sense to enable it.
>
> However we should also update the annotations file to note the bug
> number which explains why we've enabled it. Can you resend this with the
> annotations update?
>
> Thanks,
> Seth

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: NAK: [B][D][E][SRU][PATCH 0/1] Enable VIMC module

Seth Forshee
On Mon, Aug 12, 2019 at 12:39:38PM +0800, Po-Hsu Lin wrote:
> Hi Seth,
> nice to know we have this rule.
>
> A side note is that for now we don't have any test that depends on
> this module (perhaps we can investigate for one in the future, after
> knowing such driver exists), should we keep going and enable this?

It's fine to enable it if it is useful to end users, and since someone
is requesting it I guess it must have some use.

Seth

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team