[Bionic][PATCH] UBUNTU: SAUCE: fix warning from "ipvlan: drop ipv6 dependency"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bionic][PATCH] UBUNTU: SAUCE: fix warning from "ipvlan: drop ipv6 dependency"

Kamal Mostafa-2
Backport commit eacec4b "ipvlan: drop ipv6 dependency" inadvertently
introduced an unused function ipvlan_is_valid_dev(), which should be
dropped.

Ignore: yes

Signed-off-by: Kamal Mostafa <[hidden email]>
---
 drivers/net/ipvlan/ipvlan_main.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index 0cfbcdf..b858e98 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -847,19 +847,6 @@ static void ipvlan_del_addr(struct ipvl_dev *ipvlan, void *iaddr, bool is_v6)
  kfree_rcu(addr, rcu);
 }
 
-static bool ipvlan_is_valid_dev(const struct net_device *dev)
-{
- struct ipvl_dev *ipvlan = netdev_priv(dev);
-
- if (!netif_is_ipvlan(dev))
- return false;
-
- if (!ipvlan || !ipvlan->port)
- return false;
-
- return true;
-}
-
 #if IS_ENABLED(CONFIG_IPV6)
 static int ipvlan_add_addr6(struct ipvl_dev *ipvlan, struct in6_addr *ip6_addr)
 {
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [Bionic][PATCH] UBUNTU: SAUCE: fix warning from "ipvlan: drop ipv6 dependency"

Joseph Salisbury-3
On 08/07/2018 07:24 PM, Kamal Mostafa wrote:

> Backport commit eacec4b "ipvlan: drop ipv6 dependency" inadvertently
> introduced an unused function ipvlan_is_valid_dev(), which should be
> dropped.
>
> Ignore: yes
>
> Signed-off-by: Kamal Mostafa <[hidden email]>
> ---
>  drivers/net/ipvlan/ipvlan_main.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
> index 0cfbcdf..b858e98 100644
> --- a/drivers/net/ipvlan/ipvlan_main.c
> +++ b/drivers/net/ipvlan/ipvlan_main.c
> @@ -847,19 +847,6 @@ static void ipvlan_del_addr(struct ipvl_dev *ipvlan, void *iaddr, bool is_v6)
>   kfree_rcu(addr, rcu);
>  }
>  
> -static bool ipvlan_is_valid_dev(const struct net_device *dev)
> -{
> - struct ipvl_dev *ipvlan = netdev_priv(dev);
> -
> - if (!netif_is_ipvlan(dev))
> - return false;
> -
> - if (!ipvlan || !ipvlan->port)
> - return false;
> -
> - return true;
> -}
> -
>  #if IS_ENABLED(CONFIG_IPV6)
>  static int ipvlan_add_addr6(struct ipvl_dev *ipvlan, struct in6_addr *ip6_addr)
>  {

Acked-by: Joseph Salisbury <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [Bionic][PATCH] UBUNTU: SAUCE: fix warning from "ipvlan: drop ipv6 dependency"

Khaled Elmously
In reply to this post by Kamal Mostafa-2
On 2018-08-07 16:24:29 , Kamal Mostafa wrote:

> Backport commit eacec4b "ipvlan: drop ipv6 dependency" inadvertently
> introduced an unused function ipvlan_is_valid_dev(), which should be
> dropped.
>
> Ignore: yes
>
> Signed-off-by: Kamal Mostafa <[hidden email]>
> ---
>  drivers/net/ipvlan/ipvlan_main.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
> index 0cfbcdf..b858e98 100644
> --- a/drivers/net/ipvlan/ipvlan_main.c
> +++ b/drivers/net/ipvlan/ipvlan_main.c
> @@ -847,19 +847,6 @@ static void ipvlan_del_addr(struct ipvl_dev *ipvlan, void *iaddr, bool is_v6)
>   kfree_rcu(addr, rcu);
>  }
>  
> -static bool ipvlan_is_valid_dev(const struct net_device *dev)
> -{
> - struct ipvl_dev *ipvlan = netdev_priv(dev);
> -
> - if (!netif_is_ipvlan(dev))
> - return false;
> -
> - if (!ipvlan || !ipvlan->port)
> - return false;
> -
> - return true;
> -}
> -
>  #if IS_ENABLED(CONFIG_IPV6)
>  static int ipvlan_add_addr6(struct ipvl_dev *ipvlan, struct in6_addr *ip6_addr)
>  {
> --

Not sure what to do for the next 49 minutes....

Acked-by: Khalid Elmously <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [Bionic][PATCH] UBUNTU: SAUCE: fix warning from "ipvlan: drop ipv6 dependency"

Kleber Souza
In reply to this post by Kamal Mostafa-2
On 08/08/18 01:24, Kamal Mostafa wrote:
> Backport commit eacec4b "ipvlan: drop ipv6 dependency" inadvertently
> introduced an unused function ipvlan_is_valid_dev(), which should be
> dropped.
>
> Ignore: yes

Hi Kamal,

Any reason why we don't want this fix on the changelog?


thanks,
Kleber

>
> Signed-off-by: Kamal Mostafa <[hidden email]>
> ---
>  drivers/net/ipvlan/ipvlan_main.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
> index 0cfbcdf..b858e98 100644
> --- a/drivers/net/ipvlan/ipvlan_main.c
> +++ b/drivers/net/ipvlan/ipvlan_main.c
> @@ -847,19 +847,6 @@ static void ipvlan_del_addr(struct ipvl_dev *ipvlan, void *iaddr, bool is_v6)
>   kfree_rcu(addr, rcu);
>  }
>  
> -static bool ipvlan_is_valid_dev(const struct net_device *dev)
> -{
> - struct ipvl_dev *ipvlan = netdev_priv(dev);
> -
> - if (!netif_is_ipvlan(dev))
> - return false;
> -
> - if (!ipvlan || !ipvlan->port)
> - return false;
> -
> - return true;
> -}
> -
>  #if IS_ENABLED(CONFIG_IPV6)
>  static int ipvlan_add_addr6(struct ipvl_dev *ipvlan, struct in6_addr *ip6_addr)
>  {
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [Bionic][PATCH] UBUNTU: SAUCE: fix warning from "ipvlan: drop ipv6 dependency"

Kamal Mostafa-2
As discussed in irc, please drop the Ignore, and add a BugLink to the original commit when you apply:

 -Kamal

On Tue, Aug 14, 2018 at 5:52 AM Kleber Souza <[hidden email]> wrote:
On 08/08/18 01:24, Kamal Mostafa wrote:
> Backport commit eacec4b "ipvlan: drop ipv6 dependency" inadvertently
> introduced an unused function ipvlan_is_valid_dev(), which should be
> dropped.
>
> Ignore: yes

Hi Kamal,

Any reason why we don't want this fix on the changelog?


thanks,
Kleber

>
> Signed-off-by: Kamal Mostafa <[hidden email]>
> ---
>  drivers/net/ipvlan/ipvlan_main.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
> index 0cfbcdf..b858e98 100644
> --- a/drivers/net/ipvlan/ipvlan_main.c
> +++ b/drivers/net/ipvlan/ipvlan_main.c
> @@ -847,19 +847,6 @@ static void ipvlan_del_addr(struct ipvl_dev *ipvlan, void *iaddr, bool is_v6)
>       kfree_rcu(addr, rcu);
>  }

> -static bool ipvlan_is_valid_dev(const struct net_device *dev)
> -{
> -     struct ipvl_dev *ipvlan = netdev_priv(dev);
> -
> -     if (!netif_is_ipvlan(dev))
> -             return false;
> -
> -     if (!ipvlan || !ipvlan->port)
> -             return false;
> -
> -     return true;
> -}
> -
>  #if IS_ENABLED(CONFIG_IPV6)
>  static int ipvlan_add_addr6(struct ipvl_dev *ipvlan, struct in6_addr *ip6_addr)
>  {
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [Bionic][PATCH] UBUNTU: SAUCE: fix warning from "ipvlan: drop ipv6 dependency"

Kleber Souza
In reply to this post by Kamal Mostafa-2
On 08/08/18 01:24, Kamal Mostafa wrote:
> Backport commit eacec4b "ipvlan: drop ipv6 dependency" inadvertently
> introduced an unused function ipvlan_is_valid_dev(), which should be
> dropped.
>
> Ignore: yes

Applied to bionic/master-next branch, removing the above line and adding:

BugLink: http://bugs.launchpad.net/bugs/1776927



Thanks,
Kleber

>
> Signed-off-by: Kamal Mostafa <[hidden email]>
> ---
>  drivers/net/ipvlan/ipvlan_main.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
> index 0cfbcdf..b858e98 100644
> --- a/drivers/net/ipvlan/ipvlan_main.c
> +++ b/drivers/net/ipvlan/ipvlan_main.c
> @@ -847,19 +847,6 @@ static void ipvlan_del_addr(struct ipvl_dev *ipvlan, void *iaddr, bool is_v6)
>   kfree_rcu(addr, rcu);
>  }
>  
> -static bool ipvlan_is_valid_dev(const struct net_device *dev)
> -{
> - struct ipvl_dev *ipvlan = netdev_priv(dev);
> -
> - if (!netif_is_ipvlan(dev))
> - return false;
> -
> - if (!ipvlan || !ipvlan->port)
> - return false;
> -
> - return true;
> -}
> -
>  #if IS_ENABLED(CONFIG_IPV6)
>  static int ipvlan_add_addr6(struct ipvl_dev *ipvlan, struct in6_addr *ip6_addr)
>  {
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team