[Bionic][deb-to-snap master][Patch] deb to snap: install updates before building

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bionic][deb-to-snap master][Patch] deb to snap: install updates before building

Robert Liu
BugLink: https://launchpad.net/bugs/1808768

Install updates after deboostrap to avoid using out-of-date packages.

Signed-off-by: Robert Liu <[hidden email]>
---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Makefile b/Makefile
index 0a9a7c4..c60d6a4 100644
--- a/Makefile
+++ b/Makefile
@@ -67,6 +67,9 @@ install : KVERS = $(shell ls -1 chroot/boot/vmlinuz-*| tail -1 |sed 's/^.*vmlinu
 all:
  debootstrap --variant=minbase $(RELEASE) chroot
  cp /etc/apt/sources.list chroot/etc/apt/sources.list
+ # install all updates
+ $(ENV) chroot chroot apt-get -y update
+ $(ENV) chroot chroot apt-get -y upgrade
  echo "deb http://ppa.launchpad.net/snappy-dev/image/ubuntu $(RELEASE) main" >> chroot/etc/apt/sources.list
  if [ "$(PROPOSED)" = "true" ]; then \
   echo "deb http://$(MIRROR) $(RELEASE)-proposed main restricted" >> chroot/etc/apt/sources.list; \
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [Bionic][deb-to-snap master][Patch] deb to snap: install updates before building

Wen-chien Jesse Sung
Acked-By: Wen-chien Jesse Sung <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [Bionic][deb-to-snap master][Patch] deb to snap: install updates before building

Paolo Pisati-5
In reply to this post by Robert Liu
Acked-by: Paolo Pisati <[hidden email]>

both for Xenial and Bionic

On Mon, Dec 17, 2018 at 12:06 PM Robert Liu <[hidden email]> wrote:

>
> BugLink: https://launchpad.net/bugs/1808768
>
> Install updates after deboostrap to avoid using out-of-date packages.
>
> Signed-off-by: Robert Liu <[hidden email]>
> ---
>  Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 0a9a7c4..c60d6a4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -67,6 +67,9 @@ install : KVERS = $(shell ls -1 chroot/boot/vmlinuz-*| tail -1 |sed 's/^.*vmlinu
>  all:
>         debootstrap --variant=minbase $(RELEASE) chroot
>         cp /etc/apt/sources.list chroot/etc/apt/sources.list
> +       # install all updates
> +       $(ENV) chroot chroot apt-get -y update
> +       $(ENV) chroot chroot apt-get -y upgrade
>         echo "deb http://ppa.launchpad.net/snappy-dev/image/ubuntu $(RELEASE) main" >> chroot/etc/apt/sources.list
>         if [ "$(PROPOSED)" = "true" ]; then \
>           echo "deb http://$(MIRROR) $(RELEASE)-proposed main restricted" >> chroot/etc/apt/sources.list; \
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



--
bye,
p.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [Bionic][deb-to-snap master][Patch] deb to snap: install updates before building

Stefan Bader-2
In reply to this post by Robert Liu
On 17.12.18 12:06, Robert Liu wrote:
> BugLink: https://launchpad.net/bugs/1808768
>
> Install updates after deboostrap to avoid using out-of-date packages.
>
> Signed-off-by: Robert Liu <[hidden email]>
> ---
Applied to bionic/linux-snap/master. Thanks.

-Stefan

>  Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 0a9a7c4..c60d6a4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -67,6 +67,9 @@ install : KVERS = $(shell ls -1 chroot/boot/vmlinuz-*| tail -1 |sed 's/^.*vmlinu
>  all:
>   debootstrap --variant=minbase $(RELEASE) chroot
>   cp /etc/apt/sources.list chroot/etc/apt/sources.list
> + # install all updates
> + $(ENV) chroot chroot apt-get -y update
> + $(ENV) chroot chroot apt-get -y upgrade
>   echo "deb http://ppa.launchpad.net/snappy-dev/image/ubuntu $(RELEASE) main" >> chroot/etc/apt/sources.list
>   if [ "$(PROPOSED)" = "true" ]; then \
>    echo "deb http://$(MIRROR) $(RELEASE)-proposed main restricted" >> chroot/etc/apt/sources.list; \
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment