[F/G/H/Unstable][SRU][PATCH 0/1] selftests/powerpc/eeh: increase timeout for eeh-basic

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[F/G/H/Unstable][SRU][PATCH 0/1] selftests/powerpc/eeh: increase timeout for eeh-basic

Po-Hsu Lin (Sam)
[Impact]
The breakable devices test is hardware-dependent. In our test pool
it will take about:
* 30 seconds to run on a Power8 system that with 5 breakable devices,
* 60 seconds to run on a Power9 system that with 4 breakable devices.

The default 45 seconds kselftest framework timeout is not enough to
allow this test to finish on some nodes. Thus causing this test to
fail with TIMEOUT error.

[Fix]
* f5eca0b279117f ("selftests/powerpc/eeh: disable kselftest timeout
setting for eeh-basic")

We have this testcase since Focal, and this patch can be cherry-picked
into all affected releases.

[Test case]
Run this test on P9 node baltar, on which this timeout issue can be
100% reproduced. With this patch applied, the test can finish without
being terminated by the default timeout.

[Where problems could occur]
This will make test takes longer to finish, but it's still being
controlled by the timeout mechanism both in the test case and
kselftest framework. It's unlikely to make the test hang forever.

Po-Hsu Lin (1):
  selftests/powerpc/eeh: disable kselftest timeout setting for eeh-basic

 tools/testing/selftests/powerpc/eeh/Makefile | 2 +-
 tools/testing/selftests/powerpc/eeh/settings | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/powerpc/eeh/settings

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[F/G/H/Unstable][SRU][PATCH 1/1] selftests/powerpc/eeh: disable kselftest timeout setting for eeh-basic

Po-Hsu Lin (Sam)
BugLink: https://bugs.launchpad.net/bugs/1882503

The eeh-basic test got its own 60 seconds timeout (defined in commit
414f50434aa2 "selftests/eeh: Bump EEH wait time to 60s") per breakable
device.

And we have discovered that the number of breakable devices varies
on different hardware. The device recovery time ranges from 0 to 35
seconds. In our test pool it will take about 30 seconds to run on a
Power8 system that with 5 breakable devices, 60 seconds to run on a
Power9 system that with 4 breakable devices.

Extend the timeout setting in the kselftest framework to 5 minutes
to give it a chance to finish.

Signed-off-by: Po-Hsu Lin <[hidden email]>
Signed-off-by: Michael Ellerman <[hidden email]>
Link: https://lore.kernel.org/r/20201023024539.9512-1-po-hsu.lin@...
(cherry picked from commit f5eca0b279117f25020112a2f65ec9c3ea25f3ac)
Signed-off-by: Po-Hsu Lin <[hidden email]>
---
 tools/testing/selftests/powerpc/eeh/Makefile | 2 +-
 tools/testing/selftests/powerpc/eeh/settings | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/powerpc/eeh/settings

diff --git a/tools/testing/selftests/powerpc/eeh/Makefile b/tools/testing/selftests/powerpc/eeh/Makefile
index b397bab..ae963eb 100644
--- a/tools/testing/selftests/powerpc/eeh/Makefile
+++ b/tools/testing/selftests/powerpc/eeh/Makefile
@@ -3,7 +3,7 @@ noarg:
  $(MAKE) -C ../
 
 TEST_PROGS := eeh-basic.sh
-TEST_FILES := eeh-functions.sh
+TEST_FILES := eeh-functions.sh settings
 
 top_srcdir = ../../../../..
 include ../../lib.mk
diff --git a/tools/testing/selftests/powerpc/eeh/settings b/tools/testing/selftests/powerpc/eeh/settings
new file mode 100644
index 0000000..694d707
--- /dev/null
+++ b/tools/testing/selftests/powerpc/eeh/settings
@@ -0,0 +1 @@
+timeout=300
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK / APPLIED[Unstable]: [F/G/H/Unstable][SRU][PATCH 0/1] selftests/powerpc/eeh: increase timeout for eeh-basic

Seth Forshee
In reply to this post by Po-Hsu Lin (Sam)
On Fri, Dec 18, 2020 at 05:50:13PM +0800, Po-Hsu Lin wrote:

> [Impact]
> The breakable devices test is hardware-dependent. In our test pool
> it will take about:
> * 30 seconds to run on a Power8 system that with 5 breakable devices,
> * 60 seconds to run on a Power9 system that with 4 breakable devices.
>
> The default 45 seconds kselftest framework timeout is not enough to
> allow this test to finish on some nodes. Thus causing this test to
> fail with TIMEOUT error.
>
> [Fix]
> * f5eca0b279117f ("selftests/powerpc/eeh: disable kselftest timeout
> setting for eeh-basic")
>
> We have this testcase since Focal, and this patch can be cherry-picked
> into all affected releases.
>
> [Test case]
> Run this test on P9 node baltar, on which this timeout issue can be
> 100% reproduced. With this patch applied, the test can finish without
> being terminated by the default timeout.
>
> [Where problems could occur]
> This will make test takes longer to finish, but it's still being
> controlled by the timeout mechanism both in the test case and
> kselftest framework. It's unlikely to make the test hang forever.
>
> Po-Hsu Lin (1):
>   selftests/powerpc/eeh: disable kselftest timeout setting for eeh-basic

Acked-by: Seth Forshee <[hidden email]>

Applied to unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [F/G/H/Unstable][SRU][PATCH 0/1] selftests/powerpc/eeh: increase timeout for eeh-basic

Stefan Bader-2
In reply to this post by Po-Hsu Lin (Sam)
On 18.12.20 10:50, Po-Hsu Lin wrote:

> [Impact]
> The breakable devices test is hardware-dependent. In our test pool
> it will take about:
> * 30 seconds to run on a Power8 system that with 5 breakable devices,
> * 60 seconds to run on a Power9 system that with 4 breakable devices.
>
> The default 45 seconds kselftest framework timeout is not enough to
> allow this test to finish on some nodes. Thus causing this test to
> fail with TIMEOUT error.
>
> [Fix]
> * f5eca0b279117f ("selftests/powerpc/eeh: disable kselftest timeout
> setting for eeh-basic")
>
> We have this testcase since Focal, and this patch can be cherry-picked
> into all affected releases.
>
> [Test case]
> Run this test on P9 node baltar, on which this timeout issue can be
> 100% reproduced. With this patch applied, the test can finish without
> being terminated by the default timeout.
>
> [Where problems could occur]
> This will make test takes longer to finish, but it's still being
> controlled by the timeout mechanism both in the test case and
> kselftest framework. It's unlikely to make the test hang forever.
>
> Po-Hsu Lin (1):
>   selftests/powerpc/eeh: disable kselftest timeout setting for eeh-basic
>
>  tools/testing/selftests/powerpc/eeh/Makefile | 2 +-
>  tools/testing/selftests/powerpc/eeh/settings | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>  create mode 100644 tools/testing/selftests/powerpc/eeh/settings
>
Acked-by: Stefan Bader <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[F/G]: [F/G/H/Unstable][SRU][PATCH 0/1] selftests/powerpc/eeh: increase timeout for eeh-basic

Kelsey Skunberg
In reply to this post by Po-Hsu Lin (Sam)
Applied to F/G master-next. thank you!

-Kelsey

On 2020-12-18 17:50:13 , Po-Hsu Lin wrote:

> [Impact]
> The breakable devices test is hardware-dependent. In our test pool
> it will take about:
> * 30 seconds to run on a Power8 system that with 5 breakable devices,
> * 60 seconds to run on a Power9 system that with 4 breakable devices.
>
> The default 45 seconds kselftest framework timeout is not enough to
> allow this test to finish on some nodes. Thus causing this test to
> fail with TIMEOUT error.
>
> [Fix]
> * f5eca0b279117f ("selftests/powerpc/eeh: disable kselftest timeout
> setting for eeh-basic")
>
> We have this testcase since Focal, and this patch can be cherry-picked
> into all affected releases.
>
> [Test case]
> Run this test on P9 node baltar, on which this timeout issue can be
> 100% reproduced. With this patch applied, the test can finish without
> being terminated by the default timeout.
>
> [Where problems could occur]
> This will make test takes longer to finish, but it's still being
> controlled by the timeout mechanism both in the test case and
> kselftest framework. It's unlikely to make the test hang forever.
>
> Po-Hsu Lin (1):
>   selftests/powerpc/eeh: disable kselftest timeout setting for eeh-basic
>
>  tools/testing/selftests/powerpc/eeh/Makefile | 2 +-
>  tools/testing/selftests/powerpc/eeh/settings | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>  create mode 100644 tools/testing/selftests/powerpc/eeh/settings
>
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team