[Hardy LUM] SRU: atl1e: Enable ethtool support

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Hardy LUM] SRU: atl1e: Enable ethtool support

Colin Ian King-2
LP#349478

https://bugs.launchpad.net/ubuntu/+source/linux-ubuntu-modules-2.6.24/+bug/349478

SRU justification:

Impact: Newer Atheros L1c NICs with PCI ID's 0x1969:1067 and 0x1969:1063
do not have carrier sense detected by NetworkManager - hence
NetworkManager cannot sense ethernet cable plug/unplug events.

Fix: Patch attached - enable ethtool support in driver to allow
NetworkManager detect that the L1c NICs have carrier sense capability.

Testcase: Without the patch, boot up the machine without the cable
attached and then plug in the cable and nothing happens - no network
connection is configured - uplug and plug and nothing happens. With the
patch repeated ethernet cable plug/unplug actions work and the NIC is
correctly configured by NetworkManager.

----
Notes:

This patch simply turns on ethtool support L1c NICs - the ethtool source
code already existed in the driver but was not originally enabled or
compiled in.

Note that the patch does not enable ethtool support for the L1e NICs
(also supported in the driver) because this code is applicable only for
older versions of the kernel.

Attached: The patch

--
Colin King   <[hidden email]>
"Me transmitte sursum, caledoni"

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

0001-UBUNTU-atl1e-Enable-ethtool-support.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Hardy LUM] SRU: atl1e: Enable ethtool support

Andy Whitcroft-3
On Fri, Mar 27, 2009 at 11:15:54AM +0000, Colin Ian King wrote:

> LP#349478
>
> https://bugs.launchpad.net/ubuntu/+source/linux-ubuntu-modules-2.6.24/+bug/349478
>
> SRU justification:
>
> Impact: Newer Atheros L1c NICs with PCI ID's 0x1969:1067 and 0x1969:1063
> do not have carrier sense detected by NetworkManager - hence
> NetworkManager cannot sense ethernet cable plug/unplug events.
>
> Fix: Patch attached - enable ethtool support in driver to allow
> NetworkManager detect that the L1c NICs have carrier sense capability.
>
> Testcase: Without the patch, boot up the machine without the cable
> attached and then plug in the cable and nothing happens - no network
> connection is configured - uplug and plug and nothing happens. With the
> patch repeated ethernet cable plug/unplug actions work and the NIC is
> correctly configured by NetworkManager.
>
> ----
> Notes:
>
> This patch simply turns on ethtool support L1c NICs - the ethtool source
> code already existed in the driver but was not originally enabled or
> compiled in.
>
> Note that the patch does not enable ethtool support for the L1e NICs
> (also supported in the driver) because this code is applicable only for
> older versions of the kernel.
>
> Attached: The patch
>
> --
> Colin King   <[hidden email]>
> "Me transmitte sursum, caledoni"

> From 18feb136f182758c8353c34569d096504a4943b5 Mon Sep 17 00:00:00 2001
> From: Colin Ian King <[hidden email]>
> Date: Fri, 27 Mar 2009 10:29:07 +0000
> Subject: [PATCH] UBUNTU: atl1e: Enable ethtool support
>
> Bug: #349478
>
> NetworkMananger fails to detect that the driver has carrier
> detection support because ethtool is not enabled. Enabling
> this allows ethernet cable plugging/unplugging to be detected.
>
> Signed-off-by: Colin Ian King <[hidden email]>
> ---
>  ubuntu/net/atl1e/Makefile |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/ubuntu/net/atl1e/Makefile b/ubuntu/net/atl1e/Makefile
> index 4126aab..ddd6f23 100644
> --- a/ubuntu/net/atl1e/Makefile
> +++ b/ubuntu/net/atl1e/Makefile
> @@ -1,8 +1,10 @@
>  CFILES = at_common_main.c \
> - atl1c_hw.c atl1c_main.c atl1c_param.c \
> + atl1c_hw.c atl1c_main.c atl1c_param.c atl1c_ethtool.c \
>   atl1e_hw.c atl1e_main.c atl1e_param.c \
>   kcompat.c
>  
> +CFLAGS_atl1c_main.o += -DETHTOOL_OPS_COMPAT
> +
>  HFILES = at_common.h atl1c.h atl1c_hw.h atl1e.h \
>   atl1e_hw.h at_osdep.h kcompat.h
>  
> --
> 1.6.0.4
>

Looks sensible.  The confusion with the atl1c being enabled and the
atl1e _not_ being enabled probabally should be mentioned in the BOM
(which currently says its all disabled) and called out specifically in
this commit mesage.  In particular the title of this implies nay states
that you are enabling it for atl1e which is false, it only enables the
ethtool support for the atl1c component of the atl1e driver; at least if
I understand you correctly.

Otherwise:

Acked-by: Andy Whitcroft <[hidden email]>

-apw

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [Hardy LUM] SRU: atl1e: Enable ethtool support

Stefan Bader-2
In reply to this post by Colin Ian King-2
Colin Ian King wrote:

> LP#349478
>
> https://bugs.launchpad.net/ubuntu/+source/linux-ubuntu-modules-2.6.24/+bug/349478
>
> SRU justification:
>
> Impact: Newer Atheros L1c NICs with PCI ID's 0x1969:1067 and 0x1969:1063
> do not have carrier sense detected by NetworkManager - hence
> NetworkManager cannot sense ethernet cable plug/unplug events.
>
> Fix: Patch attached - enable ethtool support in driver to allow
> NetworkManager detect that the L1c NICs have carrier sense capability.
>
> Testcase: Without the patch, boot up the machine without the cable
> attached and then plug in the cable and nothing happens - no network
> connection is configured - uplug and plug and nothing happens. With the
> patch repeated ethernet cable plug/unplug actions work and the NIC is
> correctly configured by NetworkManager.
>
> ----
> Notes:
>
> This patch simply turns on ethtool support L1c NICs - the ethtool source
> code already existed in the driver but was not originally enabled or
> compiled in.
>
> Note that the patch does not enable ethtool support for the L1e NICs
> (also supported in the driver) because this code is applicable only for
> older versions of the kernel.
>
> Attached: The patch
>
>
ACK, wow, it took me a few seconds to realize this is for standard Hardy and I
am not getting deja-vu's...

--

When all other means of communication fail, try words!



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team