[Hardy SRU] bluetooth hid: enable quirk handling for Apple Wireless Keyboards in 2.6.24

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Hardy SRU] bluetooth hid: enable quirk handling for Apple Wireless Keyboards in 2.6.24

Bryan Wu-5
SRU Justification:

Impact: This bug causes missing support for the "Fn"-key on the Apple Wireless Keyboard

Fix: This patch based on an upstream patch since 2.6.28 (and is contained in Jaunty) and a backport
patch in Intrepid kernel

Testcase: Make sure that "Fn" key works on the Apple Wirelss Keyboard

Bryan Wu (1):
  bluetooth hid: enable quirk handling for Apple Wireless Keyboards in
    2.6.24

 net/bluetooth/hidp/core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

bluetooth hid: enable quirk handling for Apple Wireless Keyboards in 2.6.24

Bryan Wu-5
Bug: #227501

This patch is basically a backport of
commit ee8a1a0a1a5817accd03ced7e7ffde3a4430f485 upstream
and 5a027e910cc26f9b1f8e32daaeb0d552664b2a54 in Intrepid kernel
which was made after the big HID overhaul in 2.6.28.

Kernel 2.6.24 fails to handle quirks for the aluminum Apple Wireless
Keyboard because it is handled as USB device and not as Bluetooth
device. This patch expands 'hidp_blacklist' to make the kernel handle
the keyboard in the same way as the Apple wireless Mighty Mouse (also a
Bluetooth device).

Signed-off-by: Torsten Rausche <[hidden email]>
Cc: Jan Scholz <[hidden email]>
Cc: Jiri Kosina <[hidden email]>
Signed-off-by: Greg Kroah-Hartman <[hidden email]>
Signed-off-by: Stefan Bader <[hidden email]>
Acked-by: Andy Whitcroft <[hidden email]>
Signed-off-by: Bryan Wu <[hidden email]>
---
 net/bluetooth/hidp/core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index dfaef02..3eebb5f 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -696,6 +696,8 @@ static const struct {
  { 0x05ac, 0x030c, HID_QUIRK_MIGHTYMOUSE | HID_QUIRK_INVERT_HWHEEL },
  /* Apple Wireless Aluminum Keyboard */
  { 0x05ac, 0x022c, HID_QUIRK_APPLE_HAS_FN },
+ { 0x05ac, 0x022d, HID_QUIRK_APPLE_HAS_FN },
+ { 0x05ac, 0x022e, HID_QUIRK_APPLE_HAS_FN },
 
  { } /* Terminating entry */
 };
--
1.6.0.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: bluetooth hid: enable quirk handling for Apple Wireless Keyboards in 2.6.24

Amit Kucheria-6
On Tue, Apr 28, 2009 at 11:32:07PM +0800, Bryan Wu wrote:

> Bug: #227501
>
> This patch is basically a backport of
> commit ee8a1a0a1a5817accd03ced7e7ffde3a4430f485 upstream
> and 5a027e910cc26f9b1f8e32daaeb0d552664b2a54 in Intrepid kernel
> which was made after the big HID overhaul in 2.6.28.
>
> Kernel 2.6.24 fails to handle quirks for the aluminum Apple Wireless
> Keyboard because it is handled as USB device and not as Bluetooth
> device. This patch expands 'hidp_blacklist' to make the kernel handle
> the keyboard in the same way as the Apple wireless Mighty Mouse (also a
> Bluetooth device).
>
> Signed-off-by: Torsten Rausche <[hidden email]>
> Cc: Jan Scholz <[hidden email]>
> Cc: Jiri Kosina <[hidden email]>
> Signed-off-by: Greg Kroah-Hartman <[hidden email]>
> Signed-off-by: Stefan Bader <[hidden email]>
> Acked-by: Andy Whitcroft <[hidden email]>
> Signed-off-by: Bryan Wu <[hidden email]>
> ---
>  net/bluetooth/hidp/core.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)


ACK. Seems straightforward enough.

> diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
> index dfaef02..3eebb5f 100644
> --- a/net/bluetooth/hidp/core.c
> +++ b/net/bluetooth/hidp/core.c
> @@ -696,6 +696,8 @@ static const struct {
>   { 0x05ac, 0x030c, HID_QUIRK_MIGHTYMOUSE | HID_QUIRK_INVERT_HWHEEL },
>   /* Apple Wireless Aluminum Keyboard */
>   { 0x05ac, 0x022c, HID_QUIRK_APPLE_HAS_FN },
> + { 0x05ac, 0x022d, HID_QUIRK_APPLE_HAS_FN },
> + { 0x05ac, 0x022e, HID_QUIRK_APPLE_HAS_FN },
>  
>   { } /* Terminating entry */
>  };
> --
> 1.6.0.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || [hidden email]
----------------------------------------------------------------------

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: bluetooth hid: enable quirk handling for Apple Wireless Keyboards in 2.6.24

Stefan Bader-2
In reply to this post by Bryan Wu-5
ACK, and applied

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team