[JAUNTY] SRU: V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[JAUNTY] SRU: V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.

Manoj Iyer

SRU JUSTIFICATION:

IMPACT: Logitech Quickcam E2500 not supported
FIX: patch added to recoginize USB webcam 046d:089d
TEST: The originator of the bug tested the kernel
http://people.ubuntu.com/~manjo/lp326674-jaunty/ and reported that the
camera is detected but the image quality is poor in 640x480 but good for
320x240.


The following changes since commit
a63b7d7beeaa1f8f33369cab6419831fa8991e40:
   Tyler Hicks (1):
         UBUNTU: SAUCE: (drop after 2.6.28) [PATCH] eCryptfs: Larger buffer
for encrypted symlink targets

are available in the git repository at:

   git://kernel.ubuntu.com/manjo/ubuntu-jaunty.git lp326674

Fabio Rossi (1):
       V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.

  Documentation/video4linux/gspca.txt |    1 +
  drivers/media/video/gspca/zc3xx.c   |    1 +
  2 files changed, 2 insertions(+), 0 deletions(-)

From 132e9427969d67aae6a5951aa03504ee67730b28 Mon Sep 17 00:00:00 2001
From: Fabio Rossi <[hidden email]>
Date: Fri, 26 Dec 2008 14:41:48 -0300
Subject: [PATCH] V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.

Signed-off-by: Fabio Rossi <[hidden email]>
Signed-off-by: Jean-Francois Moine <[hidden email]>
Signed-off-by: Mauro Carvalho Chehab <[hidden email]>
Signed-off-by: Manoj Iyer <[hidden email]>

Author:    Fabio Rossi <[hidden email]>
UBUNTU LP#326674
---
  Documentation/video4linux/gspca.txt |    1 +
  drivers/media/video/gspca/zc3xx.c   |    1 +
  2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/Documentation/video4linux/gspca.txt b/Documentation/video4linux/gspca.txt
index 004818f..fb7e654 100644
--- a/Documentation/video4linux/gspca.txt
+++ b/Documentation/video4linux/gspca.txt
@@ -53,6 +53,7 @@ zc3xx 0461:0a00 MicroInnovation WebCam320
  spca500 046d:0890 Logitech QuickCam traveler
  vc032x 046d:0892 Logitech Orbicam
  vc032x 046d:0896 Logitech Orbicam
+zc3xx 046d:089d Logitech QuickCam E2500
  zc3xx 046d:08a0 Logitech QC IM
  zc3xx 046d:08a1 Logitech QC IM 0x08A1 +sound
  zc3xx 046d:08a2 Labtec Webcam Pro
diff --git a/drivers/media/video/gspca/zc3xx.c b/drivers/media/video/gspca/zc3xx.c
index 8068e3c..0593341 100644
--- a/drivers/media/video/gspca/zc3xx.c
+++ b/drivers/media/video/gspca/zc3xx.c
@@ -7530,6 +7530,7 @@ static const __devinitdata struct usb_device_id device_table[] = {
  {USB_DEVICE(0x0458, 0x700c)},
  {USB_DEVICE(0x0458, 0x700f)},
  {USB_DEVICE(0x0461, 0x0a00)},
+ {USB_DEVICE(0x046d, 0x089d), .driver_info = SENSOR_MC501CB},
  {USB_DEVICE(0x046d, 0x08a0)},
  {USB_DEVICE(0x046d, 0x08a1)},
  {USB_DEVICE(0x046d, 0x08a2)},
--
1.6.0.4

Cheers
--- manjo

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [JAUNTY] SRU: V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.

Amit Kucheria-6
On Wed, Apr 22, 2009 at 04:10:10PM -0500, Manoj Iyer wrote:

>
> SRU JUSTIFICATION:
>
> IMPACT: Logitech Quickcam E2500 not supported
> FIX: patch added to recoginize USB webcam 046d:089d
> TEST: The originator of the bug tested the kernel
> http://people.ubuntu.com/~manjo/lp326674-jaunty/ and reported that the
> camera is detected but the image quality is poor in 640x480 but good for
> 320x240.
>
>
> The following changes since commit
> a63b7d7beeaa1f8f33369cab6419831fa8991e40:
>    Tyler Hicks (1):
>          UBUNTU: SAUCE: (drop after 2.6.28) [PATCH] eCryptfs: Larger buffer
> for encrypted symlink targets
>
> are available in the git repository at:
>
>    git://kernel.ubuntu.com/manjo/ubuntu-jaunty.git lp326674
>
> Fabio Rossi (1):
>        V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.
>

ACK.

--
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || [hidden email]
----------------------------------------------------------------------

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [JAUNTY] SRU: V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.

Stefan Bader-2
In reply to this post by Manoj Iyer
Manoj Iyer wrote:

> SRU JUSTIFICATION:
>
> IMPACT: Logitech Quickcam E2500 not supported
> FIX: patch added to recoginize USB webcam 046d:089d
> TEST: The originator of the bug tested the kernel
> http://people.ubuntu.com/~manjo/lp326674-jaunty/ and reported that the
> camera is detected but the image quality is poor in 640x480 but good for
> 320x240.
>
>
> The following changes since commit
> a63b7d7beeaa1f8f33369cab6419831fa8991e40:
>    Tyler Hicks (1):
>          UBUNTU: SAUCE: (drop after 2.6.28) [PATCH] eCryptfs: Larger buffer
> for encrypted symlink targets
>
> are available in the git repository at:
>
>    git://kernel.ubuntu.com/manjo/ubuntu-jaunty.git lp326674
>
> Fabio Rossi (1):
>        V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.
>
>   Documentation/video4linux/gspca.txt |    1 +
>   drivers/media/video/gspca/zc3xx.c   |    1 +
>   2 files changed, 2 insertions(+), 0 deletions(-)
>
> From 132e9427969d67aae6a5951aa03504ee67730b28 Mon Sep 17 00:00:00 2001
> From: Fabio Rossi <[hidden email]>
> Date: Fri, 26 Dec 2008 14:41:48 -0300
> Subject: [PATCH] V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.
>
> Signed-off-by: Fabio Rossi <[hidden email]>
> Signed-off-by: Jean-Francois Moine <[hidden email]>
> Signed-off-by: Mauro Carvalho Chehab <[hidden email]>
> Signed-off-by: Manoj Iyer <[hidden email]>
>
> Author:    Fabio Rossi <[hidden email]>
> UBUNTU LP#326674
> ---
>   Documentation/video4linux/gspca.txt |    1 +
>   drivers/media/video/gspca/zc3xx.c   |    1 +
>   2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/video4linux/gspca.txt b/Documentation/video4linux/gspca.txt
> index 004818f..fb7e654 100644
> --- a/Documentation/video4linux/gspca.txt
> +++ b/Documentation/video4linux/gspca.txt
> @@ -53,6 +53,7 @@ zc3xx 0461:0a00 MicroInnovation WebCam320
>   spca500 046d:0890 Logitech QuickCam traveler
>   vc032x 046d:0892 Logitech Orbicam
>   vc032x 046d:0896 Logitech Orbicam
> +zc3xx 046d:089d Logitech QuickCam E2500
>   zc3xx 046d:08a0 Logitech QC IM
>   zc3xx 046d:08a1 Logitech QC IM 0x08A1 +sound
>   zc3xx 046d:08a2 Labtec Webcam Pro
> diff --git a/drivers/media/video/gspca/zc3xx.c b/drivers/media/video/gspca/zc3xx.c
> index 8068e3c..0593341 100644
> --- a/drivers/media/video/gspca/zc3xx.c
> +++ b/drivers/media/video/gspca/zc3xx.c
> @@ -7530,6 +7530,7 @@ static const __devinitdata struct usb_device_id device_table[] = {
>   {USB_DEVICE(0x0458, 0x700c)},
>   {USB_DEVICE(0x0458, 0x700f)},
>   {USB_DEVICE(0x0461, 0x0a00)},
> + {USB_DEVICE(0x046d, 0x089d), .driver_info = SENSOR_MC501CB},
>   {USB_DEVICE(0x046d, 0x08a0)},
>   {USB_DEVICE(0x046d, 0x08a1)},
>   {USB_DEVICE(0x046d, 0x08a2)},
ACK

--

When all other means of communication fail, try words!



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [JAUNTY] SRU: V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.

Stefan Bader-2
In reply to this post by Manoj Iyer
Applied and pushed with slight modifications to the header (we need the "Bug:
#" line). Same kindly nudge as with the last request.

Stefan

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [JAUNTY] SRU: V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.

Tim Gardner-2
In reply to this post by Manoj Iyer
Manoj,

When you cherry-pick from Linus' tree (as this one was), use the '-x'
option:

git cherry-pick -s -x -e 88a40cfbf25d82758237250a04d9bed51266215c

Edit the commit log such that the Launchpad bug number is in the
following form (preceded by at least one blank line):

Bug: #NNNN

This mimics the form of the commit template in
debian/commit-templates/patch. That way 'debian/rules insertchanges'
will correctly extract the bug number and add it to the changelog (which
saves Stefan a fair bit of manual work).

rtg
--
Tim Gardner [hidden email]

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [JAUNTY] SRU: V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.

Manoj Iyer

I was always confused about this, let me repeat so that I understand this
corretly.....

git cherry-pick -s -x -e SHAid

when the editor pops up I add the 2 lines

BUG: #LPNNNNN

UBUNTU LP:/http://launchpad.net/....../NNNNN

uncomment Author:

exit editor

Is this correct ?

Cheers
--- manjo

On Thu, 23 Apr 2009, Tim Gardner wrote:

> Manoj,
>
> When you cherry-pick from Linus' tree (as this one was), use the '-x'
> option:
>
> git cherry-pick -s -x -e 88a40cfbf25d82758237250a04d9bed51266215c
>
> Edit the commit log such that the Launchpad bug number is in the
> following form (preceded by at least one blank line):
>
> Bug: #NNNN
>
> This mimics the form of the commit template in
> debian/commit-templates/patch. That way 'debian/rules insertchanges'
> will correctly extract the bug number and add it to the changelog (which
> saves Stefan a fair bit of manual work).
>
> rtg
> --
> Tim Gardner [hidden email]
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [JAUNTY] SRU: V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.

Tim Gardner-2
The bug field is case specific and does not require a leading LP, e.g.,

Bug: #123456

The Launchpad URL can follow on the next line.

You need not uncomment the Author field, that is preserved as part of
the cherry-pick in the git meta-data.

rtg

[hidden email] wrote:

>
> I was always confused about this, let me repeat so that I understand
> this corretly.....
>
> git cherry-pick -s -x -e SHAid
>
> when the editor pops up I add the 2 lines
>
> BUG: #LPNNNNN
>
> UBUNTU LP:/http://launchpad.net/....../NNNNN
>
> uncomment Author:
>
> exit editor
>
> Is this correct ?
>
> Cheers
> --- manjo
>
> On Thu, 23 Apr 2009, Tim Gardner wrote:
>
>> Manoj,
>>
>> When you cherry-pick from Linus' tree (as this one was), use the '-x'
>> option:
>>
>> git cherry-pick -s -x -e 88a40cfbf25d82758237250a04d9bed51266215c
>>
>> Edit the commit log such that the Launchpad bug number is in the
>> following form (preceded by at least one blank line):
>>
>> Bug: #NNNN
>>
>> This mimics the form of the commit template in
>> debian/commit-templates/patch. That way 'debian/rules insertchanges'
>> will correctly extract the bug number and add it to the changelog (which
>> saves Stefan a fair bit of manual work).
>>
>> rtg
>> --
>> Tim Gardner [hidden email]
>>


--
Tim Gardner [hidden email]

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [JAUNTY] SRU: V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.

Stefan Bader-2
In reply to this post by Manoj Iyer
[hidden email] wrote:
> I was always confused about this, let me repeat so that I understand this
> corretly.....
>
> git cherry-pick -s -x -e SHAid
>
> when the editor pops up I add the 2 lines
>
> BUG: #LPNNNNN

Bug: #<number>

No LP. And not all capital letters.
>
> UBUNTU LP:/http://launchpad.net/....../NNNNN

We did not have this before. I started to use

BugLink: http://...

> uncomment Author:

Not sure what this would be for. When I use format-patch there is no need to
uncomment something. Andy/Tim?

> exit editor
>
> Is this correct ?
>
> Cheers
> --- manjo
>
> On Thu, 23 Apr 2009, Tim Gardner wrote:
>
>> Manoj,
>>
>> When you cherry-pick from Linus' tree (as this one was), use the '-x'
>> option:
>>
>> git cherry-pick -s -x -e 88a40cfbf25d82758237250a04d9bed51266215c
>>
>> Edit the commit log such that the Launchpad bug number is in the
>> following form (preceded by at least one blank line):
>>
>> Bug: #NNNN
>>
>> This mimics the form of the commit template in
>> debian/commit-templates/patch. That way 'debian/rules insertchanges'
>> will correctly extract the bug number and add it to the changelog (which
>> saves Stefan a fair bit of manual work).
>>
>> rtg
>> --
>> Tim Gardner [hidden email]
>>
>


--

When all other means of communication fail, try words!



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [JAUNTY] SRU: V4L/DVB (9999): gspca - zc3xx: Webcam 046d:089d added.

Manoj Iyer

Ok, sounds good, I will add this info to the kernelstarter page so that
other newbies know how to do this.

Cheers
--- manjo

On Thu, 23 Apr 2009, Stefan Bader wrote:

> [hidden email] wrote:
>> I was always confused about this, let me repeat so that I understand this
>> corretly.....
>>
>> git cherry-pick -s -x -e SHAid
>>
>> when the editor pops up I add the 2 lines
>>
>> BUG: #LPNNNNN
>
> Bug: #<number>
>
> No LP. And not all capital letters.
>>
>> UBUNTU LP:/http://launchpad.net/....../NNNNN
>
> We did not have this before. I started to use
>
> BugLink: http://...
>
>> uncomment Author:
>
> Not sure what this would be for. When I use format-patch there is no need to
> uncomment something. Andy/Tim?
>
>> exit editor
>>
>> Is this correct ?
>>
>> Cheers
>> --- manjo
>>
>> On Thu, 23 Apr 2009, Tim Gardner wrote:
>>
>>> Manoj,
>>>
>>> When you cherry-pick from Linus' tree (as this one was), use the '-x'
>>> option:
>>>
>>> git cherry-pick -s -x -e 88a40cfbf25d82758237250a04d9bed51266215c
>>>
>>> Edit the commit log such that the Launchpad bug number is in the
>>> following form (preceded by at least one blank line):
>>>
>>> Bug: #NNNN
>>>
>>> This mimics the form of the commit template in
>>> debian/commit-templates/patch. That way 'debian/rules insertchanges'
>>> will correctly extract the bug number and add it to the changelog (which
>>> saves Stefan a fair bit of manual work).
>>>
>>> rtg
>>> --
>>> Tim Gardner [hidden email]
>>>
>>
>
>
> --
>
> When all other means of communication fail, try words!
>
>
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

added note on cherry-pick to wiki KernelMaintenanceStarter

Manoj Iyer

Added note at the end to:

https://wiki.ubuntu.com/KernelTeam/KernelMaintenanceStarter

Cheers
--- manjo

On Thu, 23 Apr 2009, [hidden email] wrote:

>
> Ok, sounds good, I will add this info to the kernelstarter page so that other
> newbies know how to do this.
>
> Cheers
> --- manjo
>
> On Thu, 23 Apr 2009, Stefan Bader wrote:
>
>> [hidden email] wrote:
>>> I was always confused about this, let me repeat so that I understand this
>>> corretly.....
>>>
>>> git cherry-pick -s -x -e SHAid
>>>
>>> when the editor pops up I add the 2 lines
>>>
>>> BUG: #LPNNNNN
>>
>> Bug: #<number>
>>
>> No LP. And not all capital letters.
>>>
>>> UBUNTU LP:/http://launchpad.net/....../NNNNN
>>
>> We did not have this before. I started to use
>>
>> BugLink: http://...
>>
>>> uncomment Author:
>>
>> Not sure what this would be for. When I use format-patch there is no need
>> to uncomment something. Andy/Tim?
>>
>>> exit editor
>>>
>>> Is this correct ?
>>>
>>> Cheers
>>> --- manjo
>>>
>>> On Thu, 23 Apr 2009, Tim Gardner wrote:
>>>
>>>> Manoj,
>>>>
>>>> When you cherry-pick from Linus' tree (as this one was), use the '-x'
>>>> option:
>>>>
>>>> git cherry-pick -s -x -e 88a40cfbf25d82758237250a04d9bed51266215c
>>>>
>>>> Edit the commit log such that the Launchpad bug number is in the
>>>> following form (preceded by at least one blank line):
>>>>
>>>> Bug: #NNNN
>>>>
>>>> This mimics the form of the commit template in
>>>> debian/commit-templates/patch. That way 'debian/rules insertchanges'
>>>> will correctly extract the bug number and add it to the changelog (which
>>>> saves Stefan a fair bit of manual work).
>>>>
>>>> rtg
>>>> --
>>>> Tim Gardner [hidden email]
>>>>
>>>
>>
>>
>> --
>>
>> When all other means of communication fail, try words!
>>
>>
>>
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team