[PATCH 0/1][B/C/OEM/Unstable] Enable middle button of touchpad on P72

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/1][B/C/OEM/Unstable] Enable middle button of touchpad on P72

Aaron Ma
BugLink: https://bugs.launchpad.net/bugs/1793463

[Impact]
ThinkPad P72 has 3 physical hardware button on touchpad.
Middle button didn't work due to kernel mask it.

[Fix]
Add this button support by PNPID in kernel input driver.

[Test Case]
Touchpad left/right/middle buttons works fine. scroll mode
works fine.

[Regression Potential]
Very low, Just enable specific hardware support.

Aaron Ma (1):
  Input: elantech - enable middle button of touchpad on ThinkPad P72

 drivers/input/mouse/elantech.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] Input: elantech - enable middle button of touchpad on ThinkPad P72

Aaron Ma
BugLink: https://bugs.launchpad.net/bugs/1793463

Adding 2 new touchpad IDs to support middle button support.

Cc: [hidden email]
Signed-off-by: Aaron Ma <[hidden email]>
Signed-off-by: Dmitry Torokhov <[hidden email]>
(cherry picked from commit 91a97507323e1ad4bfc10f4a5922e67cdaf8b3cd linux-next)
Signed-off-by: Aaron Ma <[hidden email]>
---
 drivers/input/mouse/elantech.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index a250f433eb96..84c69e962230 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1180,6 +1180,8 @@ static const struct dmi_system_id elantech_dmi_has_middle_button[] = {
 static const char * const middle_button_pnp_ids[] = {
  "LEN2131", /* ThinkPad P52 w/ NFC */
  "LEN2132", /* ThinkPad P52 */
+ "LEN2133", /* ThinkPad P72 w/ NFC */
+ "LEN2134", /* ThinkPad P72 */
  NULL
 };
 
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK / APPLIED[C/Unstable]: [PATCH 0/1][B/C/OEM/Unstable] Enable middle button of touchpad on P72

Seth Forshee
In reply to this post by Aaron Ma
On Thu, Sep 20, 2018 at 10:07:31AM +0200, Aaron Ma wrote:

> BugLink: https://bugs.launchpad.net/bugs/1793463
>
> [Impact]
> ThinkPad P72 has 3 physical hardware button on touchpad.
> Middle button didn't work due to kernel mask it.
>
> [Fix]
> Add this button support by PNPID in kernel input driver.
>
> [Test Case]
> Touchpad left/right/middle buttons works fine. scroll mode
> works fine.
>
> [Regression Potential]
> Very low, Just enable specific hardware support.

Acked-by: Seth Forshee <[hidden email]>

Applied to cosmic/master-next and unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 0/1][B/C/OEM/Unstable] Enable middle button of touchpad on P72

Po-Hsu Lin (Sam)
In reply to this post by Aaron Ma
Acked-by: Po-Hsu Lin <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK / APPLIED[C/Unstable]: [PATCH 0/1][B/C/OEM/Unstable] Enable middle button of touchpad on P72

Aaron Ma
In reply to this post by Seth Forshee
Hi:

Could this patch be applied in Bionic?

Hi Timo:

Could you apply this patch to OEM?

OEM image is still waiting for this fix.

Thanks,
Aaron

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[B]: [PATCH 0/1][B/C/OEM/Unstable] Enable middle button of touchpad on P72

Stefan Bader-2
In reply to this post by Aaron Ma
On 20.09.2018 10:07, Aaron Ma wrote:

> BugLink: https://bugs.launchpad.net/bugs/1793463
>
> [Impact]
> ThinkPad P72 has 3 physical hardware button on touchpad.
> Middle button didn't work due to kernel mask it.
>
> [Fix]
> Add this button support by PNPID in kernel input driver.
>
> [Test Case]
> Touchpad left/right/middle buttons works fine. scroll mode
> works fine.
>
> [Regression Potential]
> Very low, Just enable specific hardware support.
>
> Aaron Ma (1):
>   Input: elantech - enable middle button of touchpad on ThinkPad P72
>
>  drivers/input/mouse/elantech.c | 2 ++
>  1 file changed, 2 insertions(+)
>
Applied to bionic/master-next. Thanks.

-Stefan


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment