[PATCH 0/1] HyperV ata_piix disable

[Andy Whitcroft-3]

We have been seeing some problems on hyper-v hypervisors wherein if the
ata_piix driver is enabled the instance may not start.  Where this occurs
there is no way to recover the instance.  This patch adds an option
to disable this driver completely even when builtin to allow recovery.
This is achieved view a new kernel command line option.

Proposing for SRU to Precise.

-apw

Andy Whitcroft (1):
  UBUNTU: SAUCE: ata_piix: add a disable_driver option

 drivers/ata/ata_piix.c |    7 +++++++
 1 file changed, 7 insertions(+)

--
1.7.9.5


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Andy Whitcroft-3]

We need to be able to fully disable the ata_piix driver from the kernel
command line.  Add a generic disable_driver to the module init to
completely short circuit the initialisation.

BugLink: http://bugs.launchpad.net/bugs/994870
Signed-off-by: Andy Whitcroft <[hidden email]>
---
 drivers/ata/ata_piix.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 1952869..0d2cf7e 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -1708,10 +1708,16 @@ static void piix_remove_one(struct pci_dev *pdev)
  ata_pci_remove_one(pdev);
 }
 
+static bool disable_driver = 0;
 static int __init piix_init(void)
 {
  int rc;
 
+ if (disable_driver) {
+ printk(KERN_WARNING "ata_piix: driver disabled completely\n");
+ return 0;
+ }
+
  DPRINTK("pci_register_driver\n");
  rc = pci_register_driver(&piix_pci_driver);
  if (rc)
@@ -1732,3 +1738,4 @@ module_init(piix_init);
 module_exit(piix_exit);
 
 module_param(prefer_ms_hyperv, int, 0);
+module_param(disable_driver, bool, 0);
--
1.7.9.5


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Herton Ronaldo Krzesinski]

On Thu, May 17, 2012 at 06:55:27PM +0100, Andy Whitcroft wrote:

> We have been seeing some problems on hyper-v hypervisors wherein if the
> ata_piix driver is enabled the instance may not start.  Where this occurs
> there is no way to recover the instance.  This patch adds an option
> to disable this driver completely even when builtin to allow recovery.
> This is achieved view a new kernel command line option.
>
> Proposing for SRU to Precise.
>
> -apw
>
> Andy Whitcroft (1):
>   UBUNTU: SAUCE: ata_piix: add a disable_driver option
>
>  drivers/ata/ata_piix.c |    7 +++++++
>  1 file changed, 7 insertions(+)
>
> --
> 1.7.9.5
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>

--
[]'s
Herton

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[brad.figg]

On 05/17/2012 10:55 AM, Andy Whitcroft wrote:

> We have been seeing some problems on hyper-v hypervisors wherein if the
> ata_piix driver is enabled the instance may not start.  Where this occurs
> there is no way to recover the instance.  This patch adds an option
> to disable this driver completely even when builtin to allow recovery.
> This is achieved view a new kernel command line option.
>
> Proposing for SRU to Precise.
>
> -apw
>
> Andy Whitcroft (1):
>   UBUNTU: SAUCE: ata_piix: add a disable_driver option
>
>  drivers/ata/ata_piix.c |    7 +++++++
>  1 file changed, 7 insertions(+)
>

--
Brad Figg [hidden email] http://www.canonical.com

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Luis Henriques]

Andy Whitcroft <[hidden email]> writes:

> We need to be able to fully disable the ata_piix driver from the kernel
> command line.  Add a generic disable_driver to the module init to
> completely short circuit the initialisation.
>
> BugLink: http://bugs.launchpad.net/bugs/994870
> Signed-off-by: Andy Whitcroft <[hidden email]>
> ---
>  drivers/ata/ata_piix.c |    7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> index 1952869..0d2cf7e 100644
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -1708,10 +1708,16 @@ static void piix_remove_one(struct pci_dev *pdev)
>   ata_pci_remove_one(pdev);
>  }
>  
> +static bool disable_driver = 0;
>  static int __init piix_init(void)
>  {
>   int rc;
>  
> + if (disable_driver) {
> + printk(KERN_WARNING "ata_piix: driver disabled completely\n");

The only comment I have would be that you could replace printk by
one of the dev_* functions, to be consistent with the code in the
file.  Other than that, it looks fine to me.

--
Luis

> + return 0; + } + DPRINTK("pci_register_driver\n"); rc =
> pci_register_driver(&piix_pci_driver); if (rc) @@ -1732,3 +1738,4 @@
> module_init(piix_init); module_exit(piix_exit);
>  
>  module_param(prefer_ms_hyperv, int, 0);
> +module_param(disable_driver, bool, 0);
> --
> 1.7.9.5

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Tim Gardner-2]

--
Tim Gardner [hidden email]

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team