[PATCH 0/1][SRU][B][OEM-B][C][D]Power leakage at S5 with Qualcomm Atheros QCA9377 802.11ac Wireless Network Adapter

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/1][SRU][B][OEM-B][C][D]Power leakage at S5 with Qualcomm Atheros QCA9377 802.11ac Wireless Network Adapter

AceLan Kao
BugLink: https://bugs.launchpad.net/bugs/1805607

[Impact]
It drains power more than 0.5 Watt after power off(S5) the machine with
QCA9377 wifi card. The power consumption should be lower than 0.5 Watt,
or it won't pass E-star 7.

[Fix]
Qualcomm provides this fix, and the power consumption becomes 0.23 Watt
at S5. This fix doesn't submit to upstream yet, Qualcomm is still working
on it.

[Test]
Verified on Dell machines, it works.

[Regression Potential]
Low.

AceLan Kao (1):
  SAUCE: ath10k: provide reset function for QCA9377 chip

 drivers/net/wireless/ath/ath10k/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1][SRU][B][OEM-B]SAUCE: ath10k: provide reset function for QCA9377 chip

AceLan Kao
BugLink: https://bugs.launchpad.net/bugs/1805607

The reset function helps with the S5 power consumption, make the power
consumption reduce from 0.52W to 0.23W at S5.

Signed-off-by: AceLan Kao <[hidden email]>
---
 drivers/net/wireless/ath/ath10k/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index e9c316274ee0..b4b88708a288 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -3254,7 +3254,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
  case QCA9377_1_0_DEVICE_ID:
  hw_rev = ATH10K_HW_QCA9377;
  pci_ps = true;
- pci_soft_reset = NULL;
+ pci_soft_reset = ath10k_pci_warm_reset;
  pci_hard_reset = ath10k_pci_qca6174_chip_reset;
  targ_cpu_to_ce_addr = ath10k_pci_qca988x_targ_cpu_to_ce_addr;
  break;
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH][SRU][C][D] SAUCE: ath10k: provide reset function for QCA9377 chip

AceLan Kao
In reply to this post by AceLan Kao
BugLink: https://bugs.launchpad.net/bugs/1805607

The reset function helps with the S5 power consumption, make the power
consumption reduce from 0.52W to 0.23W at S5.

Signed-off-by: AceLan Kao <[hidden email]>
---
 drivers/net/wireless/ath/ath10k/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index af2cf55c4c1e..bc5bdbc23cb3 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -3536,7 +3536,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
  case QCA9377_1_0_DEVICE_ID:
  hw_rev = ATH10K_HW_QCA9377;
  pci_ps = true;
- pci_soft_reset = NULL;
+ pci_soft_reset = ath10k_pci_warm_reset;
  pci_hard_reset = ath10k_pci_qca6174_chip_reset;
  targ_cpu_to_ce_addr = ath10k_pci_qca988x_targ_cpu_to_ce_addr;
  break;
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/1][SRU][B][OEM-B][C][D]Power leakage at S5 with Qualcomm Atheros QCA9377 802.11ac Wireless Network Adapter

Kai-Heng Feng
In reply to this post by AceLan Kao


> On Nov 29, 2018, at 2:02 PM, AceLan Kao <[hidden email]> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/1805607
>
> [Impact]
> It drains power more than 0.5 Watt after power off(S5) the machine with
> QCA9377 wifi card. The power consumption should be lower than 0.5 Watt,
> or it won't pass E-star 7.
>
> [Fix]
> Qualcomm provides this fix, and the power consumption becomes 0.23 Watt
> at S5. This fix doesn't submit to upstream yet, Qualcomm is still working
> on it.
>
> [Test]
> Verified on Dell machines, it works.
>
> [Regression Potential]
> Low.
>
> AceLan Kao (1):
>  SAUCE: ath10k: provide reset function for QCA9377 chip
>
> drivers/net/wireless/ath/ath10k/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Kai-Heng Feng <[hidden email]>

>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[OEM-B]: [PATCH 0/1][SRU][B][OEM-B][C][D]Power leakage at S5 with Qualcomm Atheros QCA9377 802.11ac Wireless Network Adapter

AceLan Kao
In reply to this post by AceLan Kao
Applied on oem kernel 4.15.0-1029.34

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/1][SRU][B][OEM-B][C][D]Power leakage at S5 with Qualcomm Atheros QCA9377 802.11ac Wireless Network Adapter

Seth Forshee
In reply to this post by AceLan Kao
On Thu, Nov 29, 2018 at 02:02:10PM +0800, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1805607
>
> [Impact]
> It drains power more than 0.5 Watt after power off(S5) the machine with
> QCA9377 wifi card. The power consumption should be lower than 0.5 Watt,
> or it won't pass E-star 7.
>
> [Fix]
> Qualcomm provides this fix, and the power consumption becomes 0.23 Watt
> at S5. This fix doesn't submit to upstream yet, Qualcomm is still working
> on it.

Can you elaborate? The fact that they are still working on it implies
that it isn't done. Can you explain what is still being worked on, and
why it's "good enough" in the current, imcomplete form?

> [Test]
> Verified on Dell machines, it works.
>
> [Regression Potential]
> Low.

Please explain why the regression potential is low.

Thanks,
Seth


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/1][SRU][B][OEM-B][C][D]Power leakage at S5 with Qualcomm Atheros QCA9377 802.11ac Wireless Network Adapter

AceLan Kao
Seth Forshee <[hidden email]> 於 2018年12月5日 週三 下午9:52寫道:

>
> On Thu, Nov 29, 2018 at 02:02:10PM +0800, AceLan Kao wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1805607
> >
> > [Impact]
> > It drains power more than 0.5 Watt after power off(S5) the machine with
> > QCA9377 wifi card. The power consumption should be lower than 0.5 Watt,
> > or it won't pass E-star 7.
> >
> > [Fix]
> > Qualcomm provides this fix, and the power consumption becomes 0.23 Watt
> > at S5. This fix doesn't submit to upstream yet, Qualcomm is still working
> > on it.
>
> Can you elaborate? The fact that they are still working on it implies
> that it isn't done. Can you explain what is still being worked on, and
> why it's "good enough" in the current, imcomplete form?
The code snip was given by Qualcomm to PM through email.
We've asked them to submit the fix the upstream, but they didn't send it out.
I have no idea why it takes so long, but to catch up the produce
release schedule,
I submit it to Ubuntu kernel first.

>
> > [Test]
> > Verified on Dell machines, it works.
> >
> > [Regression Potential]
> > Low.
>
> Please explain why the regression potential is low.
Sorry, I should provide below info in the beginning.
It looks like Qualcomm forgot the provide a pci_soft_reset() function
for QCA9377 chip,
compare to others they all have pci_soft_reset function assigned.
This commit provides ath10k_pci_warm_reset() as pci_soft_reset()
function for QCA9377,
and this function has been used for other chips as pci_soft_reset(),
and compare the
power consumption results, the chip has been disabled correctly after power off,
so this function should work well for this chip, too.
We've also done S3 and S5 tests, no regression.

>
> Thanks,
> Seth
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK / APPLIED[D/Unstable]: [PATCH 0/1][SRU][B][OEM-B][C][D]Power leakage at S5 with Qualcomm Atheros QCA9377 802.11ac Wireless Network Adapter

Seth Forshee
On Thu, Dec 06, 2018 at 03:18:38PM +0800, AceLan Kao wrote:

> Seth Forshee <[hidden email]> 於 2018年12月5日 週三 下午9:52寫道:
> >
> > On Thu, Nov 29, 2018 at 02:02:10PM +0800, AceLan Kao wrote:
> > > BugLink: https://bugs.launchpad.net/bugs/1805607
> > >
> > > [Impact]
> > > It drains power more than 0.5 Watt after power off(S5) the machine with
> > > QCA9377 wifi card. The power consumption should be lower than 0.5 Watt,
> > > or it won't pass E-star 7.
> > >
> > > [Fix]
> > > Qualcomm provides this fix, and the power consumption becomes 0.23 Watt
> > > at S5. This fix doesn't submit to upstream yet, Qualcomm is still working
> > > on it.
> >
> > Can you elaborate? The fact that they are still working on it implies
> > that it isn't done. Can you explain what is still being worked on, and
> > why it's "good enough" in the current, imcomplete form?
> The code snip was given by Qualcomm to PM through email.
> We've asked them to submit the fix the upstream, but they didn't send it out.
> I have no idea why it takes so long, but to catch up the produce
> release schedule,
> I submit it to Ubuntu kernel first.
>
> >
> > > [Test]
> > > Verified on Dell machines, it works.
> > >
> > > [Regression Potential]
> > > Low.
> >
> > Please explain why the regression potential is low.
> Sorry, I should provide below info in the beginning.
> It looks like Qualcomm forgot the provide a pci_soft_reset() function
> for QCA9377 chip,
> compare to others they all have pci_soft_reset function assigned.
> This commit provides ath10k_pci_warm_reset() as pci_soft_reset()
> function for QCA9377,
> and this function has been used for other chips as pci_soft_reset(),
> and compare the
> power consumption results, the chip has been disabled correctly after power off,
> so this function should work well for this chip, too.
> We've also done S3 and S5 tests, no regression.

Thanks.

Acked-by: Seth Forshee <[hidden email]>

Applied to disco/master-next and unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team