[PATCH 0/1][SRU][Bionic] Remove false errors "AE_NOT_FOUND, Evaluating _PRS"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/1][SRU][Bionic] Remove false errors "AE_NOT_FOUND, Evaluating _PRS"

Alex Hung
BugLink: https://bugs.launchpad.net/bugs/1773295

[Impact]

  Kernel generates false errors "ACPI Exception: AE_NOT_FOUND, Evaluating _PRS"
  as new platforms do not have _PRS control method when OS is not allowed to
  modify hardware registers for routing table.

[Fix]

  The patch disables the error messages by default for users who do not need
  to debug _PRS methods.

  The patches are included in upstream and are cherry-picked from Linus's repo.

[Regression potential]

  No regression for older systems as they have _PRS methods, and new systems
  will see pci_link driver loaded but there should be no functional changes.

Alex Hung (1):
  ACPI / PCI: pci_link: Allow the absence of _PRS and change log level

 drivers/acpi/pci_link.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.17.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1][SRU][Bionic] ACPI / PCI: pci_link: Allow the absence of _PRS and change log level

Alex Hung
BugLink: https://bugs.launchpad.net/bugs/1773295

In recent Intel hardware the IRQs become non-configurable after BIOS
initializes them in PEI phase and _PRS objects are no longer included in
ASL.

This is the same as "static (non-configurable) devices do not
specify a _PRS object" in ACPI spec. As a result, error messages
saying "ACPI Exception: AE_NOT_FOUND, Evaluating _PRS" does not need to
be in kernel messenges all the time but only when debug is enabled, and
acpi_pci_link_get_possible should not return -ENODEV when _PRS is
absent.

Signed-off-by: Alex Hung <[hidden email]>
Acked-by: Bjorn Helgaas <[hidden email]>
Signed-off-by: Rafael J. Wysocki <[hidden email]>
(cherry picked from commit 92d1b381f677cbd2d4370dc3b8d0679b7f0ace32)
Signed-off-by: Alex Hung <[hidden email]>
---
 drivers/acpi/pci_link.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
index bc3d914dfc3e..65f1908480d4 100644
--- a/drivers/acpi/pci_link.c
+++ b/drivers/acpi/pci_link.c
@@ -173,8 +173,8 @@ static int acpi_pci_link_get_possible(struct acpi_pci_link *link)
  status = acpi_walk_resources(link->device->handle, METHOD_NAME__PRS,
      acpi_pci_link_check_possible, link);
  if (ACPI_FAILURE(status)) {
- ACPI_EXCEPTION((AE_INFO, status, "Evaluating _PRS"));
- return -ENODEV;
+ acpi_handle_debug(link->device->handle, "_PRS not present or invalid");
+ return 0;
  }
 
  ACPI_DEBUG_PRINT((ACPI_DB_INFO,
--
2.17.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 1/1][SRU][Bionic] ACPI / PCI: pci_link: Allow the absence of _PRS and change log level

Colin Ian King-2
On 28/05/18 04:27, Alex Hung wrote:

> BugLink: https://bugs.launchpad.net/bugs/1773295
>
> In recent Intel hardware the IRQs become non-configurable after BIOS
> initializes them in PEI phase and _PRS objects are no longer included in
> ASL.
>
> This is the same as "static (non-configurable) devices do not
> specify a _PRS object" in ACPI spec. As a result, error messages
> saying "ACPI Exception: AE_NOT_FOUND, Evaluating _PRS" does not need to
> be in kernel messenges all the time but only when debug is enabled, and
> acpi_pci_link_get_possible should not return -ENODEV when _PRS is
> absent.
>
> Signed-off-by: Alex Hung <[hidden email]>
> Acked-by: Bjorn Helgaas <[hidden email]>
> Signed-off-by: Rafael J. Wysocki <[hidden email]>
> (cherry picked from commit 92d1b381f677cbd2d4370dc3b8d0679b7f0ace32)
> Signed-off-by: Alex Hung <[hidden email]>
> ---
>  drivers/acpi/pci_link.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index bc3d914dfc3e..65f1908480d4 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -173,8 +173,8 @@ static int acpi_pci_link_get_possible(struct acpi_pci_link *link)
>   status = acpi_walk_resources(link->device->handle, METHOD_NAME__PRS,
>       acpi_pci_link_check_possible, link);
>   if (ACPI_FAILURE(status)) {
> - ACPI_EXCEPTION((AE_INFO, status, "Evaluating _PRS"));
> - return -ENODEV;
> + acpi_handle_debug(link->device->handle, "_PRS not present or invalid");
> + return 0;
>   }
>  
>   ACPI_DEBUG_PRINT((ACPI_DB_INFO,
>
Upstream cherry pick, makes lots of sense.

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 1/1][SRU][Bionic] ACPI / PCI: pci_link: Allow the absence of _PRS and change log level

Kleber Souza
In reply to this post by Alex Hung
On 05/27/18 20:27, Alex Hung wrote:

> BugLink: https://bugs.launchpad.net/bugs/1773295
>
> In recent Intel hardware the IRQs become non-configurable after BIOS
> initializes them in PEI phase and _PRS objects are no longer included in
> ASL.
>
> This is the same as "static (non-configurable) devices do not
> specify a _PRS object" in ACPI spec. As a result, error messages
> saying "ACPI Exception: AE_NOT_FOUND, Evaluating _PRS" does not need to
> be in kernel messenges all the time but only when debug is enabled, and
> acpi_pci_link_get_possible should not return -ENODEV when _PRS is
> absent.
>
> Signed-off-by: Alex Hung <[hidden email]>
> Acked-by: Bjorn Helgaas <[hidden email]>
> Signed-off-by: Rafael J. Wysocki <[hidden email]>
> (cherry picked from commit 92d1b381f677cbd2d4370dc3b8d0679b7f0ace32)
> Signed-off-by: Alex Hung <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  drivers/acpi/pci_link.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index bc3d914dfc3e..65f1908480d4 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -173,8 +173,8 @@ static int acpi_pci_link_get_possible(struct acpi_pci_link *link)
>   status = acpi_walk_resources(link->device->handle, METHOD_NAME__PRS,
>       acpi_pci_link_check_possible, link);
>   if (ACPI_FAILURE(status)) {
> - ACPI_EXCEPTION((AE_INFO, status, "Evaluating _PRS"));
> - return -ENODEV;
> + acpi_handle_debug(link->device->handle, "_PRS not present or invalid");
> + return 0;
>   }
>  
>   ACPI_DEBUG_PRINT((ACPI_DB_INFO,
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [PATCH 0/1][SRU][Bionic] Remove false errors "AE_NOT_FOUND, Evaluating _PRS"

Khaled Elmously
In reply to this post by Alex Hung
Applied to Bionic


On 2018-05-27 20:27:21 , Alex Hung wrote:

> BugLink: https://bugs.launchpad.net/bugs/1773295
>
> [Impact]
>
>   Kernel generates false errors "ACPI Exception: AE_NOT_FOUND, Evaluating _PRS"
>   as new platforms do not have _PRS control method when OS is not allowed to
>   modify hardware registers for routing table.
>
> [Fix]
>
>   The patch disables the error messages by default for users who do not need
>   to debug _PRS methods.
>
>   The patches are included in upstream and are cherry-picked from Linus's repo.
>
> [Regression potential]
>
>   No regression for older systems as they have _PRS methods, and new systems
>   will see pci_link driver loaded but there should be no functional changes.
>
> Alex Hung (1):
>   ACPI / PCI: pci_link: Allow the absence of _PRS and change log level
>
>  drivers/acpi/pci_link.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.17.0
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team