[PATCH 0/1] [SRU][C/master] Fix gic_irq_domain_translate warnings

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/1] [SRU][C/master] Fix gic_irq_domain_translate warnings

Paolo Pisati-5
BugLink: https://bugs.launchpad.net/bugs/1797143

Impact:

During boot on a Dragonboard410c using a recent Cosmic kernel:

...
[ 0.071535] WARNING: CPU: 0 PID: 1 at drivers/irqchip/irq-gic.c:1016
gic_irq_domain_translate+0xe4/0xf0
[ 0.071541] Modules linked in:
[ 0.071552] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W
4.18.0-8-snapdragon #9
[ 0.071558] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT)
[ 0.071566] pstate: 60400005 (nZCv daif +PAN -UAO)
[ 0.071575] pc : gic_irq_domain_translate+0xe4/0xf0
[ 0.071582] lr : gic_irq_domain_alloc+0x58/0xc0
[ 0.071588] sp : ffff0000080337d0
[ 0.071594] x29: ffff0000080337d0 x28: 0000000000000000
[ 0.071604] x27: ffff000008033938 x26: 0000000000000001
[ 0.071615] x25: 00000000006080c0 x24: ffff000009a6ef70
[ 0.071625] x23: ffff000009a48708 x22: 0000000000000025
[ 0.071636] x21: ffff00000803384c x20: ffff000008033850
[ 0.071647] x19: ffff000008033938 x18: 0000000000000001
[ 0.071658] x17: 0000000000000000 x16: 0000000000000000
[ 0.071668] x15: ffffffffffffffff x14: ffff000009a48708
[ 0.071679] x13: ffff80003a4c2703 x12: 0000000000000038
[ 0.071690] x11: 0101010101010101 x10: 0000000000000040
[ 0.071700] x9 : ffff000009a6e9d8 x8 : ffff80003b0016f8
[ 0.071710] x7 : 0000000000000000 x6 : ffff80003b0016d0
[ 0.071721] x5 : ffff80003b001820 x4 : ffff00000857b4f8
[ 0.071731] x3 : ffff00000803384c x2 : 0000000000000000
[ 0.071741] x1 : 0000000000000057 x0 : 0000000000000000
[ 0.071751] Call trace:
[ 0.071759] gic_irq_domain_translate+0xe4/0xf0
[ 0.071767] gic_irq_domain_alloc+0x58/0xc0
[ 0.071777] __irq_domain_alloc_irqs+0x150/0x338
[ 0.071786] irq_create_fwspec_mapping+0x118/0x318
[ 0.071794] irq_create_of_mapping+0x7c/0xa8
[ 0.071803] of_irq_get+0x88/0xe0
[ 0.071812] of_irq_to_resource+0x48/0x108
[ 0.071821] of_irq_to_resource_table+0x54/0x70
[ 0.071829] of_device_alloc+0x110/0x1e0
[ 0.071837] of_platform_device_create_pdata+0x60/0xe0
[ 0.071846] of_platform_bus_create+0x2bc/0x4b0
[ 0.071854] of_platform_bus_create+0x31c/0x4b0
[ 0.071862] of_platform_populate+0x8c/0x140
[ 0.071872] of_platform_default_populate_init+0xb4/0xd0
[ 0.071880] do_one_initcall+0x54/0x1e0
[ 0.071890] kernel_init_freeable+0x254/0x2f8
[ 0.071898] kernel_init+0x18/0x110
[ 0.071907] ret_from_fork+0x10/0x18
[ 0.071913] ---[ end trace dc768b294fafe4b4 ]---
...

remove the usage of IRQ_TYPE_NONE to fix loud warnings from
patch (83a86fbb5b56b "irqchip/gic: Loudly complain about
the use of IRQ_TYPE_NONE").

The same was done in commit 242579dd0829 ("arm64: dts: msm8996: fix
gic_irq_domain_translate warnings") and commit c16e78b8e862("arm64: dts:
msm8916: fix gic_irq_domain_translate warnings") upstream, so fix the
same issue in our forward-ported Qualcomm BSP code.

Fix:

Apply the attached patch and recompile

How to test:

Boot the patched kernel and check for the above WARNING in dmesg

Regression potential:

None, it's a mechanical modification to silence a WARNING

Paolo Pisati (1):
  UBUNTU: SAUCE: arm64: dts: msm8916: camms: fix
    gic_irq_domain_translate warnings

 arch/arm64/boot/dts/qcom/msm8916.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] UBUNTU: SAUCE: arm64: dts: msm8916: camms: fix gic_irq_domain_translate warnings

Paolo Pisati-5
BugLink: https://bugs.launchpad.net/bugs/1797143

Remove the usage of IRQ_TYPE_NONE to fix loud warnings from
patch (83a86fbb5b56b "irqchip/gic: Loudly complain about
the use of IRQ_TYPE_NONE").

Signed-off-by: Paolo Pisati <[hidden email]>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 51df6d37250c..03df1c2d56ef 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -1478,12 +1478,12 @@
  "ispif",
  "csi_clk_mux",
  "vfe0";
- interrupts = <GIC_SPI 78 0>,
- <GIC_SPI 79 0>,
- <GIC_SPI 51 0>,
- <GIC_SPI 52 0>,
- <GIC_SPI 55 0>,
- <GIC_SPI 57 0>;
+ interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
  interrupt-names = "csiphy0",
  "csiphy1",
  "csid0",
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 1/1] UBUNTU: SAUCE: arm64: dts: msm8916: camms: fix gic_irq_domain_translate warnings

Colin Ian King-2
On 10/10/18 15:48, Paolo Pisati wrote:

> BugLink: https://bugs.launchpad.net/bugs/1797143
>
> Remove the usage of IRQ_TYPE_NONE to fix loud warnings from
> patch (83a86fbb5b56b "irqchip/gic: Loudly complain about
> the use of IRQ_TYPE_NONE").
>
> Signed-off-by: Paolo Pisati <[hidden email]>
> ---
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 51df6d37250c..03df1c2d56ef 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1478,12 +1478,12 @@
>   "ispif",
>   "csi_clk_mux",
>   "vfe0";
> - interrupts = <GIC_SPI 78 0>,
> - <GIC_SPI 79 0>,
> - <GIC_SPI 51 0>,
> - <GIC_SPI 52 0>,
> - <GIC_SPI 55 0>,
> - <GIC_SPI 57 0>;
> + interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
>   interrupt-names = "csiphy0",
>   "csiphy1",
>   "csid0",
>

Silence is golden for this warnings.

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 1/1] UBUNTU: SAUCE: arm64: dts: msm8916: camms: fix gic_irq_domain_translate warnings

Stefan Bader-2
In reply to this post by Paolo Pisati-5
On 10.10.2018 16:48, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1797143
>
> Remove the usage of IRQ_TYPE_NONE to fix loud warnings from
> patch (83a86fbb5b56b "irqchip/gic: Loudly complain about
> the use of IRQ_TYPE_NONE").
>
> Signed-off-by: Paolo Pisati <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 51df6d37250c..03df1c2d56ef 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1478,12 +1478,12 @@
>   "ispif",
>   "csi_clk_mux",
>   "vfe0";
> - interrupts = <GIC_SPI 78 0>,
> - <GIC_SPI 79 0>,
> - <GIC_SPI 51 0>,
> - <GIC_SPI 52 0>,
> - <GIC_SPI 55 0>,
> - <GIC_SPI 57 0>;
> + interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
>   interrupt-names = "csiphy0",
>   "csiphy1",
>   "csid0",
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[Unstable]: [PATCH 0/1] [SRU][C/master] Fix gic_irq_domain_translate warnings

Seth Forshee
In reply to this post by Paolo Pisati-5
On Wed, Oct 10, 2018 at 04:48:51PM +0200, Paolo Pisati wrote:

> BugLink: https://bugs.launchpad.net/bugs/1797143
>
> Impact:
>
> During boot on a Dragonboard410c using a recent Cosmic kernel:
>
> ...
> [ 0.071535] WARNING: CPU: 0 PID: 1 at drivers/irqchip/irq-gic.c:1016
> gic_irq_domain_translate+0xe4/0xf0
> [ 0.071541] Modules linked in:
> [ 0.071552] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W
> 4.18.0-8-snapdragon #9
> [ 0.071558] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT)
> [ 0.071566] pstate: 60400005 (nZCv daif +PAN -UAO)
> [ 0.071575] pc : gic_irq_domain_translate+0xe4/0xf0
> [ 0.071582] lr : gic_irq_domain_alloc+0x58/0xc0
> [ 0.071588] sp : ffff0000080337d0
> [ 0.071594] x29: ffff0000080337d0 x28: 0000000000000000
> [ 0.071604] x27: ffff000008033938 x26: 0000000000000001
> [ 0.071615] x25: 00000000006080c0 x24: ffff000009a6ef70
> [ 0.071625] x23: ffff000009a48708 x22: 0000000000000025
> [ 0.071636] x21: ffff00000803384c x20: ffff000008033850
> [ 0.071647] x19: ffff000008033938 x18: 0000000000000001
> [ 0.071658] x17: 0000000000000000 x16: 0000000000000000
> [ 0.071668] x15: ffffffffffffffff x14: ffff000009a48708
> [ 0.071679] x13: ffff80003a4c2703 x12: 0000000000000038
> [ 0.071690] x11: 0101010101010101 x10: 0000000000000040
> [ 0.071700] x9 : ffff000009a6e9d8 x8 : ffff80003b0016f8
> [ 0.071710] x7 : 0000000000000000 x6 : ffff80003b0016d0
> [ 0.071721] x5 : ffff80003b001820 x4 : ffff00000857b4f8
> [ 0.071731] x3 : ffff00000803384c x2 : 0000000000000000
> [ 0.071741] x1 : 0000000000000057 x0 : 0000000000000000
> [ 0.071751] Call trace:
> [ 0.071759] gic_irq_domain_translate+0xe4/0xf0
> [ 0.071767] gic_irq_domain_alloc+0x58/0xc0
> [ 0.071777] __irq_domain_alloc_irqs+0x150/0x338
> [ 0.071786] irq_create_fwspec_mapping+0x118/0x318
> [ 0.071794] irq_create_of_mapping+0x7c/0xa8
> [ 0.071803] of_irq_get+0x88/0xe0
> [ 0.071812] of_irq_to_resource+0x48/0x108
> [ 0.071821] of_irq_to_resource_table+0x54/0x70
> [ 0.071829] of_device_alloc+0x110/0x1e0
> [ 0.071837] of_platform_device_create_pdata+0x60/0xe0
> [ 0.071846] of_platform_bus_create+0x2bc/0x4b0
> [ 0.071854] of_platform_bus_create+0x31c/0x4b0
> [ 0.071862] of_platform_populate+0x8c/0x140
> [ 0.071872] of_platform_default_populate_init+0xb4/0xd0
> [ 0.071880] do_one_initcall+0x54/0x1e0
> [ 0.071890] kernel_init_freeable+0x254/0x2f8
> [ 0.071898] kernel_init+0x18/0x110
> [ 0.071907] ret_from_fork+0x10/0x18
> [ 0.071913] ---[ end trace dc768b294fafe4b4 ]---
> ...
>
> remove the usage of IRQ_TYPE_NONE to fix loud warnings from
> patch (83a86fbb5b56b "irqchip/gic: Loudly complain about
> the use of IRQ_TYPE_NONE").
>
> The same was done in commit 242579dd0829 ("arm64: dts: msm8996: fix
> gic_irq_domain_translate warnings") and commit c16e78b8e862("arm64: dts:
> msm8916: fix gic_irq_domain_translate warnings") upstream, so fix the
> same issue in our forward-ported Qualcomm BSP code.
>
> Fix:
>
> Apply the attached patch and recompile
>
> How to test:
>
> Boot the patched kernel and check for the above WARNING in dmesg
>
> Regression potential:
>
> None, it's a mechanical modification to silence a WARNING

Applied to unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team