[PATCH 0/1][SRU][D][OEM-OSP1-B] First click on Goodix touchpad doesn't be recognized while in runtime suspended

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/1][SRU][D][OEM-OSP1-B] First click on Goodix touchpad doesn't be recognized while in runtime suspended

AceLan Kao
BugLink: https://bugs.launchpad.net/bugs/1836836

[Impact]
Wake up from runtime suspend, Goodix doesn't report correct Tap event by
tapping it the first time, so if you double tap the touchpad, the system
only got one tap.

[Fix]
Adding one missing platform which uses Goodix touchpad IC to the i2c
designware quirk list.

[Test]
Verified on the buggy machines.

[Regression Potential]
Low, this quirk doesn't hurt anything and do little or none to power consumption.

AceLan Kao (1):
  UBUNTU: SAUCE: i2c: designware: add G3 3590 into i2c quirk

 drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
 1 file changed, 7 insertions(+)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1][SRU][D][OEM-OSP1-B] UBUNTU: SAUCE: i2c: designware: add G3 3590 into i2c quirk

AceLan Kao
BugLink: https://bugs.launchpad.net/bugs/1836836

Add one missing platform which uses Goodix touchpad IC into i2c designware
quirk to prevent touchpad from entering runtime suspend.

Signed-off-by: AceLan Kao <[hidden email]>
---
 drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
index d1063ef81ac6..53225b4263e8 100644
--- a/drivers/i2c/busses/i2c-designware-master.c
+++ b/drivers/i2c/busses/i2c-designware-master.c
@@ -74,6 +74,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
  DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 7590"),
  },
  },
+ {
+ .ident = "Dell G3 3590",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "G3 3590"),
+ },
+ },
  { }
 };
 
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED [OEM-OSP1-B] Re: [PATCH 0/1][SRU][D][OEM-OSP1-B] First click on Goodix touchpad doesn't be recognized while in runtime suspended

Timo Aaltonen-6
In reply to this post by AceLan Kao
On 17.7.2019 10.13, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836836
>
> [Impact]
> Wake up from runtime suspend, Goodix doesn't report correct Tap event by
> tapping it the first time, so if you double tap the touchpad, the system
> only got one tap.
>
> [Fix]
> Adding one missing platform which uses Goodix touchpad IC to the i2c
> designware quirk list.
>
> [Test]
> Verified on the buggy machines.
>
> [Regression Potential]
> Low, this quirk doesn't hurt anything and do little or none to power consumption.
>
> AceLan Kao (1):
>   UBUNTU: SAUCE: i2c: designware: add G3 3590 into i2c quirk
>
>  drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
>  1 file changed, 7 insertions(+)

applied to osp1 oem-next, thanks



--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1][SRU][D][OEM-OSP1-B] UBUNTU: SAUCE: i2c: designware: add G3 3590 into i2c quirk

Stefan Bader-2
In reply to this post by AceLan Kao
On 17.07.19 09:13, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836836
>
> Add one missing platform which uses Goodix touchpad IC into i2c designware
> quirk to prevent touchpad from entering runtime suspend.
>
> Signed-off-by: AceLan Kao <[hidden email]>
> ---
>  drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> index d1063ef81ac6..53225b4263e8 100644
> --- a/drivers/i2c/busses/i2c-designware-master.c
> +++ b/drivers/i2c/busses/i2c-designware-master.c
> @@ -74,6 +74,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
>   DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 7590"),
Wasn't there just recently another request which adds a Vostro 7591 here?
And again what about Unstable/Eoan?

-Stefan

>   },
>   },
> + {
> + .ident = "Dell G3 3590",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "G3 3590"),
> + },
> + },
>   { }
>  };
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK / APPLIED[E]: [PATCH 0/1][SRU][D][OEM-OSP1-B] First click on Goodix touchpad doesn't be recognized while in runtime suspended

Seth Forshee
In reply to this post by AceLan Kao
On Wed, Jul 17, 2019 at 03:13:23PM +0800, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836836
>
> [Impact]
> Wake up from runtime suspend, Goodix doesn't report correct Tap event by
> tapping it the first time, so if you double tap the touchpad, the system
> only got one tap.
>
> [Fix]
> Adding one missing platform which uses Goodix touchpad IC to the i2c
> designware quirk list.
>
> [Test]
> Verified on the buggy machines.
>
> [Regression Potential]
> Low, this quirk doesn't hurt anything and do little or none to power consumption.

As Stefan mentioned, please remember to include the development release
for these patches!!!

Scope limited to specific platform, positive testing.

Acked-by: Seth Forshee <[hidden email]>

Applied to eoan/master-next, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1][SRU][D][OEM-OSP1-B] UBUNTU: SAUCE: i2c: designware: add G3 3590 into i2c quirk

AceLan Kao
In reply to this post by Stefan Bader-2
Hi Stefan,

Thanks for reminding the me Unstable/Eoan branches.
I found I've forgotten to submit other quirks to eoan, so I skipped
this one, too.
We're figuring out another solution for this issue, and it won't have
to add the platforms one by one,
after we verified the new fix on some platforms, we'll submit the fix
for all series.
Thanks.

Best regards,
AceLan Kao.

Stefan Bader <[hidden email]> 於 2019年7月19日 週五 下午5:26寫道:

>
> On 17.07.19 09:13, AceLan Kao wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1836836
> >
> > Add one missing platform which uses Goodix touchpad IC into i2c designware
> > quirk to prevent touchpad from entering runtime suspend.
> >
> > Signed-off-by: AceLan Kao <[hidden email]>
> > ---
> >  drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> > index d1063ef81ac6..53225b4263e8 100644
> > --- a/drivers/i2c/busses/i2c-designware-master.c
> > +++ b/drivers/i2c/busses/i2c-designware-master.c
> > @@ -74,6 +74,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
> >                       DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 7590"),
>
> Wasn't there just recently another request which adds a Vostro 7591 here?
> And again what about Unstable/Eoan?
>
> -Stefan
> >               },
> >       },
> > +     {
> > +             .ident = "Dell G3 3590",
> > +             .matches = {
> > +                     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +                     DMI_MATCH(DMI_PRODUCT_NAME, "G3 3590"),
> > +             },
> > +     },
> >       { }
> >  };
> >
> >
>
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NACK: [PATCH 1/1][SRU][D] UBUNTU: SAUCE: i2c: designware: add G3 3590 into i2c quirk

Stefan Bader-2
On 22.07.19 03:56, AceLan Kao wrote:
> Hi Stefan,
>
> Thanks for reminding the me Unstable/Eoan branches.
> I found I've forgotten to submit other quirks to eoan, so I skipped
> this one, too.
> We're figuring out another solution for this issue, and it won't have
> to add the platforms one by one,
> after we verified the new fix on some platforms, we'll submit the fix
> for all series.

In that case I would wait for that for the SRU into Disco.

-Stefan

> Thanks.
>
> Best regards,
> AceLan Kao.
>
> Stefan Bader <[hidden email]> 於 2019年7月19日 週五 下午5:26寫道:
>>
>> On 17.07.19 09:13, AceLan Kao wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1836836
>>>
>>> Add one missing platform which uses Goodix touchpad IC into i2c designware
>>> quirk to prevent touchpad from entering runtime suspend.
>>>
>>> Signed-off-by: AceLan Kao <[hidden email]>
>>> ---
>>>  drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
>>> index d1063ef81ac6..53225b4263e8 100644
>>> --- a/drivers/i2c/busses/i2c-designware-master.c
>>> +++ b/drivers/i2c/busses/i2c-designware-master.c
>>> @@ -74,6 +74,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
>>>                       DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 7590"),
>>
>> Wasn't there just recently another request which adds a Vostro 7591 here?
>> And again what about Unstable/Eoan?
>>
>> -Stefan
>>>               },
>>>       },
>>> +     {
>>> +             .ident = "Dell G3 3590",
>>> +             .matches = {
>>> +                     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>>> +                     DMI_MATCH(DMI_PRODUCT_NAME, "G3 3590"),
>>> +             },
>>> +     },
>>>       { }
>>>  };
>>>
>>>
>>
>>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment