[PATCH 0/1][SRU][D][OEM-OSP1-B]Sometimes touchpad(goodix) can't use tap function

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/1][SRU][D][OEM-OSP1-B]Sometimes touchpad(goodix) can't use tap function

AceLan Kao
BugLink: https://bugs.launchpad.net/bugs/1836020

[Impact]
Wake up from runtime suspend, Goodix doesn't report correct Tap event by
tapping it the first time, so if you double tap the touchpad, the system
only got one tap.

[Fix]
Adding the platforms which uses Goodix touchpad IC to the i2c designware
quirk list.

[Test]
Verified on the buggy machines.

[Regression Potential]
Low, this quirk doesn't hurt anything and do little or none to power
consumption.

AceLan Kao (1):
  UBUNTU: SAUCE: i2c: designware: add Inpiron/Vostro 7590 into i2c quirk

 drivers/i2c/busses/i2c-designware-master.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1][SRU][D][OEM-OSP1-B] UBUNTU: SAUCE: i2c: designware: add Inpiron/Vostro 7590 into i2c quirk

AceLan Kao
BugLink: https://bugs.launchpad.net/bugs/1836020

Add 2 more platforms which uses Goodix touchpad IC into i2c designware
quirk to prevent touchpad from entering runtime suspend.

Signed-off-by: AceLan Kao <[hidden email]>
---
 drivers/i2c/busses/i2c-designware-master.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
index 6ff73b20dc26..00a906ec43be 100644
--- a/drivers/i2c/busses/i2c-designware-master.c
+++ b/drivers/i2c/busses/i2c-designware-master.c
@@ -39,6 +39,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
  DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5391"),
  },
  },
+ {
+ .ident = "Dell Inspiron 7590",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7590"),
+ },
+ },
  {
  .ident = "Dell Vostro 5390",
  .matches = {
@@ -53,6 +60,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
  DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 5391"),
  },
  },
+ {
+ .ident = "Dell Vostro 7590",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 7590"),
+ },
+ },
  { }
 };
 
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 1/1][SRU][D][OEM-OSP1-B] UBUNTU: SAUCE: i2c: designware: add Inpiron/Vostro 7590 into i2c quirk

Kleber Souza
On 10.07.19 11:04, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1836020
>
> Add 2 more platforms which uses Goodix touchpad IC into i2c designware
> quirk to prevent touchpad from entering runtime suspend.
>
> Signed-off-by: AceLan Kao <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>


> ---
>  drivers/i2c/busses/i2c-designware-master.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> index 6ff73b20dc26..00a906ec43be 100644
> --- a/drivers/i2c/busses/i2c-designware-master.c
> +++ b/drivers/i2c/busses/i2c-designware-master.c
> @@ -39,6 +39,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
>   DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5391"),
>   },
>   },
> + {
> + .ident = "Dell Inspiron 7590",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7590"),
> + },
> + },
>   {
>   .ident = "Dell Vostro 5390",
>   .matches = {
> @@ -53,6 +60,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
>   DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 5391"),
>   },
>   },
> + {
> + .ident = "Dell Vostro 7590",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 7590"),
> + },
> + },
>   { }
>  };
>  
>
 

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 1/1][SRU][D][OEM-OSP1-B] UBUNTU: SAUCE: i2c: designware: add Inpiron/Vostro 7590 into i2c quirk

Connor Kuehl
In reply to this post by AceLan Kao
On 7/10/19 2:04 AM, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1836020
>
> Add 2 more platforms which uses Goodix touchpad IC into i2c designware
> quirk to prevent touchpad from entering runtime suspend.
>
> Signed-off-by: AceLan Kao <[hidden email]>

Acked-by: Connor Kuehl <[hidden email]>

> ---
>  drivers/i2c/busses/i2c-designware-master.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> index 6ff73b20dc26..00a906ec43be 100644
> --- a/drivers/i2c/busses/i2c-designware-master.c
> +++ b/drivers/i2c/busses/i2c-designware-master.c
> @@ -39,6 +39,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
>   DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5391"),
>   },
>   },
> + {
> + .ident = "Dell Inspiron 7590",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7590"),
> + },
> + },
>   {
>   .ident = "Dell Vostro 5390",
>   .matches = {
> @@ -53,6 +60,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
>   DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 5391"),
>   },
>   },
> + {
> + .ident = "Dell Vostro 7590",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 7590"),
> + },
> + },
>   { }
>  };
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/1][SRU][D][OEM-OSP1-B]Sometimes touchpad(goodix) can't use tap function

Timo Aaltonen-6
In reply to this post by AceLan Kao
On 10.7.2019 12.04, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836020
>
> [Impact]
> Wake up from runtime suspend, Goodix doesn't report correct Tap event by
> tapping it the first time, so if you double tap the touchpad, the system
> only got one tap.
>
> [Fix]
> Adding the platforms which uses Goodix touchpad IC to the i2c designware
> quirk list.

applied to osp1 oem-next, thanks


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[OEM-OSP1-B] Re: [PATCH 0/1][SRU][D][OEM-OSP1-B]Sometimes touchpad(goodix) can't use tap function

Timo Aaltonen-6
On 11.7.2019 10.05, Timo Aaltonen wrote:

> On 10.7.2019 12.04, AceLan Kao wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1836020
>>
>> [Impact]
>> Wake up from runtime suspend, Goodix doesn't report correct Tap event by
>> tapping it the first time, so if you double tap the touchpad, the system
>> only got one tap.
>>
>> [Fix]
>> Adding the platforms which uses Goodix touchpad IC to the i2c designware
>> quirk list.
>
> applied to osp1 oem-next, thanks

damn, forgot the subject again


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED(D)/cmt: [PATCH 0/1][SRU][D][OEM-OSP1-B]Sometimes touchpad(goodix) can't use tap function

Khaled Elmously
In reply to this post by AceLan Kao
Applied to Disco, and fixed the bug nominations.


On 2019-07-10 17:04:34 , AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836020
>
> [Impact]
> Wake up from runtime suspend, Goodix doesn't report correct Tap event by
> tapping it the first time, so if you double tap the touchpad, the system
> only got one tap.
>
> [Fix]
> Adding the platforms which uses Goodix touchpad IC to the i2c designware
> quirk list.
>
> [Test]
> Verified on the buggy machines.
>
> [Regression Potential]
> Low, this quirk doesn't hurt anything and do little or none to power
> consumption.
>
> AceLan Kao (1):
>   UBUNTU: SAUCE: i2c: designware: add Inpiron/Vostro 7590 into i2c quirk
>
>  drivers/i2c/busses/i2c-designware-master.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/1][SRU][D][OEM-OSP1-B]Sometimes touchpad(goodix) can't use tap function

Seth Forshee
In reply to this post by AceLan Kao
On Wed, Jul 10, 2019 at 05:04:34PM +0800, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836020
>
> [Impact]
> Wake up from runtime suspend, Goodix doesn't report correct Tap event by
> tapping it the first time, so if you double tap the touchpad, the system
> only got one tap.
>
> [Fix]
> Adding the platforms which uses Goodix touchpad IC to the i2c designware
> quirk list.
>
> [Test]
> Verified on the buggy machines.
>
> [Regression Potential]
> Low, this quirk doesn't hurt anything and do little or none to power
> consumption.

Why is this being requested for disco but not for eoan? Is there a
reason it is not necessary in eoan? Generally patches should not go into
a stable release and not into the development release.

Thanks,
Seth

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[E]: [PATCH 0/1][SRU][D][OEM-OSP1-B]Sometimes touchpad(goodix) can't use tap function

Seth Forshee
On Mon, Jul 15, 2019 at 07:18:31AM -0500, Seth Forshee wrote:

> On Wed, Jul 10, 2019 at 05:04:34PM +0800, AceLan Kao wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1836020
> >
> > [Impact]
> > Wake up from runtime suspend, Goodix doesn't report correct Tap event by
> > tapping it the first time, so if you double tap the touchpad, the system
> > only got one tap.
> >
> > [Fix]
> > Adding the platforms which uses Goodix touchpad IC to the i2c designware
> > quirk list.
> >
> > [Test]
> > Verified on the buggy machines.
> >
> > [Regression Potential]
> > Low, this quirk doesn't hurt anything and do little or none to power
> > consumption.
>
> Why is this being requested for disco but not for eoan? Is there a
> reason it is not necessary in eoan? Generally patches should not go into
> a stable release and not into the development release.

I can't see any reason to omit this from eoan, so applied. Please
remember to include the development release in the future unless there's
a good reason not to.

Thanks,
Seth

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/1][SRU][D][OEM-OSP1-B]Sometimes touchpad(goodix) can't use tap function

AceLan Kao
In reply to this post by Seth Forshee
Hi Seth,

There is no specific reason for the patch not go into eoan,
it's just because I forgot to submit its precede quirk to eoan, it
can't clean apply onto eoan now.
We're working on another solution for this issue, and no need to
increase the list anymore.
It should be okay to skip this quirk on non-oem kernel currently,
we'll submit another fix to all series after we finish the testing.

Best regards,
AceLan Kao.

Seth Forshee <[hidden email]> 於 2019年7月15日 週一 下午8:18寫道:

>
> On Wed, Jul 10, 2019 at 05:04:34PM +0800, AceLan Kao wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1836020
> >
> > [Impact]
> > Wake up from runtime suspend, Goodix doesn't report correct Tap event by
> > tapping it the first time, so if you double tap the touchpad, the system
> > only got one tap.
> >
> > [Fix]
> > Adding the platforms which uses Goodix touchpad IC to the i2c designware
> > quirk list.
> >
> > [Test]
> > Verified on the buggy machines.
> >
> > [Regression Potential]
> > Low, this quirk doesn't hurt anything and do little or none to power
> > consumption.
>
> Why is this being requested for disco but not for eoan? Is there a
> reason it is not necessary in eoan? Generally patches should not go into
> a stable release and not into the development release.
>
> Thanks,
> Seth

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team