[PATCH 0/1][SRU][D][OEM-OSP1-B] Sometimes touchpad(goodix) can't use tap function

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/1][SRU][D][OEM-OSP1-B] Sometimes touchpad(goodix) can't use tap function

AceLan Kao
BugLink: https://bugs.launchpad.net/bugs/1836020

[Impact]
Wake up from runtime suspend, Goodix doesn't report correct Tap event by
tapping it the first time, so if you double tap the touchpad, the system
only got one tap.

[Fix]
Adding one missing platform which uses Goodix touchpad IC to the i2c
designware quirk list.

[Test]
Verified on the buggy machines.

[Regression Potential]
Low, this quirk doesn't hurt anything and do little or none to power consumption.

AceLan Kao (1):
  UBUNTU: SAUCE: i2c: designware: add Inpiron 7591 into i2c quirk

 drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
 1 file changed, 7 insertions(+)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1][SRU][D][OEM-OSP1-B] UBUNTU: SAUCE: i2c: designware: add Inpiron 7591 into i2c quirk

AceLan Kao
BugLink: https://bugs.launchpad.net/bugs/1836020

Add one missing platform which uses Goodix touchpad IC into i2c designware
quirk to prevent touchpad from entering runtime suspend.

Signed-off-by: AceLan Kao <[hidden email]>
---
 drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
index 00a906ec43be..d1063ef81ac6 100644
--- a/drivers/i2c/busses/i2c-designware-master.c
+++ b/drivers/i2c/busses/i2c-designware-master.c
@@ -46,6 +46,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
  DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7590"),
  },
  },
+ {
+ .ident = "Dell Inspiron 7591",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7591"),
+ },
+ },
  {
  .ident = "Dell Vostro 5390",
  .matches = {
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[OEM-OSP1-B] Re: [PATCH 0/1][SRU][D][OEM-OSP1-B] Sometimes touchpad(goodix) can't use tap function

Timo Aaltonen-6
In reply to this post by AceLan Kao
On 11.7.2019 11.58, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836020
>
> [Impact]
> Wake up from runtime suspend, Goodix doesn't report correct Tap event by
> tapping it the first time, so if you double tap the touchpad, the system
> only got one tap.
>
> [Fix]
> Adding one missing platform which uses Goodix touchpad IC to the i2c
> designware quirk list.
>
> [Test]
> Verified on the buggy machines.
>
> [Regression Potential]
> Low, this quirk doesn't hurt anything and do little or none to power consumption.
>
> AceLan Kao (1):
>   UBUNTU: SAUCE: i2c: designware: add Inpiron 7591 into i2c quirk
>
>  drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>

applied to osp1 oem-next, thanks

--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/1][SRU][D][OEM-OSP1-B] Sometimes touchpad(goodix) can't use tap function

Seth Forshee
In reply to this post by AceLan Kao
On Thu, Jul 11, 2019 at 04:58:38PM +0800, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836020
>
> [Impact]
> Wake up from runtime suspend, Goodix doesn't report correct Tap event by
> tapping it the first time, so if you double tap the touchpad, the system
> only got one tap.
>
> [Fix]
> Adding one missing platform which uses Goodix touchpad IC to the i2c
> designware quirk list.
>
> [Test]
> Verified on the buggy machines.
>
> [Regression Potential]
> Low, this quirk doesn't hurt anything and do little or none to power consumption.

Again, is there a reason for not including eoan for this patch?

Thanks,
Seth

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK / APPLIED[E]: [PATCH 0/1][SRU][D][OEM-OSP1-B] Sometimes touchpad(goodix) can't use tap function

Seth Forshee
In reply to this post by AceLan Kao
On Thu, Jul 11, 2019 at 04:58:38PM +0800, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836020
>
> [Impact]
> Wake up from runtime suspend, Goodix doesn't report correct Tap event by
> tapping it the first time, so if you double tap the touchpad, the system
> only got one tap.
>
> [Fix]
> Adding one missing platform which uses Goodix touchpad IC to the i2c
> designware quirk list.
>
> [Test]
> Verified on the buggy machines.
>
> [Regression Potential]
> Low, this quirk doesn't hurt anything and do little or none to power consumption.

Limited scope, positive testing.

Acked-by: Seth Forshee <[hidden email]>

Applied to eoan/master-next, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [PATCH 1/1][SRU][D][OEM-OSP1-B] UBUNTU: SAUCE: i2c: designware: add Inpiron 7591 into i2c quirk

Stefan Bader-2
In reply to this post by AceLan Kao
On 11.07.19 10:58, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1836020
>
> Add one missing platform which uses Goodix touchpad IC into i2c designware
> quirk to prevent touchpad from entering runtime suspend.
>
> Signed-off-by: AceLan Kao <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

The way this is submitted is confusing and somewhat prone to errors. The patch
depends on the other addition to the quirks for the 7590 but as it is submitted
independently it could get picked up before the other one. I only looked closer
because the status of the bug report already is fix-committed which sounded wrong.

In this case I think it would be better to submit a follow-up v2 which carries
both patches and self-NACK the initial one. Or, if the first patch already is
applied, then follow-up with the additional patch on the initial thread.

-Stefan

>  drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> index 00a906ec43be..d1063ef81ac6 100644
> --- a/drivers/i2c/busses/i2c-designware-master.c
> +++ b/drivers/i2c/busses/i2c-designware-master.c
> @@ -46,6 +46,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
>   DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7590"),
>   },
>   },
> + {
> + .ident = "Dell Inspiron 7591",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7591"),
> + },
> + },
>   {
>   .ident = "Dell Vostro 5390",
>   .matches = {
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

NACK/Cmnt: [PATCH 1/1][SRU][D] UBUNTU: SAUCE: i2c: designware: add Inpiron 7591 into i2c quirk

Stefan Bader-2
In reply to this post by AceLan Kao
On 11.07.19 10:58, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1836020
>
> Add one missing platform which uses Goodix touchpad IC into i2c designware
> quirk to prevent touchpad from entering runtime suspend.
>
> Signed-off-by: AceLan Kao <[hidden email]>
> ---

Though we have applied the Inspiron 7590 part already, there was another
follow-up patch where it was said that the approach will be re-worked. So I
would rather wait for that for SRU into Disco.

-Stefan

>  drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> index 00a906ec43be..d1063ef81ac6 100644
> --- a/drivers/i2c/busses/i2c-designware-master.c
> +++ b/drivers/i2c/busses/i2c-designware-master.c
> @@ -46,6 +46,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
>   DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7590"),
>   },
>   },
> + {
> + .ident = "Dell Inspiron 7591",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7591"),
> + },
> + },
>   {
>   .ident = "Dell Vostro 5390",
>   .matches = {
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment