[PATCH 0/1][SRU][OEM-5.10] Add an OEM _OSI string to workaround auto-wakeup

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/1][SRU][OEM-5.10] Add an OEM _OSI string to workaround auto-wakeup

Alex Hung
BugLink: https://bugs.launchpad.net/bugs/1902577

[Impact]
TGL systems wake up automatically from s2idle when connecting to a docking
station with a monitor. The wake-up events are generated when BIOS sets
ALL_MONITOR_OFF for power-saving on TGL systems.

[Fix]
A BIOS workaround is used to skip ALL_MONITOR_OFF with an _OSI string
"Linux-Dell-USB4-Wakeup".

[Test]
Verified on Dell's TigerLake platforms

[Regression Potential]
Low. This only works on platforms supporting "Linux-Dell-USB4-Wakeup".
No other platforms will be affected.

Note: This patch was sent and merged to OEM-5.6, but BIOS fixes are
not ready and thus this is needed in oem-5.10 too.

Alex Hung (1):
  UBUNTU: SAUCE: ACPI: avoid auto-wakeup with an _OSI string

 drivers/acpi/osi.c | 6 ++++++
 1 file changed, 6 insertions(+)

--
2.25.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-5.10][PATCH 1/1] UBUNTU: SAUCE: ACPI: avoid auto-wakeup with an _OSI string

Alex Hung
Some TGL systems wake up automatically from s2idle when connecting to
a docking station with a monitor. The wake-up events are generated when
BIOS sets ALL_MONITOR_OFF for power-saving on TGL systems.

A BIOS workaround is used to skip ALL_MONITOR_OFF with an _OSI string
"Linux-Dell-USB4-Wakeup".

BugLink: http://bugs.launchpad.net/bugs/1902577

Signed-off-by: Alex Hung <[hidden email]>
---
 drivers/acpi/osi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/acpi/osi.c b/drivers/acpi/osi.c
index 6fce7fb54f6d..69f8820cd0a7 100644
--- a/drivers/acpi/osi.c
+++ b/drivers/acpi/osi.c
@@ -68,6 +68,12 @@ osi_setup_entries[OSI_STRING_ENTRIES_MAX] __initdata = {
  * hybrid graphics supports.
  */
  {"Linux-HPI-Hybrid-Graphics", true},
+ /*
+ * Linux-Dell-USB4-Wakeup is used by BIOS to workaround auto wakeup
+ * on Tigerlake. This is done by skipping ALL_MONITOR_OFF when systems
+ * are going to s2idle.
+ */
+ {"Linux-Dell-USB4-Wakeup", true},
 };
 
 static u32 acpi_osi_handler(acpi_string interface, u32 supported)
--
2.25.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 0/1][SRU][OEM-5.10] Add an OEM _OSI string to workaround auto-wakeup

Colin Ian King-2
In reply to this post by Alex Hung
On 16/01/2021 00:44, Alex Hung wrote:

> BugLink: https://bugs.launchpad.net/bugs/1902577
>
> [Impact]
> TGL systems wake up automatically from s2idle when connecting to a docking
> station with a monitor. The wake-up events are generated when BIOS sets
> ALL_MONITOR_OFF for power-saving on TGL systems.
>
> [Fix]
> A BIOS workaround is used to skip ALL_MONITOR_OFF with an _OSI string
> "Linux-Dell-USB4-Wakeup".
>
> [Test]
> Verified on Dell's TigerLake platforms
>
> [Regression Potential]
> Low. This only works on platforms supporting "Linux-Dell-USB4-Wakeup".
> No other platforms will be affected.
>
> Note: This patch was sent and merged to OEM-5.6, but BIOS fixes are
> not ready and thus this is needed in oem-5.10 too.
>
> Alex Hung (1):
>   UBUNTU: SAUCE: ACPI: avoid auto-wakeup with an _OSI string
>
>  drivers/acpi/osi.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
I believe this is a SAUCE patch and should be tagged as such when
applied.  Should/can this be upstreamed too?


Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED Re: [PATCH 0/1][SRU][OEM-5.10] Add an OEM _OSI string to workaround auto-wakeup

Timo Aaltonen-6
In reply to this post by Alex Hung
On 16.1.2021 2.44, Alex Hung wrote:

> BugLink: https://bugs.launchpad.net/bugs/1902577
>
> [Impact]
> TGL systems wake up automatically from s2idle when connecting to a docking
> station with a monitor. The wake-up events are generated when BIOS sets
> ALL_MONITOR_OFF for power-saving on TGL systems.
>
> [Fix]
> A BIOS workaround is used to skip ALL_MONITOR_OFF with an _OSI string
> "Linux-Dell-USB4-Wakeup".
>
> [Test]
> Verified on Dell's TigerLake platforms
>
> [Regression Potential]
> Low. This only works on platforms supporting "Linux-Dell-USB4-Wakeup".
> No other platforms will be affected.
>
> Note: This patch was sent and merged to OEM-5.6, but BIOS fixes are
> not ready and thus this is needed in oem-5.10 too.
>
> Alex Hung (1):
>    UBUNTU: SAUCE: ACPI: avoid auto-wakeup with an _OSI string
>
>   drivers/acpi/osi.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>

applied to oem-5.10, thanks


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team