[PATCH 0/1 SRU X/Z/A] Forbid ALSA reads sample rate on Plantronics P610

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/1 SRU X/Z/A] Forbid ALSA reads sample rate on Plantronics P610

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1719853

[Impact]
[ 74.344674] usb 3-1: 2:1: cannot get freq at ep 0x1
...the same message will flood over dmesg.

[Test Case]
With this patch, ALSA stops trying to read sample rate from device,
hence no more error messages.

[Fix]
Make affected device to use sample rate quirk.

[Regression Potential]
Minimal. This patch only affect one device.

Kai-Heng Feng (1):
  ALSA: usb-audio: Add sample rate quirk for Plantronics P610

 sound/usb/quirks.c | 1 +
 1 file changed, 1 insertion(+)

--
2.14.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1 SRU X/Z/A] ALSA: usb-audio: Add sample rate quirk for Plantronics P610

Kai-Heng Feng
Like other Plantronics devices, P610 does not support sample
rate reading. Apply sample rate quirk to it.

BugLink: https://bugs.launchpad.net/bugs/1719853

Signed-off-by: Kai-Heng Feng <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit c247487c0dd6fefff6ed0cbcbe66f037721755fb)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 sound/usb/quirks.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index c0b86f77755c..dcfe6669c362 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1139,6 +1139,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
  case USB_ID(0x047F, 0x0415): /* Plantronics BT-300 */
  case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
  case USB_ID(0x047F, 0xC022): /* Plantronics C310 */
+ case USB_ID(0x047F, 0xC02F): /* Plantronics P610 */
  case USB_ID(0x047F, 0xC036): /* Plantronics C520-M */
  case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
  case USB_ID(0x0556, 0x0014): /* Phoenix Audio TMX320VC */
--
2.14.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 1/1 SRU X/Z/A] ALSA: usb-audio: Add sample rate quirk for Plantronics P610

Kleber Souza
On 11/09/17 10:33, Kai-Heng Feng wrote:
> Like other Plantronics devices, P610 does not support sample
> rate reading. Apply sample rate quirk to it.
>
> BugLink: https://bugs.launchpad.net/bugs/1719853
>
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> Signed-off-by: Takashi Iwai <[hidden email]>
> (cherry picked from commit c247487c0dd6fefff6ed0cbcbe66f037721755fb)
> Signed-off-by: Kai-Heng Feng <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  sound/usb/quirks.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index c0b86f77755c..dcfe6669c362 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -1139,6 +1139,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
>   case USB_ID(0x047F, 0x0415): /* Plantronics BT-300 */
>   case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
>   case USB_ID(0x047F, 0xC022): /* Plantronics C310 */
> + case USB_ID(0x047F, 0xC02F): /* Plantronics P610 */
>   case USB_ID(0x047F, 0xC036): /* Plantronics C520-M */
>   case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
>   case USB_ID(0x0556, 0x0014): /* Phoenix Audio TMX320VC */
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [PATCH 1/1 SRU X/Z/A] ALSA: usb-audio: Add sample rate quirk for Plantronics P610

Stefan Bader-2
In reply to this post by Kai-Heng Feng
On 09.11.2017 10:33, Kai-Heng Feng wrote:
> Like other Plantronics devices, P610 does not support sample
> rate reading. Apply sample rate quirk to it.
>
> BugLink: https://bugs.launchpad.net/bugs/1719853
>
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> Signed-off-by: Takashi Iwai <[hidden email]>
> (cherry picked from commit c247487c0dd6fefff6ed0cbcbe66f037721755fb)
> Signed-off-by: Kai-Heng Feng <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---

Patch looks ok but could you copy the sru justification into the bug report
subject? Thanks.

-Stefan

>  sound/usb/quirks.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index c0b86f77755c..dcfe6669c362 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -1139,6 +1139,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
>   case USB_ID(0x047F, 0x0415): /* Plantronics BT-300 */
>   case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
>   case USB_ID(0x047F, 0xC022): /* Plantronics C310 */
> + case USB_ID(0x047F, 0xC02F): /* Plantronics P610 */
>   case USB_ID(0x047F, 0xC036): /* Plantronics C520-M */
>   case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
>   case USB_ID(0x0556, 0x0014): /* Phoenix Audio TMX320VC */
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED: [PATCH 0/1 SRU X/Z/A] Forbid ALSA reads sample rate on Plantronics P610

Stefan Bader-2
In reply to this post by Kai-Heng Feng
On 09.11.2017 10:33, Kai-Heng Feng wrote:

> [Impact]
> [ 74.344674] usb 3-1: 2:1: cannot get freq at ep 0x1
> ...the same message will flood over dmesg.
>
> [Test Case]
> With this patch, ALSA stops trying to read sample rate from device,
> hence no more error messages.
>
> [Fix]
> Make affected device to use sample rate quirk.
>
> [Regression Potential]
> Minimal. This patch only affect one device.
Applied to Xenial/Zesty/Artful master-next. Thanks
(did copy the sru justification to the bug report as well since that still had
not been done)


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment