[PATCH 0/1] UBUNTU: ARM: Enable AA with SECURITYFS for imx51

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/1] UBUNTU: ARM: Enable AA with SECURITYFS for imx51

Brad Figg-2
Please pull from:
    git://kernel.ubuntu.com/bradf/ubuntu-jaunty master

It is necessary to have SECURITYFS enabled at the same time
as AA.

Signed-off-by: Brad Figg <[hidden email]>
---
 debian/config/armel/config           |    1 -
 debian/config/armel/config.imx51     |    3 ++-
 debian/config/armel/config.iop32x    |    1 +
 debian/config/armel/config.ixp4xx    |    1 +
 debian/config/armel/config.versatile |    1 +
 5 files changed, 5 insertions(+), 2 deletions(-)


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] UBUNTU: ARM: Enable AA with SECURITYFS for imx51

Brad Figg-2
It is necessary to have SECURITYFS enabled at the same time
as AA.

Signed-off-by: Brad Figg <[hidden email]>
---
 debian/config/armel/config           |    1 -
 debian/config/armel/config.imx51     |    3 ++-
 debian/config/armel/config.iop32x    |    1 +
 debian/config/armel/config.ixp4xx    |    1 +
 debian/config/armel/config.versatile |    1 +
 5 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/debian/config/armel/config b/debian/config/armel/config
index f485def..47bd110 100644
--- a/debian/config/armel/config
+++ b/debian/config/armel/config
@@ -322,7 +322,6 @@ CONFIG_SCSI_DMA=y
 # CONFIG_SCSI_LOGGING is not set
 # CONFIG_SCSI_SRP_ATTRS is not set
 CONFIG_SCSI_WAIT_SCAN=m
-# CONFIG_SECURITYFS is not set
 CONFIG_SELECT_MEMORY_MODEL=y
 CONFIG_SERIAL_CORE=y
 CONFIG_SERIAL_CORE_CONSOLE=y
diff --git a/debian/config/armel/config.imx51 b/debian/config/armel/config.imx51
index 335aa0d..36abaa3 100644
--- a/debian/config/armel/config.imx51
+++ b/debian/config/armel/config.imx51
@@ -1186,8 +1186,9 @@ CONFIG_SDIO_UNIFI_FS=m
 CONFIG_SDMA_IRAM=y
 CONFIG_SDMA_IRAM_SIZE=0x1000
 CONFIG_SECURITY=y
+CONFIG_SECURITYFS=y
 CONFIG_SECURITY_APPARMOR=y
-CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=0
+CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=1
 CONFIG_SECURITY_APPARMOR_DISABLE=y
 CONFIG_SECURITY_DEFAULT_MMAP_MIN_ADDR=32768
 CONFIG_SECURITY_FILE_CAPABILITIES=y
diff --git a/debian/config/armel/config.iop32x b/debian/config/armel/config.iop32x
index 6183dd6..a0f5298 100644
--- a/debian/config/armel/config.iop32x
+++ b/debian/config/armel/config.iop32x
@@ -863,6 +863,7 @@ CONFIG_SCHED_DEBUG=y
 # CONFIG_SCSI_SPI_ATTRS is not set
 # CONFIG_SCSI_TGT is not set
 CONFIG_SECURITY=y
+# CONFIG_SECURITYFS is not set
 CONFIG_SECURITY_APPARMOR=y
 CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=1
 CONFIG_SECURITY_APPARMOR_DISABLE=y
diff --git a/debian/config/armel/config.ixp4xx b/debian/config/armel/config.ixp4xx
index 30088da..08d5838 100644
--- a/debian/config/armel/config.ixp4xx
+++ b/debian/config/armel/config.ixp4xx
@@ -924,6 +924,7 @@ CONFIG_SCTP_HMAC_MD5=y
 # CONFIG_SCTP_HMAC_SHA1 is not set
 CONFIG_SDIO_UART=m
 # CONFIG_SECURITY is not set
+# CONFIG_SECURITYFS is not set
 # CONFIG_SECURITY_FILE_CAPABILITIES is not set
 CONFIG_SENSORS_AD7414=m
 CONFIG_SENSORS_AD7418=m
diff --git a/debian/config/armel/config.versatile b/debian/config/armel/config.versatile
index ebaeacf..d884ee4 100644
--- a/debian/config/armel/config.versatile
+++ b/debian/config/armel/config.versatile
@@ -673,6 +673,7 @@ CONFIG_SCSI_SYM53C8XX_MMIO=y
 # CONFIG_SCSI_TGT is not set
 # CONFIG_SDIO_UART is not set
 CONFIG_SECURITY=y
+# CONFIG_SECURITYFS is not set
 CONFIG_SECURITY_APPARMOR=y
 CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=1
 CONFIG_SECURITY_APPARMOR_DISABLE=y
--
1.6.1.3


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/1] UBUNTU: ARM: Enable AA with SECURITYFS for imx51

Tim Gardner-2
In reply to this post by Brad Figg-2
Brad Figg wrote:

> Please pull from:
>     git://kernel.ubuntu.com/bradf/ubuntu-jaunty master
>
> It is necessary to have SECURITYFS enabled at the same time
> as AA.
>
> Signed-off-by: Brad Figg <[hidden email]>
> ---
>  debian/config/armel/config           |    1 -
>  debian/config/armel/config.imx51     |    3 ++-
>  debian/config/armel/config.iop32x    |    1 +
>  debian/config/armel/config.ixp4xx    |    1 +
>  debian/config/armel/config.versatile |    1 +
>  5 files changed, 5 insertions(+), 2 deletions(-)
>
>

pulled with modifications. Anytime you make changes to a Kconfig or to a
debian/config/* you should also run 'debian/rules updateconfigs'. The
goal is to make any particular commit bisectable, e.g., any commit you
make should at least build. I'll usually collapse Kconfig changes and
config updates into the same commit, but then perhaps I'm just retentive.
--
Tim Gardner [hidden email]

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] UBUNTU: ARM: Enable AA with SECURITYFS for imx51

Andy Whitcroft-3
In reply to this post by Brad Figg-2
On Tue, Mar 24, 2009 at 03:43:46PM -0700, Brad Figg wrote:

> It is necessary to have SECURITYFS enabled at the same time
> as AA.
>
> Signed-off-by: Brad Figg <[hidden email]>
> ---
>  debian/config/armel/config           |    1 -
>  debian/config/armel/config.imx51     |    3 ++-
>  debian/config/armel/config.iop32x    |    1 +
>  debian/config/armel/config.ixp4xx    |    1 +
>  debian/config/armel/config.versatile |    1 +
>  5 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/debian/config/armel/config b/debian/config/armel/config
> index f485def..47bd110 100644
> --- a/debian/config/armel/config
> +++ b/debian/config/armel/config
> @@ -322,7 +322,6 @@ CONFIG_SCSI_DMA=y
>  # CONFIG_SCSI_LOGGING is not set
>  # CONFIG_SCSI_SRP_ATTRS is not set
>  CONFIG_SCSI_WAIT_SCAN=m
> -# CONFIG_SECURITYFS is not set
>  CONFIG_SELECT_MEMORY_MODEL=y
>  CONFIG_SERIAL_CORE=y
>  CONFIG_SERIAL_CORE_CONSOLE=y
> diff --git a/debian/config/armel/config.imx51 b/debian/config/armel/config.imx51
> index 335aa0d..36abaa3 100644
> --- a/debian/config/armel/config.imx51
> +++ b/debian/config/armel/config.imx51
> @@ -1186,8 +1186,9 @@ CONFIG_SDIO_UNIFI_FS=m
>  CONFIG_SDMA_IRAM=y
>  CONFIG_SDMA_IRAM_SIZE=0x1000
>  CONFIG_SECURITY=y
> +CONFIG_SECURITYFS=y
>  CONFIG_SECURITY_APPARMOR=y
> -CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=0
> +CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=1

Do we know why this changed here?

-apw

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] UBUNTU: ARM: Enable AA with SECURITYFS for imx51

Amit Kucheria-6
On Wed, Mar 25, 2009 at 01:11:23PM +0000, Andy Whitcroft wrote:

> On Tue, Mar 24, 2009 at 03:43:46PM -0700, Brad Figg wrote:
> > It is necessary to have SECURITYFS enabled at the same time
> > as AA.
> >
> > Signed-off-by: Brad Figg <[hidden email]>
> > ---
> >  debian/config/armel/config           |    1 -
> >  debian/config/armel/config.imx51     |    3 ++-
> >  debian/config/armel/config.iop32x    |    1 +
> >  debian/config/armel/config.ixp4xx    |    1 +
> >  debian/config/armel/config.versatile |    1 +
> >  5 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/debian/config/armel/config b/debian/config/armel/config
> > index f485def..47bd110 100644
> > --- a/debian/config/armel/config
> > +++ b/debian/config/armel/config
> > @@ -322,7 +322,6 @@ CONFIG_SCSI_DMA=y
> >  # CONFIG_SCSI_LOGGING is not set
> >  # CONFIG_SCSI_SRP_ATTRS is not set
> >  CONFIG_SCSI_WAIT_SCAN=m
> > -# CONFIG_SECURITYFS is not set
> >  CONFIG_SELECT_MEMORY_MODEL=y
> >  CONFIG_SERIAL_CORE=y
> >  CONFIG_SERIAL_CORE_CONSOLE=y
> > diff --git a/debian/config/armel/config.imx51 b/debian/config/armel/config.imx51
> > index 335aa0d..36abaa3 100644
> > --- a/debian/config/armel/config.imx51
> > +++ b/debian/config/armel/config.imx51
> > @@ -1186,8 +1186,9 @@ CONFIG_SDIO_UNIFI_FS=m
> >  CONFIG_SDMA_IRAM=y
> >  CONFIG_SDMA_IRAM_SIZE=0x1000
> >  CONFIG_SECURITY=y
> > +CONFIG_SECURITYFS=y
> >  CONFIG_SECURITY_APPARMOR=y
> > -CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=0
> > +CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=1
>
> Do we know why this changed here?

0 -> 1?

That enables AA on bootup. We were compiling AA in, but disabling it on bootup till Brad found the problem.

--
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || [hidden email]
----------------------------------------------------------------------

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] UBUNTU: ARM: Enable AA with SECURITYFS for imx51

Brad Figg-2
Amit Kucheria wrote:

> On Wed, Mar 25, 2009 at 01:11:23PM +0000, Andy Whitcroft wrote:
>> On Tue, Mar 24, 2009 at 03:43:46PM -0700, Brad Figg wrote:
>>> It is necessary to have SECURITYFS enabled at the same time
>>> as AA.
>>>
>>> Signed-off-by: Brad Figg <[hidden email]>
>>> ---
>>>  debian/config/armel/config           |    1 -
>>>  debian/config/armel/config.imx51     |    3 ++-
>>>  debian/config/armel/config.iop32x    |    1 +
>>>  debian/config/armel/config.ixp4xx    |    1 +
>>>  debian/config/armel/config.versatile |    1 +
>>>  5 files changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/debian/config/armel/config b/debian/config/armel/config
>>> index f485def..47bd110 100644
>>> --- a/debian/config/armel/config
>>> +++ b/debian/config/armel/config
>>> @@ -322,7 +322,6 @@ CONFIG_SCSI_DMA=y
>>>  # CONFIG_SCSI_LOGGING is not set
>>>  # CONFIG_SCSI_SRP_ATTRS is not set
>>>  CONFIG_SCSI_WAIT_SCAN=m
>>> -# CONFIG_SECURITYFS is not set
>>>  CONFIG_SELECT_MEMORY_MODEL=y
>>>  CONFIG_SERIAL_CORE=y
>>>  CONFIG_SERIAL_CORE_CONSOLE=y
>>> diff --git a/debian/config/armel/config.imx51 b/debian/config/armel/config.imx51
>>> index 335aa0d..36abaa3 100644
>>> --- a/debian/config/armel/config.imx51
>>> +++ b/debian/config/armel/config.imx51
>>> @@ -1186,8 +1186,9 @@ CONFIG_SDIO_UNIFI_FS=m
>>>  CONFIG_SDMA_IRAM=y
>>>  CONFIG_SDMA_IRAM_SIZE=0x1000
>>>  CONFIG_SECURITY=y
>>> +CONFIG_SECURITYFS=y
>>>  CONFIG_SECURITY_APPARMOR=y
>>> -CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=0
>>> +CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=1
>> Do we know why this changed here?
>
> 0 -> 1?
>
> That enables AA on bootup. We were compiling AA in, but disabling it on bootup till Brad found the problem.
>

I thought that since I'd found the problem and turned on the securityfs
in the config we'd want to enable AA.

Was I mistaken?

Brad

--
Brad Figg [hidden email] http://www.canonical.com

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] UBUNTU: ARM: Enable AA with SECURITYFS for imx51

Tim Gardner-2
Brad Figg wrote:

> Amit Kucheria wrote:
>> On Wed, Mar 25, 2009 at 01:11:23PM +0000, Andy Whitcroft wrote:
>>> On Tue, Mar 24, 2009 at 03:43:46PM -0700, Brad Figg wrote:
>>>> It is necessary to have SECURITYFS enabled at the same time
>>>> as AA.
>>>>
>>>> Signed-off-by: Brad Figg <[hidden email]>
>>>> ---
>>>>  debian/config/armel/config           |    1 -
>>>>  debian/config/armel/config.imx51     |    3 ++-
>>>>  debian/config/armel/config.iop32x    |    1 +
>>>>  debian/config/armel/config.ixp4xx    |    1 +
>>>>  debian/config/armel/config.versatile |    1 +
>>>>  5 files changed, 5 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/debian/config/armel/config b/debian/config/armel/config
>>>> index f485def..47bd110 100644
>>>> --- a/debian/config/armel/config
>>>> +++ b/debian/config/armel/config
>>>> @@ -322,7 +322,6 @@ CONFIG_SCSI_DMA=y
>>>>  # CONFIG_SCSI_LOGGING is not set
>>>>  # CONFIG_SCSI_SRP_ATTRS is not set
>>>>  CONFIG_SCSI_WAIT_SCAN=m
>>>> -# CONFIG_SECURITYFS is not set
>>>>  CONFIG_SELECT_MEMORY_MODEL=y
>>>>  CONFIG_SERIAL_CORE=y
>>>>  CONFIG_SERIAL_CORE_CONSOLE=y
>>>> diff --git a/debian/config/armel/config.imx51 b/debian/config/armel/config.imx51
>>>> index 335aa0d..36abaa3 100644
>>>> --- a/debian/config/armel/config.imx51
>>>> +++ b/debian/config/armel/config.imx51
>>>> @@ -1186,8 +1186,9 @@ CONFIG_SDIO_UNIFI_FS=m
>>>>  CONFIG_SDMA_IRAM=y
>>>>  CONFIG_SDMA_IRAM_SIZE=0x1000
>>>>  CONFIG_SECURITY=y
>>>> +CONFIG_SECURITYFS=y
>>>>  CONFIG_SECURITY_APPARMOR=y
>>>> -CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=0
>>>> +CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=1
>>> Do we know why this changed here?
>> 0 -> 1?
>>
>> That enables AA on bootup. We were compiling AA in, but disabling it on bootup till Brad found the problem.
>>
>
> I thought that since I'd found the problem and turned on the securityfs
> in the config we'd want to enable AA.
>
> Was I mistaken?
>
> Brad
>

You are not mistaken. Enabling AA was the whole point of this patch set
AFAIUI.

--
Tim Gardner [hidden email]

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] UBUNTU: ARM: Enable AA with SECURITYFS for imx51

Amit Kucheria-6
In reply to this post by Brad Figg-2
On Wed, Mar 25, 2009 at 11:01:42AM -0700, Brad Figg wrote:

> Amit Kucheria wrote:
> > On Wed, Mar 25, 2009 at 01:11:23PM +0000, Andy Whitcroft wrote:
> >> On Tue, Mar 24, 2009 at 03:43:46PM -0700, Brad Figg wrote:
> >>> It is necessary to have SECURITYFS enabled at the same time
> >>> as AA.
> >>>
> >>> Signed-off-by: Brad Figg <[hidden email]>
> >>> ---
> >>>  debian/config/armel/config           |    1 -
> >>>  debian/config/armel/config.imx51     |    3 ++-
> >>>  debian/config/armel/config.iop32x    |    1 +
> >>>  debian/config/armel/config.ixp4xx    |    1 +
> >>>  debian/config/armel/config.versatile |    1 +
> >>>  5 files changed, 5 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/debian/config/armel/config b/debian/config/armel/config
> >>> index f485def..47bd110 100644
> >>> --- a/debian/config/armel/config
> >>> +++ b/debian/config/armel/config
> >>> @@ -322,7 +322,6 @@ CONFIG_SCSI_DMA=y
> >>>  # CONFIG_SCSI_LOGGING is not set
> >>>  # CONFIG_SCSI_SRP_ATTRS is not set
> >>>  CONFIG_SCSI_WAIT_SCAN=m
> >>> -# CONFIG_SECURITYFS is not set
> >>>  CONFIG_SELECT_MEMORY_MODEL=y
> >>>  CONFIG_SERIAL_CORE=y
> >>>  CONFIG_SERIAL_CORE_CONSOLE=y
> >>> diff --git a/debian/config/armel/config.imx51 b/debian/config/armel/config.imx51
> >>> index 335aa0d..36abaa3 100644
> >>> --- a/debian/config/armel/config.imx51
> >>> +++ b/debian/config/armel/config.imx51
> >>> @@ -1186,8 +1186,9 @@ CONFIG_SDIO_UNIFI_FS=m
> >>>  CONFIG_SDMA_IRAM=y
> >>>  CONFIG_SDMA_IRAM_SIZE=0x1000
> >>>  CONFIG_SECURITY=y
> >>> +CONFIG_SECURITYFS=y
> >>>  CONFIG_SECURITY_APPARMOR=y
> >>> -CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=0
> >>> +CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE=1
> >> Do we know why this changed here?
> >
> > 0 -> 1?
> >
> > That enables AA on bootup. We were compiling AA in, but disabling it on bootup till Brad found the problem.
> >
>
> I thought that since I'd found the problem and turned on the securityfs
> in the config we'd want to enable AA.
>
> Was I mistaken?

Nope. This was exactly what we needed. I was just answering Andy's question.

Regards,
Amit

--
------------------------------------------------------------
Amit Kucheria, Finland
------------------------------------------------------------

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team