[PATCH 0/2] [Lucid] Miscellaneous configuration changes

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/2] [Lucid] Miscellaneous configuration changes

Andy Whitcroft-3
Following this email are a couple of minor configration changes which have
come out of discussions on other bugs.  The first enables MMIOTRACE which
is slated to be the best thing since sliced bread for reporting Nouveau
issues upstream.  The second enabled BLK_DEV_BSG which is required for
UDEV to get serial numbers of some disks.

-apw

Andy Whitcroft (2):
  UBUNTU: [Config] enable MMIOTRACE for graphics debugging
  UBUNTU: [Config] enable BLK_DEV_BSG

 debian.master/config/config.common.ports  |    2 +-
 debian.master/config/config.common.ubuntu |    5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/2] UBUNTU: [Config] enable MMIOTRACE for graphics debugging

Andy Whitcroft-3
Enable MMIOTRACE to allow us to trace low level card operations.  This is
commonly used to debug graphics issues particularly under Nouveau.
According to the documentation it is a near zero impact when disabled.

Signed-off-by: Andy Whitcroft <[hidden email]>
---
 debian.master/config/config.common.ubuntu |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 0bca70a..989c14c 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -2236,7 +2236,8 @@ CONFIG_MMC_TIFM_SD=m
 # CONFIG_MMC_UNSAFE_RESUME is not set
 CONFIG_MMC_VIA_SDMMC=m
 CONFIG_MMC_WBSD=m
-# CONFIG_MMIOTRACE is not set
+CONFIG_MMIOTRACE=y
+# CONFIG_MMIOTRACE_TEST is not set
 CONFIG_MMU=y
 CONFIG_MMU_NOTIFIER=y
 CONFIG_MM_OWNER=y
--
1.7.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 2/2] UBUNTU: [Config] enable BLK_DEV_BSG

Andy Whitcroft-3
In reply to this post by Andy Whitcroft-3
Enable block layer SCSI Generic V4:

    BLK_DEV_BSG=y

This is an option which is recommended enabled, and seemingly required
for recent UDEV versions.  From the option's help text:

    This option is required by recent UDEV versions to properly
    access device serial numbers, etc.

    If unsure, say Y.

Signed-off-by: Andy Whitcroft <[hidden email]>
---
 debian.master/config/config.common.ports  |    2 +-
 debian.master/config/config.common.ubuntu |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian.master/config/config.common.ports b/debian.master/config/config.common.ports
index bfc858e..d9c2164 100644
--- a/debian.master/config/config.common.ports
+++ b/debian.master/config/config.common.ports
@@ -272,7 +272,7 @@ CONFIG_BLK_DEV_3W_XXXX_RAID=m
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
-# CONFIG_BLK_DEV_BSG is not set
+CONFIG_BLK_DEV_BSG=y
 # CONFIG_BLK_DEV_CMD64X is not set
 CONFIG_BLK_DEV_COMPCACHE=m
 # CONFIG_BLK_DEV_COMPCACHE_DEBUG is not set
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 989c14c..d35c307 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -365,7 +365,7 @@ CONFIG_BLK_CPQ_CISS_DA=m
 CONFIG_BLK_CPQ_DA=m
 CONFIG_BLK_DEV=y
 CONFIG_BLK_DEV_3W_XXXX_RAID=m
-# CONFIG_BLK_DEV_BSG is not set
+CONFIG_BLK_DEV_BSG=y
 CONFIG_BLK_DEV_COMPCACHE=m
 # CONFIG_BLK_DEV_COMPCACHE_DEBUG is not set
 # CONFIG_BLK_DEV_COMPCACHE_STATS is not set
--
1.7.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 2/2] UBUNTU: [Config] enable BLK_DEV_BSG

Stefan Bader-2
It was on our list (though a bit hidden) and has moved from experimental (for
which it was not enabled) to recommended. So it seem reasonable to turn it on now.

Andy Whitcroft wrote:

> Enable block layer SCSI Generic V4:
>
>     BLK_DEV_BSG=y
>
> This is an option which is recommended enabled, and seemingly required
> for recent UDEV versions.  From the option's help text:
>
>     This option is required by recent UDEV versions to properly
>     access device serial numbers, etc.
>
>     If unsure, say Y.
>
> Signed-off-by: Andy Whitcroft <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---
>  debian.master/config/config.common.ports  |    2 +-
>  debian.master/config/config.common.ubuntu |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/debian.master/config/config.common.ports b/debian.master/config/config.common.ports
> index bfc858e..d9c2164 100644
> --- a/debian.master/config/config.common.ports
> +++ b/debian.master/config/config.common.ports
> @@ -272,7 +272,7 @@ CONFIG_BLK_DEV_3W_XXXX_RAID=m
>  # CONFIG_BLK_DEV_AEC62XX is not set
>  # CONFIG_BLK_DEV_ALI15X3 is not set
>  # CONFIG_BLK_DEV_AMD74XX is not set
> -# CONFIG_BLK_DEV_BSG is not set
> +CONFIG_BLK_DEV_BSG=y
>  # CONFIG_BLK_DEV_CMD64X is not set
>  CONFIG_BLK_DEV_COMPCACHE=m
>  # CONFIG_BLK_DEV_COMPCACHE_DEBUG is not set
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 989c14c..d35c307 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -365,7 +365,7 @@ CONFIG_BLK_CPQ_CISS_DA=m
>  CONFIG_BLK_CPQ_DA=m
>  CONFIG_BLK_DEV=y
>  CONFIG_BLK_DEV_3W_XXXX_RAID=m
> -# CONFIG_BLK_DEV_BSG is not set
> +CONFIG_BLK_DEV_BSG=y
>  CONFIG_BLK_DEV_COMPCACHE=m
>  # CONFIG_BLK_DEV_COMPCACHE_DEBUG is not set
>  # CONFIG_BLK_DEV_COMPCACHE_STATS is not set


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/2] UBUNTU: [Config] enable MMIOTRACE for graphics debugging

Stefan Bader-2
In reply to this post by Andy Whitcroft-3
It seems at least worth trying as everything that helps to debug is good as long
as it does not impact normal usage.

Andy Whitcroft wrote:
> Enable MMIOTRACE to allow us to trace low level card operations.  This is
> commonly used to debug graphics issues particularly under Nouveau.
> According to the documentation it is a near zero impact when disabled.
>
> Signed-off-by: Andy Whitcroft <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---
>  debian.master/config/config.common.ubuntu |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 0bca70a..989c14c 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -2236,7 +2236,8 @@ CONFIG_MMC_TIFM_SD=m
>  # CONFIG_MMC_UNSAFE_RESUME is not set
>  CONFIG_MMC_VIA_SDMMC=m
>  CONFIG_MMC_WBSD=m
> -# CONFIG_MMIOTRACE is not set
> +CONFIG_MMIOTRACE=y
> +# CONFIG_MMIOTRACE_TEST is not set
>  CONFIG_MMU=y
>  CONFIG_MMU_NOTIFIER=y
>  CONFIG_MM_OWNER=y


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/2] UBUNTU: [Config] enable MMIOTRACE for graphics debugging

Colin Ian King-2
In reply to this post by Andy Whitcroft-3
The benefit as a debugging tool makes this a very good option to turn
on. It appears to add minimal overhead when not being used in debug
mode, so I'm for this.

On Wed, 2010-03-17 at 09:26 +0000, Andy Whitcroft wrote:
> Enable MMIOTRACE to allow us to trace low level card operations.  This is
> commonly used to debug graphics issues particularly under Nouveau.
> According to the documentation it is a near zero impact when disabled.
>
> Signed-off-by: Andy Whitcroft <[hidden email]>
Acked-by: Colin King <[hidden email]>

> ---
>  debian.master/config/config.common.ubuntu |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 0bca70a..989c14c 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -2236,7 +2236,8 @@ CONFIG_MMC_TIFM_SD=m
>  # CONFIG_MMC_UNSAFE_RESUME is not set
>  CONFIG_MMC_VIA_SDMMC=m
>  CONFIG_MMC_WBSD=m
> -# CONFIG_MMIOTRACE is not set
> +CONFIG_MMIOTRACE=y
> +# CONFIG_MMIOTRACE_TEST is not set
>  CONFIG_MMU=y
>  CONFIG_MMU_NOTIFIER=y
>  CONFIG_MM_OWNER=y
> --
> 1.7.0
>
>



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/2] UBUNTU: [Config] enable MMIOTRACE for graphics debugging

Bryce Harrington-5
In reply to this post by Andy Whitcroft-3
On Wed, Mar 17, 2010 at 09:26:24AM +0000, Andy Whitcroft wrote:
> Enable MMIOTRACE to allow us to trace low level card operations.  This is
> commonly used to debug graphics issues particularly under Nouveau.
> According to the documentation it is a near zero impact when disabled.

"when enabled" I hope?

> Signed-off-by: Andy Whitcroft <[hidden email]>
> ---
>  debian.master/config/config.common.ubuntu |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 0bca70a..989c14c 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -2236,7 +2236,8 @@ CONFIG_MMC_TIFM_SD=m
>  # CONFIG_MMC_UNSAFE_RESUME is not set
>  CONFIG_MMC_VIA_SDMMC=m
>  CONFIG_MMC_WBSD=m
> -# CONFIG_MMIOTRACE is not set
> +CONFIG_MMIOTRACE=y
> +# CONFIG_MMIOTRACE_TEST is not set
>  CONFIG_MMU=y
>  CONFIG_MMU_NOTIFIER=y
>  CONFIG_MM_OWNER=y
> --
> 1.7.0
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 2/2] UBUNTU: [Config] enable BLK_DEV_BSG

Colin Ian King-2
In reply to this post by Andy Whitcroft-3
Well, this is no longer experimental and I cannot see any reason why not
to enable it, especially since the Kconfig recommends enabling it by
default.

On Wed, 2010-03-17 at 09:26 +0000, Andy Whitcroft wrote:

> Enable block layer SCSI Generic V4:
>
>     BLK_DEV_BSG=y
>
> This is an option which is recommended enabled, and seemingly required
> for recent UDEV versions.  From the option's help text:
>
>     This option is required by recent UDEV versions to properly
>     access device serial numbers, etc.
>
>     If unsure, say Y.
>
> Signed-off-by: Andy Whitcroft <[hidden email]>
Acked-by: Colin King <[hidden email]>

> ---
>  debian.master/config/config.common.ports  |    2 +-
>  debian.master/config/config.common.ubuntu |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/debian.master/config/config.common.ports b/debian.master/config/config.common.ports
> index bfc858e..d9c2164 100644
> --- a/debian.master/config/config.common.ports
> +++ b/debian.master/config/config.common.ports
> @@ -272,7 +272,7 @@ CONFIG_BLK_DEV_3W_XXXX_RAID=m
>  # CONFIG_BLK_DEV_AEC62XX is not set
>  # CONFIG_BLK_DEV_ALI15X3 is not set
>  # CONFIG_BLK_DEV_AMD74XX is not set
> -# CONFIG_BLK_DEV_BSG is not set
> +CONFIG_BLK_DEV_BSG=y
>  # CONFIG_BLK_DEV_CMD64X is not set
>  CONFIG_BLK_DEV_COMPCACHE=m
>  # CONFIG_BLK_DEV_COMPCACHE_DEBUG is not set
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 989c14c..d35c307 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -365,7 +365,7 @@ CONFIG_BLK_CPQ_CISS_DA=m
>  CONFIG_BLK_CPQ_DA=m
>  CONFIG_BLK_DEV=y
>  CONFIG_BLK_DEV_3W_XXXX_RAID=m
> -# CONFIG_BLK_DEV_BSG is not set
> +CONFIG_BLK_DEV_BSG=y
>  CONFIG_BLK_DEV_COMPCACHE=m
>  # CONFIG_BLK_DEV_COMPCACHE_DEBUG is not set
>  # CONFIG_BLK_DEV_COMPCACHE_STATS is not set
> --
> 1.7.0
>
>



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/2] UBUNTU: [Config] enable MMIOTRACE for graphics debugging

Andy Whitcroft-3
In reply to this post by Bryce Harrington-5
On Wed, Mar 17, 2010 at 03:03:41AM -0700, Bryce Harrington wrote:
> On Wed, Mar 17, 2010 at 09:26:24AM +0000, Andy Whitcroft wrote:
> > Enable MMIOTRACE to allow us to trace low level card operations.  This is
> > commonly used to debug graphics issues particularly under Nouveau.
> > According to the documentation it is a near zero impact when disabled.
>
> "when enabled" I hope?

The cost is near-zero for having the MMIOTRACE option enabled with the
trace collection turned off (the default).  We take one additional branch
in the mmio map/upmap paths which are non-critical initialisation/teardone
paths in normal usage.  The actual mmio operations are not affected at all.
When we enable trace collection the overhead is high, taking a page
fault for each access to the mmio mapping.

-apw

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[APPLIED] [PATCH 0/2] [Lucid] Miscellaneous configuration changes

Andy Whitcroft-3
In reply to this post by Andy Whitcroft-3
Applied to Lucid.

-apw

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/2] UBUNTU: [Config] enable MMIOTRACE for graphics debugging

Christopher James Halse Rogers-5
In reply to this post by Bryce Harrington-5
On Wed, 2010-03-17 at 03:03 -0700, Bryce Harrington wrote:
> On Wed, Mar 17, 2010 at 09:26:24AM +0000, Andy Whitcroft wrote:
> > Enable MMIOTRACE to allow us to trace low level card operations.  This is
> > commonly used to debug graphics issues particularly under Nouveau.
> > According to the documentation it is a near zero impact when disabled.
>
> "when enabled" I hope?
>
No; when it's enabled it's a huge performance hit.  It's not uncommon
for a mmio-traced nvidia blob to take multiple minutes to bring up X.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (501 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/2] UBUNTU: [Config] enable MMIOTRACE for graphics debugging

Scott James Remnant-2
On Thu, 2010-03-18 at 16:43 +1100, Christopher James Halse Rogers wrote:

> On Wed, 2010-03-17 at 03:03 -0700, Bryce Harrington wrote:
> > On Wed, Mar 17, 2010 at 09:26:24AM +0000, Andy Whitcroft wrote:
> > > Enable MMIOTRACE to allow us to trace low level card operations.  This is
> > > commonly used to debug graphics issues particularly under Nouveau.
> > > According to the documentation it is a near zero impact when disabled.
> >
> > "when enabled" I hope?
> >
> No; when it's enabled it's a huge performance hit.  It's not uncommon
> for a mmio-traced nvidia blob to take multiple minutes to bring up X.
>
To be clear here:

The kernel config option, when enabled, adds a new available tracer,
which when itself is enabled, causes a huge performance hit.

Enabling the kernel config option doesn't cause a huge performance hit
in its own right.

Scott
--
Scott James Remnant
[hidden email]

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (205 bytes) Download Attachment