[PATCH 0/2][SRU][B/OEM-B/OEM-OSP1/D/E] UBUNTU: SAUCE: add rtl623 codec support and fix mic issues

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/2][SRU][B/OEM-B/OEM-OSP1/D/E] UBUNTU: SAUCE: add rtl623 codec support and fix mic issues

Aaron Ma
BugLink: https://bugs.launchpad.net/bugs/1850599

[Impact]
Headset mic jack can not work.

[Fix]
Add new rtl 623 codec support then fix headset mic issues.

[Test]
Verified on hardware. Tests results are good.

[Regression Potential]
Low.
cherry-picked from maintainer's tree.

The 2nd patch can be applied with "git am -3" on 4.15 kernel.

Aaron Ma (1):
  ALSA: hda/realtek - Fix 2 front mics of codec 0x623

Kailang Yang (1):
  ALSA: hda/realtek - Add support for ALC623

 sound/pci/hda/patch_realtek.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/2] UBUNTU: SAUCE: ALSA: hda/realtek - Add support for ALC623

Aaron Ma
From: Kailang Yang <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1850599

Support new codec ALC623.

Signed-off-by: Kailang Yang <[hidden email]>
Cc: <[hidden email]>
Link: https://lore.kernel.org/r/ed97b6a8bd9445ecb48bc763d9aaba7a@...
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit f0778871a13889b86a65d4ad34bef8340af9d082
https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Aaron Ma <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4278acb82445..cad0c2d6f400 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -408,6 +408,9 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
  case 0x10ec0672:
  alc_update_coef_idx(codec, 0xd, 0, 1<<14); /* EAPD Ctrl */
  break;
+ case 0x10ec0623:
+ alc_update_coef_idx(codec, 0x19, 1<<13, 0);
+ break;
  case 0x10ec0668:
  alc_update_coef_idx(codec, 0x7, 3<<13, 0);
  break;
@@ -2918,6 +2921,7 @@ enum {
  ALC269_TYPE_ALC225,
  ALC269_TYPE_ALC294,
  ALC269_TYPE_ALC300,
+ ALC269_TYPE_ALC623,
  ALC269_TYPE_ALC700,
 };
 
@@ -2953,6 +2957,7 @@ static int alc269_parse_auto_config(struct hda_codec *codec)
  case ALC269_TYPE_ALC225:
  case ALC269_TYPE_ALC294:
  case ALC269_TYPE_ALC300:
+ case ALC269_TYPE_ALC623:
  case ALC269_TYPE_ALC700:
  ssids = alc269_ssids;
  break;
@@ -7971,6 +7976,9 @@ static int patch_alc269(struct hda_codec *codec)
  spec->codec_variant = ALC269_TYPE_ALC300;
  spec->gen.mixer_nid = 0; /* no loopback on ALC300 */
  break;
+ case 0x10ec0623:
+ spec->codec_variant = ALC269_TYPE_ALC623;
+ break;
  case 0x10ec0700:
  case 0x10ec0701:
  case 0x10ec0703:
@@ -9098,6 +9106,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
  HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
  HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
  HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
+ HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
  HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660", patch_alc861),
  HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
  HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 2/2] UBUNTU: SAUCE: ALSA: hda/realtek - Fix 2 front mics of codec 0x623

Aaron Ma
In reply to this post by Aaron Ma
BugLink: https://bugs.launchpad.net/bugs/1850599

These 2 ThinkCentres installed a new realtek codec ID 0x623,
it has 2 front mics with the same location on pin 0x18 and 0x19.

Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
location to right, then pulseaudio can handle them.
One "Front Mic" and one "Mic" will be shown, and audio output works
fine.

Signed-off-by: Aaron Ma <[hidden email]>
Cc: <[hidden email]>
Link: https://lore.kernel.org/r/20191024114439.31522-1-aaron.ma@...
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit 8a6c55d0f883e9a7e7c91841434f3b6bbf932bb2
https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Aaron Ma <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index cad0c2d6f400..ec624835ec1d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7180,6 +7180,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
  SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+ SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+ SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
  SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
  SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
  SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK / APPLIED[Unstable]: [PATCH 0/2][SRU][B/OEM-B/OEM-OSP1/D/E] UBUNTU: SAUCE: add rtl623 codec support and fix mic issues

Seth Forshee
In reply to this post by Aaron Ma
On Wed, Oct 30, 2019 at 02:55:59PM +0800, Aaron Ma wrote:

> BugLink: https://bugs.launchpad.net/bugs/1850599
>
> [Impact]
> Headset mic jack can not work.
>
> [Fix]
> Add new rtl 623 codec support then fix headset mic issues.
>
> [Test]
> Verified on hardware. Tests results are good.
>
> [Regression Potential]
> Low.
> cherry-picked from maintainer's tree.
>
> The 2nd patch can be applied with "git am -3" on 4.15 kernel.

Acked-by: Seth Forshee <[hidden email]>

Applied to unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/APPLIED[OEM-B]: [PATCH 0/2][SRU][B/OEM-B/OEM-OSP1/D/E] UBUNTU: SAUCE: add rtl623 codec support and fix mic issues

AceLan Kao
In reply to this post by Aaron Ma
Acked-By: AceLan Kao <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED/cmt: [PATCH 0/2][SRU][B/OEM-B/OEM-OSP1/D/E] UBUNTU: SAUCE: add rtl623 codec support and fix mic issues

Khaled Elmously
In reply to this post by Aaron Ma
Patch #2 doesn't apply to Bionic for some reason - git am just complains. However, it was easy to manually apply it.

Bug was only targeted to B but not to D nor E - I targeted it D and E



On 2019-10-30 14:55:59 , Aaron Ma wrote:

> BugLink: https://bugs.launchpad.net/bugs/1850599
>
> [Impact]
> Headset mic jack can not work.
>
> [Fix]
> Add new rtl 623 codec support then fix headset mic issues.
>
> [Test]
> Verified on hardware. Tests results are good.
>
> [Regression Potential]
> Low.
> cherry-picked from maintainer's tree.
>
> The 2nd patch can be applied with "git am -3" on 4.15 kernel.
>
> Aaron Ma (1):
>   ALSA: hda/realtek - Fix 2 front mics of codec 0x623
>
> Kailang Yang (1):
>   ALSA: hda/realtek - Add support for ALC623
>
>  sound/pci/hda/patch_realtek.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> --
> 2.20.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED(B,D,E): [PATCH 0/2][SRU][B/OEM-B/OEM-OSP1/D/E] UBUNTU: SAUCE: add rtl623 codec support and fix mic issues

Khaled Elmously
My original APPLIED email should have specified that I only applied to targets B, D and E. Looks like OEM-OSP1 is still un-applied



On 2019-11-09 00:38:49 , Khaled Elmously wrote:

> Patch #2 doesn't apply to Bionic for some reason - git am just complains. However, it was easy to manually apply it.
>
> Bug was only targeted to B but not to D nor E - I targeted it D and E
>
>
>
> On 2019-10-30 14:55:59 , Aaron Ma wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1850599
> >
> > [Impact]
> > Headset mic jack can not work.
> >
> > [Fix]
> > Add new rtl 623 codec support then fix headset mic issues.
> >
> > [Test]
> > Verified on hardware. Tests results are good.
> >
> > [Regression Potential]
> > Low.
> > cherry-picked from maintainer's tree.
> >
> > The 2nd patch can be applied with "git am -3" on 4.15 kernel.
> >
> > Aaron Ma (1):
> >   ALSA: hda/realtek - Fix 2 front mics of codec 0x623
> >
> > Kailang Yang (1):
> >   ALSA: hda/realtek - Add support for ALC623
> >
> >  sound/pci/hda/patch_realtek.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > --
> > 2.20.1
> >
> >
> > --
> > kernel-team mailing list
> > [hidden email]
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team