[PATCH 0/2][SRU][B][OEM-B] dell-laptop: add more DMI whitelist

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/2][SRU][B][OEM-B] dell-laptop: add more DMI whitelist

You-Sheng Yang
BugLink: https://bugs.launchpad.net/bugs/1846453

[Impact]
Micphone-mute LED indicator on Dell Latitude 3310 keyboard may always
shown as on or off.

[Fix]
* fe486138788ba4 [1]: dell-laptop: Add 2-in-1 devices to the DMI whitelist
* c8ba9db2a790c0 [2]: dell-laptop: Removed duplicates in DMI whitelist

[Test Case]
Verified on Dell Latitude 3310.

[Regression Risk]
Low. The two target patch was landed to v4.16 and is already in
production use for a long time. Besides, this changeset only addes new
IDs (and remove duplicated ones), so it doesn't affect existing systems
but fix those affected ones.

Alexander Abrosimov (2):
  platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
  platform/x86: dell-laptop: Removed duplicates in DMI whitelist

 drivers/platform/x86/dell-laptop.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/2][SRU][B][OEM-B] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist

You-Sheng Yang
From: Alexander Abrosimov <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1846453

SMBIOS 3.0.0 Specification introduced new Chassis Types field values for
2-in-1 devices like tablets, convertibles and detachables. Dell's
Inspiron 2-in-1 and XPS 2-in-1 fall into this category and they have to
be added to the DMI whitelist, so rfkill and backlight can be controlled
for them as for other laptops.

Signed-off-by: Alexander Abrosimov <[hidden email]>
Reviewed-by: Mario Limonciello <[hidden email]>
Signed-off-by: Darren Hart (VMware) <[hidden email]>
(cherry picked from commit fe486138788ba435ffa918c8d7aba05a77b6289a)
Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/platform/x86/dell-laptop.c | 36 ++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index bb83e2c30601..f484b5a989cd 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -108,6 +108,42 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
  DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/
  },
  },
+ {
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
+ },
+ },
+ {
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
+ },
+ },
+ {
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
+ },
+ },
+ {
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
+ },
+ },
+ {
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
+ },
+ },
+ {
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
+ },
+ },
  {
  .ident = "Dell Computer Corporation",
  .matches = {
--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 2/2][SRU][B][OEM-B] platform/x86: dell-laptop: Removed duplicates in DMI whitelist

You-Sheng Yang
In reply to this post by You-Sheng Yang
From: Alexander Abrosimov <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1846453

Fixed a mistake in which several entries were duplicated in the DMI list
from the below commit
fe486138 platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist

Signed-off-by: Alexander Abrosimov <[hidden email]>
Reviewed-by: Pali Rohár <[hidden email]>
Signed-off-by: Andy Shevchenko <[hidden email]>
(cherry picked from commit c8ba9db2a790c0fcf2f6c4cafd45ff3a0751800e)
Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/platform/x86/dell-laptop.c | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index f484b5a989cd..77bedf5b3aac 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -126,24 +126,6 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
  DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
  },
  },
- {
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
- DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
- },
- },
- {
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
- DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
- },
- },
- {
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
- DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
- },
- },
  {
  .ident = "Dell Computer Corporation",
  .matches = {
--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/APPLIED[OEM-B]: [PATCH 0/2][SRU][B][OEM-B] dell-laptop: add more DMI whitelist

AceLan Kao
In reply to this post by You-Sheng Yang
Applied on linux-oem (4.15.0-1058.67)

Acked-By: AceLan Kao <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 0/2][SRU][B][OEM-B] dell-laptop: add more DMI whitelist

Po-Hsu Lin (Sam)
In reply to this post by You-Sheng Yang
Clean cherry-pick with positive test result and limited to specific HW.
Acked-by: Po-Hsu Lin <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 1/2][SRU][B][OEM-B] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist

Connor Kuehl
In reply to this post by You-Sheng Yang
On 10/3/19 12:50 AM, You-Sheng Yang wrote:

> From: Alexander Abrosimov <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1846453
>
> SMBIOS 3.0.0 Specification introduced new Chassis Types field values for
> 2-in-1 devices like tablets, convertibles and detachables. Dell's
> Inspiron 2-in-1 and XPS 2-in-1 fall into this category and they have to
> be added to the DMI whitelist, so rfkill and backlight can be controlled
> for them as for other laptops.
>
> Signed-off-by: Alexander Abrosimov <[hidden email]>
> Reviewed-by: Mario Limonciello <[hidden email]>
> Signed-off-by: Darren Hart (VMware) <[hidden email]>
> (cherry picked from commit fe486138788ba435ffa918c8d7aba05a77b6289a)
> Signed-off-by: You-Sheng Yang <[hidden email]>

Acked-by: Connor Kuehl <[hidden email]>

> ---
>   drivers/platform/x86/dell-laptop.c | 36 ++++++++++++++++++++++++++++++
>   1 file changed, 36 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index bb83e2c30601..f484b5a989cd 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -108,6 +108,42 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
>   DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/
>   },
>   },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> + },
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> + },
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> + },
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> + },
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> + },
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> + },
> + },
>   {
>   .ident = "Dell Computer Corporation",
>   .matches = {
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[B]: [PATCH 0/2][SRU][B][OEM-B] dell-laptop: add more DMI whitelist

Kleber Souza
In reply to this post by You-Sheng Yang
On 03.10.19 09:50, You-Sheng Yang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1846453
>
> [Impact]
> Micphone-mute LED indicator on Dell Latitude 3310 keyboard may always
> shown as on or off.
>
> [Fix]
> * fe486138788ba4 [1]: dell-laptop: Add 2-in-1 devices to the DMI whitelist
> * c8ba9db2a790c0 [2]: dell-laptop: Removed duplicates in DMI whitelist
>
> [Test Case]
> Verified on Dell Latitude 3310.
>
> [Regression Risk]
> Low. The two target patch was landed to v4.16 and is already in
> production use for a long time. Besides, this changeset only addes new
> IDs (and remove duplicated ones), so it doesn't affect existing systems
> but fix those affected ones.
>
> Alexander Abrosimov (2):
>   platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
>   platform/x86: dell-laptop: Removed duplicates in DMI whitelist
>
>  drivers/platform/x86/dell-laptop.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>

Applied to bionic/master-next branch.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team