[PATCH 0/3][D/Unstable] Make r8822be usable under kernel lockdown

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/3][D/Unstable] Make r8822be usable under kernel lockdown

Seth Forshee
BugLink: http://bugs.launchpad.net/bugs/1806472

Resending patch from Kai-Heng, plus patches to turn off
CONFIG_RTLWIFI_DEBUG_ST. This option is virtually identical to
CONFIG_RTLWIFI_DEBUG which we have disabled for the non-staging driver,
but for reasons that aren't clear the CONFIG_RTLWIFI_DEBUG_ST option
cannot be disabled. The extra patches make it so that the option can be
turned off and turn it off for our kernels.

Kai-Heng: Since the driver obviously hasn't been getting used with
CONFIG_RTLWIFI_DEBUG_ST=n, can you test with these patches and confirm
that you don't see any issues?

Only sending for disco and unstable. Bionic requires some trivial
backporting, and I will wait for testing before sending patches.

Thanks,
Seth


Kai-Heng Feng (1):
  UBUNTU: SAUCE: Add r8822be to signature inclusion list

Seth Forshee (2):
  UBUNTU: SAUCE: staging: rtlwifi: allow RTLWIFI_DEBUG_ST to be disabled
  UBUNTU: [Config] CONFIG_RTLWIFI_DEBUG_ST=n

 debian.master/config/config.common.ubuntu | 2 +-
 drivers/staging/rtlwifi/Kconfig           | 4 ++--
 drivers/staging/signature-inclusion       | 1 +
 3 files changed, 4 insertions(+), 3 deletions(-)


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/3][D/Unstable] UBUNTU: SAUCE: staging: rtlwifi: allow RTLWIFI_DEBUG_ST to be disabled

Seth Forshee
BugLink: https://bugs.launchpad.net/bugs/1806472

Also default the option to off as with RTLWIFI_DEBUG, which seems
like a more reasonable default.

Signed-off-by: Seth Forshee <[hidden email]>
---
 drivers/staging/rtlwifi/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtlwifi/Kconfig b/drivers/staging/rtlwifi/Kconfig
index 7b4276f5c41f..f8e185dfe2a8 100644
--- a/drivers/staging/rtlwifi/Kconfig
+++ b/drivers/staging/rtlwifi/Kconfig
@@ -7,6 +7,6 @@ config R8822BE
  wireless network adapters.
 
 config RTLWIFI_DEBUG_ST
- bool
+ bool "Debugging output for Realtek RTL8822BE driver"
  depends on R8822BE
- default y
+ default n
--
2.19.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 2/3][D/Unstable] UBUNTU: [Config] CONFIG_RTLWIFI_DEBUG_ST=n

Seth Forshee
In reply to this post by Seth Forshee
BugLink: https://bugs.launchpad.net/bugs/1806472

This is very similar to the CONFIG_RTLWIFI_DEBUG option for the
non-staging driver, and since that is disabled it should also be
disabled in the staging driver, especially now that the staging
driver will be signed.

Signed-off-by: Seth Forshee <[hidden email]>
---
 debian.master/config/config.common.ubuntu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 0e6b45db8e13..fc748686167d 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -7860,7 +7860,7 @@ CONFIG_RTLLIB_CRYPTO_TKIP=m
 CONFIG_RTLLIB_CRYPTO_WEP=m
 CONFIG_RTLWIFI=m
 # CONFIG_RTLWIFI_DEBUG is not set
-CONFIG_RTLWIFI_DEBUG_ST=y
+# CONFIG_RTLWIFI_DEBUG_ST is not set
 CONFIG_RTLWIFI_PCI=m
 CONFIG_RTLWIFI_USB=m
 CONFIG_RTL_CARDS=m
--
2.19.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 3/3][D/Unstable] UBUNTU: SAUCE: Add r8822be to signature inclusion list

Seth Forshee
In reply to this post by Seth Forshee
From: Kai-Heng Feng <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1806472

r8822be is sent and maintained by [hidden email], so it's in a good
shape. Let's add it to signature inclusion list.

Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/staging/signature-inclusion | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/signature-inclusion b/drivers/staging/signature-inclusion
index e9f5bb53c5c7..f7f19616a9fc 100644
--- a/drivers/staging/signature-inclusion
+++ b/drivers/staging/signature-inclusion
@@ -12,6 +12,7 @@ r8188eu.ko
 r8192e_pci.ko
 r8192u_usb.ko
 r8712u.ko
+r8822be.ko
 rtllib_crypt_ccmp.ko
 rtllib_crypt_tkip.ko
 rtllib_crypt_wep.ko
--
2.19.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 0/3][D/Unstable] Make r8822be usable under kernel lockdown

Khaled Elmously
In reply to this post by Seth Forshee
On 2019-01-08 07:46:24 , Seth Forshee wrote:

> BugLink: http://bugs.launchpad.net/bugs/1806472
>
> Resending patch from Kai-Heng, plus patches to turn off
> CONFIG_RTLWIFI_DEBUG_ST. This option is virtually identical to
> CONFIG_RTLWIFI_DEBUG which we have disabled for the non-staging driver,
> but for reasons that aren't clear the CONFIG_RTLWIFI_DEBUG_ST option
> cannot be disabled. The extra patches make it so that the option can be
> turned off and turn it off for our kernels.
>
> Kai-Heng: Since the driver obviously hasn't been getting used with
> CONFIG_RTLWIFI_DEBUG_ST=n, can you test with these patches and confirm
> that you don't see any issues?
>
> Only sending for disco and unstable. Bionic requires some trivial
> backporting, and I will wait for testing before sending patches.
>
> Thanks,
> Seth
>
>
> Kai-Heng Feng (1):
>   UBUNTU: SAUCE: Add r8822be to signature inclusion list
>
> Seth Forshee (2):
>   UBUNTU: SAUCE: staging: rtlwifi: allow RTLWIFI_DEBUG_ST to be disabled
>   UBUNTU: [Config] CONFIG_RTLWIFI_DEBUG_ST=n
>
>  debian.master/config/config.common.ubuntu | 2 +-
>  drivers/staging/rtlwifi/Kconfig           | 4 ++--
>  drivers/staging/signature-inclusion       | 1 +
>  3 files changed, 4 insertions(+), 3 deletions(-)
>
>

Acked-by: Khalid Elmously <[hidden email]>
 

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/3][D/Unstable] Make r8822be usable under kernel lockdown

Kai-Heng Feng
In reply to this post by Seth Forshee


> On Jan 8, 2019, at 21:46, Seth Forshee <[hidden email]> wrote:
>
> BugLink: http://bugs.launchpad.net/bugs/1806472
>
> Resending patch from Kai-Heng, plus patches to turn off
> CONFIG_RTLWIFI_DEBUG_ST. This option is virtually identical to
> CONFIG_RTLWIFI_DEBUG which we have disabled for the non-staging driver,
> but for reasons that aren't clear the CONFIG_RTLWIFI_DEBUG_ST option
> cannot be disabled. The extra patches make it so that the option can be
> turned off and turn it off for our kernels.
>
> Kai-Heng: Since the driver obviously hasn't been getting used with
> CONFIG_RTLWIFI_DEBUG_ST=n, can you test with these patches and confirm
> that you don't see any issues?

The user reports that r8822be works with debugfs disabled.

So I guess it’s good to be included in B/C?

Kai-Heng

>
> Only sending for disco and unstable. Bionic requires some trivial
> backporting, and I will wait for testing before sending patches.
>
> Thanks,
> Seth
>
>
> Kai-Heng Feng (1):
>  UBUNTU: SAUCE: Add r8822be to signature inclusion list
>
> Seth Forshee (2):
>  UBUNTU: SAUCE: staging: rtlwifi: allow RTLWIFI_DEBUG_ST to be disabled
>  UBUNTU: [Config] CONFIG_RTLWIFI_DEBUG_ST=n
>
> debian.master/config/config.common.ubuntu | 2 +-
> drivers/staging/rtlwifi/Kconfig           | 4 ++--
> drivers/staging/signature-inclusion       | 1 +
> 3 files changed, 4 insertions(+), 3 deletions(-)
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [PATCH 0/3][D/Unstable] Make r8822be usable under kernel lockdown

Seth Forshee
In reply to this post by Seth Forshee
On Tue, Jan 08, 2019 at 07:46:24AM -0600, Seth Forshee wrote:

> BugLink: http://bugs.launchpad.net/bugs/1806472
>
> Resending patch from Kai-Heng, plus patches to turn off
> CONFIG_RTLWIFI_DEBUG_ST. This option is virtually identical to
> CONFIG_RTLWIFI_DEBUG which we have disabled for the non-staging driver,
> but for reasons that aren't clear the CONFIG_RTLWIFI_DEBUG_ST option
> cannot be disabled. The extra patches make it so that the option can be
> turned off and turn it off for our kernels.
>
> Kai-Heng: Since the driver obviously hasn't been getting used with
> CONFIG_RTLWIFI_DEBUG_ST=n, can you test with these patches and confirm
> that you don't see any issues?
>
> Only sending for disco and unstable. Bionic requires some trivial
> backporting, and I will wait for testing before sending patches.
>
> Thanks,
> Seth
>
>
> Kai-Heng Feng (1):
>   UBUNTU: SAUCE: Add r8822be to signature inclusion list
>
> Seth Forshee (2):
>   UBUNTU: SAUCE: staging: rtlwifi: allow RTLWIFI_DEBUG_ST to be disabled
>   UBUNTU: [Config] CONFIG_RTLWIFI_DEBUG_ST=n
>
>  debian.master/config/config.common.ubuntu | 2 +-
>  drivers/staging/rtlwifi/Kconfig           | 4 ++--
>  drivers/staging/signature-inclusion       | 1 +
>  3 files changed, 4 insertions(+), 3 deletions(-)
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/3][D/Unstable] Make r8822be usable under kernel lockdown

Seth Forshee
In reply to this post by Kai-Heng Feng
On Tue, Jan 15, 2019 at 02:41:59PM +0800, Kai Heng Feng wrote:

>
>
> > On Jan 8, 2019, at 21:46, Seth Forshee <[hidden email]> wrote:
> >
> > BugLink: http://bugs.launchpad.net/bugs/1806472
> >
> > Resending patch from Kai-Heng, plus patches to turn off
> > CONFIG_RTLWIFI_DEBUG_ST. This option is virtually identical to
> > CONFIG_RTLWIFI_DEBUG which we have disabled for the non-staging driver,
> > but for reasons that aren't clear the CONFIG_RTLWIFI_DEBUG_ST option
> > cannot be disabled. The extra patches make it so that the option can be
> > turned off and turn it off for our kernels.
> >
> > Kai-Heng: Since the driver obviously hasn't been getting used with
> > CONFIG_RTLWIFI_DEBUG_ST=n, can you test with these patches and confirm
> > that you don't see any issues?
>
> The user reports that r8822be works with debugfs disabled.
>
> So I guess it’s good to be included in B/C?

Yes, I'd say you could go ahead and submit these for B/C now.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team