[PATCH 0/3][SRU][F] Add a new hardware ID to intel-hid

[Alex Hung]

BugLink: https://bugs.launchpad.net/bugs/1907160

[Impact]

 intel-hid is not loaded on Intel Tiger Lake and Rocket Lake platforms because the existing
 hardware ids "INT33D5" aren't used in BIOS.

[Fix]

 New ids "INTC1051" and "INTC1054" are to be added to intel-hid kernel driver.

[Test Case]

 This was tested on a Rocket Lake platform and intel-hid was loaded correctly as kernel log below:

 [ 2.938964] input: Intel HID 5 button array as /devices/platform/INT1054:00/input/input11

[Where problems could occur]

 None.

 New IDs were added for new platforms. Previous platforms will not be affected.

 The patches were cherry-picked from upstream


Alex Hung (1):
  platform/x86: intel-hid: add Rocket Lake ACPI device ID

Gayatri Kammela (2):
  platform/x86: intel-hid: Add Tiger Lake ACPI device ID
  platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID

 drivers/platform/x86/intel-hid.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.25.1

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Alex Hung]

From: Gayatri Kammela <[hidden email]>

Tiger Lake has a new unique ACPI device ID for the Intel HID event
filter device that needs to be added to the intel-hid driver to
support it.

BugLink: https://bugs.launchpad.net/bugs/1907160

Acked-by: Andy Shevchenko <[hidden email]>
Signed-off-by: Gayatri Kammela <[hidden email]>
[ rjw: Subject and changelog ]
Signed-off-by: Rafael J. Wysocki <[hidden email]>
(cherry picked from commit bdd11b6540358f25c1eb1e21c1b92bd6276f5e53)
Signed-off-by: Alex Hung <[hidden email]>
---
 drivers/platform/x86/intel-hid.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
index ad1399dcb21f..df1f40c9644c 100644
--- a/drivers/platform/x86/intel-hid.c
+++ b/drivers/platform/x86/intel-hid.c
@@ -19,6 +19,7 @@ MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Alex Hung");

 static const struct acpi_device_id intel_hid_ids[] = {
+ {"INT1051", 0},
  {"INT33D5", 0},
  {"", 0},
 };
--
2.25.1

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Alex Hung]

From: Gayatri Kammela <[hidden email]>

Tiger Lake's new unique ACPI device IDs for intel-hid driver is not
valid because of missing 'C' in the ID. Fix the ID by updating it.

After the update, the new ID should now look like
INT1051 --> INTC1051

BugLink: https://bugs.launchpad.net/bugs/1907160

Fixes: bdd11b654035 ("platform/x86: intel-hid: Add Tiger Lake ACPI device ID")
Suggested-by: Srinivas Pandruvada <[hidden email]>
Signed-off-by: Gayatri Kammela <[hidden email]>
Reviewed-by: Andy Shevchenko <[hidden email]>
Signed-off-by: Rafael J. Wysocki <[hidden email]>
(cherry picked from commit d5764dc597467664a1a70ab66a2314a011aeccd4)
Signed-off-by: Alex Hung <[hidden email]>
---
 drivers/platform/x86/intel-hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
index df1f40c9644c..6fdf064ba67f 100644
--- a/drivers/platform/x86/intel-hid.c
+++ b/drivers/platform/x86/intel-hid.c
@@ -19,8 +19,8 @@ MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Alex Hung");

 static const struct acpi_device_id intel_hid_ids[] = {
- {"INT1051", 0},
  {"INT33D5", 0},
+ {"INTC1051", 0},
  {"", 0},
 };

--
2.25.1

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Alex Hung]

Rocket Lake has a new ACPI ID for Intel HID event filter device.

BugLink: https://bugs.launchpad.net/bugs/1907160

Signed-off-by: Alex Hung <[hidden email]>
Link: https://lore.kernel.org/r/20201208020620.101455-1-alex.hung@...
Signed-off-by: Hans de Goede <[hidden email]>
(cherry picked from commit 7067be7059e8edc186474db9727c519da886a1ce)
Signed-off-by: Alex Hung <[hidden email]>
---
 drivers/platform/x86/intel-hid.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
index 6fdf064ba67f..bc6fd641a7bc 100644
--- a/drivers/platform/x86/intel-hid.c
+++ b/drivers/platform/x86/intel-hid.c
@@ -21,6 +21,7 @@ MODULE_AUTHOR("Alex Hung");
 static const struct acpi_device_id intel_hid_ids[] = {
  {"INT33D5", 0},
  {"INTC1051", 0},
+ {"INTC1054", 0},
  {"", 0},
 };

--
2.25.1

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Marcelo Henrique Cerri]

The changes look good to me, but why not target Groovy too? It seems
that G is missing the third patch.

On Fri, Jan 22, 2021 at 07:14:51PM -0700, Alex Hung wrote:

> BugLink: https://bugs.launchpad.net/bugs/1907160
>
> [Impact]
>
>  intel-hid is not loaded on Intel Tiger Lake and Rocket Lake platforms because the existing
>  hardware ids "INT33D5" aren't used in BIOS.
>
> [Fix]
>
>  New ids "INTC1051" and "INTC1054" are to be added to intel-hid kernel driver.
>
> [Test Case]
>
>  This was tested on a Rocket Lake platform and intel-hid was loaded correctly as kernel log below:
>
>  [ 2.938964] input: Intel HID 5 button array as /devices/platform/INT1054:00/input/input11
>
> [Where problems could occur]
>
>  None.
>
>  New IDs were added for new platforms. Previous platforms will not be affected.
>
>  The patches were cherry-picked from upstream
>
>
> Alex Hung (1):
>   platform/x86: intel-hid: add Rocket Lake ACPI device ID
>
> Gayatri Kammela (2):
>   platform/x86: intel-hid: Add Tiger Lake ACPI device ID
>   platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID
>
>  drivers/platform/x86/intel-hid.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> --
> 2.25.1
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
Regards,
Marcelo


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Alex Hung]

On 2021-01-25 11:46 a.m., Marcelo Henrique Cerri wrote:
> The changes look good to me, but why not target Groovy too? It seems
> that G is missing the third patch.
>

Groovy doesn't have the HID for Rocket Lake (3rd patch), but Rocket Lake
hardware may be officially available around the same time as Hirsute
which can have both HIDs.

Therefore, targeting Groovy is less valuable IMHO.

> On Fri, Jan 22, 2021 at 07:14:51PM -0700, Alex Hung wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1907160
>>
>> [Impact]
>>
>>  intel-hid is not loaded on Intel Tiger Lake and Rocket Lake platforms because the existing
>>  hardware ids "INT33D5" aren't used in BIOS.
>>
>> [Fix]
>>
>>  New ids "INTC1051" and "INTC1054" are to be added to intel-hid kernel driver.
>>
>> [Test Case]
>>
>>  This was tested on a Rocket Lake platform and intel-hid was loaded correctly as kernel log below:
>>
>>  [ 2.938964] input: Intel HID 5 button array as /devices/platform/INT1054:00/input/input11
>>
>> [Where problems could occur]
>>
>>  None.
>>
>>  New IDs were added for new platforms. Previous platforms will not be affected.
>>
>>  The patches were cherry-picked from upstream
>>
>>
>> Alex Hung (1):
>>   platform/x86: intel-hid: add Rocket Lake ACPI device ID
>>
>> Gayatri Kammela (2):
>>   platform/x86: intel-hid: Add Tiger Lake ACPI device ID
>>   platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID
>>
>>  drivers/platform/x86/intel-hid.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> --
>> 2.25.1
>>
>> --
>> kernel-team mailing list
>> [hidden email]
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>

--
Cheers,
Alex Hung

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Stefan Bader-2]

On 26.01.21 07:43, Alex Hung wrote:

> On 2021-01-25 11:46 a.m., Marcelo Henrique Cerri wrote:
>> The changes look good to me, but why not target Groovy too? It seems
>> that G is missing the third patch.
>>
>
> Groovy doesn't have the HID for Rocket Lake (3rd patch), but Rocket Lake
> hardware may be officially available around the same time as Hirsute
> which can have both HIDs.
>
> Therefore, targeting Groovy is less valuable IMHO.

But groovy 5.8 is the current hwe kernel for focal, so leaving it out is
inconsistent.

-Stefan

>
>> On Fri, Jan 22, 2021 at 07:14:51PM -0700, Alex Hung wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1907160
>>>
>>> [Impact]
>>>
>>>  intel-hid is not loaded on Intel Tiger Lake and Rocket Lake platforms because the existing
>>>  hardware ids "INT33D5" aren't used in BIOS.
>>>
>>> [Fix]
>>>
>>>  New ids "INTC1051" and "INTC1054" are to be added to intel-hid kernel driver.
>>>
>>> [Test Case]
>>>
>>>  This was tested on a Rocket Lake platform and intel-hid was loaded correctly as kernel log below:
>>>
>>>  [ 2.938964] input: Intel HID 5 button array as /devices/platform/INT1054:00/input/input11
>>>
>>> [Where problems could occur]
>>>
>>>  None.
>>>
>>>  New IDs were added for new platforms. Previous platforms will not be affected.
>>>
>>>  The patches were cherry-picked from upstream
>>>
>>>
>>> Alex Hung (1):
>>>   platform/x86: intel-hid: add Rocket Lake ACPI device ID
>>>
>>> Gayatri Kammela (2):
>>>   platform/x86: intel-hid: Add Tiger Lake ACPI device ID
>>>   platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID
>>>
>>>  drivers/platform/x86/intel-hid.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> --
>>> 2.25.1
>>>
>>> --
>>> kernel-team mailing list
>>> [hidden email]
>>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>>
>
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Alex Hung]

On Tue, Jan 26, 2021 at 1:40 AM Stefan Bader <[hidden email]> wrote:

On 26.01.21 07:43, Alex Hung wrote:
> On 2021-01-25 11:46 a.m., Marcelo Henrique Cerri wrote:
>> The changes look good to me, but why not target Groovy too? It seems
>> that G is missing the third patch.
>>
>
> Groovy doesn't have the HID for Rocket Lake (3rd patch), but Rocket Lake
> hardware may be officially available around the same time as Hirsute
> which can have both HIDs.
>
> Therefore, targeting Groovy is less valuable IMHO.

But groovy 5.8 is the current hwe kernel for focal, so leaving it out is
inconsistent.

Is it preferred to send another SRU for G or fix and resend this SRU?

 

-Stefan

>
>> On Fri, Jan 22, 2021 at 07:14:51PM -0700, Alex Hung wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1907160
>>>
>>> [Impact]
>>>
>>>  intel-hid is not loaded on Intel Tiger Lake and Rocket Lake platforms because the existing
>>>  hardware ids "INT33D5" aren't used in BIOS.
>>>
>>> [Fix]
>>>
>>>  New ids "INTC1051" and "INTC1054" are to be added to intel-hid kernel driver.
>>>
>>> [Test Case]
>>>
>>>  This was tested on a Rocket Lake platform and intel-hid was loaded correctly as kernel log below:
>>>
>>>  [ 2.938964] input: Intel HID 5 button array as /devices/platform/INT1054:00/input/input11
>>>
>>> [Where problems could occur]
>>>
>>>  None.
>>>
>>>  New IDs were added for new platforms. Previous platforms will not be affected.
>>>
>>>  The patches were cherry-picked from upstream
>>>
>>>
>>> Alex Hung (1):
>>>   platform/x86: intel-hid: add Rocket Lake ACPI device ID
>>>
>>> Gayatri Kammela (2):
>>>   platform/x86: intel-hid: Add Tiger Lake ACPI device ID
>>>   platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID
>>>
>>>  drivers/platform/x86/intel-hid.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> --
>>> 2.25.1
>>>
>>> --
>>> kernel-team mailing list
>>> [hidden email]
>>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>>
>
>

--

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Stefan Bader-2]

On 26.01.21 21:20, Alex Hung wrote:

>
>
> On Tue, Jan 26, 2021 at 1:40 AM Stefan Bader <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     On 26.01.21 07:43, Alex Hung wrote:
>     > On 2021-01-25 11:46 a.m., Marcelo Henrique Cerri wrote:
>     >> The changes look good to me, but why not target Groovy too? It seems
>     >> that G is missing the third patch.
>     >>
>     >
>     > Groovy doesn't have the HID for Rocket Lake (3rd patch), but Rocket Lake
>     > hardware may be officially available around the same time as Hirsute
>     > which can have both HIDs.
>     >
>     > Therefore, targeting Groovy is less valuable IMHO.
>
>     But groovy 5.8 is the current hwe kernel for focal, so leaving it out is
>     inconsistent.
>
> Is it preferred to send another SRU for G or fix and resend this SRU?

I think it is better to re-send for both series. That keeps things together and
more obvious (if the same patch applies to both it only needs to be there once).
Also a single thread per SRU is easier to follow.

-Stefan

>
>  
>
>
>     -Stefan
>
>     >
>     >> On Fri, Jan 22, 2021 at 07:14:51PM -0700, Alex Hung wrote:
>     >>> BugLink: https://bugs.launchpad.net/bugs/1907160
>     >>>
>     >>> [Impact]
>     >>>
>     >>>  intel-hid is not loaded on Intel Tiger Lake and Rocket Lake platforms
>     because the existing
>     >>>  hardware ids "INT33D5" aren't used in BIOS.
>     >>>
>     >>> [Fix]
>     >>>
>     >>>  New ids "INTC1051" and "INTC1054" are to be added to intel-hid kernel
>     driver.
>     >>>
>     >>> [Test Case]
>     >>>
>     >>>  This was tested on a Rocket Lake platform and intel-hid was loaded
>     correctly as kernel log below:
>     >>>
>     >>>  [ 2.938964] input: Intel HID 5 button array as
>     /devices/platform/INT1054:00/input/input11
>     >>>
>     >>> [Where problems could occur]
>     >>>
>     >>>  None.
>     >>>
>     >>>  New IDs were added for new platforms. Previous platforms will not be
>     affected.
>     >>>
>     >>>  The patches were cherry-picked from upstream
>     >>>
>     >>>
>     >>> Alex Hung (1):
>     >>>   platform/x86: intel-hid: add Rocket Lake ACPI device ID
>     >>>
>     >>> Gayatri Kammela (2):
>     >>>   platform/x86: intel-hid: Add Tiger Lake ACPI device ID
>     >>>   platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID
>     >>>
>     >>>  drivers/platform/x86/intel-hid.c | 2 ++
>     >>>  1 file changed, 2 insertions(+)
>     >>>
>     >>> --
>     >>> 2.25.1
>     >>>
>     >>> --
>     >>> kernel-team mailing list
>     >>> [hidden email] <mailto:[hidden email]>
>     >>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>     >>
>     >
>     >
>
>
>
>
> --
> Cheers,
> Alex Hung

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team