[PATCH 0/4] [Intrepid LBM, Jaunty LBM] LP#351586:Add driver for Lenovo SL Thinkpads

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/4] [Intrepid LBM, Jaunty LBM] LP#351586:Add driver for Lenovo SL Thinkpads

Ike Panhc
Add driver for Lenovo SL Series laptops.

Since Jaunty and Intrepid kernel is already feature freeze,
I add the driver to LBM of Jaunty and Intrepid.

I will send patches for Karmic later.

Ike Panhc (4):
  UBUNTU: [PATCH] Add driver for Lenovo SL Thinkpads
  UBUNTU: [PATCH] Add BOM file of lenovo-sl-laptop
  UBUNTU: [PATCH] Add lenovo-sl-laptop in backport package
  UBUNTU: [PATCH] Add dmi pattern for Lenovo SL laptop

 debian/rules.d/2-binary-arch.mk             |    1 +
 updates/lenovo-sl-laptop/BOM                |    3 +
 updates/lenovo-sl-laptop/Makefile           |   11 +
 updates/lenovo-sl-laptop/README             |   44 +
 updates/lenovo-sl-laptop/lenovo-sl-laptop.c | 1313 +++++++++++++++++++++++++++
 5 files changed, 1372 insertions(+), 0 deletions(-)
 create mode 100644 updates/lenovo-sl-laptop/BOM
 create mode 100644 updates/lenovo-sl-laptop/Makefile
 create mode 100644 updates/lenovo-sl-laptop/README
 create mode 100644 updates/lenovo-sl-laptop/lenovo-sl-laptop.c


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/4] [Intrepid LBM, Jaunty LBM] LP#351586:Add driver for Lenovo SL Thinkpads

Tim Gardner-2
Ike Panhc wrote:

> Add driver for Lenovo SL Series laptops.
>
> Since Jaunty and Intrepid kernel is already feature freeze,
> I add the driver to LBM of Jaunty and Intrepid.
>
> I will send patches for Karmic later.
>
> Ike Panhc (4):
>   UBUNTU: [PATCH] Add driver for Lenovo SL Thinkpads
>   UBUNTU: [PATCH] Add BOM file of lenovo-sl-laptop
>   UBUNTU: [PATCH] Add lenovo-sl-laptop in backport package
>   UBUNTU: [PATCH] Add dmi pattern for Lenovo SL laptop
>
>  debian/rules.d/2-binary-arch.mk             |    1 +
>  updates/lenovo-sl-laptop/BOM                |    3 +
>  updates/lenovo-sl-laptop/Makefile           |   11 +
>  updates/lenovo-sl-laptop/README             |   44 +
>  updates/lenovo-sl-laptop/lenovo-sl-laptop.c | 1313 +++++++++++++++++++++++++++
>  5 files changed, 1372 insertions(+), 0 deletions(-)
>  create mode 100644 updates/lenovo-sl-laptop/BOM
>  create mode 100644 updates/lenovo-sl-laptop/Makefile
>  create mode 100644 updates/lenovo-sl-laptop/README
>  create mode 100644 updates/lenovo-sl-laptop/lenovo-sl-laptop.c
>
>

Stefan - Please put this one on your radar as a possible Jaunty SRU
candidate. Its not going to make the initial release.
--
Tim Gardner [hidden email]

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/4] [Intrepid LBM, Jaunty LBM] LP#351586:Add driver for Lenovo SL Thinkpads

Stefan Bader-2
Tim Gardner wrote:

> Ike Panhc wrote:
>> Add driver for Lenovo SL Series laptops.
>>
>> Since Jaunty and Intrepid kernel is already feature freeze,
>> I add the driver to LBM of Jaunty and Intrepid.
>>
>> I will send patches for Karmic later.
>>
>> Ike Panhc (4):
>>   UBUNTU: [PATCH] Add driver for Lenovo SL Thinkpads
>>   UBUNTU: [PATCH] Add BOM file of lenovo-sl-laptop
>>   UBUNTU: [PATCH] Add lenovo-sl-laptop in backport package
>>   UBUNTU: [PATCH] Add dmi pattern for Lenovo SL laptop
>>
>>  debian/rules.d/2-binary-arch.mk             |    1 +
>>  updates/lenovo-sl-laptop/BOM                |    3 +
>>  updates/lenovo-sl-laptop/Makefile           |   11 +
>>  updates/lenovo-sl-laptop/README             |   44 +
>>  updates/lenovo-sl-laptop/lenovo-sl-laptop.c | 1313 +++++++++++++++++++++++++++
>>  5 files changed, 1372 insertions(+), 0 deletions(-)
>>  create mode 100644 updates/lenovo-sl-laptop/BOM
>>  create mode 100644 updates/lenovo-sl-laptop/Makefile
>>  create mode 100644 updates/lenovo-sl-laptop/README
>>  create mode 100644 updates/lenovo-sl-laptop/lenovo-sl-laptop.c
>>
>>
>
> Stefan - Please put this one on your radar as a possible Jaunty SRU
> candidate. Its not going to make the initial release.

Will do so. Still have to take a better review on that, but it won't happen today.


--

When all other means of communication fail, try words!



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/4] [Intrepid LBM, Jaunty LBM] LP#351586:Add driver for Lenovo SL Thinkpads

Stefan Bader-2
In reply to this post by Ike Panhc
Ike Panhc wrote:

> Add driver for Lenovo SL Series laptops.
>
> Since Jaunty and Intrepid kernel is already feature freeze,
> I add the driver to LBM of Jaunty and Intrepid.
>
> I will send patches for Karmic later.
>
> Ike Panhc (4):
>   UBUNTU: [PATCH] Add driver for Lenovo SL Thinkpads
>   UBUNTU: [PATCH] Add BOM file of lenovo-sl-laptop
>   UBUNTU: [PATCH] Add lenovo-sl-laptop in backport package
>   UBUNTU: [PATCH] Add dmi pattern for Lenovo SL laptop
>
>  debian/rules.d/2-binary-arch.mk             |    1 +
>  updates/lenovo-sl-laptop/BOM                |    3 +
>  updates/lenovo-sl-laptop/Makefile           |   11 +
>  updates/lenovo-sl-laptop/README             |   44 +
>  updates/lenovo-sl-laptop/lenovo-sl-laptop.c | 1313 +++++++++++++++++++++++++++
>  5 files changed, 1372 insertions(+), 0 deletions(-)
>  create mode 100644 updates/lenovo-sl-laptop/BOM
>  create mode 100644 updates/lenovo-sl-laptop/Makefile
>  create mode 100644 updates/lenovo-sl-laptop/README
>  create mode 100644 updates/lenovo-sl-laptop/lenovo-sl-laptop.c
>
>
ACK with comments:
1) The last patch (dmi pattern) definitely should go back upstream.
    Lenovo seems to have had some creativity in adding/removing random
    letter. Could you get into touch with the maintiner? For the time
    being, this patch should be tagged with SAUCE.
2) Do you/could you provide this series on a private tree on zinc? That
    way I could pull it, given we get another ACK from someone.
    /me waves at the group

--

When all other means of communication fail, try words!



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/4] [Intrepid LBM, Jaunty LBM] LP#351586:Add driver for Lenovo SL Thinkpads

Ike Panhc
Stefan Bader wrote:
> ACK with comments:
> 1) The last patch (dmi pattern) definitely should go back upstream.
>    Lenovo seems to have had some creativity in adding/removing random
>    letter. Could you get into touch with the maintiner? For the time
>    being, this patch should be tagged with SAUCE.

Will get in touch with maintainer.

> 2) Do you/could you provide this series on a private tree on zinc? That
>    way I could pull it, given we get another ACK from someone.
>    /me waves at the group
>

=== request-pull summary for intrepid-lbm

The following changes since commit 01313fb93a9e35162abb0d449634ee73e0b82e07:
  Stefan Bader (1):
        UBUNTU: Start new release

are available in the git repository at:

  git://zinc.ubuntu.com/ikepanhc/ike-intrepid-lbm.git lp#351586

Ike Panhc (4):
      UBUNTU: Add driver for Lenovo SL Thinkpads
      UBUNTU: Add BOM file of lenovo-sl-laptop
      UBUNTU: Add lenovo-sl-laptop in backport package
      UBUNTU: Add dmi pattern for Lenovo SL laptop

 debian/rules.d/2-binary-arch.mk             |    1 +
 updates/lenovo-sl-laptop/BOM                |    3 +
 updates/lenovo-sl-laptop/Makefile           |   11 +
 updates/lenovo-sl-laptop/README             |   44 +
 updates/lenovo-sl-laptop/lenovo-sl-laptop.c | 1313 +++++++++++++++++++++++++++
 5 files changed, 1372 insertions(+), 0 deletions(-)
 create mode 100644 updates/lenovo-sl-laptop/BOM
 create mode 100644 updates/lenovo-sl-laptop/Makefile
 create mode 100644 updates/lenovo-sl-laptop/README
 create mode 100644 updates/lenovo-sl-laptop/lenovo-sl-laptop.c


=== request-pull summary for jaunty-lbm

The following changes since commit 52191535c4c318a90529666740a25eb13739ce57:
  Tim Gardner (1):
        UBUNTU: Ubuntu-2.6.28-11.12

are available in the git repository at:

  git://zinc.ubuntu.com/ikepanhc/ike-jaunty-lbm.git lp#351586

Ike Panhc (4):
      UBUNTU: Add driver for Lenovo SL Thinkpads
      UBUNTU: Add BOM file of lenovo-sl-laptop
      UBUNTU: Add lenovo-sl-laptop in backport package
      UBUNTU: Add dmi pattern for Lenovo SL laptop

 debian/rules.d/2-binary-arch.mk             |    1 +
 updates/lenovo-sl-laptop/BOM                |    3 +
 updates/lenovo-sl-laptop/Makefile           |   11 +
 updates/lenovo-sl-laptop/README             |   44 +
 updates/lenovo-sl-laptop/lenovo-sl-laptop.c | 1313 +++++++++++++++++++++++++++
 5 files changed, 1372 insertions(+), 0 deletions(-)
 create mode 100644 updates/lenovo-sl-laptop/BOM
 create mode 100644 updates/lenovo-sl-laptop/Makefile
 create mode 100644 updates/lenovo-sl-laptop/README
 create mode 100644 updates/lenovo-sl-laptop/lenovo-sl-laptop.c

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/4] [Intrepid LBM, Jaunty LBM] LP#351586:Add driver for Lenovo SL Thinkpads

Ike Panhc
In reply to this post by Stefan Bader-2
Stefan Bader wrote:

> Ike Panhc wrote:
>> Add driver for Lenovo SL Series laptops.
>>
>> Since Jaunty and Intrepid kernel is already feature freeze,
>> I add the driver to LBM of Jaunty and Intrepid.
>>
>> I will send patches for Karmic later.
>>
>> Ike Panhc (4):
>>   UBUNTU: [PATCH] Add driver for Lenovo SL Thinkpads
>>   UBUNTU: [PATCH] Add BOM file of lenovo-sl-laptop
>>   UBUNTU: [PATCH] Add lenovo-sl-laptop in backport package
>>   UBUNTU: [PATCH] Add dmi pattern for Lenovo SL laptop
>>
>>  debian/rules.d/2-binary-arch.mk             |    1 +
>>  updates/lenovo-sl-laptop/BOM                |    3 +
>>  updates/lenovo-sl-laptop/Makefile           |   11 +
>>  updates/lenovo-sl-laptop/README             |   44 +
>>  updates/lenovo-sl-laptop/lenovo-sl-laptop.c | 1313
>> +++++++++++++++++++++++++++
>>  5 files changed, 1372 insertions(+), 0 deletions(-)
>>  create mode 100644 updates/lenovo-sl-laptop/BOM
>>  create mode 100644 updates/lenovo-sl-laptop/Makefile
>>  create mode 100644 updates/lenovo-sl-laptop/README
>>  create mode 100644 updates/lenovo-sl-laptop/lenovo-sl-laptop.c
>>
>>
> ACK with comments:
> 1) The last patch (dmi pattern) definitely should go back upstream.
>    Lenovo seems to have had some creativity in adding/removing random
>    letter. Could you get into touch with the maintiner? For the time
>    being, this patch should be tagged with SAUCE.
> 2) Do you/could you provide this series on a private tree on zinc? That
>    way I could pull it, given we get another ACK from someone.
>    /me waves at the group
>

Is there anyone think of ACK with LBM module?

If no, I will drop this patch and end this bugs with Fix commited to Karmic.

Thanks.

-- Ike

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/4] [Intrepid LBM, Jaunty LBM] LP#351586:Add driver for Lenovo SL Thinkpads

Amit Kucheria-6
In reply to this post by Ike Panhc
On Fri, Apr 10, 2009 at 08:46:29PM +0800, Ike Panhc wrote:

> Add driver for Lenovo SL Series laptops.
>
> Since Jaunty and Intrepid kernel is already feature freeze,
> I add the driver to LBM of Jaunty and Intrepid.
>
> I will send patches for Karmic later.
>
> Ike Panhc (4):
>   UBUNTU: [PATCH] Add driver for Lenovo SL Thinkpads
>   UBUNTU: [PATCH] Add BOM file of lenovo-sl-laptop
>   UBUNTU: [PATCH] Add lenovo-sl-laptop in backport package
>   UBUNTU: [PATCH] Add dmi pattern for Lenovo SL laptop
>
>  debian/rules.d/2-binary-arch.mk             |    1 +
>  updates/lenovo-sl-laptop/BOM                |    3 +
>  updates/lenovo-sl-laptop/Makefile           |   11 +
>  updates/lenovo-sl-laptop/README             |   44 +
>  updates/lenovo-sl-laptop/lenovo-sl-laptop.c | 1313 +++++++++++++++++++++++++++
>  5 files changed, 1372 insertions(+), 0 deletions(-)
>  create mode 100644 updates/lenovo-sl-laptop/BOM
>  create mode 100644 updates/lenovo-sl-laptop/Makefile
>  create mode 100644 updates/lenovo-sl-laptop/README
>  create mode 100644 updates/lenovo-sl-laptop/lenovo-sl-laptop.c

ACK.

In the future, when sending a set of patches, could you use in-reply-to option of git send-email. This way 1/n, 2/n, 3/n are in the same thread as 0/n.

For Karmic, perhaps it will be better to ask the upstream maintainer to submit it to staging.

Regards,
Amit

--
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || [hidden email]
----------------------------------------------------------------------

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/4] [Intrepid LBM, Jaunty LBM] LP#351586:Add driver for Lenovo SL Thinkpads

Stefan Bader-2
In reply to this post by Ike Panhc
Patchset committed to Intrepid and Jaunty LBM packages.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team