Quantcast

[PATCH 1/2] verify tracking bug really exists

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH 1/2] verify tracking bug really exists

Thadeu Lima de Souza Cascardo-3
---
 maintscripts/verify-release-ready | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
index f9ad400..a99b7b3 100755
--- a/maintscripts/verify-release-ready
+++ b/maintscripts/verify-release-ready
@@ -266,7 +266,9 @@ class VerifyReleaseReady():
 
         # Verify the bugs in the changelog are public, targeted against linux and the
         # proper series, and marked Fix Committed.
-        s.verify_changelog_bugs()
+        tracker = s.verify_changelog_bugs()
+
+        s.verify_tracker_bug(tracker)
 
         s.verify_content()
 
@@ -348,6 +350,8 @@ class VerifyReleaseReady():
         changelog_series = changelog[1]['series']
         changelog_source_package = changelog[1]['package']
 
+        tracker = None
+
         for bug in changelog_bugs:
             # Error on private or invalid bugs
             try:
@@ -358,6 +362,7 @@ class VerifyReleaseReady():
 
             # Ignore kernel-release-tracking-bug's
             if 'kernel-release-tracking-bug' in lp_bug.tags:
+                tracker = lp_bug
                 continue
 
             # check bug tasks, is series/package/status correct?
@@ -385,6 +390,14 @@ class VerifyReleaseReady():
             if not is_fix_committed:
                 s.status('LP: #%s is not fix committed' % bug, 'warning')
 
+        return tracker
+
+    def verify_tracker_bug(s, bug):
+        if bug == None:
+            s.status('No tracker bug found', 'warning')
+            return
+ s.status('Tracker bug found', bug.id)
+
     def verify_content(s):
         changelog = Debian.changelog()
         content = changelog[1]['content']
--
2.9.3


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH 2/2] start-sru-cycle: convert bug IDs to strings before appending

Thadeu Lima de Souza Cascardo-3
Otherwise, the script will just fail when creating backports and
derivatives tracking bugs.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 stable/start-sru-cycle | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/stable/start-sru-cycle b/stable/start-sru-cycle
index cfac5bc..2459785 100755
--- a/stable/start-sru-cycle
+++ b/stable/start-sru-cycle
@@ -104,7 +104,7 @@ class Crankers():
                         print('        %s:%s' % (backport_series, backport_project))
                         bug = tb.open(backport_project, '<version to be filled>', True, master_bug.id, backport_series)
                         bug.tags.append(cycle_tag)
-                        backports.append(bug.id)
+                        backports.append(str(bug.id))
                         bug.tags.append('kernel-sru-backport-of-%s' % master_bug.id)
 
                     derivatives = []
@@ -112,7 +112,7 @@ class Crankers():
                         print('        ' + derivative_project)
                         bug = tb.open(derivative_project, '<version to be filled>', True, master_bug.id, series)
                         bug.tags.append(cycle_tag)
-                        derivatives.append(bug.id)
+                        derivatives.append(str(bug.id))
                         bug.tags.append('kernel-sru-derivative-of-%s' % master_bug.id)
 
                     description = master_bug.description
--
2.9.3


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH 1/2] verify tracking bug really exists

Thadeu Lima de Souza Cascardo-3
In reply to this post by Thadeu Lima de Souza Cascardo-3
On Wed, Apr 05, 2017 at 03:08:30PM +0100, Thadeu Lima de Souza Cascardo wrote:
> ---
>  maintscripts/verify-release-ready | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
>

Please, ignore this patch, still working on it.

Cascardo.

> diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
> index f9ad400..a99b7b3 100755
> --- a/maintscripts/verify-release-ready
> +++ b/maintscripts/verify-release-ready
> @@ -266,7 +266,9 @@ class VerifyReleaseReady():
>  
>          # Verify the bugs in the changelog are public, targeted against linux and the
>          # proper series, and marked Fix Committed.
> -        s.verify_changelog_bugs()
> +        tracker = s.verify_changelog_bugs()
> +
> +        s.verify_tracker_bug(tracker)
>  
>          s.verify_content()
>  
> @@ -348,6 +350,8 @@ class VerifyReleaseReady():
>          changelog_series = changelog[1]['series']
>          changelog_source_package = changelog[1]['package']
>  
> +        tracker = None
> +
>          for bug in changelog_bugs:
>              # Error on private or invalid bugs
>              try:
> @@ -358,6 +362,7 @@ class VerifyReleaseReady():
>  
>              # Ignore kernel-release-tracking-bug's
>              if 'kernel-release-tracking-bug' in lp_bug.tags:
> +                tracker = lp_bug
>                  continue
>  
>              # check bug tasks, is series/package/status correct?
> @@ -385,6 +390,14 @@ class VerifyReleaseReady():
>              if not is_fix_committed:
>                  s.status('LP: #%s is not fix committed' % bug, 'warning')
>  
> +        return tracker
> +
> +    def verify_tracker_bug(s, bug):
> +        if bug == None:
> +            s.status('No tracker bug found', 'warning')
> +            return
> + s.status('Tracker bug found', bug.id)
> +
>      def verify_content(s):
>          changelog = Debian.changelog()
>          content = changelog[1]['content']
> --
> 2.9.3
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

ACK: [PATCH 2/2] start-sru-cycle: convert bug IDs to strings before appending

Stefan Bader-2
In reply to this post by Thadeu Lima de Souza Cascardo-3



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Applied: [PATCH 1/2] verify tracking bug really exists

brad.figg
In reply to this post by Thadeu Lima de Souza Cascardo-3
Loading...