[PATCH][AB] fix do_libc_dev_package breakage

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH][AB] fix do_libc_dev_package breakage

Kamal Mostafa-2
Our do_libc_dev_package vars feature was broken by debhelper deprecating
dh_clean in favor of dh_prep.

To support custom kernels derived from {Artful, Bionic}, only try to
dh_prep linux-libc-dev if do_libc_dev_package=true.

This results in no changes to the master kernels, just allows derivs to
override standard behaviors.

 -Kamal

---

Kamal Mostafa (1):
  UBUNTU: [debian] prep linux-libc-dev only if do_libc_dev_package=true

 debian/rules.d/2-binary-arch.mk | 2 ++
 1 file changed, 2 insertions(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

UBUNTU: [debian] prep linux-libc-dev only if do_libc_dev_package=true

Kamal Mostafa-2
Required for do_libc_dev_package=false to not break the build.

Ignore: yes

Signed-off-by: Kamal Mostafa <[hidden email]>
---
 debian/rules.d/2-binary-arch.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
index b0829c2..2944126 100644
--- a/debian/rules.d/2-binary-arch.mk
+++ b/debian/rules.d/2-binary-arch.mk
@@ -415,7 +415,9 @@ install-arch-headers:
  @echo Debug: $@
  dh_testdir
  dh_testroot
+ifeq ($(do_libc_dev_package),true)
  dh_prep -plinux-libc-dev
+endif
 
  rm -rf $(headers_tmp)
  install -d $(headers_tmp) $(headers_dir)/usr/include/
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/APPLIED[B]: [PATCH][AB] fix do_libc_dev_package breakage

Seth Forshee
In reply to this post by Kamal Mostafa-2
On Wed, Dec 13, 2017 at 11:44:24AM -0800, Kamal Mostafa wrote:
> Our do_libc_dev_package vars feature was broken by debhelper deprecating
> dh_clean in favor of dh_prep.
>
> To support custom kernels derived from {Artful, Bionic}, only try to
> dh_prep linux-libc-dev if do_libc_dev_package=true.
>
> This results in no changes to the master kernels, just allows derivs to
> override standard behaviors.

Acked-by: Seth Forshee <[hidden email]>

Applied to bionic/master-next and unstable/master. Thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH][AB] fix do_libc_dev_package breakage

Stefan Bader-2
In reply to this post by Kamal Mostafa-2
On 13.12.2017 20:44, Kamal Mostafa wrote:

> Our do_libc_dev_package vars feature was broken by debhelper deprecating
> dh_clean in favor of dh_prep.
>
> To support custom kernels derived from {Artful, Bionic}, only try to
> dh_prep linux-libc-dev if do_libc_dev_package=true.
>
> This results in no changes to the master kernels, just allows derivs to
> override standard behaviors.
>
>  -Kamal
>
> ---
>
> Kamal Mostafa (1):
>   UBUNTU: [debian] prep linux-libc-dev only if do_libc_dev_package=true
>
>  debian/rules.d/2-binary-arch.mk | 2 ++
>  1 file changed, 2 insertions(+)
>
Acked-by: Stefan Bader <[hidden email]>



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[A]: [PATCH][AB] fix do_libc_dev_package breakage

Stefan Bader-2
In reply to this post by Kamal Mostafa-2
On 13.12.2017 20:44, Kamal Mostafa wrote:

> Our do_libc_dev_package vars feature was broken by debhelper deprecating
> dh_clean in favor of dh_prep.
>
> To support custom kernels derived from {Artful, Bionic}, only try to
> dh_prep linux-libc-dev if do_libc_dev_package=true.
>
> This results in no changes to the master kernels, just allows derivs to
> override standard behaviors.
>
>  -Kamal
>
> ---
>
> Kamal Mostafa (1):
>   UBUNTU: [debian] prep linux-libc-dev only if do_libc_dev_package=true
>
>  debian/rules.d/2-binary-arch.mk | 2 ++
>  1 file changed, 2 insertions(+)
>
Applied to artful/master-next-backlog


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment