[PATCH][BIONIC][SRU] UBUNTU: SAUCE: (noup) Update zfs to 0.7.5-1ubuntu16.4

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH][BIONIC][SRU] UBUNTU: SAUCE: (noup) Update zfs to 0.7.5-1ubuntu16.4

Colin Ian King-2
From: Colin Ian King <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1769937

Sync with zfsutils-linux 0.7.5-1ubuntu16.4 to pick up fixes for
LP#1769937.

Upstream ZFS fix 4ceb8dd6fdfd ("Fix 'zpool create -t <tempname>'")
fixes error message and error exit when using the -t option
when creating a pool.

Signed-off-by: Colin Ian King <[hidden email]>
---
 zfs/META                   |  2 +-
 zfs/module/zfs/zfs_ioctl.c | 10 ++++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/zfs/META b/zfs/META
index a906a795c..9864f8f64 100644
--- a/zfs/META
+++ b/zfs/META
@@ -2,7 +2,7 @@ Meta:         1
 Name:         zfs
 Branch:       1.0
 Version:      0.7.5
-Release:      1ubuntu16.3
+Release:      1ubuntu16.4
 Release-Tags: relext
 License:      CDDL
 Author:       OpenZFS on Linux
diff --git a/zfs/module/zfs/zfs_ioctl.c b/zfs/module/zfs/zfs_ioctl.c
index f41e1b9bd..c6d180cda 100644
--- a/zfs/module/zfs/zfs_ioctl.c
+++ b/zfs/module/zfs/zfs_ioctl.c
@@ -1474,6 +1474,7 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
  nvlist_t *config, *props = NULL;
  nvlist_t *rootprops = NULL;
  nvlist_t *zplprops = NULL;
+ char *spa_name = zc->zc_name;
 
  if ((error = get_nvlist(zc->zc_nvlist_conf, zc->zc_nvlist_conf_size,
     zc->zc_iflags, &config)))
@@ -1489,6 +1490,7 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
  if (props) {
  nvlist_t *nvl = NULL;
  uint64_t version = SPA_VERSION;
+ char *tname;
 
  (void) nvlist_lookup_uint64(props,
     zpool_prop_to_name(ZPOOL_PROP_VERSION), &version);
@@ -1511,6 +1513,10 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
     zplprops, NULL);
  if (error != 0)
  goto pool_props_bad;
+
+ if (nvlist_lookup_string(props,
+    zpool_prop_to_name(ZPOOL_PROP_TNAME), &tname) == 0)
+ spa_name = tname;
  }
 
  error = spa_create(zc->zc_name, config, props, zplprops);
@@ -1518,9 +1524,9 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
  /*
  * Set the remaining root properties
  */
- if (!error && (error = zfs_set_prop_nvlist(zc->zc_name,
+ if (!error && (error = zfs_set_prop_nvlist(spa_name,
     ZPROP_SRC_LOCAL, rootprops, NULL)) != 0)
- (void) spa_destroy(zc->zc_name);
+ (void) spa_destroy(spa_name);
 
 pool_props_bad:
  nvlist_free(rootprops);
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH][BIONIC][SRU] UBUNTU: SAUCE: (noup) Update zfs to 0.7.5-1ubuntu16.4

Stefan Bader-2
On 12.09.2018 19:04, Colin King wrote:

> From: Colin Ian King <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1769937
>
> Sync with zfsutils-linux 0.7.5-1ubuntu16.4 to pick up fixes for
> LP#1769937.
>
> Upstream ZFS fix 4ceb8dd6fdfd ("Fix 'zpool create -t <tempname>'")
> fixes error message and error exit when using the -t option
> when creating a pool.
>
> Signed-off-by: Colin Ian King <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---
>  zfs/META                   |  2 +-
>  zfs/module/zfs/zfs_ioctl.c | 10 ++++++++--
>  2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/zfs/META b/zfs/META
> index a906a795c..9864f8f64 100644
> --- a/zfs/META
> +++ b/zfs/META
> @@ -2,7 +2,7 @@ Meta:         1
>  Name:         zfs
>  Branch:       1.0
>  Version:      0.7.5
> -Release:      1ubuntu16.3
> +Release:      1ubuntu16.4
>  Release-Tags: relext
>  License:      CDDL
>  Author:       OpenZFS on Linux
> diff --git a/zfs/module/zfs/zfs_ioctl.c b/zfs/module/zfs/zfs_ioctl.c
> index f41e1b9bd..c6d180cda 100644
> --- a/zfs/module/zfs/zfs_ioctl.c
> +++ b/zfs/module/zfs/zfs_ioctl.c
> @@ -1474,6 +1474,7 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
>   nvlist_t *config, *props = NULL;
>   nvlist_t *rootprops = NULL;
>   nvlist_t *zplprops = NULL;
> + char *spa_name = zc->zc_name;
>  
>   if ((error = get_nvlist(zc->zc_nvlist_conf, zc->zc_nvlist_conf_size,
>      zc->zc_iflags, &config)))
> @@ -1489,6 +1490,7 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
>   if (props) {
>   nvlist_t *nvl = NULL;
>   uint64_t version = SPA_VERSION;
> + char *tname;
>  
>   (void) nvlist_lookup_uint64(props,
>      zpool_prop_to_name(ZPOOL_PROP_VERSION), &version);
> @@ -1511,6 +1513,10 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
>      zplprops, NULL);
>   if (error != 0)
>   goto pool_props_bad;
> +
> + if (nvlist_lookup_string(props,
> +    zpool_prop_to_name(ZPOOL_PROP_TNAME), &tname) == 0)
> + spa_name = tname;
>   }
>  
>   error = spa_create(zc->zc_name, config, props, zplprops);
> @@ -1518,9 +1524,9 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
>   /*
>   * Set the remaining root properties
>   */
> - if (!error && (error = zfs_set_prop_nvlist(zc->zc_name,
> + if (!error && (error = zfs_set_prop_nvlist(spa_name,
>      ZPROP_SRC_LOCAL, rootprops, NULL)) != 0)
> - (void) spa_destroy(zc->zc_name);
> + (void) spa_destroy(spa_name);
>  
>  pool_props_bad:
>   nvlist_free(rootprops);
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [PATCH][BIONIC][SRU] UBUNTU: SAUCE: (noup) Update zfs to 0.7.5-1ubuntu16.4

Marcelo Henrique Cerri
In reply to this post by Colin Ian King-2
Does that also affect xenial or other series?

Acked-by: Marcelo Henrique Cerri <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [PATCH][BIONIC][SRU] UBUNTU: SAUCE: (noup) Update zfs to 0.7.5-1ubuntu16.4

Stefan Bader-2
In reply to this post by Colin Ian King-2
On 12.09.2018 19:04, Colin King wrote:

> From: Colin Ian King <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1769937
>
> Sync with zfsutils-linux 0.7.5-1ubuntu16.4 to pick up fixes for
> LP#1769937.
>
> Upstream ZFS fix 4ceb8dd6fdfd ("Fix 'zpool create -t <tempname>'")
> fixes error message and error exit when using the -t option
> when creating a pool.
>
> Signed-off-by: Colin Ian King <[hidden email]>
> ---
Applied to bionic/master-next. Thanks.

-Stefan

>  zfs/META                   |  2 +-
>  zfs/module/zfs/zfs_ioctl.c | 10 ++++++++--
>  2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/zfs/META b/zfs/META
> index a906a795c..9864f8f64 100644
> --- a/zfs/META
> +++ b/zfs/META
> @@ -2,7 +2,7 @@ Meta:         1
>  Name:         zfs
>  Branch:       1.0
>  Version:      0.7.5
> -Release:      1ubuntu16.3
> +Release:      1ubuntu16.4
>  Release-Tags: relext
>  License:      CDDL
>  Author:       OpenZFS on Linux
> diff --git a/zfs/module/zfs/zfs_ioctl.c b/zfs/module/zfs/zfs_ioctl.c
> index f41e1b9bd..c6d180cda 100644
> --- a/zfs/module/zfs/zfs_ioctl.c
> +++ b/zfs/module/zfs/zfs_ioctl.c
> @@ -1474,6 +1474,7 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
>   nvlist_t *config, *props = NULL;
>   nvlist_t *rootprops = NULL;
>   nvlist_t *zplprops = NULL;
> + char *spa_name = zc->zc_name;
>  
>   if ((error = get_nvlist(zc->zc_nvlist_conf, zc->zc_nvlist_conf_size,
>      zc->zc_iflags, &config)))
> @@ -1489,6 +1490,7 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
>   if (props) {
>   nvlist_t *nvl = NULL;
>   uint64_t version = SPA_VERSION;
> + char *tname;
>  
>   (void) nvlist_lookup_uint64(props,
>      zpool_prop_to_name(ZPOOL_PROP_VERSION), &version);
> @@ -1511,6 +1513,10 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
>      zplprops, NULL);
>   if (error != 0)
>   goto pool_props_bad;
> +
> + if (nvlist_lookup_string(props,
> +    zpool_prop_to_name(ZPOOL_PROP_TNAME), &tname) == 0)
> + spa_name = tname;
>   }
>  
>   error = spa_create(zc->zc_name, config, props, zplprops);
> @@ -1518,9 +1524,9 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
>   /*
>   * Set the remaining root properties
>   */
> - if (!error && (error = zfs_set_prop_nvlist(zc->zc_name,
> + if (!error && (error = zfs_set_prop_nvlist(spa_name,
>      ZPROP_SRC_LOCAL, rootprops, NULL)) != 0)
> - (void) spa_destroy(zc->zc_name);
> + (void) spa_destroy(spa_name);
>  
>  pool_props_bad:
>   nvlist_free(rootprops);
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment