[PATCH Bionic/Unstable] UBUNTU: SAUCE: usb: typec: ucsi: Increase command completion timeout value

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH Bionic/Unstable] UBUNTU: SAUCE: usb: typec: ucsi: Increase command completion timeout value

Thadeu Lima de Souza Cascardo-3
From: Heikki Krogerus <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1758797

On some boards, under heavy load, the EC firmware is
unable to complete commands even in one second. Increasing
the command completion timeout value to five seconds.

Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
Cc: <[hidden email]>
Signed-off-by: Heikki Krogerus <[hidden email]>
Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 drivers/usb/typec/ucsi/ucsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
index 79046fe66426..8d95b3a168d2 100644
--- a/drivers/usb/typec/ucsi/ucsi.c
+++ b/drivers/usb/typec/ucsi/ucsi.c
@@ -28,7 +28,7 @@
  * difficult to estimate the time it takes for the system to process the command
  * before it is actually passed to the PPM.
  */
-#define UCSI_TIMEOUT_MS 1000
+#define UCSI_TIMEOUT_MS 5000
 
 /*
  * UCSI_SWAP_TIMEOUT_MS - Timeout for role swap requests
--
2.15.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH Bionic/Unstable] UBUNTU: SAUCE: usb: typec: ucsi: Increase command completion timeout value

Seth Forshee
On Fri, Apr 13, 2018 at 06:54:33AM -0300, Thadeu Lima de Souza Cascardo wrote:

> From: Heikki Krogerus <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1758797
>
> On some boards, under heavy load, the EC firmware is
> unable to complete commands even in one second. Increasing
> the command completion timeout value to five seconds.
>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Cc: <[hidden email]>
> Signed-off-by: Heikki Krogerus <[hidden email]>
> Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>

Acked-by: Seth Forshee <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH Bionic/Unstable] UBUNTU: SAUCE: usb: typec: ucsi: Increase command completion timeout value

Colin King
In reply to this post by Thadeu Lima de Souza Cascardo-3
On 13/04/18 10:54, Thadeu Lima de Souza Cascardo wrote:

> From: Heikki Krogerus <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1758797
>
> On some boards, under heavy load, the EC firmware is
> unable to complete commands even in one second. Increasing
> the command completion timeout value to five seconds.
>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Cc: <[hidden email]>
> Signed-off-by: Heikki Krogerus <[hidden email]>
> Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
> ---
>  drivers/usb/typec/ucsi/ucsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 79046fe66426..8d95b3a168d2 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -28,7 +28,7 @@
>   * difficult to estimate the time it takes for the system to process the command
>   * before it is actually passed to the PPM.
>   */
> -#define UCSI_TIMEOUT_MS 1000
> +#define UCSI_TIMEOUT_MS 5000
>  
>  /*
>   * UCSI_SWAP_TIMEOUT_MS - Timeout for role swap requests
>

Upstream fix, seems very reasonable to me, minimal regression potential.

Acked-by: Colin Ian King <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [PATCH Bionic/Unstable] UBUNTU: SAUCE: usb: typec: ucsi: Increase command completion timeout value

Stefan Bader-2
In reply to this post by Thadeu Lima de Souza Cascardo-3
On 13.04.2018 11:54, Thadeu Lima de Souza Cascardo wrote:

> From: Heikki Krogerus <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1758797
>
> On some boards, under heavy load, the EC firmware is
> unable to complete commands even in one second. Increasing
> the command completion timeout value to five seconds.
>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Cc: <[hidden email]>
> Signed-off-by: Heikki Krogerus <[hidden email]>
> Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---

Looks safe enough. Only question would be whether this is/should go upstream at
some point.

-Stefan

>  drivers/usb/typec/ucsi/ucsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 79046fe66426..8d95b3a168d2 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -28,7 +28,7 @@
>   * difficult to estimate the time it takes for the system to process the command
>   * before it is actually passed to the PPM.
>   */
> -#define UCSI_TIMEOUT_MS 1000
> +#define UCSI_TIMEOUT_MS 5000
>  
>  /*
>   * UCSI_SWAP_TIMEOUT_MS - Timeout for role swap requests
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED: [PATCH Bionic/Unstable] UBUNTU: SAUCE: usb: typec: ucsi: Increase command completion timeout value

Thadeu Lima de Souza Cascardo-3
In reply to this post by Thadeu Lima de Souza Cascardo-3
Applied to bionic master-next.

Thanks.
Cascardo.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team