[PATCH Eoan] UBUNTU: SAUCE: powerpc/vio: drop bus_type from parent device

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH Eoan] UBUNTU: SAUCE: powerpc/vio: drop bus_type from parent device

Thadeu Lima de Souza Cascardo-3
BugLink: https://bugs.launchpad.net/bugs/1845572

Commit df44b479654f62b478c18ee4d8bc4e9f897a9844 ("kobject: return error code if
writing /sys/.../uevent fails") started returning failure when writing to
/sys/devices/vio/uevent.

This causes an early udevadm trigger to fail. On some installer versions of
Ubuntu, this will cause init to exit, thus panicing the system very early
during boot.

Removing the bus_type from the parent device will remove some of the extra
empty files from /sys/devices/vio/, but will keep the rest of the layout for
vio devices, keeping them under /sys/devices/vio/.

It has been tested that uevents for vio devices don't change after this fix,
they still contain MODALIAS.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---

This has been submitted upstream just now.

---
 arch/powerpc/platforms/pseries/vio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/vio.c b/arch/powerpc/platforms/pseries/vio.c
index 6601b9d404dc..d570d5494f30 100644
--- a/arch/powerpc/platforms/pseries/vio.c
+++ b/arch/powerpc/platforms/pseries/vio.c
@@ -36,7 +36,6 @@ static struct vio_dev vio_bus_device  = { /* fake "parent" device */
  .name = "vio",
  .type = "",
  .dev.init_name = "vio",
- .dev.bus = &vio_bus_type,
 };
 
 #ifdef CONFIG_PPC_SMLPAR
--
2.20.1



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH Eoan] UBUNTU: SAUCE: powerpc/vio: drop bus_type from parent device

Andrea Righi
On Fri, Sep 27, 2019 at 11:41:53AM -0300, Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1845572
>
> Commit df44b479654f62b478c18ee4d8bc4e9f897a9844 ("kobject: return error code if
> writing /sys/.../uevent fails") started returning failure when writing to
> /sys/devices/vio/uevent.

What's the downside of reverting df44b479654f?

>
> This causes an early udevadm trigger to fail. On some installer versions of
> Ubuntu, this will cause init to exit, thus panicing the system very early
> during boot.
>
> Removing the bus_type from the parent device will remove some of the extra
> empty files from /sys/devices/vio/, but will keep the rest of the layout for
> vio devices, keeping them under /sys/devices/vio/.
>
> It has been tested that uevents for vio devices don't change after this fix,
> they still contain MODALIAS.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
> ---
>
> This has been submitted upstream just now.

Link:?

Thanks,
-Andrea

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH Eoan] UBUNTU: SAUCE: powerpc/vio: drop bus_type from parent device

Thadeu Lima de Souza Cascardo-3
On Fri, Sep 27, 2019 at 05:06:03PM +0200, Andrea Righi wrote:
> On Fri, Sep 27, 2019 at 11:41:53AM -0300, Thadeu Lima de Souza Cascardo wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1845572
> >
> > Commit df44b479654f62b478c18ee4d8bc4e9f897a9844 ("kobject: return error code if
> > writing /sys/.../uevent fails") started returning failure when writing to
> > /sys/devices/vio/uevent.
>
> What's the downside of reverting df44b479654f?
>

We divert from upstream and change core code, instead of changing only powerpc
specific code.

> >
> > This causes an early udevadm trigger to fail. On some installer versions of
> > Ubuntu, this will cause init to exit, thus panicing the system very early
> > during boot.
> >
> > Removing the bus_type from the parent device will remove some of the extra
> > empty files from /sys/devices/vio/, but will keep the rest of the layout for
> > vio devices, keeping them under /sys/devices/vio/.
> >
> > It has been tested that uevents for vio devices don't change after this fix,
> > they still contain MODALIAS.
> >
> > Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
> > ---
> >
> > This has been submitted upstream just now.
>
> Link:?
>

There was no link yet when I sent the sauce patch.  :-)

http://patchwork.ozlabs.org/patch/1168596/

> Thanks,
> -Andrea

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH Eoan] UBUNTU: SAUCE: powerpc/vio: drop bus_type from parent device

Seth Forshee
In reply to this post by Thadeu Lima de Souza Cascardo-3
On Fri, Sep 27, 2019 at 11:41:53AM -0300, Thadeu Lima de Souza Cascardo wrote:

> BugLink: https://bugs.launchpad.net/bugs/1845572
>
> Commit df44b479654f62b478c18ee4d8bc4e9f897a9844 ("kobject: return error code if
> writing /sys/.../uevent fails") started returning failure when writing to
> /sys/devices/vio/uevent.
>
> This causes an early udevadm trigger to fail. On some installer versions of
> Ubuntu, this will cause init to exit, thus panicing the system very early
> during boot.
>
> Removing the bus_type from the parent device will remove some of the extra
> empty files from /sys/devices/vio/, but will keep the rest of the layout for
> vio devices, keeping them under /sys/devices/vio/.
>
> It has been tested that uevents for vio devices don't change after this fix,
> they still contain MODALIAS.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>

Positive testing, fixes a bug critical for eoan release.

Acked-by: Seth Forshee <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH Eoan] UBUNTU: SAUCE: powerpc/vio: drop bus_type from parent device

Marcelo Henrique Cerri
In reply to this post by Thadeu Lima de Souza Cascardo-3
Acked-by: Marcelo Henrique Cerri <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (673 bytes) Download Attachment