[PATCH][Hardy SRU] atkbd: mark keyboard as disabled when

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH][Hardy SRU] atkbd: mark keyboard as disabled when

Amit Kucheria-6
SRU Justification:

Impact: This bug causes keyboard to spew garbage on resume and might cause it to
go into an unknown state as reported by the bug reporter

Fix: This patch that is upstream since 2.6.26 (and is contained in Intrepid and
Jaunty)

Testcase: Make sure that keyboard works normally after resume

Dmitry Torokhov (1):
  UBUNTU: Input: atkbd - mark keyboard as disabled when
    suspending/unloading

 drivers/input/keyboard/atkbd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH] UBUNTU: Input: atkbd - mark keyboard as disabled when suspending/unloading

Amit Kucheria-6
From: Dmitry Torokhov <[hidden email]>

Bug: #213988

This will shut off garbage that may come from KBD port during resume.
(cherry picked from commit 57f5b1590f2d801a3a7f072e2c65f14d4545852c)

Signed-off-by: Dmitry Torokhov <[hidden email]>
Signed-off-by: Amit Kucheria <[hidden email]>
---
 drivers/input/keyboard/atkbd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index b39c5b3..b58a51a 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -809,6 +809,8 @@ static int atkbd_activate(struct atkbd *atkbd)
 static void atkbd_cleanup(struct serio *serio)
 {
  struct atkbd *atkbd = serio_get_drvdata(serio);
+
+ atkbd_disable(atkbd);
  ps2_command(&atkbd->ps2dev, NULL, ATKBD_CMD_RESET_BAT);
 }
 
--
1.6.0.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH][Hardy SRU] atkbd: mark keyboard as disabled when

Andy Whitcroft-3
In reply to this post by Amit Kucheria-6
On Tue, Apr 28, 2009 at 10:03:20AM +0300, Amit Kucheria wrote:

> SRU Justification:
>
> Impact: This bug causes keyboard to spew garbage on resume and might cause it to
> go into an unknown state as reported by the bug reporter
>
> Fix: This patch that is upstream since 2.6.26 (and is contained in Intrepid and
> Jaunty)
>
> Testcase: Make sure that keyboard works normally after resume
>
> Dmitry Torokhov (1):
>   UBUNTU: Input: atkbd - mark keyboard as disabled when
>     suspending/unloading
>
>  drivers/input/keyboard/atkbd.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Looks ok to me and also sounds well tested from the bug.

ACK.

-apw

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH][Hardy SRU] atkbd: mark keyboard as disabled when

Stefan Bader-2
In reply to this post by Amit Kucheria-6
Amit Kucheria wrote:

> SRU Justification:
>
> Impact: This bug causes keyboard to spew garbage on resume and might cause it to
> go into an unknown state as reported by the bug reporter
>
> Fix: This patch that is upstream since 2.6.26 (and is contained in Intrepid and
> Jaunty)
>
> Testcase: Make sure that keyboard works normally after resume
>
> Dmitry Torokhov (1):
>   UBUNTU: Input: atkbd - mark keyboard as disabled when
>     suspending/unloading
>
>  drivers/input/keyboard/atkbd.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
>
ACK, as well as applied

--

When all other means of communication fail, try words!



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team