[PATCH][SRU][Bionic] HP workstations cannot output to external monitors by dGPU

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH][SRU][Bionic] HP workstations cannot output to external monitors by dGPU

Alex Hung
BugLink: http://bugs.launchpad.net/bugs/1810702

[Impact]

  HP mobile workstations are able to output to external monitors by dGPU in
  Windows with hybrid graphics, but this is not supported by Linux GPU
  drivers. As a result, this feature needs to be supported by BIOS but
  an _OSI string is required.

[Fix]
  BIOS added solutions with _OSI string "Linux-HPI-Hybrid-Graphics" to
  workaround, and a patch to report _OSI("Linux-HPI-Hybrid-Graphics")
  is required in Linux kernel.

  The patches are included in upstream and are cherry-picked from Linus's repo.

[Regression potential]
  No regression as all but targeted firmware will not use this _OSI string


Alex Hung (1):
  ACPI / OSI: Add OEM _OSI string to enable dGPU direct output

 drivers/acpi/osi.c | 7 +++++++
 1 file changed, 7 insertions(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH] ACPI / OSI: Add OEM _OSI string to enable dGPU direct output

Alex Hung
For HP Inc. mobile workstation with hybrid graphics support, dGPU can
directly output to external monitors; however, Nvidia and AMD's Linux
drivers aren't able to support this feature.

The OEM _OSI string "Linux-HPI-Hybrid-Graphics" is used by BIOS to
implement dGPU direct output to external monitors.

The form of the OEM _OSI strings is defined by each OEMs and is
discussed in Documentation/acpi/osi.txt.

BugLink: http://bugs.launchpad.net/bugs/1810702

Signed-off-by: Alex Hung <[hidden email]>
Signed-off-by: Rafael J. Wysocki <[hidden email]>
(cherry picked from commit 28586a51eea666d5531bcaef2f68e4abbd87242c)
Signed-off-by: Alex Hung <[hidden email]>
---
 drivers/acpi/osi.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/acpi/osi.c b/drivers/acpi/osi.c
index e83297e..09053a2 100644
--- a/drivers/acpi/osi.c
+++ b/drivers/acpi/osi.c
@@ -74,6 +74,13 @@ osi_setup_entries[OSI_STRING_ENTRIES_MAX] __initdata = {
  * a BIOS workaround.
  */
  {"Linux-Lenovo-NV-HDMI-Audio", true},
+ /*
+ * Linux-HPI-Hybrid-Graphics is used by BIOS to enable dGPU to
+ * output video directly to external monitors on HP Inc. mobile
+ * workstations as Nvidia and AMD VGA drivers provide limited
+ * hybrid graphics supports.
+ */
+ {"Linux-HPI-Hybrid-Graphics", true},
 };
 
 static u32 acpi_osi_handler(acpi_string interface, u32 supported)
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH] ACPI / OSI: Add OEM _OSI string to enable dGPU direct output

Colin King
On 07/01/2019 16:13, Alex Hung wrote:

> For HP Inc. mobile workstation with hybrid graphics support, dGPU can
> directly output to external monitors; however, Nvidia and AMD's Linux
> drivers aren't able to support this feature.
>
> The OEM _OSI string "Linux-HPI-Hybrid-Graphics" is used by BIOS to
> implement dGPU direct output to external monitors.
>
> The form of the OEM _OSI strings is defined by each OEMs and is
> discussed in Documentation/acpi/osi.txt.
>
> BugLink: http://bugs.launchpad.net/bugs/1810702
>
> Signed-off-by: Alex Hung <[hidden email]>
> Signed-off-by: Rafael J. Wysocki <[hidden email]>
> (cherry picked from commit 28586a51eea666d5531bcaef2f68e4abbd87242c)
> Signed-off-by: Alex Hung <[hidden email]>
> ---
>  drivers/acpi/osi.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/osi.c b/drivers/acpi/osi.c
> index e83297e..09053a2 100644
> --- a/drivers/acpi/osi.c
> +++ b/drivers/acpi/osi.c
> @@ -74,6 +74,13 @@ osi_setup_entries[OSI_STRING_ENTRIES_MAX] __initdata = {
>   * a BIOS workaround.
>   */
>   {"Linux-Lenovo-NV-HDMI-Audio", true},
> + /*
> + * Linux-HPI-Hybrid-Graphics is used by BIOS to enable dGPU to
> + * output video directly to external monitors on HP Inc. mobile
> + * workstations as Nvidia and AMD VGA drivers provide limited
> + * hybrid graphics supports.
> + */
> + {"Linux-HPI-Hybrid-Graphics", true},
>  };
>  
>  static u32 acpi_osi_handler(acpi_string interface, u32 supported)
>

Oh, another fun OEM _OSI string. Fun.

Clean upstream cherry pick and I trust the committer :-)

Acked-by: Colin Ian King <[hidden email]>

Do we need this for Cosmic etc?

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH][SRU][Bionic] HP workstations cannot output to external monitors by dGPU

Khaled Elmously
In reply to this post by Alex Hung
On 2019-01-07 08:13:20 , Alex Hung wrote:

> BugLink: http://bugs.launchpad.net/bugs/1810702
>
> [Impact]
>
>   HP mobile workstations are able to output to external monitors by dGPU in
>   Windows with hybrid graphics, but this is not supported by Linux GPU
>   drivers. As a result, this feature needs to be supported by BIOS but
>   an _OSI string is required.
>
> [Fix]
>   BIOS added solutions with _OSI string "Linux-HPI-Hybrid-Graphics" to
>   workaround, and a patch to report _OSI("Linux-HPI-Hybrid-Graphics")
>   is required in Linux kernel.
>
>   The patches are included in upstream and are cherry-picked from Linus's repo.
>
> [Regression potential]
>   No regression as all but targeted firmware will not use this _OSI string
>
>
> Alex Hung (1):
>   ACPI / OSI: Add OEM _OSI string to enable dGPU direct output
>
>  drivers/acpi/osi.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
Acked-by: Khalid Elmously <[hidden email]>
 

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [PATCH][SRU][Bionic] HP workstations cannot output to external monitors by dGPU

Khaled Elmously
In reply to this post by Alex Hung
On 2019-01-07 08:13:20 , Alex Hung wrote:

> BugLink: http://bugs.launchpad.net/bugs/1810702
>
> [Impact]
>
>   HP mobile workstations are able to output to external monitors by dGPU in
>   Windows with hybrid graphics, but this is not supported by Linux GPU
>   drivers. As a result, this feature needs to be supported by BIOS but
>   an _OSI string is required.
>
> [Fix]
>   BIOS added solutions with _OSI string "Linux-HPI-Hybrid-Graphics" to
>   workaround, and a patch to report _OSI("Linux-HPI-Hybrid-Graphics")
>   is required in Linux kernel.
>
>   The patches are included in upstream and are cherry-picked from Linus's repo.
>
> [Regression potential]
>   No regression as all but targeted firmware will not use this _OSI string
>
>
> Alex Hung (1):
>   ACPI / OSI: Add OEM _OSI string to enable dGPU direct output
>
>  drivers/acpi/osi.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: APPLIED: [PATCH][SRU][Bionic] HP workstations cannot output to external monitors by dGPU

Stefan Bader-2
On 08.01.19 01:36, Khaled Elmously wrote:
> On 2019-01-07 08:13:20 , Alex Hung wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1810702

Bug not nominated for Bionic, the fix committed state should have gone to the
nomination not the development task. And since the fix upstream went into
v5.0-rc1 someone should ensure that disco picks it up.

-Stefan

>>
>> [Impact]
>>
>>   HP mobile workstations are able to output to external monitors by dGPU in
>>   Windows with hybrid graphics, but this is not supported by Linux GPU
>>   drivers. As a result, this feature needs to be supported by BIOS but
>>   an _OSI string is required.
>>
>> [Fix]
>>   BIOS added solutions with _OSI string "Linux-HPI-Hybrid-Graphics" to
>>   workaround, and a patch to report _OSI("Linux-HPI-Hybrid-Graphics")
>>   is required in Linux kernel.
>>
>>   The patches are included in upstream and are cherry-picked from Linus's repo.
>>
>> [Regression potential]
>>   No regression as all but targeted firmware will not use this _OSI string
>>
>>
>> Alex Hung (1):
>>   ACPI / OSI: Add OEM _OSI string to enable dGPU direct output
>>
>>  drivers/acpi/osi.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> --
>> 2.7.4
>>
>>
>> --
>> kernel-team mailing list
>> [hidden email]
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[D/Unstable]: [PATCH][SRU][Bionic] HP workstations cannot output to external monitors by dGPU

Seth Forshee
In reply to this post by Alex Hung
On Mon, Jan 07, 2019 at 08:13:20AM -0800, Alex Hung wrote:

> BugLink: http://bugs.launchpad.net/bugs/1810702
>
> [Impact]
>
>   HP mobile workstations are able to output to external monitors by dGPU in
>   Windows with hybrid graphics, but this is not supported by Linux GPU
>   drivers. As a result, this feature needs to be supported by BIOS but
>   an _OSI string is required.
>
> [Fix]
>   BIOS added solutions with _OSI string "Linux-HPI-Hybrid-Graphics" to
>   workaround, and a patch to report _OSI("Linux-HPI-Hybrid-Graphics")
>   is required in Linux kernel.
>
>   The patches are included in upstream and are cherry-picked from Linus's repo.
>
> [Regression potential]
>   No regression as all but targeted firmware will not use this _OSI string

Please be sure to send SRU patches for the development kernel too if
they aren't there already. Applied to disco/master-next and
unstable/master, thanks!

I'll also reiterate Colin's question. Shouldn't this go into cosmic too?

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team