[PATCH][SRU][Disco] UBUNTU: SAUCE: shiftfs: mark slab objects SLAB_RECLAIM_ACCOUNT

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH][SRU][Disco] UBUNTU: SAUCE: shiftfs: mark slab objects SLAB_RECLAIM_ACCOUNT

Christian Brauner-3
BugLink: https://bugs.launchpad.net/bugs/1842059

Shiftfs does not mark it's slab cache as reclaimable. While this is not
a big deal it is not nice to the kernel in general. The shiftfs cache is
not so important that it can't be reclaimed.

Signed-off-by: Christian Brauner <[hidden email]>
---
 fs/shiftfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/shiftfs.c b/fs/shiftfs.c
index 400c3062365c..57e04a02d74c 100644
--- a/fs/shiftfs.c
+++ b/fs/shiftfs.c
@@ -2102,7 +2102,7 @@ static int __init shiftfs_init(void)
 {
  shiftfs_file_info_cache = kmem_cache_create(
  "shiftfs_file_info_cache", sizeof(struct shiftfs_file_info), 0,
- SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
+ SLAB_RECLAIM_ACCOUNT | SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
  if (!shiftfs_file_info_cache)
  return -ENOMEM;
 
--
2.23.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK / APPLIED[E/Unstable]: [PATCH][SRU][Disco] UBUNTU: SAUCE: shiftfs: mark slab objects SLAB_RECLAIM_ACCOUNT

Seth Forshee
On Fri, Aug 30, 2019 at 02:14:31PM +0200, Christian Brauner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1842059
>
> Shiftfs does not mark it's slab cache as reclaimable. While this is not
> a big deal it is not nice to the kernel in general. The shiftfs cache is
> not so important that it can't be reclaimed.
>
> Signed-off-by: Christian Brauner <[hidden email]>

Acked-by: Seth Forshee <[hidden email]>

Again, please remember to submit these for the development release too.
Applied to eoan/master-next and unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH][SRU][Disco] UBUNTU: SAUCE: shiftfs: mark slab objects SLAB_RECLAIM_ACCOUNT

Stefan Bader-2
In reply to this post by Christian Brauner-3
On 30.08.19 14:14, Christian Brauner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1842059
>
> Shiftfs does not mark it's slab cache as reclaimable. While this is not
> a big deal it is not nice to the kernel in general. The shiftfs cache is
> not so important that it can't be reclaimed.
>
> Signed-off-by: Christian Brauner <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---
>  fs/shiftfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/shiftfs.c b/fs/shiftfs.c
> index 400c3062365c..57e04a02d74c 100644
> --- a/fs/shiftfs.c
> +++ b/fs/shiftfs.c
> @@ -2102,7 +2102,7 @@ static int __init shiftfs_init(void)
>  {
>   shiftfs_file_info_cache = kmem_cache_create(
>   "shiftfs_file_info_cache", sizeof(struct shiftfs_file_info), 0,
> - SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
> + SLAB_RECLAIM_ACCOUNT | SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
>   if (!shiftfs_file_info_cache)
>   return -ENOMEM;
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED: [PATCH][SRU][Disco] UBUNTU: SAUCE: shiftfs: mark slab objects SLAB_RECLAIM_ACCOUNT

Kleber Souza
In reply to this post by Christian Brauner-3
On 30.08.19 14:14, Christian Brauner wrote:

> BugLink: https://bugs.launchpad.net/bugs/1842059
>
> Shiftfs does not mark it's slab cache as reclaimable. While this is not
> a big deal it is not nice to the kernel in general. The shiftfs cache is
> not so important that it can't be reclaimed.
>
> Signed-off-by: Christian Brauner <[hidden email]>
> ---
>  fs/shiftfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/shiftfs.c b/fs/shiftfs.c
> index 400c3062365c..57e04a02d74c 100644
> --- a/fs/shiftfs.c
> +++ b/fs/shiftfs.c
> @@ -2102,7 +2102,7 @@ static int __init shiftfs_init(void)
>  {
>   shiftfs_file_info_cache = kmem_cache_create(
>   "shiftfs_file_info_cache", sizeof(struct shiftfs_file_info), 0,
> - SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
> + SLAB_RECLAIM_ACCOUNT | SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
>   if (!shiftfs_file_info_cache)
>   return -ENOMEM;
>  
>

Applied to disco/master-next branch.

Thanks,
Kleber


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team