Ubuntu › kernel-team

[PATCH][SRU][E] UBUNTU: SAUCE: s390: Mark atomic const ops always inline

classic Classic list List threaded Threaded
♦
♦
 5 messages Options
Seth Forshee
Reply | Threaded
Open this post in threaded view
♦
♦
|

[PATCH][SRU][E] UBUNTU: SAUCE: s390: Mark atomic const ops always inline

Seth Forshee
BugLink: https://bugs.launchpad.net/bugs/1846143

I get the following error building zfs for s390 with debug
symbols enabled:

./arch/s390/include/asm/atomic_ops.h:46:2: error: impossible constraint in ‘asm’

Similar problems have been fixed in the past by using
__always_inline to force inlining, and trying the same here fixes
the build.

Signed-off-by: Seth Forshee <[hidden email]>
---
 arch/s390/include/asm/atomic_ops.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/include/asm/atomic_ops.h b/arch/s390/include/asm/atomic_ops.h
index d3f09526ee19..61467b9eecc7 100644
--- a/arch/s390/include/asm/atomic_ops.h
+++ b/arch/s390/include/asm/atomic_ops.h
@@ -41,7 +41,7 @@ __ATOMIC_OPS(__atomic64_xor, long, "laxg")
 #undef __ATOMIC_OP
 
 #define __ATOMIC_CONST_OP(op_name, op_type, op_string, op_barrier) \
-static inline void op_name(op_type val, op_type *ptr) \
+static __always_inline void op_name(op_type val, op_type *ptr) \
 { \
  asm volatile( \
  op_string " %[ptr],%[val]\n" \
--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Andrea Righi
Reply | Threaded
Open this post in threaded view
♦
♦
|

ACK/Cmnt: [PATCH][SRU][E] UBUNTU: SAUCE: s390: Mark atomic const ops always inline

Andrea Righi
On Mon, Sep 30, 2019 at 09:06:05PM -0500, Seth Forshee wrote:

> BugLink: https://bugs.launchpad.net/bugs/1846143
>
> I get the following error building zfs for s390 with debug
> symbols enabled:
>
> ./arch/s390/include/asm/atomic_ops.h:46:2: error: impossible constraint in ‘asm’
>
> Similar problems have been fixed in the past by using
> __always_inline to force inlining, and trying the same here fixes
> the build.
>
> Signed-off-by: Seth Forshee <[hidden email]>

Looks like a mainline bug. Maybe we should also send this to the LKML?
In the meantime:

Acked-by: Andrea Righi <[hidden email]>

> ---
>  arch/s390/include/asm/atomic_ops.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/include/asm/atomic_ops.h b/arch/s390/include/asm/atomic_ops.h
> index d3f09526ee19..61467b9eecc7 100644
> --- a/arch/s390/include/asm/atomic_ops.h
> +++ b/arch/s390/include/asm/atomic_ops.h
> @@ -41,7 +41,7 @@ __ATOMIC_OPS(__atomic64_xor, long, "laxg")
>  #undef __ATOMIC_OP
>  
>  #define __ATOMIC_CONST_OP(op_name, op_type, op_string, op_barrier) \
> -static inline void op_name(op_type val, op_type *ptr) \
> +static __always_inline void op_name(op_type val, op_type *ptr) \
>  { \
>   asm volatile( \
>   op_string " %[ptr],%[val]\n" \
> --
> 2.20.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Andy Whitcroft-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

[Acked/CMT] [PATCH][SRU][E] UBUNTU: SAUCE: s390: Mark atomic const ops always inline

Andy Whitcroft-3
In reply to this post by Seth Forshee
On Mon, Sep 30, 2019 at 09:06:05PM -0500, Seth Forshee wrote:

> BugLink: https://bugs.launchpad.net/bugs/1846143
>
> I get the following error building zfs for s390 with debug
> symbols enabled:
>
> ./arch/s390/include/asm/atomic_ops.h:46:2: error: impossible constraint in ‘asm’
>
> Similar problems have been fixed in the past by using
> __always_inline to force inlining, and trying the same here fixes
> the build.
>
> Signed-off-by: Seth Forshee <[hidden email]>
> ---
>  arch/s390/include/asm/atomic_ops.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/include/asm/atomic_ops.h b/arch/s390/include/asm/atomic_ops.h
> index d3f09526ee19..61467b9eecc7 100644
> --- a/arch/s390/include/asm/atomic_ops.h
> +++ b/arch/s390/include/asm/atomic_ops.h
> @@ -41,7 +41,7 @@ __ATOMIC_OPS(__atomic64_xor, long, "laxg")
>  #undef __ATOMIC_OP
>  
>  #define __ATOMIC_CONST_OP(op_name, op_type, op_string, op_barrier) \
> -static inline void op_name(op_type val, op_type *ptr) \
> +static __always_inline void op_name(op_type val, op_type *ptr) \
>  { \
>   asm volatile( \
>   op_string " %[ptr],%[val]\n" \
> --
> 2.20.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

"Trying the same here ..." wimper.  But if it makes it build I guess:

Acked-by: Andy Whitcroft <[hidden email]>

-apw

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Marcelo Henrique Cerri
Reply | Threaded
Open this post in threaded view
♦
♦
|

ACK: [PATCH][SRU][E] UBUNTU: SAUCE: s390: Mark atomic const ops always inline

Marcelo Henrique Cerri
In reply to this post by Seth Forshee
Acked-by: Marcelo Henrique Cerri <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (673 bytes) Download Attachment
Seth Forshee
Reply | Threaded
Open this post in threaded view
♦
♦
|

APPLIED: [PATCH][SRU][E] UBUNTU: SAUCE: s390: Mark atomic const ops always inline

Seth Forshee
In reply to this post by Seth Forshee
On Mon, Sep 30, 2019 at 09:06:05PM -0500, Seth Forshee wrote:

> BugLink: https://bugs.launchpad.net/bugs/1846143
>
> I get the following error building zfs for s390 with debug
> symbols enabled:
>
> ./arch/s390/include/asm/atomic_ops.h:46:2: error: impossible constraint in ‘asm’
>
> Similar problems have been fixed in the past by using
> __always_inline to force inlining, and trying the same here fixes
> the build.
>
> Signed-off-by: Seth Forshee <[hidden email]>

Applied to eoan/master-next.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Free forum by Nabble Edit this page