[PATCH][SRU][xenial] Support a new side button on Dell AIO

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH][SRU][xenial] Support a new side button on Dell AIO

Alex Hung
Impact:
  Dell AIO has a side button to toggle display on & off, but it requires
  dell-wmi to handle a new event from BIOS and to generate KEY_DISPLAYTOGGLE

Fix:
  This patch adds a new keycode KEY_DISPLAYTOGGLE to handle the BIOS event.

  The patches are included in upstream and are cherry-picked from Linus's repo.

Tested:
  The patches are tested on Dell Inspiron 24-3460

Regression Potential:
  Very low - the patch adds a new keycode only.

BugLink: http://bugs.launchpad.net/bugs/1702541

Alex Hung (1):
  dell-wmi: Add a WMI event code for display on/off

 drivers/platform/x86/dell-wmi.c | 3 +++
 1 file changed, 3 insertions(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] dell-wmi: Add a WMI event code for display on/off

Alex Hung
Some new Dell AIO systems have a button that generates a WMI event to
turn the LCD on/off.

BugLink: http://bugs.launchpad.net/bugs/1702541

Signed-off-by: Alex Hung <[hidden email]>
Acked-by: Pali Rohár <[hidden email]>
Signed-off-by: Darren Hart <[hidden email]>
(backported from commit ab9bb11ccbaa9e84be2534b677fe5350c2cc2014)
Signed-off-by: Alex Hung <[hidden email]>
---
 drivers/platform/x86/dell-wmi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index f2d77fe..88dd7b5 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -90,6 +90,9 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
  { KE_IGNORE, 0xe025, { KEY_RESERVED } },
  { KE_IGNORE, 0xe026, { KEY_RESERVED } },
 
+ /* LCD Display On/Off Control key */
+ { KE_KEY,    0xe027, { KEY_DISPLAYTOGGLE } },
+
  { KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } },
  { KE_IGNORE, 0xe030, { KEY_VOLUMEUP } },
  { KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } },
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

ACK: [PATCH] dell-wmi: Add a WMI event code for display on/off

Colin Ian King-2
On 06/07/17 07:50, Alex Hung wrote:

> Some new Dell AIO systems have a button that generates a WMI event to
> turn the LCD on/off.
>
> BugLink: http://bugs.launchpad.net/bugs/1702541
>
> Signed-off-by: Alex Hung <[hidden email]>
> Acked-by: Pali Rohár <[hidden email]>
> Signed-off-by: Darren Hart <[hidden email]>
> (backported from commit ab9bb11ccbaa9e84be2534b677fe5350c2cc2014)
> Signed-off-by: Alex Hung <[hidden email]>
> ---
>  drivers/platform/x86/dell-wmi.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index f2d77fe..88dd7b5 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -90,6 +90,9 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
>   { KE_IGNORE, 0xe025, { KEY_RESERVED } },
>   { KE_IGNORE, 0xe026, { KEY_RESERVED } },
>  
> + /* LCD Display On/Off Control key */
> + { KE_KEY,    0xe027, { KEY_DISPLAYTOGGLE } },
> +
>   { KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } },
>   { KE_IGNORE, 0xe030, { KEY_VOLUMEUP } },
>   { KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } },
>

Limited to Dell WMI devices with WMI magic code 0xe027. Looks good to me.

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

ACK: [PATCH] dell-wmi: Add a WMI event code for display on/off

AceLan Kao
In reply to this post by Alex Hung
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

APPLIED: [PATCH][SRU][xenial] Support a new side button on Dell AIO

Thadeu Lima de Souza Cascardo-3
In reply to this post by Alex Hung
Applied to xenial master-next branch.

Thanks.
Cascardo.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Loading...