[PATCH] [SRU] [xenial/master-next] [Config] arm64: disable BPF_JIT_ALWAYS_ON

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] [SRU] [xenial/master-next] [Config] arm64: disable BPF_JIT_ALWAYS_ON

Paolo Pisati-5
BugLink: https://bugs.launchpad.net/bugs/1763644

[Impact]

The Ubuntu-4.4.0-120.144 kernel (now in -proposed) fails to boot on all arm64
hardware: no console output or any other sign of activity, the system freezes
right after the bootloader loads vmlinuz, and jumps to it.

We first experienced it on the snapdragon kernel snap in -beta (dragonboard
410c) but the bug is arm64 generic, and it affects all the arm64 hardware: a
thunderx board shows the same exact symptoms.

The regression came down as part of the 4.4.115 stable update ("79e83d1 bpf:
introduce BPF_JIT_ALWAYS_ON config") and enabled this option that crashes the
arm64 kernel on boot.

[How to test]

Apply the attached patch, recompile, install and boot.

[Regression potential]

None, since the kernel already fails to boot.

I attached the config change for generic and snapdragon.

Paolo Pisati (1):
  UBUNTU: [Config] arm64: disable BPF_JIT_ALWAYS_ON

 debian.master/config/amd64/config.common.amd64 | 1 +
 debian.master/config/arm64/config.common.arm64 | 1 +
 debian.master/config/config.common.ubuntu      | 1 -
 debian.master/config/s390x/config.common.s390x | 1 +
 4 files changed, 3 insertions(+), 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH] UBUNTU: [Config] arm64: disable BPF_JIT_ALWAYS_ON

Paolo Pisati-5
BugLink: https://bugs.launchpad.net/bugs/1763644

Signed-off-by: Paolo Pisati <[hidden email]>
---
 debian.master/config/amd64/config.common.amd64 | 1 +
 debian.master/config/arm64/config.common.arm64 | 1 +
 debian.master/config/config.common.ubuntu      | 1 -
 debian.master/config/s390x/config.common.s390x | 1 +
 4 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/debian.master/config/amd64/config.common.amd64 b/debian.master/config/amd64/config.common.amd64
index 1377cde..4717770 100644
--- a/debian.master/config/amd64/config.common.amd64
+++ b/debian.master/config/amd64/config.common.amd64
@@ -52,6 +52,7 @@ CONFIG_BLK_DEV_SKD=m
 CONFIG_BLK_DEV_SX8=m
 CONFIG_BLK_DEV_UMEM=m
 CONFIG_BOUNCE=y
+CONFIG_BPF_JIT_ALWAYS_ON=y
 CONFIG_BSD_DISKLABEL=y
 CONFIG_C2PORT=m
 CONFIG_CADENCE_WATCHDOG=m
diff --git a/debian.master/config/arm64/config.common.arm64 b/debian.master/config/arm64/config.common.arm64
index 06c6881..18f8e06 100644
--- a/debian.master/config/arm64/config.common.arm64
+++ b/debian.master/config/arm64/config.common.arm64
@@ -52,6 +52,7 @@ CONFIG_BLK_DEV_SKD=m
 CONFIG_BLK_DEV_SX8=m
 CONFIG_BLK_DEV_UMEM=m
 CONFIG_BOUNCE=y
+# CONFIG_BPF_JIT_ALWAYS_ON is not set
 CONFIG_BSD_DISKLABEL=y
 CONFIG_C2PORT=m
 CONFIG_CADENCE_WATCHDOG=m
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 408ccc3..151cd37 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -931,7 +931,6 @@ CONFIG_BOOT_PRINTK_DELAY=y
 CONFIG_BPF=y
 CONFIG_BPF_EVENTS=y
 CONFIG_BPF_JIT=y
-CONFIG_BPF_JIT_ALWAYS_ON=y
 CONFIG_BPF_SYSCALL=y
 CONFIG_BPQETHER=m
 CONFIG_BQL=y
diff --git a/debian.master/config/s390x/config.common.s390x b/debian.master/config/s390x/config.common.s390x
index b82bf27..6d64fdf 100644
--- a/debian.master/config/s390x/config.common.s390x
+++ b/debian.master/config/s390x/config.common.s390x
@@ -43,6 +43,7 @@ CONFIG_BLK_DEV_SR_VENDOR=y
 # CONFIG_BLK_DEV_SX8 is not set
 # CONFIG_BLK_DEV_UMEM is not set
 # CONFIG_BOUNCE is not set
+CONFIG_BPF_JIT_ALWAYS_ON=y
 # CONFIG_BSD_DISKLABEL is not set
 # CONFIG_C2PORT is not set
 # CONFIG_CADENCE_WATCHDOG is not set
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH] UBUNTU: [Config] arm64: disable BPF_JIT_ALWAYS_ON

Paolo Pisati-5
In reply to this post by Paolo Pisati-5
BugLink: https://bugs.launchpad.net/bugs/1763644

Signed-off-by: Paolo Pisati <[hidden email]>
---
 debian.snapdragon/config/config.common.ubuntu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian.snapdragon/config/config.common.ubuntu b/debian.snapdragon/config/config.common.ubuntu
index 7b8b7c7..7bc0e5c 100644
--- a/debian.snapdragon/config/config.common.ubuntu
+++ b/debian.snapdragon/config/config.common.ubuntu
@@ -630,7 +630,7 @@ CONFIG_BOOT_PRINTK_DELAY=y
 CONFIG_BOUNCE=y
 CONFIG_BPF=y
 CONFIG_BPF_JIT=y
-CONFIG_BPF_JIT_ALWAYS_ON=y
+# CONFIG_BPF_JIT_ALWAYS_ON is not set
 CONFIG_BPF_SYSCALL=y
 CONFIG_BPQETHER=m
 CONFIG_BQL=y
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [PATCH] [SRU] [xenial/master-next] [Config] arm64: disable BPF_JIT_ALWAYS_ON

Stefan Bader-2
In reply to this post by Paolo Pisati-5
On 13.04.2018 11:41, Paolo Pisati wrote:

> BugLink: https://bugs.launchpad.net/bugs/1763644
>
> [Impact]
>
> The Ubuntu-4.4.0-120.144 kernel (now in -proposed) fails to boot on all arm64
> hardware: no console output or any other sign of activity, the system freezes
> right after the bootloader loads vmlinuz, and jumps to it.
>
> We first experienced it on the snapdragon kernel snap in -beta (dragonboard
> 410c) but the bug is arm64 generic, and it affects all the arm64 hardware: a
> thunderx board shows the same exact symptoms.
>
> The regression came down as part of the 4.4.115 stable update ("79e83d1 bpf:
> introduce BPF_JIT_ALWAYS_ON config") and enabled this option that crashes the
> arm64 kernel on boot.
>
> [How to test]
>
> Apply the attached patch, recompile, install and boot.
>
> [Regression potential]
>
> None, since the kernel already fails to boot.
>
> I attached the config change for generic and snapdragon.
>
> Paolo Pisati (1):
>   UBUNTU: [Config] arm64: disable BPF_JIT_ALWAYS_ON
>
>  debian.master/config/amd64/config.common.amd64 | 1 +
>  debian.master/config/arm64/config.common.arm64 | 1 +
>  debian.master/config/config.common.ubuntu      | 1 -
>  debian.master/config/s390x/config.common.s390x | 1 +
>  4 files changed, 3 insertions(+), 1 deletion(-)
>
Just to double check for generic config, let us run updateconfigs after applying
the patch (slightly wondering whether it should propagate into more than just
amd64 and s390x).

-Stefan

Acked-by: Stefan Bader <[hidden email]>



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH] [SRU] [xenial/master-next] [Config] arm64: disable BPF_JIT_ALWAYS_ON

Kleber Sacilotto de Souza
In reply to this post by Paolo Pisati-5
On 04/13/18 11:41, Paolo Pisati wrote:

> BugLink: https://bugs.launchpad.net/bugs/1763644
>
> [Impact]
>
> The Ubuntu-4.4.0-120.144 kernel (now in -proposed) fails to boot on all arm64
> hardware: no console output or any other sign of activity, the system freezes
> right after the bootloader loads vmlinuz, and jumps to it.
>
> We first experienced it on the snapdragon kernel snap in -beta (dragonboard
> 410c) but the bug is arm64 generic, and it affects all the arm64 hardware: a
> thunderx board shows the same exact symptoms.
>
> The regression came down as part of the 4.4.115 stable update ("79e83d1 bpf:
> introduce BPF_JIT_ALWAYS_ON config") and enabled this option that crashes the
> arm64 kernel on boot.
>
> [How to test]
>
> Apply the attached patch, recompile, install and boot.
>
> [Regression potential]
>
> None, since the kernel already fails to boot.
>
> I attached the config change for generic and snapdragon.
>
> Paolo Pisati (1):
>   UBUNTU: [Config] arm64: disable BPF_JIT_ALWAYS_ON
>
>  debian.master/config/amd64/config.common.amd64 | 1 +
>  debian.master/config/arm64/config.common.arm64 | 1 +
>  debian.master/config/config.common.ubuntu      | 1 -
>  debian.master/config/s390x/config.common.s390x | 1 +
>  4 files changed, 3 insertions(+), 1 deletion(-)
>


Acked-by: Kleber Sacilotto de Souza <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[Xenial/linux]: [PATCH] UBUNTU: [Config] arm64: disable BPF_JIT_ALWAYS_ON

Kleber Sacilotto de Souza
In reply to this post by Paolo Pisati-5
On 04/13/18 11:41, Paolo Pisati wrote:

> BugLink: https://bugs.launchpad.net/bugs/1763644
>
> Signed-off-by: Paolo Pisati <[hidden email]>
> ---
>  debian.master/config/amd64/config.common.amd64 | 1 +
>  debian.master/config/arm64/config.common.arm64 | 1 +
>  debian.master/config/config.common.ubuntu      | 1 -
>  debian.master/config/s390x/config.common.s390x | 1 +
>  4 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/debian.master/config/amd64/config.common.amd64 b/debian.master/config/amd64/config.common.amd64
> index 1377cde..4717770 100644
> --- a/debian.master/config/amd64/config.common.amd64
> +++ b/debian.master/config/amd64/config.common.amd64
> @@ -52,6 +52,7 @@ CONFIG_BLK_DEV_SKD=m
>  CONFIG_BLK_DEV_SX8=m
>  CONFIG_BLK_DEV_UMEM=m
>  CONFIG_BOUNCE=y
> +CONFIG_BPF_JIT_ALWAYS_ON=y
>  CONFIG_BSD_DISKLABEL=y
>  CONFIG_C2PORT=m
>  CONFIG_CADENCE_WATCHDOG=m
> diff --git a/debian.master/config/arm64/config.common.arm64 b/debian.master/config/arm64/config.common.arm64
> index 06c6881..18f8e06 100644
> --- a/debian.master/config/arm64/config.common.arm64
> +++ b/debian.master/config/arm64/config.common.arm64
> @@ -52,6 +52,7 @@ CONFIG_BLK_DEV_SKD=m
>  CONFIG_BLK_DEV_SX8=m
>  CONFIG_BLK_DEV_UMEM=m
>  CONFIG_BOUNCE=y
> +# CONFIG_BPF_JIT_ALWAYS_ON is not set
>  CONFIG_BSD_DISKLABEL=y
>  CONFIG_C2PORT=m
>  CONFIG_CADENCE_WATCHDOG=m
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 408ccc3..151cd37 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -931,7 +931,6 @@ CONFIG_BOOT_PRINTK_DELAY=y
>  CONFIG_BPF=y
>  CONFIG_BPF_EVENTS=y
>  CONFIG_BPF_JIT=y
> -CONFIG_BPF_JIT_ALWAYS_ON=y
>  CONFIG_BPF_SYSCALL=y
>  CONFIG_BPQETHER=m
>  CONFIG_BQL=y
> diff --git a/debian.master/config/s390x/config.common.s390x b/debian.master/config/s390x/config.common.s390x
> index b82bf27..6d64fdf 100644
> --- a/debian.master/config/s390x/config.common.s390x
> +++ b/debian.master/config/s390x/config.common.s390x
> @@ -43,6 +43,7 @@ CONFIG_BLK_DEV_SR_VENDOR=y
>  # CONFIG_BLK_DEV_SX8 is not set
>  # CONFIG_BLK_DEV_UMEM is not set
>  # CONFIG_BOUNCE is not set
> +CONFIG_BPF_JIT_ALWAYS_ON=y
>  # CONFIG_BSD_DISKLABEL is not set
>  # CONFIG_C2PORT is not set
>  # CONFIG_CADENCE_WATCHDOG is not set
>

Applied to xenial/master-next branch.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[xenial/snapdragon]: [PATCH] UBUNTU: [Config] arm64: disable BPF_JIT_ALWAYS_ON

Kleber Sacilotto de Souza
In reply to this post by Paolo Pisati-5
On 04/13/18 11:41, Paolo Pisati wrote:

> BugLink: https://bugs.launchpad.net/bugs/1763644
>
> Signed-off-by: Paolo Pisati <[hidden email]>
> ---
>  debian.snapdragon/config/config.common.ubuntu | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debian.snapdragon/config/config.common.ubuntu b/debian.snapdragon/config/config.common.ubuntu
> index 7b8b7c7..7bc0e5c 100644
> --- a/debian.snapdragon/config/config.common.ubuntu
> +++ b/debian.snapdragon/config/config.common.ubuntu
> @@ -630,7 +630,7 @@ CONFIG_BOOT_PRINTK_DELAY=y
>  CONFIG_BOUNCE=y
>  CONFIG_BPF=y
>  CONFIG_BPF_JIT=y
> -CONFIG_BPF_JIT_ALWAYS_ON=y
> +# CONFIG_BPF_JIT_ALWAYS_ON is not set
>  CONFIG_BPF_SYSCALL=y
>  CONFIG_BPQETHER=m
>  CONFIG_BQL=y
>

Applied to xenial/snapdragon branch.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] [SRU] [xenial/master-next] [Config] arm64: disable BPF_JIT_ALWAYS_ON

Juerg Haefliger
In reply to this post by Paolo Pisati-5
On 04/13/2018 11:41 AM, Paolo Pisati wrote:

> BugLink: https://bugs.launchpad.net/bugs/1763644
>
> [Impact]
>
> The Ubuntu-4.4.0-120.144 kernel (now in -proposed) fails to boot on all arm64
> hardware: no console output or any other sign of activity, the system freezes
> right after the bootloader loads vmlinuz, and jumps to it.
>
> We first experienced it on the snapdragon kernel snap in -beta (dragonboard
> 410c) but the bug is arm64 generic, and it affects all the arm64 hardware: a
> thunderx board shows the same exact symptoms.
>
> The regression came down as part of the 4.4.115 stable update ("79e83d1 bpf:
> introduce BPF_JIT_ALWAYS_ON config") and enabled this option that crashes the
> arm64 kernel on boot.
Is upstream aware of this problem?

...Juerg

> [How to test]
>
> Apply the attached patch, recompile, install and boot.
>
> [Regression potential]
>
> None, since the kernel already fails to boot.
>
> I attached the config change for generic and snapdragon.
>
> Paolo Pisati (1):
>   UBUNTU: [Config] arm64: disable BPF_JIT_ALWAYS_ON
>
>  debian.master/config/amd64/config.common.amd64 | 1 +
>  debian.master/config/arm64/config.common.arm64 | 1 +
>  debian.master/config/config.common.ubuntu      | 1 -
>  debian.master/config/s390x/config.common.s390x | 1 +
>  4 files changed, 3 insertions(+), 1 deletion(-)
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (817 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] [SRU] [xenial/master-next] [Config] arm64: disable BPF_JIT_ALWAYS_ON

Paolo Pisati-5
On Mon, Apr 16, 2018 at 9:14 AM, Juerg Haefliger
<[hidden email]> wrote:

> On 04/13/2018 11:41 AM, Paolo Pisati wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1763644
>>
>> [Impact]
>>
>> The Ubuntu-4.4.0-120.144 kernel (now in -proposed) fails to boot on all arm64
>> hardware: no console output or any other sign of activity, the system freezes
>> right after the bootloader loads vmlinuz, and jumps to it.
>>
>> We first experienced it on the snapdragon kernel snap in -beta (dragonboard
>> 410c) but the bug is arm64 generic, and it affects all the arm64 hardware: a
>> thunderx board shows the same exact symptoms.
>>
>> The regression came down as part of the 4.4.115 stable update ("79e83d1 bpf:
>> introduce BPF_JIT_ALWAYS_ON config") and enabled this option that crashes the
>> arm64 kernel on boot.
>
> Is upstream aware of this problem?

No, because the vanilla arm64 defconfig doesn't trigger it: so it's
either some patch we carry in -generic, or our ubuntu config, and i'm
still trying to figure it out.

--
bye,
p.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team