[PATCH] UBUNTU: Karmic: Fix comments in the postinst script

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] UBUNTU: Karmic: Fix comments in the postinst script

Amit Kucheria-6
Very sharp-eyed reporter actual read through that script and caught a bug in the
comments. Soft-links and Hard-links now have the correct corresponding comments.

Bug: #305861

Signed-off-by: Amit Kucheria <[hidden email]>
---
 debian/control-scripts/postinst |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/debian/control-scripts/postinst b/debian/control-scripts/postinst
index 3c1c13c..9295195 100644
--- a/debian/control-scripts/postinst
+++ b/debian/control-scripts/postinst
@@ -365,14 +365,14 @@ sub really_reverse_link {
 
   if ($use_hard_links =~ m/YES/i) {
     link($Old . "$link_name", $src_dir . "$link_name") ||
-      die("Failed to symbolic-link " . $dest_dir . "$link_name to " . $src_dir
-          . "$link_name .\n");
+      die("Failed to link " . $dest_dir . "$link_name to " . $src_dir .
+          "$link_name .\n");
     warn "ln " . $Old . "$link_name " . $src_dir . "$link_name"  if $DEBUG;
   }
   else {
     symlink($Old . "$link_name", $src_dir . "$link_name") ||
-      die("Failed to link " . $dest_dir . "$link_name to " . $src_dir .
-          "$link_name .\n");
+      die("Failed to symbolic-link " . $dest_dir . "$link_name to " . $src_dir
+          . "$link_name .\n");
     warn "ln -s " . $Old . "$link_name " . $src_dir . "$link_name" if $DEBUG;
   }
 }
--
1.6.0.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] UBUNTU: Karmic: Fix comments in the postinst script

Tim Gardner-2
Amit Kucheria wrote:

> Very sharp-eyed reporter actual read through that script and caught a bug in the
> comments. Soft-links and Hard-links now have the correct corresponding comments.
>
> Bug: #305861
>
> Signed-off-by: Amit Kucheria <[hidden email]>
> ---
>  debian/control-scripts/postinst |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/debian/control-scripts/postinst b/debian/control-scripts/postinst
> index 3c1c13c..9295195 100644
> --- a/debian/control-scripts/postinst
> +++ b/debian/control-scripts/postinst
> @@ -365,14 +365,14 @@ sub really_reverse_link {
>  
>    if ($use_hard_links =~ m/YES/i) {
>      link($Old . "$link_name", $src_dir . "$link_name") ||
> -      die("Failed to symbolic-link " . $dest_dir . "$link_name to " . $src_dir
> -          . "$link_name .\n");
> +      die("Failed to link " . $dest_dir . "$link_name to " . $src_dir .
> +          "$link_name .\n");
>      warn "ln " . $Old . "$link_name " . $src_dir . "$link_name"  if $DEBUG;
>    }
>    else {
>      symlink($Old . "$link_name", $src_dir . "$link_name") ||
> -      die("Failed to link " . $dest_dir . "$link_name to " . $src_dir .
> -          "$link_name .\n");
> +      die("Failed to symbolic-link " . $dest_dir . "$link_name to " . $src_dir
> +          . "$link_name .\n");
>      warn "ln -s " . $Old . "$link_name " . $src_dir . "$link_name" if $DEBUG;
>    }
>  }

ACK

--
Tim Gardner [hidden email]

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] UBUNTU: Karmic: Fix comments in the postinst script

Tim Gardner-2
Tim Gardner wrote:

> Amit Kucheria wrote:
>> Very sharp-eyed reporter actual read through that script and caught a bug in the
>> comments. Soft-links and Hard-links now have the correct corresponding comments.
>>
>> Bug: #305861
>>
>> Signed-off-by: Amit Kucheria <[hidden email]>
>> ---
>>  debian/control-scripts/postinst |    8 ++++----
>>  1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/debian/control-scripts/postinst b/debian/control-scripts/postinst
>> index 3c1c13c..9295195 100644
>> --- a/debian/control-scripts/postinst
>> +++ b/debian/control-scripts/postinst
>> @@ -365,14 +365,14 @@ sub really_reverse_link {
>>  
>>    if ($use_hard_links =~ m/YES/i) {
>>      link($Old . "$link_name", $src_dir . "$link_name") ||
>> -      die("Failed to symbolic-link " . $dest_dir . "$link_name to " . $src_dir
>> -          . "$link_name .\n");
>> +      die("Failed to link " . $dest_dir . "$link_name to " . $src_dir .
>> +          "$link_name .\n");
>>      warn "ln " . $Old . "$link_name " . $src_dir . "$link_name"  if $DEBUG;
>>    }
>>    else {
>>      symlink($Old . "$link_name", $src_dir . "$link_name") ||
>> -      die("Failed to link " . $dest_dir . "$link_name to " . $src_dir .
>> -          "$link_name .\n");
>> +      die("Failed to symbolic-link " . $dest_dir . "$link_name to " . $src_dir
>> +          . "$link_name .\n");
>>      warn "ln -s " . $Old . "$link_name " . $src_dir . "$link_name" if $DEBUG;
>>    }
>>  }
>
> ACK
>

pushed

--
Tim Gardner [hidden email]

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team