[PATCH V3 0/2][SRU][OEM-OSP1-B] drm/i915/fbc: disable framebuffer compression on IceLake

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH V3 0/2][SRU][OEM-OSP1-B] drm/i915/fbc: disable framebuffer compression on IceLake

You-Sheng Yang
BugLink: https://bugs.launchpad.net/bugs/1840236

[Impact]
On IceLake platforms there might be a thin, horizon strap of corruption
image at the top of screen randomly after some series of window
operations and disappears within a second or so. This is found on
multiple platforms and is quite annonying that results in bad user
experience.

[Fix]
The upstream bug has been filed for previous platforms, e.g. GeminiLake
for an year or so, still working in progress, and so far this only known
work-around is to turn off framebuffer compression on affected platforms.

[Test Case]
The most easy way is to observe if such corruption appears during the
transition from GDM to gnome-shell. Verified on pre-launch ICL
platforms.

[Regression Risk]
Low. The work-around for GeminiLake was landed to Linux stable 4.14.125
and has been backported to B/D.

Daniel Drake (1):
  drm/i915/fbc: disable framebuffer compression on GeminiLake

You-Sheng Yang (1):
  UBUNTU: SAUCE: drm/i915/fbc: disable framebuffer compression on
    IceLake

 drivers/gpu/drm/i915/intel_fbc.c | 5 +++++
 1 file changed, 5 insertions(+)

--
2.23.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH V3 1/2][SRU][OEM-OSP1-B] drm/i915/fbc: disable framebuffer compression on GeminiLake

You-Sheng Yang
From: Daniel Drake <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1840236

On many (all?) the Gemini Lake systems we work with, there is frequent
momentary graphical corruption at the top of the screen, and it seems
that disabling framebuffer compression can avoid this.

The ticket was reported 6 months ago and has already affected a
multitude of users, without any real progress being made. So, lets
disable framebuffer compression on GeminiLake until a solution is found.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108085
Fixes: fd7d6c5c8f3e ("drm/i915: enable FBC on gen9+ too")
Cc: Paulo Zanoni <[hidden email]>
Cc: Daniel Vetter <[hidden email]>
Cc: Jani Nikula <[hidden email]>
Cc: <[hidden email]> # v4.11+
Reviewed-by: Paulo Zanoni <[hidden email]>
Signed-off-by: Daniel Drake <[hidden email]>
Signed-off-by: Jian-Hong Pan <[hidden email]>
Signed-off-by: Jani Nikula <[hidden email]>
Link: https://patchwork.freedesktop.org/patch/msgid/20190423092810.28359-1-jian-hong@...
(cherry picked from commit 1d25724b41fad7eeb2c3058a5c8190d6ece73e08)
Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/gpu/drm/i915/intel_fbc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 8b9c92e80715b..6d3c5057b2413 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -1279,6 +1279,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
  if (!HAS_FBC(dev_priv))
  return 0;
 
+ /* https://bugs.freedesktop.org/show_bug.cgi?id=108085 */
+ if (IS_GEMINILAKE(dev_priv))
+ return 0;
+
  if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9)
  return 1;
 
--
2.23.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH V3 2/2][SRU][OEM-OSP1-B] UBUNTU: SAUCE: drm/i915/fbc: disable framebuffer compression on IceLake

You-Sheng Yang
In reply to this post by You-Sheng Yang
BugLink: https://bugs.launchpad.net/bugs/1840236

This is the same thing to commit
edf87a92e112ede83916155a156e41787ea11186 but found on IceLake platforms
as well.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111484
Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/gpu/drm/i915/intel_fbc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 6d3c5057b2413..8babbd3e3459a 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -1280,7 +1280,8 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
  return 0;
 
  /* https://bugs.freedesktop.org/show_bug.cgi?id=108085 */
- if (IS_GEMINILAKE(dev_priv))
+ /* https://bugs.freedesktop.org/show_bug.cgi?id=111484 */
+ if (IS_GEMINILAKE(dev_priv) || IS_ICELAKE(dev_priv))
  return 0;
 
  if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9)
--
2.23.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED Re: [PATCH V3 0/2][SRU][OEM-OSP1-B] drm/i915/fbc: disable framebuffer compression on IceLake

Timo Aaltonen-6
In reply to this post by You-Sheng Yang
On 6.9.2019 12.47, You-Sheng Yang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1840236
>
> [Impact]
> On IceLake platforms there might be a thin, horizon strap of corruption
> image at the top of screen randomly after some series of window
> operations and disappears within a second or so. This is found on
> multiple platforms and is quite annonying that results in bad user
> experience.
>
> [Fix]
> The upstream bug has been filed for previous platforms, e.g. GeminiLake
> for an year or so, still working in progress, and so far this only known
> work-around is to turn off framebuffer compression on affected platforms.
>
> [Test Case]
> The most easy way is to observe if such corruption appears during the
> transition from GDM to gnome-shell. Verified on pre-launch ICL
> platforms.
>
> [Regression Risk]
> Low. The work-around for GeminiLake was landed to Linux stable 4.14.125
> and has been backported to B/D.
>
> Daniel Drake (1):
>   drm/i915/fbc: disable framebuffer compression on GeminiLake
>
> You-Sheng Yang (1):
>   UBUNTU: SAUCE: drm/i915/fbc: disable framebuffer compression on
>     IceLake
>
>  drivers/gpu/drm/i915/intel_fbc.c | 5 +++++
>  1 file changed, 5 insertions(+)
>

the first commit was already inherited from disco, but the other was got
applied to oem-next, thanks

--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team