[PATCH] ubuntu_kernel_selftests: fix libnuma-dev install for s390x

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] ubuntu_kernel_selftests: fix libnuma-dev install for s390x

Kleber Sacilotto de Souza
After commit 27a538cb64541c30cfb0b1e9cc42e1d03d0f5e30
(ubuntu_kernel_selftests: net tests require libnuma-dev), all
ubuntu_kernel_selftests are failing for s390x on series earlier than
Yakkety, since libnuma-dev is being built only from this series on.

Fix it by not installing the package when running older series on s390x.
Net tests are expected to continue failing though.

Signed-off-by: Kleber Sacilotto de Souza <[hidden email]>
---
 ubuntu_kernel_selftests/ubuntu_kernel_selftests.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
index 30e045df..2910fe29 100644
--- a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
+++ b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
@@ -12,8 +12,10 @@ class ubuntu_kernel_selftests(test.test):
         series = platform.dist()[2]
 
         pkgs = [
-            'build-essential', 'git', 'libnuma-dev'
+            'build-essential', 'git'
         ]
+        if not (arch == 's390x' and series in ['precise', 'trusty', 'vivid', 'xenial']):
+            pkgs.append('libnuma-dev')
         gcc = 'gcc' if arch in ['ppc64le', 'aarch64', 's390x'] else 'gcc-multilib'
         pkgs.append(gcc)
 
--
2.11.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

ACK: [PATCH] ubuntu_kernel_selftests: fix libnuma-dev install for s390x

Colin Ian King-2
On 21/04/17 10:46, Kleber Sacilotto de Souza wrote:

> After commit 27a538cb64541c30cfb0b1e9cc42e1d03d0f5e30
> (ubuntu_kernel_selftests: net tests require libnuma-dev), all
> ubuntu_kernel_selftests are failing for s390x on series earlier than
> Yakkety, since libnuma-dev is being built only from this series on.
>
> Fix it by not installing the package when running older series on s390x.
> Net tests are expected to continue failing though.
>
> Signed-off-by: Kleber Sacilotto de Souza <[hidden email]>
> ---
>  ubuntu_kernel_selftests/ubuntu_kernel_selftests.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
> index 30e045df..2910fe29 100644
> --- a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
> +++ b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
> @@ -12,8 +12,10 @@ class ubuntu_kernel_selftests(test.test):
>          series = platform.dist()[2]
>  
>          pkgs = [
> -            'build-essential', 'git', 'libnuma-dev'
> +            'build-essential', 'git'
>          ]
> +        if not (arch == 's390x' and series in ['precise', 'trusty', 'vivid', 'xenial']):
> +            pkgs.append('libnuma-dev')
>          gcc = 'gcc' if arch in ['ppc64le', 'aarch64', 's390x'] else 'gcc-multilib'
>          pkgs.append(gcc)
>  
>
Seems like a suitable hack^H^H^H^H workaround to resolve this issue

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

ACK/cmnt: [PATCH] ubuntu_kernel_selftests: fix libnuma-dev install for s390x

Stefan Bader-2
In reply to this post by Kleber Sacilotto de Souza
On 21.04.2017 11:46, Kleber Sacilotto de Souza wrote:

> After commit 27a538cb64541c30cfb0b1e9cc42e1d03d0f5e30
> (ubuntu_kernel_selftests: net tests require libnuma-dev), all
> ubuntu_kernel_selftests are failing for s390x on series earlier than
> Yakkety, since libnuma-dev is being built only from this series on.
>
> Fix it by not installing the package when running older series on s390x.
> Net tests are expected to continue failing though.
>
> Signed-off-by: Kleber Sacilotto de Souza <[hidden email]>
> ---
>  ubuntu_kernel_selftests/ubuntu_kernel_selftests.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
> index 30e045df..2910fe29 100644
> --- a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
> +++ b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
> @@ -12,8 +12,10 @@ class ubuntu_kernel_selftests(test.test):
>          series = platform.dist()[2]
>  
>          pkgs = [
> -            'build-essential', 'git', 'libnuma-dev'
> +            'build-essential', 'git'
>          ]
> +        if not (arch == 's390x' and series in ['precise', 'trusty', 'vivid', 'xenial']):
> +            pkgs.append('libnuma-dev')
Strictly speaking there is no s390x before Xenial but that is ok.

-Stefan

>          gcc = 'gcc' if arch in ['ppc64le', 'aarch64', 's390x'] else 'gcc-multilib'
>          pkgs.append(gcc)
>  
>



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Applied: [PATCH] ubuntu_kernel_selftests: fix libnuma-dev install for s390x

brad.figg
In reply to this post by Kleber Sacilotto de Souza
Loading...