[PATCH v2 0/2][SRU][C][D][E]AX88772A USB to Ethernet dongle doesn't work

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 0/2][SRU][C][D][E]AX88772A USB to Ethernet dongle doesn't work

AceLan Kao
BugLink: https://bugs.launchpad.net/bugs/1834114

[Impact]
There are 2 asix drivers in the kernel, they are drivers/net/usb/asix
and drivers/net/phy/asix. It leads to the compilation race condition
that one overwrites the other asix.mod in .tmp_version directory.
This affects the USB dongle if the "phy" one wins.

T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 7 Spd=480 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=00 MxPS=64 #Cfgs= 1
P: Vendor=0b95 ProdID=7720 Rev=00.01
S: Manufacturer=ASIX Elec. Corp.
S: Product=AX88772A
S: SerialNumber=000527
C: #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=250mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=00 Driver=asix

[Fix]
The same name asix has been introduced since v4.18-rc1 by this commit
   31dd83b96641 net-next: phy: new Asix Electronics PHY driver
the new commit fix this issue by renaming it
   a9520543b123 net: phy: rename Asix Electronics PHY driver

[Test]
Verified on my own ASIX USB Ethernet dongle.

[Regression Potential]
Low, it only rename the module name, no code change.

AceLan Kao (1):
  UBUNTU: [Config] update configs and annotations for ASIX renamed

Michael Schmitz (1):
  net: phy: rename Asix Electronics PHY driver

 debian.master/abi/5.0.0-19.20/amd64/generic.modules      | 1 +
 debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules   | 1 +
 debian.master/abi/5.0.0-19.20/arm64/generic.modules      | 1 +
 debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules | 1 +
 debian.master/abi/5.0.0-19.20/armhf/generic.modules      | 1 +
 debian.master/abi/5.0.0-19.20/i386/generic.modules       | 1 +
 debian.master/abi/5.0.0-19.20/i386/lowlatency.modules    | 1 +
 debian.master/abi/5.0.0-19.20/ppc64el/generic.modules    | 1 +
 debian.master/abi/5.0.0-19.20/s390x/generic.modules      | 1 +
 debian.master/config/annotations                         | 2 +-
 debian.master/config/config.common.ubuntu                | 2 +-
 drivers/net/ethernet/8390/Kconfig                        | 2 +-
 drivers/net/phy/Kconfig                                  | 2 +-
 drivers/net/phy/Makefile                                 | 2 +-
 drivers/net/phy/{asix.c => ax88796b.c}                   | 0
 15 files changed, 14 insertions(+), 5 deletions(-)
 rename drivers/net/phy/{asix.c => ax88796b.c} (100%)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 1/2][SRU][C][D][E] net: phy: rename Asix Electronics PHY driver

AceLan Kao
From: Michael Schmitz <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1834114

[Resent to net instead of net-next - may clash with Anders Roxell's patch
series addressing duplicate module names]

Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver")
introduced a new PHY driver drivers/net/phy/asix.c that causes a module
name conflict with a pre-existiting driver (drivers/net/usb/asix.c).

The PHY driver is used by the X-Surf 100 ethernet card driver, and loaded
by that driver via its PHY ID. A rename of the driver looks unproblematic.

Rename PHY driver to ax88796b.c in order to resolve name conflict.

Signed-off-by: Michael Schmitz <[hidden email]>
Tested-by: Michael Schmitz <[hidden email]>
Fixes: 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver")
Reviewed-by: Andrew Lunn <[hidden email]>
Signed-off-by: David S. Miller <[hidden email]>
(cherry picked from commit a9520543b123bbd7275a0ab8d0375a5412683b41)
Signed-off-by: AceLan Kao <[hidden email]>
---
 drivers/net/ethernet/8390/Kconfig      | 2 +-
 drivers/net/phy/Kconfig                | 2 +-
 drivers/net/phy/Makefile               | 2 +-
 drivers/net/phy/{asix.c => ax88796b.c} | 0
 4 files changed, 3 insertions(+), 3 deletions(-)
 rename drivers/net/phy/{asix.c => ax88796b.c} (100%)

diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig
index f2f0264c58ba..443b34e2725f 100644
--- a/drivers/net/ethernet/8390/Kconfig
+++ b/drivers/net/ethernet/8390/Kconfig
@@ -49,7 +49,7 @@ config XSURF100
  tristate "Amiga XSurf 100 AX88796/NE2000 clone support"
  depends on ZORRO
  select AX88796
- select ASIX_PHY
+ select AX88796B_PHY
  help
   This driver is for the Individual Computers X-Surf 100 Ethernet
   card (based on the Asix AX88796 chip). If you have such a card,
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 3d187cd50eb0..5f7c2af31a25 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -227,7 +227,7 @@ config AQUANTIA_PHY
  ---help---
   Currently supports the Aquantia AQ1202, AQ2104, AQR105, AQR405
 
-config ASIX_PHY
+config AX88796B_PHY
  tristate "Asix PHYs"
  help
   Currently supports the Asix Electronics PHY found in the X-Surf 100
diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
index 5805c0b7d60e..f21cda9d865e 100644
--- a/drivers/net/phy/Makefile
+++ b/drivers/net/phy/Makefile
@@ -46,7 +46,7 @@ obj-y += $(sfp-obj-y) $(sfp-obj-m)
 
 obj-$(CONFIG_AMD_PHY) += amd.o
 obj-$(CONFIG_AQUANTIA_PHY) += aquantia.o
-obj-$(CONFIG_ASIX_PHY) += asix.o
+obj-$(CONFIG_AX88796B_PHY) += ax88796b.o
 obj-$(CONFIG_AT803X_PHY) += at803x.o
 obj-$(CONFIG_BCM63XX_PHY) += bcm63xx.o
 obj-$(CONFIG_BCM7XXX_PHY) += bcm7xxx.o
diff --git a/drivers/net/phy/asix.c b/drivers/net/phy/ax88796b.c
similarity index 100%
rename from drivers/net/phy/asix.c
rename to drivers/net/phy/ax88796b.c
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 2/2][SRU][D][E] UBUNTU: [Config] update configs and annotations for ASIX renamed

AceLan Kao
In reply to this post by AceLan Kao
BugLink: https://bugs.launchpad.net/bugs/1834114

Below commit rename the asix.ko module in net/phy to ax88796b.ko,
so update configs and annotations, too.
   net: phy: rename Asix Electronics PHY driver
And also update modules in debian.master/abi/*/*/*.modules files.

Signed-off-by: AceLan Kao <[hidden email]>
---
 debian.master/abi/5.0.0-19.20/amd64/generic.modules      | 1 +
 debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules   | 1 +
 debian.master/abi/5.0.0-19.20/arm64/generic.modules      | 1 +
 debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules | 1 +
 debian.master/abi/5.0.0-19.20/armhf/generic.modules      | 1 +
 debian.master/abi/5.0.0-19.20/i386/generic.modules       | 1 +
 debian.master/abi/5.0.0-19.20/i386/lowlatency.modules    | 1 +
 debian.master/abi/5.0.0-19.20/ppc64el/generic.modules    | 1 +
 debian.master/abi/5.0.0-19.20/s390x/generic.modules      | 1 +
 debian.master/config/annotations                         | 2 +-
 debian.master/config/config.common.ubuntu                | 2 +-
 11 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/debian.master/abi/5.0.0-19.20/amd64/generic.modules b/debian.master/abi/5.0.0-19.20/amd64/generic.modules
index 45c0324faded..8b659ede0742 100644
--- a/debian.master/abi/5.0.0-19.20/amd64/generic.modules
+++ b/debian.master/abi/5.0.0-19.20/amd64/generic.modules
@@ -449,6 +449,7 @@ avma1_cs
 avmfritz
 ax25
 ax88179_178a
+ax88796b
 axnet_cs
 axp20x
 axp20x-i2c
diff --git a/debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules b/debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules
index 7adf155aab94..d3c6dc8f3ecf 100644
--- a/debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules
+++ b/debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules
@@ -449,6 +449,7 @@ avma1_cs
 avmfritz
 ax25
 ax88179_178a
+ax88796b
 axnet_cs
 axp20x
 axp20x-i2c
diff --git a/debian.master/abi/5.0.0-19.20/arm64/generic.modules b/debian.master/abi/5.0.0-19.20/arm64/generic.modules
index 4dd355cd676d..5909e6258aba 100644
--- a/debian.master/abi/5.0.0-19.20/arm64/generic.modules
+++ b/debian.master/abi/5.0.0-19.20/arm64/generic.modules
@@ -432,6 +432,7 @@ autofs4
 avmfritz
 ax25
 ax88179_178a
+ax88796b
 axis-fifo
 axp20x
 axp20x-i2c
diff --git a/debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules b/debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules
index a220950cde14..31a7e218985f 100644
--- a/debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules
+++ b/debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules
@@ -428,6 +428,7 @@ avmfritz
 ax25
 ax88179_178a
 ax88796
+ax88796b
 axis-fifo
 axp20x
 axp20x-i2c
diff --git a/debian.master/abi/5.0.0-19.20/armhf/generic.modules b/debian.master/abi/5.0.0-19.20/armhf/generic.modules
index c48c977909b9..defd22ef93b9 100644
--- a/debian.master/abi/5.0.0-19.20/armhf/generic.modules
+++ b/debian.master/abi/5.0.0-19.20/armhf/generic.modules
@@ -429,6 +429,7 @@ avmfritz
 ax25
 ax88179_178a
 ax88796
+ax88796b
 axis-fifo
 axp20x
 axp20x-i2c
diff --git a/debian.master/abi/5.0.0-19.20/i386/generic.modules b/debian.master/abi/5.0.0-19.20/i386/generic.modules
index fe4cce766110..8f5bff9ef6b9 100644
--- a/debian.master/abi/5.0.0-19.20/i386/generic.modules
+++ b/debian.master/abi/5.0.0-19.20/i386/generic.modules
@@ -456,6 +456,7 @@ avma1_cs
 avmfritz
 ax25
 ax88179_178a
+ax88796b
 axnet_cs
 axp20x
 axp20x-i2c
diff --git a/debian.master/abi/5.0.0-19.20/i386/lowlatency.modules b/debian.master/abi/5.0.0-19.20/i386/lowlatency.modules
index de88a5ae7b80..cdf5c2fa6127 100644
--- a/debian.master/abi/5.0.0-19.20/i386/lowlatency.modules
+++ b/debian.master/abi/5.0.0-19.20/i386/lowlatency.modules
@@ -456,6 +456,7 @@ avma1_cs
 avmfritz
 ax25
 ax88179_178a
+ax88796b
 axnet_cs
 axp20x
 axp20x-i2c
diff --git a/debian.master/abi/5.0.0-19.20/ppc64el/generic.modules b/debian.master/abi/5.0.0-19.20/ppc64el/generic.modules
index 84f9be593cef..c4f55724fbd2 100644
--- a/debian.master/abi/5.0.0-19.20/ppc64el/generic.modules
+++ b/debian.master/abi/5.0.0-19.20/ppc64el/generic.modules
@@ -404,6 +404,7 @@ autofs4
 avmfritz
 ax25
 ax88179_178a
+ax88796b
 axis-fifo
 axp20x
 axp20x-i2c
diff --git a/debian.master/abi/5.0.0-19.20/s390x/generic.modules b/debian.master/abi/5.0.0-19.20/s390x/generic.modules
index 6081d35c13eb..4411fe38e7fd 100644
--- a/debian.master/abi/5.0.0-19.20/s390x/generic.modules
+++ b/debian.master/abi/5.0.0-19.20/s390x/generic.modules
@@ -62,6 +62,7 @@ aufs
 auth_rpcgss
 authenc
 authencesn
+ax88796b
 bcache
 bcm-phy-lib
 bcm7xxx
diff --git a/debian.master/config/annotations b/debian.master/config/annotations
index 008ead6f697c..fcd170365f01 100644
--- a/debian.master/config/annotations
+++ b/debian.master/config/annotations
@@ -5587,7 +5587,7 @@ CONFIG_LED_TRIGGER_PHY                          policy<{'amd64': 'y', 'arm64': '
 CONFIG_SFP                                      policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm'}>
 CONFIG_AMD_PHY                                  policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
 CONFIG_AQUANTIA_PHY                             policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
-CONFIG_ASIX_PHY                                 policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
+CONFIG_AX88796B_PHY                             policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
 CONFIG_AT803X_PHY                               policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
 CONFIG_BCM7XXX_PHY                              policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
 CONFIG_BCM87XX_PHY                              policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index df275aa4a69d..810d4fc3b18a 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -719,7 +719,6 @@ CONFIG_ARM_VEXPRESS_SPC_CPUFREQ=m
 CONFIG_ARM_VIRT_EXT=y
 CONFIG_AS3935=m
 CONFIG_ASHMEM=m
-CONFIG_ASIX_PHY=m
 CONFIG_ASN1=y
 CONFIG_ASSOCIATIVE_ARRAY=y
 CONFIG_ASUS_LAPTOP=m
@@ -861,6 +860,7 @@ CONFIG_AUTO_ZRELADDR=y
 CONFIG_AX25=m
 CONFIG_AX25_DAMA_SLAVE=y
 CONFIG_AX88796=m
+CONFIG_AX88796B_PHY=m
 # CONFIG_AX88796_93CX6 is not set
 CONFIG_AXP20X_ADC=m
 CONFIG_AXP20X_POWER=m
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 2/2][SRU][C] UBUNTU: [Config] update configs and annotations for ASIX renamed

AceLan Kao
In reply to this post by AceLan Kao
BugLink: https://bugs.launchpad.net/bugs/1834114

Below commit rename the asix.ko module in net/phy to ax88796b.ko,
so update configs and annotations, too.
   net: phy: rename Asix Electronics PHY driver
And also update modules in debian.master/abi/*/*/*.modules files.

Signed-off-by: AceLan Kao <[hidden email]>
---
 debian.master/abi/4.18.0-24.25/amd64/generic.modules      | 1 +
 debian.master/abi/4.18.0-24.25/amd64/lowlatency.modules   | 1 +
 debian.master/abi/4.18.0-24.25/arm64/generic.modules      | 1 +
 debian.master/abi/4.18.0-24.25/armhf/generic-lpae.modules | 1 +
 debian.master/abi/4.18.0-24.25/armhf/generic.modules      | 1 +
 debian.master/abi/4.18.0-24.25/i386/generic.modules       | 1 +
 debian.master/abi/4.18.0-24.25/i386/lowlatency.modules    | 1 +
 debian.master/abi/4.18.0-24.25/ppc64el/generic.modules    | 1 +
 debian.master/abi/4.18.0-24.25/s390x/generic.modules      | 1 +
 debian.master/config/annotations                          | 2 +-
 debian.master/config/config.common.ubuntu                 | 2 +-
 11 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/debian.master/abi/4.18.0-24.25/amd64/generic.modules b/debian.master/abi/4.18.0-24.25/amd64/generic.modules
index 288359877c79..7a3c390a2836 100644
--- a/debian.master/abi/4.18.0-24.25/amd64/generic.modules
+++ b/debian.master/abi/4.18.0-24.25/amd64/generic.modules
@@ -434,6 +434,7 @@ avma1_cs
 avmfritz
 ax25
 ax88179_178a
+ax88796b
 axnet_cs
 axp20x
 axp20x-i2c
diff --git a/debian.master/abi/4.18.0-24.25/amd64/lowlatency.modules b/debian.master/abi/4.18.0-24.25/amd64/lowlatency.modules
index 7547da9a402f..7a3d682e1eef 100644
--- a/debian.master/abi/4.18.0-24.25/amd64/lowlatency.modules
+++ b/debian.master/abi/4.18.0-24.25/amd64/lowlatency.modules
@@ -434,6 +434,7 @@ avma1_cs
 avmfritz
 ax25
 ax88179_178a
+ax88796b
 axnet_cs
 axp20x
 axp20x-i2c
diff --git a/debian.master/abi/4.18.0-24.25/arm64/generic.modules b/debian.master/abi/4.18.0-24.25/arm64/generic.modules
index b31e43f96c81..305a60f9c886 100644
--- a/debian.master/abi/4.18.0-24.25/arm64/generic.modules
+++ b/debian.master/abi/4.18.0-24.25/arm64/generic.modules
@@ -420,6 +420,7 @@ autofs4
 avmfritz
 ax25
 ax88179_178a
+ax88796b
 axp20x
 axp20x-i2c
 axp20x-pek
diff --git a/debian.master/abi/4.18.0-24.25/armhf/generic-lpae.modules b/debian.master/abi/4.18.0-24.25/armhf/generic-lpae.modules
index 27d003dfe984..d6beb956b350 100644
--- a/debian.master/abi/4.18.0-24.25/armhf/generic-lpae.modules
+++ b/debian.master/abi/4.18.0-24.25/armhf/generic-lpae.modules
@@ -416,6 +416,7 @@ avmfritz
 ax25
 ax88179_178a
 ax88796
+ax88796b
 axp20x
 axp20x-i2c
 axp20x-pek
diff --git a/debian.master/abi/4.18.0-24.25/armhf/generic.modules b/debian.master/abi/4.18.0-24.25/armhf/generic.modules
index 4754594071aa..b752ecf6fe00 100644
--- a/debian.master/abi/4.18.0-24.25/armhf/generic.modules
+++ b/debian.master/abi/4.18.0-24.25/armhf/generic.modules
@@ -417,6 +417,7 @@ avmfritz
 ax25
 ax88179_178a
 ax88796
+ax88796b
 axp20x
 axp20x-i2c
 axp20x-pek
diff --git a/debian.master/abi/4.18.0-24.25/i386/generic.modules b/debian.master/abi/4.18.0-24.25/i386/generic.modules
index e359e5eb513f..eb32ddb11756 100644
--- a/debian.master/abi/4.18.0-24.25/i386/generic.modules
+++ b/debian.master/abi/4.18.0-24.25/i386/generic.modules
@@ -444,6 +444,7 @@ avma1_cs
 avmfritz
 ax25
 ax88179_178a
+ax88796b
 axnet_cs
 axp20x
 axp20x-i2c
diff --git a/debian.master/abi/4.18.0-24.25/i386/lowlatency.modules b/debian.master/abi/4.18.0-24.25/i386/lowlatency.modules
index 35ace5cfacca..d7a1b2720ec4 100644
--- a/debian.master/abi/4.18.0-24.25/i386/lowlatency.modules
+++ b/debian.master/abi/4.18.0-24.25/i386/lowlatency.modules
@@ -444,6 +444,7 @@ avma1_cs
 avmfritz
 ax25
 ax88179_178a
+ax88796b
 axnet_cs
 axp20x
 axp20x-i2c
diff --git a/debian.master/abi/4.18.0-24.25/ppc64el/generic.modules b/debian.master/abi/4.18.0-24.25/ppc64el/generic.modules
index 175d221dd6f0..0ea59f7b9483 100644
--- a/debian.master/abi/4.18.0-24.25/ppc64el/generic.modules
+++ b/debian.master/abi/4.18.0-24.25/ppc64el/generic.modules
@@ -392,6 +392,7 @@ autofs4
 avmfritz
 ax25
 ax88179_178a
+ax88796b
 axp20x
 axp20x-i2c
 axp20x-pek
diff --git a/debian.master/abi/4.18.0-24.25/s390x/generic.modules b/debian.master/abi/4.18.0-24.25/s390x/generic.modules
index 859e5198a80a..35fa10bc79d6 100644
--- a/debian.master/abi/4.18.0-24.25/s390x/generic.modules
+++ b/debian.master/abi/4.18.0-24.25/s390x/generic.modules
@@ -60,6 +60,7 @@ aufs
 auth_rpcgss
 authenc
 authencesn
+ax88796b
 bcache
 bcm-phy-lib
 bcm7xxx
diff --git a/debian.master/config/annotations b/debian.master/config/annotations
index 8ab8dc45cdcb..894004ef04be 100644
--- a/debian.master/config/annotations
+++ b/debian.master/config/annotations
@@ -5633,7 +5633,7 @@ CONFIG_LED_TRIGGER_PHY                          policy<{'amd64': 'y', 'arm64': '
 CONFIG_SFP                                      policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm'}>
 CONFIG_AMD_PHY                                  policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
 CONFIG_AQUANTIA_PHY                             policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
-CONFIG_ASIX_PHY                                 policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
+CONFIG_AX88796B_PHY                             policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
 CONFIG_AT803X_PHY                               policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
 CONFIG_BCM7XXX_PHY                              policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
 CONFIG_BCM87XX_PHY                              policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 5ec75a9d680d..c673317afe5d 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -692,7 +692,6 @@ CONFIG_ARM_UNWIND=y
 CONFIG_ARM_VEXPRESS_SPC_CPUFREQ=m
 CONFIG_ARM_VIRT_EXT=y
 CONFIG_AS3935=m
-CONFIG_ASIX_PHY=m
 CONFIG_ASN1=y
 CONFIG_ASSOCIATIVE_ARRAY=y
 CONFIG_ASUS_LAPTOP=m
@@ -835,6 +834,7 @@ CONFIG_AUTO_ZRELADDR=y
 CONFIG_AX25=m
 CONFIG_AX25_DAMA_SLAVE=y
 CONFIG_AX88796=m
+CONFIG_AX88796B_PHY=m
 # CONFIG_AX88796_93CX6 is not set
 CONFIG_AXP20X_ADC=m
 CONFIG_AXP20X_POWER=m
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH v2 0/2][SRU][C][D][E]AX88772A USB to Ethernet dongle doesn't work

Tyler Hicks-2
In reply to this post by AceLan Kao
On 2019-06-25 14:36:50, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1834114
>
> [Impact]
> There are 2 asix drivers in the kernel, they are drivers/net/usb/asix
> and drivers/net/phy/asix. It leads to the compilation race condition
> that one overwrites the other asix.mod in .tmp_version directory.
> This affects the USB dongle if the "phy" one wins.
>
> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 7 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=0b95 ProdID=7720 Rev=00.01
> S: Manufacturer=ASIX Elec. Corp.
> S: Product=AX88772A
> S: SerialNumber=000527
> C: #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=250mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=00 Driver=asix
>
> [Fix]
> The same name asix has been introduced since v4.18-rc1 by this commit
>    31dd83b96641 net-next: phy: new Asix Electronics PHY driver
> the new commit fix this issue by renaming it
>    a9520543b123 net: phy: rename Asix Electronics PHY driver
>
> [Test]
> Verified on my own ASIX USB Ethernet dongle.
>
> [Regression Potential]
> Low, it only rename the module name, no code change.


Acked-by: Tyler Hicks <[hidden email]>

Tyler

>
> AceLan Kao (1):
>   UBUNTU: [Config] update configs and annotations for ASIX renamed
>
> Michael Schmitz (1):
>   net: phy: rename Asix Electronics PHY driver
>
>  debian.master/abi/5.0.0-19.20/amd64/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules   | 1 +
>  debian.master/abi/5.0.0-19.20/arm64/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules | 1 +
>  debian.master/abi/5.0.0-19.20/armhf/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/i386/generic.modules       | 1 +
>  debian.master/abi/5.0.0-19.20/i386/lowlatency.modules    | 1 +
>  debian.master/abi/5.0.0-19.20/ppc64el/generic.modules    | 1 +
>  debian.master/abi/5.0.0-19.20/s390x/generic.modules      | 1 +
>  debian.master/config/annotations                         | 2 +-
>  debian.master/config/config.common.ubuntu                | 2 +-
>  drivers/net/ethernet/8390/Kconfig                        | 2 +-
>  drivers/net/phy/Kconfig                                  | 2 +-
>  drivers/net/phy/Makefile                                 | 2 +-
>  drivers/net/phy/{asix.c => ax88796b.c}                   | 0
>  15 files changed, 14 insertions(+), 5 deletions(-)
>  rename drivers/net/phy/{asix.c => ax88796b.c} (100%)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 0/2][SRU][C][D][E]AX88772A USB to Ethernet dongle doesn't work

Stefan Bader-2
In reply to this post by AceLan Kao
On 25.06.19 08:36, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1834114
>
> [Impact]
> There are 2 asix drivers in the kernel, they are drivers/net/usb/asix
> and drivers/net/phy/asix. It leads to the compilation race condition
> that one overwrites the other asix.mod in .tmp_version directory.
> This affects the USB dongle if the "phy" one wins.
>
> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 7 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=0b95 ProdID=7720 Rev=00.01
> S: Manufacturer=ASIX Elec. Corp.
> S: Product=AX88772A
> S: SerialNumber=000527
> C: #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=250mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=00 Driver=asix
>
> [Fix]
> The same name asix has been introduced since v4.18-rc1 by this commit
>    31dd83b96641 net-next: phy: new Asix Electronics PHY driver
> the new commit fix this issue by renaming it
>    a9520543b123 net: phy: rename Asix Electronics PHY driver
>
> [Test]
> Verified on my own ASIX USB Ethernet dongle.
>
> [Regression Potential]
> Low, it only rename the module name, no code change.
>
> AceLan Kao (1):
>   UBUNTU: [Config] update configs and annotations for ASIX renamed
>
> Michael Schmitz (1):
>   net: phy: rename Asix Electronics PHY driver
>
>  debian.master/abi/5.0.0-19.20/amd64/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules   | 1 +
>  debian.master/abi/5.0.0-19.20/arm64/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules | 1 +
>  debian.master/abi/5.0.0-19.20/armhf/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/i386/generic.modules       | 1 +
>  debian.master/abi/5.0.0-19.20/i386/lowlatency.modules    | 1 +
>  debian.master/abi/5.0.0-19.20/ppc64el/generic.modules    | 1 +
>  debian.master/abi/5.0.0-19.20/s390x/generic.modules      | 1 +
>  debian.master/config/annotations                         | 2 +-
>  debian.master/config/config.common.ubuntu                | 2 +-
>  drivers/net/ethernet/8390/Kconfig                        | 2 +-
>  drivers/net/phy/Kconfig                                  | 2 +-
>  drivers/net/phy/Makefile                                 | 2 +-
>  drivers/net/phy/{asix.c => ax88796b.c}                   | 0
>  15 files changed, 14 insertions(+), 5 deletions(-)
>  rename drivers/net/phy/{asix.c => ax88796b.c} (100%)
>
You set the state of disco in the bug report to fix committed and there is no
cosmic nomination. So this is rather confusing.
Also, have you checked whether this renamed driver is matching one of the d-i
module lists and appears in the relevant udeb?


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 0/2][SRU][C][D][E]AX88772A USB to Ethernet dongle doesn't work

AceLan Kao
I just added the missing cosmic nomination, thanks.

I don't know how to check the d-i module lists, maybe you can give me
some hints.
This renamed driver is newly added after v4.18, and its name conflicts
with the USB one,
If the driver name, asix, listed in the d-i module lists, it should
indicate the origin USB asix driver, not
the newly added(renamed) driver. So, I think it's safe to rename it.

Stefan Bader <[hidden email]> 於 2019年6月29日 週六 上午12:03寫道:

>
> On 25.06.19 08:36, AceLan Kao wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1834114
> >
> > [Impact]
> > There are 2 asix drivers in the kernel, they are drivers/net/usb/asix
> > and drivers/net/phy/asix. It leads to the compilation race condition
> > that one overwrites the other asix.mod in .tmp_version directory.
> > This affects the USB dongle if the "phy" one wins.
> >
> > T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 7 Spd=480 MxCh= 0
> > D: Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=00 MxPS=64 #Cfgs= 1
> > P: Vendor=0b95 ProdID=7720 Rev=00.01
> > S: Manufacturer=ASIX Elec. Corp.
> > S: Product=AX88772A
> > S: SerialNumber=000527
> > C: #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=250mA
> > I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=00 Driver=asix
> >
> > [Fix]
> > The same name asix has been introduced since v4.18-rc1 by this commit
> >    31dd83b96641 net-next: phy: new Asix Electronics PHY driver
> > the new commit fix this issue by renaming it
> >    a9520543b123 net: phy: rename Asix Electronics PHY driver
> >
> > [Test]
> > Verified on my own ASIX USB Ethernet dongle.
> >
> > [Regression Potential]
> > Low, it only rename the module name, no code change.
> >
> > AceLan Kao (1):
> >   UBUNTU: [Config] update configs and annotations for ASIX renamed
> >
> > Michael Schmitz (1):
> >   net: phy: rename Asix Electronics PHY driver
> >
> >  debian.master/abi/5.0.0-19.20/amd64/generic.modules      | 1 +
> >  debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules   | 1 +
> >  debian.master/abi/5.0.0-19.20/arm64/generic.modules      | 1 +
> >  debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules | 1 +
> >  debian.master/abi/5.0.0-19.20/armhf/generic.modules      | 1 +
> >  debian.master/abi/5.0.0-19.20/i386/generic.modules       | 1 +
> >  debian.master/abi/5.0.0-19.20/i386/lowlatency.modules    | 1 +
> >  debian.master/abi/5.0.0-19.20/ppc64el/generic.modules    | 1 +
> >  debian.master/abi/5.0.0-19.20/s390x/generic.modules      | 1 +
> >  debian.master/config/annotations                         | 2 +-
> >  debian.master/config/config.common.ubuntu                | 2 +-
> >  drivers/net/ethernet/8390/Kconfig                        | 2 +-
> >  drivers/net/phy/Kconfig                                  | 2 +-
> >  drivers/net/phy/Makefile                                 | 2 +-
> >  drivers/net/phy/{asix.c => ax88796b.c}                   | 0
> >  15 files changed, 14 insertions(+), 5 deletions(-)
> >  rename drivers/net/phy/{asix.c => ax88796b.c} (100%)
> >
> You set the state of disco in the bug report to fix committed and there is no
> cosmic nomination. So this is rather confusing.
> Also, have you checked whether this renamed driver is matching one of the d-i
> module lists and appears in the relevant udeb?
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 0/2][SRU][C][D][E]AX88772A USB to Ethernet dongle doesn't work

Stefan Bader-2
On 01.07.19 03:44, AceLan Kao wrote:
> I just added the missing cosmic nomination, thanks.

You did but also set all the tasks to fix committed. This is wrong. The state is
not committed until we apply it to the tree.
>
> I don't know how to check the d-i module lists, maybe you can give me
> some hints.

git grep asix debian.master/d-i/modules/
debian.master/d-i/modules/nic-usb-modules:asix ?

git grep ax88796b debian.master/d-i/modules/

returns nothing, which means the phy driver is not supported in the installer (I
don't know which one was picked up via the usb list, maybe the wrong one). So
maybe we can say here its not worse that before...

> This renamed driver is newly added after v4.18, and its name conflicts
> with the USB one,
> If the driver name, asix, listed in the d-i module lists, it should
> indicate the origin USB asix driver, not
> the newly added(renamed) driver. So, I think it's safe to rename it.
>
> Stefan Bader <[hidden email]> 於 2019年6月29日 週六 上午12:03寫道:
>>
>> On 25.06.19 08:36, AceLan Kao wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1834114
>>>
>>> [Impact]
>>> There are 2 asix drivers in the kernel, they are drivers/net/usb/asix
>>> and drivers/net/phy/asix. It leads to the compilation race condition
>>> that one overwrites the other asix.mod in .tmp_version directory.
>>> This affects the USB dongle if the "phy" one wins.
>>>
>>> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 7 Spd=480 MxCh= 0
>>> D: Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=00 MxPS=64 #Cfgs= 1
>>> P: Vendor=0b95 ProdID=7720 Rev=00.01
>>> S: Manufacturer=ASIX Elec. Corp.
>>> S: Product=AX88772A
>>> S: SerialNumber=000527
>>> C: #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=250mA
>>> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=00 Driver=asix
>>>
>>> [Fix]
>>> The same name asix has been introduced since v4.18-rc1 by this commit
>>>    31dd83b96641 net-next: phy: new Asix Electronics PHY driver
>>> the new commit fix this issue by renaming it
>>>    a9520543b123 net: phy: rename Asix Electronics PHY driver
>>>
>>> [Test]
>>> Verified on my own ASIX USB Ethernet dongle.
>>>
>>> [Regression Potential]
>>> Low, it only rename the module name, no code change.
>>>
>>> AceLan Kao (1):
>>>   UBUNTU: [Config] update configs and annotations for ASIX renamed
>>>
>>> Michael Schmitz (1):
>>>   net: phy: rename Asix Electronics PHY driver
>>>
>>>  debian.master/abi/5.0.0-19.20/amd64/generic.modules      | 1 +
>>>  debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules   | 1 +
>>>  debian.master/abi/5.0.0-19.20/arm64/generic.modules      | 1 +
>>>  debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules | 1 +
>>>  debian.master/abi/5.0.0-19.20/armhf/generic.modules      | 1 +
>>>  debian.master/abi/5.0.0-19.20/i386/generic.modules       | 1 +
>>>  debian.master/abi/5.0.0-19.20/i386/lowlatency.modules    | 1 +
>>>  debian.master/abi/5.0.0-19.20/ppc64el/generic.modules    | 1 +
>>>  debian.master/abi/5.0.0-19.20/s390x/generic.modules      | 1 +
>>>  debian.master/config/annotations                         | 2 +-
>>>  debian.master/config/config.common.ubuntu                | 2 +-
>>>  drivers/net/ethernet/8390/Kconfig                        | 2 +-
>>>  drivers/net/phy/Kconfig                                  | 2 +-
>>>  drivers/net/phy/Makefile                                 | 2 +-
>>>  drivers/net/phy/{asix.c => ax88796b.c}                   | 0
>>>  15 files changed, 14 insertions(+), 5 deletions(-)
>>>  rename drivers/net/phy/{asix.c => ax88796b.c} (100%)
>>>
>> You set the state of disco in the bug report to fix committed and there is no
>> cosmic nomination. So this is rather confusing.
>> Also, have you checked whether this renamed driver is matching one of the d-i
>> module lists and appears in the relevant udeb?
>>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH v2 0/2][SRU][C][D][E]AX88772A USB to Ethernet dongle doesn't work

Marcelo Henrique Cerri
In reply to this post by AceLan Kao
Acked-by: Marcelo Henrique Cerri <[hidden email]>

On Tue, Jun 25, 2019 at 02:36:50PM +0800, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1834114
>
> [Impact]
> There are 2 asix drivers in the kernel, they are drivers/net/usb/asix
> and drivers/net/phy/asix. It leads to the compilation race condition
> that one overwrites the other asix.mod in .tmp_version directory.
> This affects the USB dongle if the "phy" one wins.
>
> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 7 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=0b95 ProdID=7720 Rev=00.01
> S: Manufacturer=ASIX Elec. Corp.
> S: Product=AX88772A
> S: SerialNumber=000527
> C: #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=250mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=00 Driver=asix
>
> [Fix]
> The same name asix has been introduced since v4.18-rc1 by this commit
>    31dd83b96641 net-next: phy: new Asix Electronics PHY driver
> the new commit fix this issue by renaming it
>    a9520543b123 net: phy: rename Asix Electronics PHY driver
>
> [Test]
> Verified on my own ASIX USB Ethernet dongle.
>
> [Regression Potential]
> Low, it only rename the module name, no code change.
>
> AceLan Kao (1):
>   UBUNTU: [Config] update configs and annotations for ASIX renamed
>
> Michael Schmitz (1):
>   net: phy: rename Asix Electronics PHY driver
>
>  debian.master/abi/5.0.0-19.20/amd64/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules   | 1 +
>  debian.master/abi/5.0.0-19.20/arm64/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules | 1 +
>  debian.master/abi/5.0.0-19.20/armhf/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/i386/generic.modules       | 1 +
>  debian.master/abi/5.0.0-19.20/i386/lowlatency.modules    | 1 +
>  debian.master/abi/5.0.0-19.20/ppc64el/generic.modules    | 1 +
>  debian.master/abi/5.0.0-19.20/s390x/generic.modules      | 1 +
>  debian.master/config/annotations                         | 2 +-
>  debian.master/config/config.common.ubuntu                | 2 +-
>  drivers/net/ethernet/8390/Kconfig                        | 2 +-
>  drivers/net/phy/Kconfig                                  | 2 +-
>  drivers/net/phy/Makefile                                 | 2 +-
>  drivers/net/phy/{asix.c => ax88796b.c}                   | 0
>  15 files changed, 14 insertions(+), 5 deletions(-)
>  rename drivers/net/phy/{asix.c => ax88796b.c} (100%)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
--
Regards,
Marcelo


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

NACK for Cosmic: [PATCH v2 0/2][SRU][C][D][E]AX88772A USB to Ethernet dongle doesn't work

Stefan Bader-2
In reply to this post by AceLan Kao
On 25.06.19 08:36, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1834114
>
> [Impact]
> There are 2 asix drivers in the kernel, they are drivers/net/usb/asix
> and drivers/net/phy/asix. It leads to the compilation race condition
> that one overwrites the other asix.mod in .tmp_version directory.
> This affects the USB dongle if the "phy" one wins.
>
> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 7 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=0b95 ProdID=7720 Rev=00.01
> S: Manufacturer=ASIX Elec. Corp.
> S: Product=AX88772A
> S: SerialNumber=000527
> C: #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=250mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=00 Driver=asix
>
> [Fix]
> The same name asix has been introduced since v4.18-rc1 by this commit
>    31dd83b96641 net-next: phy: new Asix Electronics PHY driver
> the new commit fix this issue by renaming it
>    a9520543b123 net: phy: rename Asix Electronics PHY driver
>
> [Test]
> Verified on my own ASIX USB Ethernet dongle.
>
> [Regression Potential]
> Low, it only rename the module name, no code change.
>
> AceLan Kao (1):
>   UBUNTU: [Config] update configs and annotations for ASIX renamed
>
> Michael Schmitz (1):
>   net: phy: rename Asix Electronics PHY driver
>
>  debian.master/abi/5.0.0-19.20/amd64/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules   | 1 +
>  debian.master/abi/5.0.0-19.20/arm64/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules | 1 +
>  debian.master/abi/5.0.0-19.20/armhf/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/i386/generic.modules       | 1 +
>  debian.master/abi/5.0.0-19.20/i386/lowlatency.modules    | 1 +
>  debian.master/abi/5.0.0-19.20/ppc64el/generic.modules    | 1 +
>  debian.master/abi/5.0.0-19.20/s390x/generic.modules      | 1 +
>  debian.master/config/annotations                         | 2 +-
>  debian.master/config/config.common.ubuntu                | 2 +-
>  drivers/net/ethernet/8390/Kconfig                        | 2 +-
>  drivers/net/phy/Kconfig                                  | 2 +-
>  drivers/net/phy/Makefile                                 | 2 +-
>  drivers/net/phy/{asix.c => ax88796b.c}                   | 0
>  15 files changed, 14 insertions(+), 5 deletions(-)
>  rename drivers/net/phy/{asix.c => ax88796b.c} (100%)
>
Lets not change Cosmic too drastically this late in its life.



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[D]: [PATCH v2 0/2][SRU][C][D][E]AX88772A USB to Ethernet dongle doesn't work

Kleber Souza
In reply to this post by AceLan Kao
On 6/25/19 8:36 AM, AceLan Kao wrote:

> BugLink: https://bugs.launchpad.net/bugs/1834114
>
> [Impact]
> There are 2 asix drivers in the kernel, they are drivers/net/usb/asix
> and drivers/net/phy/asix. It leads to the compilation race condition
> that one overwrites the other asix.mod in .tmp_version directory.
> This affects the USB dongle if the "phy" one wins.
>
> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 7 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=0b95 ProdID=7720 Rev=00.01
> S: Manufacturer=ASIX Elec. Corp.
> S: Product=AX88772A
> S: SerialNumber=000527
> C: #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=250mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=00 Driver=asix
>
> [Fix]
> The same name asix has been introduced since v4.18-rc1 by this commit
>    31dd83b96641 net-next: phy: new Asix Electronics PHY driver
> the new commit fix this issue by renaming it
>    a9520543b123 net: phy: rename Asix Electronics PHY driver
>
> [Test]
> Verified on my own ASIX USB Ethernet dongle.
>
> [Regression Potential]
> Low, it only rename the module name, no code change.

Applied to disco/master-next branch.

Thanks,
Kleber



>
> AceLan Kao (1):
>   UBUNTU: [Config] update configs and annotations for ASIX renamed
>
> Michael Schmitz (1):
>   net: phy: rename Asix Electronics PHY driver
>
>  debian.master/abi/5.0.0-19.20/amd64/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules   | 1 +
>  debian.master/abi/5.0.0-19.20/arm64/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules | 1 +
>  debian.master/abi/5.0.0-19.20/armhf/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/i386/generic.modules       | 1 +
>  debian.master/abi/5.0.0-19.20/i386/lowlatency.modules    | 1 +
>  debian.master/abi/5.0.0-19.20/ppc64el/generic.modules    | 1 +
>  debian.master/abi/5.0.0-19.20/s390x/generic.modules      | 1 +
>  debian.master/config/annotations                         | 2 +-
>  debian.master/config/config.common.ubuntu                | 2 +-
>  drivers/net/ethernet/8390/Kconfig                        | 2 +-
>  drivers/net/phy/Kconfig                                  | 2 +-
>  drivers/net/phy/Makefile                                 | 2 +-
>  drivers/net/phy/{asix.c => ax88796b.c}                   | 0
>  15 files changed, 14 insertions(+), 5 deletions(-)
>  rename drivers/net/phy/{asix.c => ax88796b.c} (100%)
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 2/2][SRU][D][E] UBUNTU: [Config] update configs and annotations for ASIX renamed

Stefan Bader-2
In reply to this post by AceLan Kao
On 25.06.19 08:36, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1834114
>
> Below commit rename the asix.ko module in net/phy to ax88796b.ko,
> so update configs and annotations, too.
>    net: phy: rename Asix Electronics PHY driver
> And also update modules in debian.master/abi/*/*/*.modules files.

This change broke the s390x build indirectly as it did not ensure that the asix
module got removed from the abi. Adding modules is not critical but dropping
them is. And this counts as a drop because the usb asix never was build and
instead the phy driver being accounted for it.

-Stefan

>
> Signed-off-by: AceLan Kao <[hidden email]>
> ---
>  debian.master/abi/5.0.0-19.20/amd64/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules   | 1 +
>  debian.master/abi/5.0.0-19.20/arm64/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules | 1 +
>  debian.master/abi/5.0.0-19.20/armhf/generic.modules      | 1 +
>  debian.master/abi/5.0.0-19.20/i386/generic.modules       | 1 +
>  debian.master/abi/5.0.0-19.20/i386/lowlatency.modules    | 1 +
>  debian.master/abi/5.0.0-19.20/ppc64el/generic.modules    | 1 +
>  debian.master/abi/5.0.0-19.20/s390x/generic.modules      | 1 +
>  debian.master/config/annotations                         | 2 +-
>  debian.master/config/config.common.ubuntu                | 2 +-
>  11 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/debian.master/abi/5.0.0-19.20/amd64/generic.modules b/debian.master/abi/5.0.0-19.20/amd64/generic.modules
> index 45c0324faded..8b659ede0742 100644
> --- a/debian.master/abi/5.0.0-19.20/amd64/generic.modules
> +++ b/debian.master/abi/5.0.0-19.20/amd64/generic.modules
> @@ -449,6 +449,7 @@ avma1_cs
>  avmfritz
>  ax25
>  ax88179_178a
> +ax88796b
>  axnet_cs
>  axp20x
>  axp20x-i2c
> diff --git a/debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules b/debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules
> index 7adf155aab94..d3c6dc8f3ecf 100644
> --- a/debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules
> +++ b/debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules
> @@ -449,6 +449,7 @@ avma1_cs
>  avmfritz
>  ax25
>  ax88179_178a
> +ax88796b
>  axnet_cs
>  axp20x
>  axp20x-i2c
> diff --git a/debian.master/abi/5.0.0-19.20/arm64/generic.modules b/debian.master/abi/5.0.0-19.20/arm64/generic.modules
> index 4dd355cd676d..5909e6258aba 100644
> --- a/debian.master/abi/5.0.0-19.20/arm64/generic.modules
> +++ b/debian.master/abi/5.0.0-19.20/arm64/generic.modules
> @@ -432,6 +432,7 @@ autofs4
>  avmfritz
>  ax25
>  ax88179_178a
> +ax88796b
>  axis-fifo
>  axp20x
>  axp20x-i2c
> diff --git a/debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules b/debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules
> index a220950cde14..31a7e218985f 100644
> --- a/debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules
> +++ b/debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules
> @@ -428,6 +428,7 @@ avmfritz
>  ax25
>  ax88179_178a
>  ax88796
> +ax88796b
>  axis-fifo
>  axp20x
>  axp20x-i2c
> diff --git a/debian.master/abi/5.0.0-19.20/armhf/generic.modules b/debian.master/abi/5.0.0-19.20/armhf/generic.modules
> index c48c977909b9..defd22ef93b9 100644
> --- a/debian.master/abi/5.0.0-19.20/armhf/generic.modules
> +++ b/debian.master/abi/5.0.0-19.20/armhf/generic.modules
> @@ -429,6 +429,7 @@ avmfritz
>  ax25
>  ax88179_178a
>  ax88796
> +ax88796b
>  axis-fifo
>  axp20x
>  axp20x-i2c
> diff --git a/debian.master/abi/5.0.0-19.20/i386/generic.modules b/debian.master/abi/5.0.0-19.20/i386/generic.modules
> index fe4cce766110..8f5bff9ef6b9 100644
> --- a/debian.master/abi/5.0.0-19.20/i386/generic.modules
> +++ b/debian.master/abi/5.0.0-19.20/i386/generic.modules
> @@ -456,6 +456,7 @@ avma1_cs
>  avmfritz
>  ax25
>  ax88179_178a
> +ax88796b
>  axnet_cs
>  axp20x
>  axp20x-i2c
> diff --git a/debian.master/abi/5.0.0-19.20/i386/lowlatency.modules b/debian.master/abi/5.0.0-19.20/i386/lowlatency.modules
> index de88a5ae7b80..cdf5c2fa6127 100644
> --- a/debian.master/abi/5.0.0-19.20/i386/lowlatency.modules
> +++ b/debian.master/abi/5.0.0-19.20/i386/lowlatency.modules
> @@ -456,6 +456,7 @@ avma1_cs
>  avmfritz
>  ax25
>  ax88179_178a
> +ax88796b
>  axnet_cs
>  axp20x
>  axp20x-i2c
> diff --git a/debian.master/abi/5.0.0-19.20/ppc64el/generic.modules b/debian.master/abi/5.0.0-19.20/ppc64el/generic.modules
> index 84f9be593cef..c4f55724fbd2 100644
> --- a/debian.master/abi/5.0.0-19.20/ppc64el/generic.modules
> +++ b/debian.master/abi/5.0.0-19.20/ppc64el/generic.modules
> @@ -404,6 +404,7 @@ autofs4
>  avmfritz
>  ax25
>  ax88179_178a
> +ax88796b
>  axis-fifo
>  axp20x
>  axp20x-i2c
> diff --git a/debian.master/abi/5.0.0-19.20/s390x/generic.modules b/debian.master/abi/5.0.0-19.20/s390x/generic.modules
> index 6081d35c13eb..4411fe38e7fd 100644
> --- a/debian.master/abi/5.0.0-19.20/s390x/generic.modules
> +++ b/debian.master/abi/5.0.0-19.20/s390x/generic.modules
> @@ -62,6 +62,7 @@ aufs
>  auth_rpcgss
>  authenc
>  authencesn
> +ax88796b
>  bcache
>  bcm-phy-lib
>  bcm7xxx
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index 008ead6f697c..fcd170365f01 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -5587,7 +5587,7 @@ CONFIG_LED_TRIGGER_PHY                          policy<{'amd64': 'y', 'arm64': '
>  CONFIG_SFP                                      policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm'}>
>  CONFIG_AMD_PHY                                  policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
>  CONFIG_AQUANTIA_PHY                             policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
> -CONFIG_ASIX_PHY                                 policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
> +CONFIG_AX88796B_PHY                             policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
>  CONFIG_AT803X_PHY                               policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
>  CONFIG_BCM7XXX_PHY                              policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
>  CONFIG_BCM87XX_PHY                              policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index df275aa4a69d..810d4fc3b18a 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -719,7 +719,6 @@ CONFIG_ARM_VEXPRESS_SPC_CPUFREQ=m
>  CONFIG_ARM_VIRT_EXT=y
>  CONFIG_AS3935=m
>  CONFIG_ASHMEM=m
> -CONFIG_ASIX_PHY=m
>  CONFIG_ASN1=y
>  CONFIG_ASSOCIATIVE_ARRAY=y
>  CONFIG_ASUS_LAPTOP=m
> @@ -861,6 +860,7 @@ CONFIG_AUTO_ZRELADDR=y
>  CONFIG_AX25=m
>  CONFIG_AX25_DAMA_SLAVE=y
>  CONFIG_AX88796=m
> +CONFIG_AX88796B_PHY=m
>  # CONFIG_AX88796_93CX6 is not set
>  CONFIG_AXP20X_ADC=m
>  CONFIG_AXP20X_POWER=m
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment