[PATCH v2 0/2][SRU][F/OEM-5.6/G/U] Enable PSR on HP ZBook Studio G7

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 0/2][SRU][F/OEM-5.6/G/U] Enable PSR on HP ZBook Studio G7

You-Sheng Yang
BugLink: https://bugs.launchpad.net/bugs/1897501

[Impact]

On some OEM platforms equipped PSR eanbled panels, i915 renders screen
half occupied and corrupted, and restore PSR previously disabled in
LP: #1849947 fixes this issue.

[Fix]

While PSR has been disabled currently in Ubuntu kernels from oem-osp1
5.0 to current unstable 5.9, there is no guaranteed PSR support in
Focal, and PSR is actually planned for v5.10 or later kernels, reverting
the disabling commit ("UBUNTU: SAUCE: drm/i915: Disable PSR by default
on all platforms") doesn't seem a viable solution here.

This patchset introduces a new, Ubuntu only, EDID quirk
'DP_QUIRK_FORCE_PSR_CHIP_DEFAULT' to identify the target panel and overrides
`enable_psr` to -1(chip defaults) when it's set to 0(disabled).

[Test Case]

On the target device, the PSR value should be 0 by default:

  $ sudo cat /sys/module/i915/parameters/enable_psr
  0

When applied, the PSR should be -1 even if no "i915.enable_psr=-1" is
passed as kernel boot parameter, and .

  $ sudo cat /sys/module/i915/parameters/enable_psr
  -1

With drm.debug=0x04, one should also find following message in dmesg:

  [drm:intel_psr_enable_locked [i915]] Enabling PSR2

[Regression Potential]
Low. This affects only the target panel with EDID mfg CMN prod-ID 19-15.

You-Sheng Yang (2):
  UBUNTU: SAUCE: drm/i915/psr: allow overriding PSR disable param by
    quirk
  UBUNTU: SAUCE: drm/dp: add DP_QUIRK_FORCE_PSR_CHIP_DEFAULT quirk to CMN
    prod-ID 19-15

 drivers/gpu/drm/drm_dp_helper.c          | 5 +++++
 drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++++++
 include/drm/drm_dp_helper.h              | 8 ++++++++
 3 files changed, 21 insertions(+)

--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 1/2][SRU][F] UBUNTU: SAUCE: drm/i915/psr: allow overriding PSR disable param by quirk

You-Sheng Yang
BugLink: https://bugs.launchpad.net/bugs/1897501

HP ZBook Studio G7 equips an INX FHD N156HCG-GQ1 panel that renders
corrupted screen when PSR is disabled. This patch allows overriding
the default disabled i915_modparams.enable_psr since LP: #1849947 to
use chip default when a EDID match is on.

Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++++++
 include/drm/drm_dp_helper.h              | 8 ++++++++
 2 files changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index e32adbbf4ee4..c0f397c8e1b7 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1219,6 +1219,14 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
  if (!dev_priv->psr.sink_support)
  return;
 
+ /*
+ * PSR was disabled by module parameters but the underlying panel is
+ * depending on it, so use per-chip default to probe that automatically.
+ */
+ if ((dev_priv->psr.dp->edid_quirks & BIT(DP_QUIRK_FORCE_PSR_CHIP_DEFAULT)) &&
+    i915_modparams.enable_psr == 0)
+ i915_modparams.enable_psr = -1;
+
  if (i915_modparams.enable_psr == -1)
  if (INTEL_GEN(dev_priv) < 9 || !dev_priv->vbt.psr.enable)
  i915_modparams.enable_psr = 0;
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 5bcb3f7d5d8e..79633ebe953f 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -1447,6 +1447,14 @@ enum drm_dp_quirk {
  * capabilities advertised.
  */
  DP_QUIRK_FORCE_DPCD_BACKLIGHT,
+ /**
+ * @DP_QUIRK_FORCE_PSR_CHIP_DEFAULT
+ *
+ * PSR was disabled by default in Ubuntu 5.0 kernels and on, but some
+ * platforms might be depending on them. If so, use per-chip default to
+ * probe that automatically.
+ */
+ DP_QUIRK_FORCE_PSR_CHIP_DEFAULT,
 };
 
 /**
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 1/2][SRU][G] UBUNTU: SAUCE: drm/i915/psr: allow overriding PSR disable param by quirk

You-Sheng Yang
In reply to this post by You-Sheng Yang
BugLink: https://bugs.launchpad.net/bugs/1897501

HP ZBook Studio G7 equips an INX FHD N156HCG-GQ1 panel that renders
corrupted screen when PSR is disabled. This patch allows overriding
the default disabled i915_modparams.enable_psr since LP: #1849947 to
use chip default when a EDID match is on.

Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++++++
 include/drm/drm_dp_helper.h              | 8 ++++++++
 2 files changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index b7a2c102648a..0c0433059eb5 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1450,6 +1450,14 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
  */
  dev_priv->hsw_psr_mmio_adjust = _SRD_CTL_EDP - _HSW_EDP_PSR_BASE;
 
+ /*
+ * PSR was disabled by module parameters but the underlying panel is
+ * depending on it, so use per-chip default to probe that automatically.
+ */
+ if ((dev_priv->psr.dp->edid_quirks & BIT(DP_QUIRK_FORCE_PSR_CHIP_DEFAULT)) &&
+    i915_modparams.enable_psr == 0)
+ i915_modparams.enable_psr = -1;
+
  if (i915_modparams.enable_psr == -1)
  if (INTEL_GEN(dev_priv) < 9 || !dev_priv->vbt.psr.enable)
  i915_modparams.enable_psr = 0;
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 2035ac44afde..cc619e759a59 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -1697,6 +1697,14 @@ enum drm_dp_quirk {
  * the DP_MAX_LINK_RATE register reporting a lower max multiplier.
  */
  DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS,
+ /**
+ * @DP_QUIRK_FORCE_PSR_CHIP_DEFAULT
+ *
+ * PSR was disabled by default in Ubuntu 5.0 kernels and on, but some
+ * platforms might be depending on them. If so, use per-chip default to
+ * probe that automatically.
+ */
+ DP_QUIRK_FORCE_PSR_CHIP_DEFAULT,
 };
 
 /**
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 1/2][SRU][OEM-5.6] UBUNTU: SAUCE: drm/i915/psr: allow overriding PSR disable param by quirk

You-Sheng Yang
In reply to this post by You-Sheng Yang
BugLink: https://bugs.launchpad.net/bugs/1897501

HP ZBook Studio G7 equips an INX FHD N156HCG-GQ1 panel that renders
corrupted screen when PSR is disabled. This patch allows overriding
the default disabled i915_modparams.enable_psr since LP: #1849947 to
use chip default when a EDID match is on.

Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++++++
 include/drm/drm_dp_helper.h              | 8 ++++++++
 2 files changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 8f50b249175d..a6a16ad026c8 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1423,6 +1423,14 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
  */
  dev_priv->hsw_psr_mmio_adjust = _SRD_CTL_EDP - _HSW_EDP_PSR_BASE;
 
+ /*
+ * PSR was disabled by module parameters but the underlying panel is
+ * depending on it, so use per-chip default to probe that automatically.
+ */
+ if ((dev_priv->psr.dp->edid_quirks & BIT(DP_QUIRK_FORCE_PSR_CHIP_DEFAULT)) &&
+    i915_modparams.enable_psr == 0)
+ i915_modparams.enable_psr = -1;
+
  if (i915_modparams.enable_psr == -1)
  if (INTEL_GEN(dev_priv) < 9 || !dev_priv->vbt.psr.enable)
  i915_modparams.enable_psr = 0;
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 98e7fd15cc15..de4d8cdad02c 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -1548,6 +1548,14 @@ enum drm_dp_quirk {
  * capabilities advertised.
  */
  DP_QUIRK_FORCE_DPCD_BACKLIGHT,
+ /**
+ * @DP_QUIRK_FORCE_PSR_CHIP_DEFAULT
+ *
+ * PSR was disabled by default in Ubuntu 5.0 kernels and on, but some
+ * platforms might be depending on them. If so, use per-chip default to
+ * probe that automatically.
+ */
+ DP_QUIRK_FORCE_PSR_CHIP_DEFAULT,
 };
 
 /**
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 1/2][SRU][U] UBUNTU: SAUCE: drm/i915/psr: allow overriding PSR disable param by quirk

You-Sheng Yang
In reply to this post by You-Sheng Yang
BugLink: https://bugs.launchpad.net/bugs/1897501

HP ZBook Studio G7 equips an INX FHD N156HCG-GQ1 panel that renders
corrupted screen when PSR is disabled. This patch allows overriding
the default disabled i915_modparams.enable_psr since LP: #1849947 to
use chip default when a EDID match is on.

Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++++++
 include/drm/drm_dp_helper.h              | 8 ++++++++
 2 files changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index bf9e320c547d..215ecd999d1d 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1500,6 +1500,14 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
  */
  dev_priv->hsw_psr_mmio_adjust = _SRD_CTL_EDP - _HSW_EDP_PSR_BASE;
 
+ /*
+ * PSR was disabled by module parameters but the underlying panel is
+ * depending on it, so use per-chip default to probe that automatically.
+ */
+ if ((dev_priv->psr.dp->edid_quirks & BIT(DP_QUIRK_FORCE_PSR_CHIP_DEFAULT)) &&
+    dev_priv->params.enable_psr == 0)
+ dev_priv->params.enable_psr = -1;
+
  if (dev_priv->params.enable_psr == -1)
  if (INTEL_GEN(dev_priv) < 9 || !dev_priv->vbt.psr.enable)
  dev_priv->params.enable_psr = 0;
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index e47dc22ebf50..933a37b29ead 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -1705,6 +1705,14 @@ enum drm_dp_quirk {
  * the DP_MAX_LINK_RATE register reporting a lower max multiplier.
  */
  DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS,
+ /**
+ * @DP_QUIRK_FORCE_PSR_CHIP_DEFAULT
+ *
+ * PSR was disabled by default in Ubuntu 5.0 kernels and on, but some
+ * platforms might be depending on them. If so, use per-chip default to
+ * probe that automatically.
+ */
+ DP_QUIRK_FORCE_PSR_CHIP_DEFAULT,
 };
 
 /**
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 2/2][SRU][F/OEM-5.6/G/U] UBUNTU: SAUCE: drm/dp: add DP_QUIRK_FORCE_PSR_CHIP_DEFAULT quirk to CMN prod-ID 19-15

You-Sheng Yang
In reply to this post by You-Sheng Yang
BugLink: https://bugs.launchpad.net/bugs/1897501

Add edid quirk for one specific sku of HP ZBook Studio G7 that relying
on PSR enabled.

Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/gpu/drm/drm_dp_helper.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index ab7c9d98ef94..2443e42ea564 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1340,6 +1340,11 @@ static const struct edid_quirk edid_quirk_list[] = {
  { MFG(0x4d, 0x10), PROD_ID(0xc7, 0x14), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
  { MFG(0x4d, 0x10), PROD_ID(0xe6, 0x14), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
  { MFG(0x4c, 0x83), PROD_ID(0x47, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
+ /*
+ * Some HP ZBook Studio G7 systems have panels support and relies on
+ * PSR being enabled.
+ */
+ { MFG(0x0d, 0xae), PROD_ID(0x19, 0x15), BIT(DP_QUIRK_FORCE_PSR_CHIP_DEFAULT) },
 };
 
 #undef MFG
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/APPLIED G: Re: [PATCH v2 0/2][SRU][F/OEM-5.6/G/U] Enable PSR on HP ZBook Studio G7

Paolo Pisati-5
In reply to this post by You-Sheng Yang
On Wed, Sep 30, 2020 at 03:05:10PM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1897501

Quirk for a specific SKU model, makes sense.

Acked-by: Paolo Pisati <[hidden email]>
--
bye,
p.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH v2 0/2][SRU][F/OEM-5.6/G/U] Enable PSR on HP ZBook Studio G7

Stefan Bader-2
In reply to this post by You-Sheng Yang
On 30.09.20 09:05, You-Sheng Yang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1897501
>
> [Impact]
>
> On some OEM platforms equipped PSR eanbled panels, i915 renders screen
> half occupied and corrupted, and restore PSR previously disabled in
> LP: #1849947 fixes this issue.
>
> [Fix]
>
> While PSR has been disabled currently in Ubuntu kernels from oem-osp1
> 5.0 to current unstable 5.9, there is no guaranteed PSR support in
> Focal, and PSR is actually planned for v5.10 or later kernels, reverting
> the disabling commit ("UBUNTU: SAUCE: drm/i915: Disable PSR by default
> on all platforms") doesn't seem a viable solution here.
>
> This patchset introduces a new, Ubuntu only, EDID quirk
> 'DP_QUIRK_FORCE_PSR_CHIP_DEFAULT' to identify the target panel and overrides
> `enable_psr` to -1(chip defaults) when it's set to 0(disabled).
>
> [Test Case]
>
> On the target device, the PSR value should be 0 by default:
>
>   $ sudo cat /sys/module/i915/parameters/enable_psr
>   0
>
> When applied, the PSR should be -1 even if no "i915.enable_psr=-1" is
> passed as kernel boot parameter, and .
>
>   $ sudo cat /sys/module/i915/parameters/enable_psr
>   -1
>
> With drm.debug=0x04, one should also find following message in dmesg:
>
>   [drm:intel_psr_enable_locked [i915]] Enabling PSR2
>
> [Regression Potential]
> Low. This affects only the target panel with EDID mfg CMN prod-ID 19-15.
>
> You-Sheng Yang (2):
>   UBUNTU: SAUCE: drm/i915/psr: allow overriding PSR disable param by
>     quirk
>   UBUNTU: SAUCE: drm/dp: add DP_QUIRK_FORCE_PSR_CHIP_DEFAULT quirk to CMN
>     prod-ID 19-15
>
>  drivers/gpu/drm/drm_dp_helper.c          | 5 +++++
>  drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++++++
>  include/drm/drm_dp_helper.h              | 8 ++++++++
>  3 files changed, 21 insertions(+)
>
Acked-by: Stefan Bader <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[Unstable]: [PATCH v2 0/2][SRU][F/OEM-5.6/G/U] Enable PSR on HP ZBook Studio G7

Seth Forshee
In reply to this post by You-Sheng Yang
On Wed, Sep 30, 2020 at 03:05:10PM +0800, You-Sheng Yang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1897501
>
> [Impact]
>
> On some OEM platforms equipped PSR eanbled panels, i915 renders screen
> half occupied and corrupted, and restore PSR previously disabled in
> LP: #1849947 fixes this issue.
>
> [Fix]
>
> While PSR has been disabled currently in Ubuntu kernels from oem-osp1
> 5.0 to current unstable 5.9, there is no guaranteed PSR support in
> Focal, and PSR is actually planned for v5.10 or later kernels, reverting
> the disabling commit ("UBUNTU: SAUCE: drm/i915: Disable PSR by default
> on all platforms") doesn't seem a viable solution here.
>
> This patchset introduces a new, Ubuntu only, EDID quirk
> 'DP_QUIRK_FORCE_PSR_CHIP_DEFAULT' to identify the target panel and overrides
> `enable_psr` to -1(chip defaults) when it's set to 0(disabled).
>
> [Test Case]
>
> On the target device, the PSR value should be 0 by default:
>
>   $ sudo cat /sys/module/i915/parameters/enable_psr
>   0
>
> When applied, the PSR should be -1 even if no "i915.enable_psr=-1" is
> passed as kernel boot parameter, and .
>
>   $ sudo cat /sys/module/i915/parameters/enable_psr
>   -1
>
> With drm.debug=0x04, one should also find following message in dmesg:
>
>   [drm:intel_psr_enable_locked [i915]] Enabling PSR2
>
> [Regression Potential]
> Low. This affects only the target panel with EDID mfg CMN prod-ID 19-15.

Applied to unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED [OEM-5.6] Re: [PATCH v2 0/2][SRU][F/OEM-5.6/G/U] Enable PSR on HP ZBook Studio G7

Timo Aaltonen-6
In reply to this post by You-Sheng Yang
On 30.9.2020 10.05, You-Sheng Yang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1897501
>
> [Impact]
>
> On some OEM platforms equipped PSR eanbled panels, i915 renders screen
> half occupied and corrupted, and restore PSR previously disabled in
> LP: #1849947 fixes this issue.
>
> [Fix]
>
> While PSR has been disabled currently in Ubuntu kernels from oem-osp1
> 5.0 to current unstable 5.9, there is no guaranteed PSR support in
> Focal, and PSR is actually planned for v5.10 or later kernels, reverting
> the disabling commit ("UBUNTU: SAUCE: drm/i915: Disable PSR by default
> on all platforms") doesn't seem a viable solution here.
>
> This patchset introduces a new, Ubuntu only, EDID quirk
> 'DP_QUIRK_FORCE_PSR_CHIP_DEFAULT' to identify the target panel and overrides
> `enable_psr` to -1(chip defaults) when it's set to 0(disabled).
>
> [Test Case]
>
> On the target device, the PSR value should be 0 by default:
>
>    $ sudo cat /sys/module/i915/parameters/enable_psr
>    0
>
> When applied, the PSR should be -1 even if no "i915.enable_psr=-1" is
> passed as kernel boot parameter, and .
>
>    $ sudo cat /sys/module/i915/parameters/enable_psr
>    -1
>
> With drm.debug=0x04, one should also find following message in dmesg:
>
>    [drm:intel_psr_enable_locked [i915]] Enabling PSR2
>
> [Regression Potential]
> Low. This affects only the target panel with EDID mfg CMN prod-ID 19-15.
>
> You-Sheng Yang (2):
>    UBUNTU: SAUCE: drm/i915/psr: allow overriding PSR disable param by
>      quirk
>    UBUNTU: SAUCE: drm/dp: add DP_QUIRK_FORCE_PSR_CHIP_DEFAULT quirk to CMN
>      prod-ID 19-15
>
>   drivers/gpu/drm/drm_dp_helper.c          | 5 +++++
>   drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++++++
>   include/drm/drm_dp_helper.h              | 8 ++++++++
>   3 files changed, 21 insertions(+)
>

applied to oem-5.6, thanks

--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[F]: [PATCH v2 0/2][SRU][F/OEM-5.6/G/U] Enable PSR on HP ZBook Studio G7

Ian May
In reply to this post by You-Sheng Yang
Applied to Focal/master-next.  Thanks!

Ian

On 2020-09-30 15:05:10 , You-Sheng Yang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1897501
>
> [Impact]
>
> On some OEM platforms equipped PSR eanbled panels, i915 renders screen
> half occupied and corrupted, and restore PSR previously disabled in
> LP: #1849947 fixes this issue.
>
> [Fix]
>
> While PSR has been disabled currently in Ubuntu kernels from oem-osp1
> 5.0 to current unstable 5.9, there is no guaranteed PSR support in
> Focal, and PSR is actually planned for v5.10 or later kernels, reverting
> the disabling commit ("UBUNTU: SAUCE: drm/i915: Disable PSR by default
> on all platforms") doesn't seem a viable solution here.
>
> This patchset introduces a new, Ubuntu only, EDID quirk
> 'DP_QUIRK_FORCE_PSR_CHIP_DEFAULT' to identify the target panel and overrides
> `enable_psr` to -1(chip defaults) when it's set to 0(disabled).
>
> [Test Case]
>
> On the target device, the PSR value should be 0 by default:
>
>   $ sudo cat /sys/module/i915/parameters/enable_psr
>   0
>
> When applied, the PSR should be -1 even if no "i915.enable_psr=-1" is
> passed as kernel boot parameter, and .
>
>   $ sudo cat /sys/module/i915/parameters/enable_psr
>   -1
>
> With drm.debug=0x04, one should also find following message in dmesg:
>
>   [drm:intel_psr_enable_locked [i915]] Enabling PSR2
>
> [Regression Potential]
> Low. This affects only the target panel with EDID mfg CMN prod-ID 19-15.
>
> You-Sheng Yang (2):
>   UBUNTU: SAUCE: drm/i915/psr: allow overriding PSR disable param by
>     quirk
>   UBUNTU: SAUCE: drm/dp: add DP_QUIRK_FORCE_PSR_CHIP_DEFAULT quirk to CMN
>     prod-ID 19-15
>
>  drivers/gpu/drm/drm_dp_helper.c          | 5 +++++
>  drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++++++
>  include/drm/drm_dp_helper.h              | 8 ++++++++
>  3 files changed, 21 insertions(+)
>
> --
> 2.27.0
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team