[PATCH v2] [deb to snap][bionic/master] pi: initrd modules: fbdev/hdmi out support

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH v2] [deb to snap][bionic/master] pi: initrd modules: fbdev/hdmi out support

Paolo Pisati-5
BugLink: https://launchpad.net/bugs/1837209

Going from kernel snap #23(4.15.0-1032.34) to #25(4.15.0-1033.35), all kernel
modules were removed from initrd, breaking binaries that required fb to be setup
early during boot (e.g. bin/psplash in pi kernel snap core 18).

Fix that by adding back all fb kmods (and dependencies) to initrd.

Proposing for linux-snap/+git/bionic, master branch.

---
v2:
  -add modules only 'if kernel == linux-image-raspi2'
  -merge multiple echo lines

Paolo Pisati (1):
  Initrd modules: fbdev/hdmi out support for psplash

 Makefile | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH v2] Initrd modules: fbdev/hdmi out support for psplash

Paolo Pisati-5
BugLink: https://launchpad.net/bugs/1837209

Signed-off-by: Paolo Pisati <[hidden email]>
---
 Makefile | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/Makefile b/Makefile
index c468f2d..b2c5ea5 100644
--- a/Makefile
+++ b/Makefile
@@ -61,6 +61,26 @@ Pin-Priority: 700
 endef
 export APTPREF
 
+define RASPIFBKMODS
+sysimgblt
+sysfillrect
+syscopyarea
+fb_sys_fops
+drm
+drm_kms_helper
+vc4
+cec
+snd
+snd_soc_core
+snd_compress
+ac97_bus
+snd_pcm_dmaengine
+snd_pcm
+snd_timer
+snd_bcm2835
+endef
+export RASPIFBKMODS
+
 versioncheck: KIMGDEB = $(shell chroot chroot apt-cache depends $(KERNELDEB) | awk '/$(KERNELPRE)/ {print $$2}')
 install : KVERS = $(shell ls -1 chroot/boot/vmlinuz-*| tail -1 |sed 's/^.*vmlinuz-//;s/.efi.signed$$//')
 
@@ -99,6 +119,10 @@ all:
  echo "COMPRESS=lzma" >chroot/etc/initramfs-tools/conf.d/ubuntu-core.conf
  # LP1794279: vc4-kms-v3d and hardware accelerated framebuffer support
  echo "i2c-bcm2708" > chroot/etc/initramfs-tools/modules
+ # LP1837209: fbdev / hdmi out support for psplash
+ if [ "$(KERNEL)" = "linux-image-raspi2" ]; then \
+ echo "$${RASPIFBKMODS}" >> chroot/etc/initramfs-tools/modules; \
+ fi
  if [ "$(DPKG_ARCH)" = "amd64" ]; then \
   echo "nvme" >> chroot/etc/initramfs-tools/modules; \
   echo "usbhid" >> chroot/etc/initramfs-tools/modules; \
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH v2] Initrd modules: fbdev/hdmi out support for psplash

Stefan Bader-2
On 23.07.19 17:24, Paolo Pisati wrote:
> BugLink: https://launchpad.net/bugs/1837209
>
> Signed-off-by: Paolo Pisati <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---
>  Makefile | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index c468f2d..b2c5ea5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -61,6 +61,26 @@ Pin-Priority: 700
>  endef
>  export APTPREF
>  
> +define RASPIFBKMODS
> +sysimgblt
> +sysfillrect
> +syscopyarea
> +fb_sys_fops
> +drm
> +drm_kms_helper
> +vc4
> +cec
> +snd
> +snd_soc_core
> +snd_compress
> +ac97_bus
> +snd_pcm_dmaengine
> +snd_pcm
> +snd_timer
> +snd_bcm2835
> +endef
> +export RASPIFBKMODS
> +
>  versioncheck: KIMGDEB = $(shell chroot chroot apt-cache depends $(KERNELDEB) | awk '/$(KERNELPRE)/ {print $$2}')
>  install : KVERS = $(shell ls -1 chroot/boot/vmlinuz-*| tail -1 |sed 's/^.*vmlinuz-//;s/.efi.signed$$//')
>  
> @@ -99,6 +119,10 @@ all:
>   echo "COMPRESS=lzma" >chroot/etc/initramfs-tools/conf.d/ubuntu-core.conf
>   # LP1794279: vc4-kms-v3d and hardware accelerated framebuffer support
>   echo "i2c-bcm2708" > chroot/etc/initramfs-tools/modules
> + # LP1837209: fbdev / hdmi out support for psplash
> + if [ "$(KERNEL)" = "linux-image-raspi2" ]; then \
> + echo "$${RASPIFBKMODS}" >> chroot/etc/initramfs-tools/modules; \
> + fi
>   if [ "$(DPKG_ARCH)" = "amd64" ]; then \
>    echo "nvme" >> chroot/etc/initramfs-tools/modules; \
>    echo "usbhid" >> chroot/etc/initramfs-tools/modules; \
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

NACK: [PATCH v2] Initrd modules: fbdev/hdmi out support for psplash

Stefan Bader-2
In reply to this post by Paolo Pisati-5
That was iirc replaced by a different approach.

-Stefan

On 23.07.19 17:24, Paolo Pisati wrote:

> BugLink: https://launchpad.net/bugs/1837209
>
> Signed-off-by: Paolo Pisati <[hidden email]>
> ---
>  Makefile | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index c468f2d..b2c5ea5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -61,6 +61,26 @@ Pin-Priority: 700
>  endef
>  export APTPREF
>  
> +define RASPIFBKMODS
> +sysimgblt
> +sysfillrect
> +syscopyarea
> +fb_sys_fops
> +drm
> +drm_kms_helper
> +vc4
> +cec
> +snd
> +snd_soc_core
> +snd_compress
> +ac97_bus
> +snd_pcm_dmaengine
> +snd_pcm
> +snd_timer
> +snd_bcm2835
> +endef
> +export RASPIFBKMODS
> +
>  versioncheck: KIMGDEB = $(shell chroot chroot apt-cache depends $(KERNELDEB) | awk '/$(KERNELPRE)/ {print $$2}')
>  install : KVERS = $(shell ls -1 chroot/boot/vmlinuz-*| tail -1 |sed 's/^.*vmlinuz-//;s/.efi.signed$$//')
>  
> @@ -99,6 +119,10 @@ all:
>   echo "COMPRESS=lzma" >chroot/etc/initramfs-tools/conf.d/ubuntu-core.conf
>   # LP1794279: vc4-kms-v3d and hardware accelerated framebuffer support
>   echo "i2c-bcm2708" > chroot/etc/initramfs-tools/modules
> + # LP1837209: fbdev / hdmi out support for psplash
> + if [ "$(KERNEL)" = "linux-image-raspi2" ]; then \
> + echo "$${RASPIFBKMODS}" >> chroot/etc/initramfs-tools/modules; \
> + fi
>   if [ "$(DPKG_ARCH)" = "amd64" ]; then \
>    echo "nvme" >> chroot/etc/initramfs-tools/modules; \
>    echo "usbhid" >> chroot/etc/initramfs-tools/modules; \
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment