[PATCH] [zesty] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revisio

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] [zesty] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revisio

Manoj Iyer
From: Manoj Iyer <[hidden email]>

For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
the ACPI oem_revision field is actually set to 1, not 0. This patch is
necessary for proper functioning of console used for D-I installs and boot.

This patch was tested by me on QDF2400 on Zesty based kernel and reported
to upstream.

Please consider merging this patch for zesty.

Timur Tabi (1):
  tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

 drivers/acpi/spcr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.10.2


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

Manoj Iyer
From: Timur Tabi <[hidden email]>

For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
the ACPI oem_revision field is actually set to 1, not 0.

Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")

BugLink: https://bugs.launchpad.net/bugs/1674466
Tested-by: Manoj Iyer <[hidden email]>
Signed-off-by: Timur Tabi <[hidden email]>
Signed-off-by: Greg Kroah-Hartman <[hidden email]>
(cherry picked from commit 542ed784671d4678406c77ed6dd01593a0cdbea1)
Signed-off-by: Manoj Iyer <[hidden email]>
---
 drivers/acpi/spcr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
index 2b5d0fa..2051a8c 100644
--- a/drivers/acpi/spcr.c
+++ b/drivers/acpi/spcr.c
@@ -30,7 +30,7 @@ static bool qdf2400_erratum_44_present(struct acpi_table_header *h)
  return true;
 
  if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) &&
- h->oem_revision == 0)
+ h->oem_revision == 1)
  return true;
 
  return false;
--
2.10.2


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

Seth Forshee
On Mon, Mar 20, 2017 at 03:17:01PM -0500, [hidden email] wrote:

> From: Timur Tabi <[hidden email]>
>
> For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
> the ACPI oem_revision field is actually set to 1, not 0.
>
> Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
>
> BugLink: https://bugs.launchpad.net/bugs/1674466
> Tested-by: Manoj Iyer <[hidden email]>
> Signed-off-by: Timur Tabi <[hidden email]>
> Signed-off-by: Greg Kroah-Hartman <[hidden email]>
> (cherry picked from commit 542ed784671d4678406c77ed6dd01593a0cdbea1)
> Signed-off-by: Manoj Iyer <[hidden email]>

The patch looks fine, but we need a buglink.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

Manoj Iyer

On Mon, 20 Mar 2017, Seth Forshee wrote:

> On Mon, Mar 20, 2017 at 03:17:01PM -0500, [hidden email] wrote:
>> From: Timur Tabi <[hidden email]>
>>
>> For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
>> the ACPI oem_revision field is actually set to 1, not 0.
>>
>> Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
>>
>> BugLink: https://bugs.launchpad.net/bugs/1674466
>> Tested-by: Manoj Iyer <[hidden email]>
>> Signed-off-by: Timur Tabi <[hidden email]>
>> Signed-off-by: Greg Kroah-Hartman <[hidden email]>
>> (cherry picked from commit 542ed784671d4678406c77ed6dd01593a0cdbea1)
>> Signed-off-by: Manoj Iyer <[hidden email]>
>
> The patch looks fine, but we need a buglink.

The buglink is right there before the signoffs

>
>

--
============================
Manoj Iyer
Ubuntu/Canonical
ARM Servers - Cloud
============================

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

Seth Forshee
On Mon, Mar 20, 2017 at 05:11:21PM -0500, Manoj Iyer wrote:

>
> On Mon, 20 Mar 2017, Seth Forshee wrote:
>
> >On Mon, Mar 20, 2017 at 03:17:01PM -0500, [hidden email] wrote:
> >>From: Timur Tabi <[hidden email]>
> >>
> >>For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
> >>the ACPI oem_revision field is actually set to 1, not 0.
> >>
> >>Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
> >>
> >>BugLink: https://bugs.launchpad.net/bugs/1674466
> >>Tested-by: Manoj Iyer <[hidden email]>
> >>Signed-off-by: Timur Tabi <[hidden email]>
> >>Signed-off-by: Greg Kroah-Hartman <[hidden email]>
> >>(cherry picked from commit 542ed784671d4678406c77ed6dd01593a0cdbea1)
> >>Signed-off-by: Manoj Iyer <[hidden email]>
> >
> >The patch looks fine, but we need a buglink.
>
> The buglink is right there before the signoffs

D'oh, so it is.

Applied to zesty master-next.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team