[PULL][SRU Bionic] hisi_sas bugfixes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PULL][SRU Bionic] hisi_sas bugfixes

dann frazier-4
BugLink: https://bugs.launchpad.net/bugs/1762824

All clean cherry-picks from upstream, limited to the hisi_sas driver.

The descriptions of 2 of the patches underplay the functional changes,
so I'll elaborate here on why I'm including them. "scsi: hisi_sas:
Code cleanup and minor bug fixes" because it corrects the interrupt
handler return values. "scsi: hisi_sas: remove unused variable
hisi_sas_devices.running_req" is an obviously correct change,
and allows the driver to drop several atomic instructions.

Tested on a HiSilicon D05 and a HiSilicon D06 board.

The following changes since commit d4174baeefbd0a9634291145600b90e13163f27d:

  UBUNTU: Ubuntu-4.15.0-20.21 (2018-04-23 23:56:56 -0500)

are available in the Git repository at:

  git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux hisi-sas-updates

for you to fetch changes up to 2e3b262ef293485798233fc4fa53758d548e99d2:

  scsi: hisi_sas: Code cleanup and minor bug fixes (2018-05-03 19:48:52 -0600)

----------------------------------------------------------------
Xiang Chen (2):
      scsi: hisi_sas: remove unused variable hisi_sas_devices.running_req
      scsi: hisi_sas: Code cleanup and minor bug fixes

Xiaofei Tan (6):
      scsi: hisi_sas: dt-bindings: add an property of signal attenuation
      scsi: hisi_sas: support the property of signal attenuation for v2 hw
      scsi: hisi_sas: fix the issue of link rate inconsistency
      scsi: hisi_sas: fix the issue of setting linkrate register
      scsi: hisi_sas: increase timer expire of internal abort task
      scsi: hisi_sas: fix return value of hisi_sas_task_prep()

 .../devicetree/bindings/scsi/hisilicon-sas.txt     |  7 +++
 drivers/scsi/hisi_sas/hisi_sas.h                   |  1 -
 drivers/scsi/hisi_sas/hisi_sas_main.c              | 34 +++++-------
 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c             | 13 +++--
 drivers/scsi/hisi_sas/hisi_sas_v2_hw.c             | 62 +++++++++++++++++-----
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c             | 46 ++++++++--------
 6 files changed, 96 insertions(+), 67 deletions(-)

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PULL][SRU Bionic] hisi_sas bugfixes

Kleber Souza
On 05/04/18 19:54, dann frazier wrote:

> BugLink: https://bugs.launchpad.net/bugs/1762824
>
> All clean cherry-picks from upstream, limited to the hisi_sas driver.
>
> The descriptions of 2 of the patches underplay the functional changes,
> so I'll elaborate here on why I'm including them. "scsi: hisi_sas:
> Code cleanup and minor bug fixes" because it corrects the interrupt
> handler return values. "scsi: hisi_sas: remove unused variable
> hisi_sas_devices.running_req" is an obviously correct change,
> and allows the driver to drop several atomic instructions.
>
> Tested on a HiSilicon D05 and a HiSilicon D06 board.
>
> The following changes since commit d4174baeefbd0a9634291145600b90e13163f27d:
>
>   UBUNTU: Ubuntu-4.15.0-20.21 (2018-04-23 23:56:56 -0500)
>
> are available in the Git repository at:
>
>   git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux hisi-sas-updates
>
> for you to fetch changes up to 2e3b262ef293485798233fc4fa53758d548e99d2:
>
>   scsi: hisi_sas: Code cleanup and minor bug fixes (2018-05-03 19:48:52 -0600)

Hi Dann,

I'm OK with the changes and I would give my ACK, however the BugLink
references to a bug that has already been used for a previous patch-set
submission and it has been marked as 'Fix Released'. In that case we
recommend opening a new bug so we can track better the progress of these
follow-up fixes.


Thanks,
Kleber

>
> ----------------------------------------------------------------
> Xiang Chen (2):
>       scsi: hisi_sas: remove unused variable hisi_sas_devices.running_req
>       scsi: hisi_sas: Code cleanup and minor bug fixes
>
> Xiaofei Tan (6):
>       scsi: hisi_sas: dt-bindings: add an property of signal attenuation
>       scsi: hisi_sas: support the property of signal attenuation for v2 hw
>       scsi: hisi_sas: fix the issue of link rate inconsistency
>       scsi: hisi_sas: fix the issue of setting linkrate register
>       scsi: hisi_sas: increase timer expire of internal abort task
>       scsi: hisi_sas: fix return value of hisi_sas_task_prep()
>
>  .../devicetree/bindings/scsi/hisilicon-sas.txt     |  7 +++
>  drivers/scsi/hisi_sas/hisi_sas.h                   |  1 -
>  drivers/scsi/hisi_sas/hisi_sas_main.c              | 34 +++++-------
>  drivers/scsi/hisi_sas/hisi_sas_v1_hw.c             | 13 +++--
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c             | 62 +++++++++++++++++-----
>  drivers/scsi/hisi_sas/hisi_sas_v3_hw.c             | 46 ++++++++--------
>  6 files changed, 96 insertions(+), 67 deletions(-)
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PULL][SRU Bionic] hisi_sas bugfixes

dann frazier-4
On Wed, May 16, 2018 at 4:13 AM, Kleber Souza
<[hidden email]> wrote:

> On 05/04/18 19:54, dann frazier wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1762824
>>
>> All clean cherry-picks from upstream, limited to the hisi_sas driver.
>>
>> The descriptions of 2 of the patches underplay the functional changes,
>> so I'll elaborate here on why I'm including them. "scsi: hisi_sas:
>> Code cleanup and minor bug fixes" because it corrects the interrupt
>> handler return values. "scsi: hisi_sas: remove unused variable
>> hisi_sas_devices.running_req" is an obviously correct change,
>> and allows the driver to drop several atomic instructions.
>>
>> Tested on a HiSilicon D05 and a HiSilicon D06 board.
>>
>> The following changes since commit d4174baeefbd0a9634291145600b90e13163f27d:
>>
>>   UBUNTU: Ubuntu-4.15.0-20.21 (2018-04-23 23:56:56 -0500)
>>
>> are available in the Git repository at:
>>
>>   git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux hisi-sas-updates
>>
>> for you to fetch changes up to 2e3b262ef293485798233fc4fa53758d548e99d2:
>>
>>   scsi: hisi_sas: Code cleanup and minor bug fixes (2018-05-03 19:48:52 -0600)
>
> Hi Dann,
>
> I'm OK with the changes and I would give my ACK, however the BugLink
> references to a bug that has already been used for a previous patch-set
> submission and it has been marked as 'Fix Released'. In that case we
> recommend opening a new bug so we can track better the progress of these
> follow-up fixes.

Oops! The BugLink should be:

  BugLink: https://bugs.launchpad.net/bugs/1768974

This is correct in the individual commits - looks like just a cut &
paste error in the PR e-mail.
Thanks for reviewing Kleber - let me know if you need a new PR e-mail
w/ this correction.

  -dann

>
> Thanks,
> Kleber
>
>>
>> ----------------------------------------------------------------
>> Xiang Chen (2):
>>       scsi: hisi_sas: remove unused variable hisi_sas_devices.running_req
>>       scsi: hisi_sas: Code cleanup and minor bug fixes
>>
>> Xiaofei Tan (6):
>>       scsi: hisi_sas: dt-bindings: add an property of signal attenuation
>>       scsi: hisi_sas: support the property of signal attenuation for v2 hw
>>       scsi: hisi_sas: fix the issue of link rate inconsistency
>>       scsi: hisi_sas: fix the issue of setting linkrate register
>>       scsi: hisi_sas: increase timer expire of internal abort task
>>       scsi: hisi_sas: fix return value of hisi_sas_task_prep()
>>
>>  .../devicetree/bindings/scsi/hisilicon-sas.txt     |  7 +++
>>  drivers/scsi/hisi_sas/hisi_sas.h                   |  1 -
>>  drivers/scsi/hisi_sas/hisi_sas_main.c              | 34 +++++-------
>>  drivers/scsi/hisi_sas/hisi_sas_v1_hw.c             | 13 +++--
>>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c             | 62 +++++++++++++++++-----
>>  drivers/scsi/hisi_sas/hisi_sas_v3_hw.c             | 46 ++++++++--------
>>  6 files changed, 96 insertions(+), 67 deletions(-)
>>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [PULL][SRU Bionic] hisi_sas bugfixes

Kleber Souza
On 05/16/18 21:13, dann frazier wrote:

> On Wed, May 16, 2018 at 4:13 AM, Kleber Souza
> <[hidden email]> wrote:
>> On 05/04/18 19:54, dann frazier wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1762824
>>>
>>> All clean cherry-picks from upstream, limited to the hisi_sas driver.
>>>
>>> The descriptions of 2 of the patches underplay the functional changes,
>>> so I'll elaborate here on why I'm including them. "scsi: hisi_sas:
>>> Code cleanup and minor bug fixes" because it corrects the interrupt
>>> handler return values. "scsi: hisi_sas: remove unused variable
>>> hisi_sas_devices.running_req" is an obviously correct change,
>>> and allows the driver to drop several atomic instructions.
>>>
>>> Tested on a HiSilicon D05 and a HiSilicon D06 board.
>>>
>>> The following changes since commit d4174baeefbd0a9634291145600b90e13163f27d:
>>>
>>>   UBUNTU: Ubuntu-4.15.0-20.21 (2018-04-23 23:56:56 -0500)
>>>
>>> are available in the Git repository at:
>>>
>>>   git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux hisi-sas-updates
>>>
>>> for you to fetch changes up to 2e3b262ef293485798233fc4fa53758d548e99d2:
>>>
>>>   scsi: hisi_sas: Code cleanup and minor bug fixes (2018-05-03 19:48:52 -0600)
>>
>> Hi Dann,
>>
>> I'm OK with the changes and I would give my ACK, however the BugLink
>> references to a bug that has already been used for a previous patch-set
>> submission and it has been marked as 'Fix Released'. In that case we
>> recommend opening a new bug so we can track better the progress of these
>> follow-up fixes.
>
> Oops! The BugLink should be:
>
>   BugLink: https://bugs.launchpad.net/bugs/1768974
>
> This is correct in the individual commits - looks like just a cut &
> paste error in the PR e-mail.
> Thanks for reviewing Kleber - let me know if you need a new PR e-mail
> w/ this correction.
>

Hi Dann,

Sorry, I didn't see the BugLink in the commits were different. That's
fine, no need to send a new PR.

Thanks!

>   -dann
>
>>
>> Thanks,
>> Kleber
>>
>>>
>>> ----------------------------------------------------------------
>>> Xiang Chen (2):
>>>       scsi: hisi_sas: remove unused variable hisi_sas_devices.running_req
>>>       scsi: hisi_sas: Code cleanup and minor bug fixes
>>>
>>> Xiaofei Tan (6):
>>>       scsi: hisi_sas: dt-bindings: add an property of signal attenuation
>>>       scsi: hisi_sas: support the property of signal attenuation for v2 hw
>>>       scsi: hisi_sas: fix the issue of link rate inconsistency
>>>       scsi: hisi_sas: fix the issue of setting linkrate register
>>>       scsi: hisi_sas: increase timer expire of internal abort task
>>>       scsi: hisi_sas: fix return value of hisi_sas_task_prep()
>>>
>>>  .../devicetree/bindings/scsi/hisilicon-sas.txt     |  7 +++
>>>  drivers/scsi/hisi_sas/hisi_sas.h                   |  1 -
>>>  drivers/scsi/hisi_sas/hisi_sas_main.c              | 34 +++++-------
>>>  drivers/scsi/hisi_sas/hisi_sas_v1_hw.c             | 13 +++--
>>>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c             | 62 +++++++++++++++++-----
>>>  drivers/scsi/hisi_sas/hisi_sas_v3_hw.c             | 46 ++++++++--------
>>>  6 files changed, 96 insertions(+), 67 deletions(-)
>>>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PULL][SRU Bionic] hisi_sas bugfixes

Kleber Souza
In reply to this post by dann frazier-4
On 05/04/18 19:54, dann frazier wrote:

> BugLink: https://bugs.launchpad.net/bugs/1762824
>
> All clean cherry-picks from upstream, limited to the hisi_sas driver.
>
> The descriptions of 2 of the patches underplay the functional changes,
> so I'll elaborate here on why I'm including them. "scsi: hisi_sas:
> Code cleanup and minor bug fixes" because it corrects the interrupt
> handler return values. "scsi: hisi_sas: remove unused variable
> hisi_sas_devices.running_req" is an obviously correct change,
> and allows the driver to drop several atomic instructions.
>
> Tested on a HiSilicon D05 and a HiSilicon D06 board.
>
> The following changes since commit d4174baeefbd0a9634291145600b90e13163f27d:
>
>   UBUNTU: Ubuntu-4.15.0-20.21 (2018-04-23 23:56:56 -0500)
>
> are available in the Git repository at:
>
>   git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux hisi-sas-updates
>
> for you to fetch changes up to 2e3b262ef293485798233fc4fa53758d548e99d2:
>
>   scsi: hisi_sas: Code cleanup and minor bug fixes (2018-05-03 19:48:52 -0600)

Changes look good to me.

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

>
> ----------------------------------------------------------------
> Xiang Chen (2):
>       scsi: hisi_sas: remove unused variable hisi_sas_devices.running_req
>       scsi: hisi_sas: Code cleanup and minor bug fixes
>
> Xiaofei Tan (6):
>       scsi: hisi_sas: dt-bindings: add an property of signal attenuation
>       scsi: hisi_sas: support the property of signal attenuation for v2 hw
>       scsi: hisi_sas: fix the issue of link rate inconsistency
>       scsi: hisi_sas: fix the issue of setting linkrate register
>       scsi: hisi_sas: increase timer expire of internal abort task
>       scsi: hisi_sas: fix return value of hisi_sas_task_prep()
>
>  .../devicetree/bindings/scsi/hisilicon-sas.txt     |  7 +++
>  drivers/scsi/hisi_sas/hisi_sas.h                   |  1 -
>  drivers/scsi/hisi_sas/hisi_sas_main.c              | 34 +++++-------
>  drivers/scsi/hisi_sas/hisi_sas_v1_hw.c             | 13 +++--
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c             | 62 +++++++++++++++++-----
>  drivers/scsi/hisi_sas/hisi_sas_v3_hw.c             | 46 ++++++++--------
>  6 files changed, 96 insertions(+), 67 deletions(-)
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team