Patches to fix warnings introduced by patch for CVE-2008-1673

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Patches to fix warnings introduced by patch for CVE-2008-1673

Stefan Bader-2
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Those are the fixes from upstream:


- --

When all other means of communication fail, try words!


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIqvSSP+TjRTJVqvQRAtyAAKDExFRIEuPIG+B8vWiTJu3TTpakVgCgqmyL
XlLOJ87rs+zd+hlU37oDptI=
=ZHlD
-----END PGP SIGNATURE-----

From 04e1e0cccade330ab3715ce59234f7e3b087e246 Mon Sep 17 00:00:00 2001
From: Jan Beulich <[hidden email]>
Date: Tue, 22 Jul 2008 13:04:18 +0000
Subject: [PATCH] [CIFS] Fix compiler warning on 64-bit

Signed-off-by: Steve French <[hidden email]>
Signed-off-by: Stefan Bader <[hidden email]>
---
 fs/cifs/asn1.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/cifs/asn1.c b/fs/cifs/asn1.c
index f58e41d..4276546 100644
--- a/fs/cifs/asn1.c
+++ b/fs/cifs/asn1.c
@@ -400,7 +400,7 @@ asn1_oid_decode(struct asn1_ctx *ctx,
  size = eoc - ctx->pointer + 1;
 
  /* first subid actually encodes first two subids */
- if (size < 2 || size > ULONG_MAX/sizeof(unsigned long))
+ if (size < 2 || size > UINT_MAX/sizeof(unsigned long))
  return 0;
 
  *oid = kmalloc(size * sizeof(unsigned long), GFP_ATOMIC);
--
1.5.4.3


From 252815b0cfe711001eff0327872209986b36d490 Mon Sep 17 00:00:00 2001
From: David Howells <[hidden email]>
Date: Wed, 9 Jul 2008 15:06:45 -0700
Subject: [PATCH] netfilter: nf_nat_snmp_basic: fix a range check in NAT for SNMP

Fix a range check in netfilter IP NAT for SNMP to always use a big enough size
variable that the compiler won't moan about comparing it to ULONG_MAX/8 on a
64-bit platform.

Signed-off-by: David Howells <[hidden email]>
Signed-off-by: Patrick McHardy <[hidden email]>
Signed-off-by: David S. Miller <[hidden email]>
Signed-off-by: Stefan Bader <[hidden email]>
---
 net/ipv4/netfilter/nf_nat_snmp_basic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/netfilter/nf_nat_snmp_basic.c b/net/ipv4/netfilter/nf_nat_snmp_basic.c
index 7750c97..ffeaffc 100644
--- a/net/ipv4/netfilter/nf_nat_snmp_basic.c
+++ b/net/ipv4/netfilter/nf_nat_snmp_basic.c
@@ -439,8 +439,8 @@ static unsigned char asn1_oid_decode(struct asn1_ctx *ctx,
      unsigned int *len)
 {
  unsigned long subid;
- unsigned int  size;
  unsigned long *optr;
+ size_t size;
 
  size = eoc - ctx->pointer + 1;
 
--
1.5.4.3


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: Patches to fix warnings introduced by patch for CVE-2008-1673

Ben Collins-4
On Tue, 2008-08-19 at 12:28 -0400, Stefan Bader wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Those are the fixes from upstream:

ACK on both.

>
> - --
>
> When all other means of communication fail, try words!
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFIqvSSP+TjRTJVqvQRAtyAAKDExFRIEuPIG+B8vWiTJu3TTpakVgCgqmyL
> XlLOJ87rs+zd+hlU37oDptI=
> =ZHlD
> -----END PGP SIGNATURE-----


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: Patches to fix warnings introduced by patch for CVE-2008-1673

Tim Gardner-2
In reply to this post by Stefan Bader-2
Stefan Bader wrote:
> Those are the fixes from upstream:
>
>

Its the change to size_t that makes this work. ACK.
--
Tim Gardner [hidden email]

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team